| 00:00.00 | LainIwakuraX | lol |
| 00:11.21 | CIA-62 | BRL-CAD: 03brlcad * r45668 10/brlcad/trunk/src/conv/step/step-g.cpp: always tear down the factory |
| 00:13.42 | CIA-62 | BRL-CAD: 03brlcad * r45669 10/brlcad/trunk/src/conv/step/STEPWrapper.cpp: dotg != dot_g |
| 00:49.48 | *** join/#brlcad tharis20 (~tharis@dyn896-219.eduroam.ic.ac.uk) | |
| 00:50.57 | LainIwakuraX | Out for the night |
| 00:57.55 | *** join/#brlcad tharis20 (~tharis@dyn896-219.eduroam.ic.ac.uk) | |
| 01:54.26 | CIA-62 | BRL-CAD: 03kunigami * r45670 10/brlcad/trunk/src/liboptical/ (liboslrend.cpp liboslrend.h sh_osl.cpp): added support for vector/normal/point and matrix shader parameters |
| 03:07.52 | CIA-62 | BRL-CAD: 03brlcad * r45671 10/brlcad/trunk/src/conv/step/STEPWrapper.cpp: sanity, abort if we encounter a null |
| 03:08.07 | CIA-62 | BRL-CAD: 03brlcad * r45672 10/brlcad/trunk/src/conv/step/ (5 files): ws |
| 04:22.17 | CIA-62 | BRL-CAD: 03brlcad * r45673 10/brlcad/trunk/configure.ac: PNG libtool library is now libpng15.la |
| 04:27.20 | CIA-62 | BRL-CAD: 03brlcad * r45674 10/brlcad/trunk/src/libbn/plane.c: parallel is set but unused, kill it |
| 04:34.05 | CIA-62 | BRL-CAD: 03brlcad * r45675 10/brlcad/trunk/src/libbn/plot3.c: more variable set-but-unused warnings from gcc 4.7 (prerelease), but these are actually needed. check the ret value and perror if we didn't write all that was expected. |
| 04:38.20 | *** join/#brlcad DarkCalf (DC@173.231.40.98) | |
| 04:40.45 | CIA-62 | BRL-CAD: 03brlcad * r45676 10/brlcad/trunk/src/librt/bundle.c: status is unused, remove |
| 04:52.42 | CIA-62 | BRL-CAD: 03brlcad * r45677 10/brlcad/trunk/src/conv/step/ (STEPWrapper.cpp STEPWrapper.h): convert InstMgr from an embedded class to a pointer with allocation on the heap |
| 05:15.31 | CIA-62 | BRL-CAD: 03brlcad * r45678 10/brlcad/trunk/src/librt/prep.c: yet another example why strict compilation is a "good thing" (tm). quell warning about old_max being set but unused. turns out this was a bug introduced several years ago in r36723 after a simple refactoring. |
| 05:17.46 | CIA-62 | BRL-CAD: 03brlcad * r45679 10/brlcad/trunk/src/other/step/src/cleditor/instmgr.cc: plug a memory leak accounting for almost a half MB. delete the InstMgr master and sorted master manager node arrays. |
| 05:34.37 | CIA-62 | BRL-CAD: 03brlcad * r45680 10/brlcad/trunk/src/librt/primitives/ (bot/btgf.c dsp/dsp.c): remove unused var |
| 05:36.15 | CIA-62 | BRL-CAD: 03brlcad * r45681 10/brlcad/trunk/src/librt/primitives/bspline/bspline.cpp: and again, strictness catches a bug -- this one affects being able to dbupgrade/dbopen incompatible v4 files. it basically was reading in old bpline objects without applying a properly byte-flipped matrix. |
| 05:38.13 | CIA-62 | BRL-CAD: 03brlcad * r45682 10/brlcad/trunk/src/other/step/src/cleditor/STEPfile.inline.cc: delete the instances before deleting the container, don't just clear them. plugs memory leak (though there is still lots to go for scl) |
| 05:41.30 | CIA-62 | BRL-CAD: 03brlcad * r45683 10/brlcad/trunk/src/other/step/TODO: leaking something nasty |
| 06:50.59 | *** join/#brlcad merzo (~merzo@193.254.217.44) | |
| 07:00.34 | CIA-62 | BRL-CAD: 03brlcad * r45684 10/brlcad/trunk/src/librt/ (13 files in 9 dirs): quell a slew of gcc 4.7 detections of variables being set but weren't being used. one of the nmg routines, nmg_eval_linear_trim_to_tol(), is a little suspect but the rest were mostly benign. |
| 09:59.59 | CIA-62 | BRL-CAD: 03bhinesley * r45685 10/brlcad/trunk/src/libged/edit.c: (log message trimmed) |
| 09:59.59 | CIA-62 | BRL-CAD: Renamed stupid "*_concise" functions to "*_wrapper". Added functions to get the |
| 09:59.59 | CIA-62 | BRL-CAD: next argument "head" in the union edit_cmd. Not too happy about adding yet |
| 09:59.59 | CIA-62 | BRL-CAD: another command-specific function; but it seems necessary to keep separation, |
| 09:59.59 | CIA-62 | BRL-CAD: while still having an intuitive way to build arguments (id est union edit_cmd). |
| 10:00.00 | CIA-62 | BRL-CAD: With these functions, we'll be able to pass over all of a command's arguments, |
| 10:00.01 | CIA-62 | BRL-CAD: without being aware of the union edit_cmd layout. The new plan is to keep edit() |
| 11:00.10 | *** join/#brlcad Stattrav (~Stattrav@122.178.209.201) | |
| 11:00.10 | *** join/#brlcad Stattrav (~Stattrav@unaffiliated/stattrav) | |
| 11:04.06 | *** join/#brlcad Stattrav_ (~Stattrav@111.93.134.142) | |
| 11:12.08 | *** join/#brlcad Stattrav (~Stattrav@111.93.134.142) | |
| 11:12.08 | *** join/#brlcad Stattrav (~Stattrav@unaffiliated/stattrav) | |
| 12:10.46 | *** join/#brlcad Stattrav (~Stattrav@111.93.134.142) | |
| 12:10.46 | *** join/#brlcad Stattrav (~Stattrav@unaffiliated/stattrav) | |
| 13:08.16 | CIA-62 | BRL-CAD: 03brlcad * r45686 10/brlcad/trunk/src/libfb/ (if_X.c if_X24.c): quell set-but-unused warnings |
| 13:11.30 | CIA-62 | BRL-CAD: 03brlcad * r45687 10/brlcad/trunk/src/libgcv/bottess.c: dir unused |
| 13:14.02 | CIA-62 | BRL-CAD: 03brlcad * r45688 10/brlcad/trunk/src/libgcv/bottess.c: actually, build just wasn't up to date -- dir is used now, but i is not. quellage. |
| 13:17.41 | CIA-62 | BRL-CAD: 03brlcad * r45689 10/brlcad/trunk/src/libged/ (bo.c bot_dump.c): remove slew of set-yet-unused vars |
| 13:22.29 | CIA-62 | BRL-CAD: 03brlcad * r45690 10/brlcad/trunk/src/libged/edit.c: gcc 4.7 no longer considers these constant/computable at compile-time. so, meh, set them at runtime. |
| 13:26.55 | CIA-62 | BRL-CAD: 03brlcad * r45691 10/brlcad/trunk/src/libged/ (glob.c human.c): more set-and-unused var elimination |
| 13:30.22 | CIA-62 | BRL-CAD: 03brlcad * r45692 10/brlcad/trunk/src/libpc/pcVariable.h: j unused |
| 13:31.59 | CIA-62 | BRL-CAD: 03brlcad * r45693 10/brlcad/trunk/src/librt/opennurbs_ext.cpp: points a and b are unused, remove |
| 13:32.46 | brlcad | i'm liking this new version of the compiler .. the warnings have actually caught a slew of bugs, some minor, some not-so-minor |
| 13:40.31 | CIA-62 | BRL-CAD: 03brlcad * r45694 10/brlcad/trunk/include/bu.h: the pointer!=NULL comparison is always true for variables on the stack. cast through void so the compiler will shut it. |
| 13:42.25 | CIA-62 | BRL-CAD: 03brlcad * r45695 10/brlcad/trunk/src/libged/ (png.c ps.c red.c screengrab.c tire.c): remainder of libged set-and-unused warnings |
| 13:51.54 | CIA-62 | BRL-CAD: 03brlcad * r45696 10/brlcad/trunk/src/liboptical/photonmap.c: unused due to commented code |
| 13:52.56 | CIA-62 | BRL-CAD: 03brlcad * r45697 10/brlcad/trunk/src/libdm/labels.c: we dont' do anything with id, so don't bother saving it from rt_db_get_internal() |
| 13:54.42 | CIA-62 | BRL-CAD: 03brlcad * r45698 10/brlcad/trunk/src/conv/ (3dm/3dm-g.cpp dxf/dxf-g.c step/OpenNurbsInterfaces.cpp): set-and-unused quellage |
| 13:56.17 | CIA-62 | BRL-CAD: 03brlcad * r45699 10/brlcad/trunk/src/librtserver/rtserver.c: idx and los are unused, so get rid of them |
| 13:58.53 | CIA-62 | BRL-CAD: 03brlcad * r45700 10/brlcad/trunk/NEWS: |
| 13:58.53 | CIA-62 | BRL-CAD: preliminary testing of the conversion from SCLstring to std::string is showing a |
| 13:58.53 | CIA-62 | BRL-CAD: consistent speed improvement in step-g for relatively small models. Models |
| 13:58.53 | CIA-62 | BRL-CAD: taking less than a few minutes to convert are now taking approximately 10-30% |
| 13:58.53 | CIA-62 | BRL-CAD: less time. Unfortunately, models that take more than 10-20 minutes still take |
| 13:58.53 | CIA-62 | BRL-CAD: 10-20 minutes implying that some other processing dominates as the files get |
| 13:58.53 | CIA-62 | BRL-CAD: bigger. |
| 14:10.19 | CIA-62 | BRL-CAD: 03brlcad * r45701 10/brlcad/trunk/src/lgt/ (do_options.c screen.h): |
| 14:10.19 | CIA-62 | BRL-CAD: let TEMPLATE_COLS represent the number of chars not including null, so we're |
| 14:10.19 | CIA-62 | BRL-CAD: protected on both ends of printing. more tricky, gcc detected that the |
| 14:10.19 | CIA-62 | BRL-CAD: snprintf() range provided was too much since IR_AUTO_MAP_PTR already indexes far |
| 14:10.19 | CIA-62 | BRL-CAD: into template. |
| 14:12.47 | brlcad | and with that, we have our first clean strict pass on 4.7 |
| 14:13.43 | brlcad | still have to test optimized and 32-bit |
| 14:14.05 | brlcad | hits the road |
| 14:15.31 | CIA-62 | BRL-CAD: 03erikgreenwald * r45702 10/brlcad/trunk/src/libgcv/bottess.c: put the i's back, they're necessary for the next step |
| 14:23.05 | brlcad | ``Erik: I figured that was a work-in-progress .. but the newer compiler builds now halt on incomplete code that's enabled |
| 14:24.18 | brlcad | we'll have to #if-wrap works in progress that get committed (that i var is actually the only one that was active code, surprisingly) |
| 14:24.54 | brlcad | rather like it actually, encourages coding complete (and committing complete) instead of stubbed functionality |
| 14:38.42 | *** join/#brlcad Stattrav (~Stattrav@unaffiliated/stattrav) | |
| 14:39.00 | ``Erik | <PROTECTED> |
| 14:39.34 | ``Erik | would rather not do a 2000 line commit O.o |
| 14:45.21 | *** join/#brlcad abhi2011 (~chatzilla@ip170-79-211-87.adsl2.static.versatel.nl) | |
| 15:28.23 | brlcad | ``Erik: I think it's smart enough to recognize that's a no-op and the var is still unused now |
| 15:32.38 | brlcad | starseeker: so there are just two or three files that keep getting edited in the source directory |
| 15:32.42 | brlcad | cmake is building built in a separate build dir |
| 15:32.50 | CIA-62 | BRL-CAD: 03r_weiss * r45703 10/brlcad/trunk/src/librt/primitives/nmg/nmg_tri.c: |
| 15:32.51 | CIA-62 | BRL-CAD: Added two new functions to support the prototype version of nmg_triangulate_fu. |
| 15:32.51 | CIA-62 | BRL-CAD: These functions are 'nmg_tri_kill_accordions' and 'validate_tbl2d'. The first |
| 15:32.51 | CIA-62 | BRL-CAD: function is a specialized version of the 'nmg_kill_accordions' function which |
| 15:32.51 | CIA-62 | BRL-CAD: allows killed vertexuse to be removed (nulled out) from the tbl2d table. The |
| 15:32.51 | CIA-62 | BRL-CAD: second function verifies that all vertexuse within a faceuse is stored in the |
| 15:32.52 | CIA-62 | BRL-CAD: tbl2d table. These functions are a work in progress and are disabled by default. |
| 15:32.52 | brlcad | zconf.h |
| 15:33.41 | brlcad | cssprop.tcl, tokenlist.txt |
| 15:34.00 | ``Erik | commits and runs O.O |
| 15:34.00 | CIA-62 | BRL-CAD: 03erikgreenwald * r45704 10/brlcad/trunk/src/libgcv/bottess.c: gut stuff and use straight moller97, modified for BRL-CAD types |
| 15:48.13 | CIA-62 | BRL-CAD: 03r_weiss * r45705 10/brlcad/trunk/src/librt/primitives/nmg/nmg_mod.c: Rewrote the 'nmg_kill_accordions' function within file 'nmg_mod.c'. The new version has cleaner logic and will continue to remove all accordions from a loopuse. |
| 15:54.33 | *** join/#brlcad b0ef (~b0ef@226.27.202.84.customer.cdi.no) | |
| 15:59.31 | CIA-62 | BRL-CAD: 03r_weiss * r45706 10/brlcad/trunk/src/librt/primitives/nmg/nmg_tri.c: |
| 15:59.31 | CIA-62 | BRL-CAD: Updated function 'find_pt2d' within file 'nmg_tri.c'. This change allows this |
| 15:59.31 | CIA-62 | BRL-CAD: function to receive a null vertexuse pointer without crashing. In addition, when |
| 15:59.31 | CIA-62 | BRL-CAD: passed a null vertexuse pointer, this function will return the first entry in |
| 15:59.31 | CIA-62 | BRL-CAD: the table which contains a null vertexuse pointer. This is useful for finding |
| 15:59.32 | CIA-62 | BRL-CAD: entries in the table which can be reused instead of allocating a new table |
| 15:59.33 | CIA-62 | BRL-CAD: entry. |
| 16:16.07 | brlcad | bhinesley: looks like a strict 4.6 build should work just fine now |
| 16:46.28 | CIA-62 | BRL-CAD: 03r_weiss * r45707 10/brlcad/trunk/src/librt/primitives/nmg/nmg_tri.c: |
| 16:46.29 | CIA-62 | BRL-CAD: Updated function 'join_mapped_loops' within file 'nmg_tri.c'. Added more error |
| 16:46.29 | CIA-62 | BRL-CAD: checking and did some code cleanup and improved the existing error messages. |
| 16:46.29 | CIA-62 | BRL-CAD: Changed some of the logic to support the prototype version of the |
| 16:46.29 | CIA-62 | BRL-CAD: 'nmg_triangulate_fu' function. Under certain conditions a new vertexuse can be |
| 16:46.29 | CIA-62 | BRL-CAD: created and it was not adding this to the tbl2d table. The logic changes are a |
| 16:46.30 | CIA-62 | BRL-CAD: work in progress and are disabled by default. |
| 17:41.31 | CIA-62 | BRL-CAD: 03brlcad * r45708 10/brlcad/trunk/src/conv/step/BRLCADWrapper.cpp: close the database on destruction, null out the pointer just in case |
| 17:43.52 | bhinesley | brlcad, sorry, there are still some issues: http://paste.pocoo.org/show/448279/ |
| 17:44.23 | CIA-62 | BRL-CAD: 03brlcad * r45709 10/brlcad/trunk/src/conv/step/step-g.cpp: so there is definitely some funky stack corruption going on. deleting the step wrapper crashes, investigating. |
| 17:44.55 | bhinesley | I cut out the middle of the file around 337, because it was too big to upload. The lines I cut out were similar to the ones directly before it. |
| 17:45.26 | brlcad | bhinesley: no need to be sorry, that's good |
| 17:45.54 | brlcad | strictness almost always requires multi-platform compilation to get all the issues ironed out |
| 17:49.59 | CIA-62 | BRL-CAD: 03brlcad * r45710 10/brlcad/trunk/src/conv/step/STEPWrapper.cpp: my bad, STEPWrapper doesn't get to own the dotg instance, they're stashing it for future use. was causing double-delete badness. |
| 17:50.50 | CIA-62 | BRL-CAD: 03brlcad * r45711 10/brlcad/trunk/src/conv/step/step-g.cpp: safe to delete stepwrapper again |
| 17:54.08 | bhinesley | brlcad: that trimmed it down enough so that I can upload the whole file now: http://paste.pocoo.org/show/448285/ |
| 17:54.18 | brlcad | cool, thx |
| 17:54.28 | bhinesley | np |
| 17:54.43 | bhinesley | oops, wait... that was the old one |
| 17:54.58 | brlcad | so in actuality, only a dozen or so issues remaining |
| 17:55.17 | brlcad | all the SdaiCONFIG_CONTROL_DESIGN ones aren't fatal (that's auto-generated code) |
| 17:56.33 | bhinesley | nods |
| 17:57.01 | bhinesley | wgetpaste is playing tricks on me... uploading the old version of a file that has been overwritten (!) |
| 17:59.40 | bhinesley | ahh, n/m, it's a problem with my primary selection/clipboard. The link in here is good, the link getting pasted into my browser is old. |
| 18:03.32 | bhinesley | counts about 50 errors, probably only a dozen or so unique as brlcad mentioned |
| 18:45.51 | CIA-62 | BRL-CAD: 03r_weiss * r45712 10/brlcad/trunk/src/librt/primitives/nmg/nmg_tri.c: |
| 18:45.51 | CIA-62 | BRL-CAD: Changed the function 'join_mapped_loops' within file 'nmg_tri.c'. I disabled one |
| 18:45.51 | CIA-62 | BRL-CAD: of the error checks which was causing some problems. The error check is now only |
| 18:45.51 | CIA-62 | BRL-CAD: enabled when the prototype version of function 'nmg_triangulate_fu' is enabled. |
| 18:46.30 | CIA-62 | BRL-CAD: 03brlcad * r45713 10/brlcad/trunk/src/conv/step/SdaiCONFIG_CONTROL_DESIGN.cc: delete debug code |
| 18:47.29 | abhi2011 | hi |
| 18:47.43 | abhi2011 | I am trying to add a command to mged |
| 18:48.03 | abhi2011 | its to learn how to add commands basically |
| 18:48.21 | abhi2011 | so I have copied out the tire.c file to a new file physics.c |
| 18:48.28 | abhi2011 | and made some changes |
| 18:49.04 | abhi2011 | the command will be simply called runphysics and has no parameters |
| 18:49.19 | abhi2011 | so apart from making a new source file, are there any other changes needed |
| 18:49.33 | abhi2011 | to compile it as part of libged |
| 18:53.25 | brlcad | of course :) |
| 18:53.46 | abhi2011 | in the CMakeLists.txt i guess |
| 18:53.47 | brlcad | otherwise how would libged know your new file from thesis.doc |
| 18:54.09 | abhi2011 | haha |
| 18:54.12 | abhi2011 | :) |
| 18:54.12 | brlcad | CMakeLists.txt and Makefile.am |
| 18:54.17 | abhi2011 | ok |
| 18:54.26 | brlcad | we have two build systems being maintained at the moment |
| 18:54.29 | brlcad | so two files |
| 18:54.45 | abhi2011 | ok, and the specific CMakeLists.txt to be edited is the top level one in the brlcad directory i guess |
| 18:54.49 | brlcad | once added, that will compile the file |
| 18:55.13 | brlcad | then you'll either want to add a command binding to mged or create a stand-alone application wrapper |
| 18:55.30 | abhi2011 | ah yes the command binding |
| 18:55.34 | brlcad | mged bindings are in src/mged/setup.c |
| 18:55.37 | abhi2011 | there wqa a specific c file for that |
| 18:55.38 | abhi2011 | right |
| 18:55.53 | brlcad | stand-alone wrapper would be writing a small binary like src/shapes/tire.c |
| 18:56.05 | abhi2011 | ok |
| 18:56.18 | abhi2011 | yah i ll try with the command binding first |
| 18:56.24 | abhi2011 | though it makes more sense |
| 18:56.31 | abhi2011 | to have it as a binary wrapper |
| 18:56.53 | abhi2011 | I have an interesting question though |
| 18:56.55 | brlcad | makes more sense as an mged command, but a binary wrapper will be easier for initial testing |
| 18:57.03 | abhi2011 | yes exactly |
| 18:57.21 | abhi2011 | and most physics engines |
| 18:57.28 | abhi2011 | can launch an opengl render window |
| 18:57.38 | abhi2011 | and show whats happening in the physics world |
| 18:57.55 | abhi2011 | which can help at times |
| 18:58.11 | brlcad | well, that would be mged |
| 18:58.34 | abhi2011 | yes right, mged already shows an opengl windows |
| 18:58.37 | brlcad | writing opengl or windowing code for a standalone binary would be undesirable, waste of time frankly |
| 18:58.39 | abhi2011 | *window |
| 18:58.47 | abhi2011 | yes right |
| 18:59.11 | brlcad | standalone binary would be just to run the simulation, console debug printing, simplified testing |
| 18:59.46 | abhi2011 | yes |
| 19:00.31 | abhi2011 | I understand your point of course. Bullet already comes with accurate rendering code though :) so there is no need to write it :) |
| 19:01.01 | brlcad | BRL-CAD already comes with rendering code too, so there's no need to bind to a new 3rd party interface |
| 19:01.11 | abhi2011 | hehe :) yes true |
| 19:03.40 | CIA-62 | BRL-CAD: 03brlcad * r45714 10/brlcad/trunk/src/libdm/dm-ogl.c: quellage, remove set-but-not-used variables |
| 19:06.45 | brlcad | bhinesley: grep -E '(CURSES|TERM|TINFO)' include/brlcad_config.h |
| 19:06.49 | brlcad | (in your build dir) |
| 19:07.00 | brlcad | /home/bhinesley/brlcad-trunk/src/libcursor/cursor.c looks like a cmake detection failure |
| 19:07.17 | brlcad | not testing for termcap or curses correctly |
| 19:07.42 | brlcad | same thing with the burst too (Sc.c) |
| 19:08.43 | brlcad | so those look like the only three problems, dm-ogl.c which I just fixed and those two files (cursor.c and Sc.c) which have the same termcap detection problem |
| 19:10.51 | abhi2011 | so I have added a new command just after rtweight |
| 19:10.58 | abhi2011 | {"rtweight", cmd_rt, GED_FUNC_PTR_NULL}, |
| 19:10.59 | CIA-62 | BRL-CAD: 03brlcad * r45715 10/brlcad/trunk/src/conv/step/OpenNurbsInterfaces.cpp: debug code tracing down stack corruption accidentally got committed. re-enable advanced brep entity loading. |
| 19:10.59 | abhi2011 | {"runphysics", cmd_rt, GED_FUNC_PTR_NULL}, |
| 19:12.39 | brlcad | doesn't look right |
| 19:12.54 | brlcad | you were following the tire command, that's your example -- not rtweight |
| 19:13.11 | brlcad | at least in terms of what that line should look like, doesn't matter where it's at |
| 19:17.29 | abhi2011 | ok yah the tire command is a wrapper ...right i ll change it |
| 19:18.51 | abhi2011 | right this should be ok |
| 19:18.54 | abhi2011 | <PROTECTED> |
| 19:18.56 | abhi2011 | <PROTECTED> |
| 19:18.57 | abhi2011 | <PROTECTED> |
| 19:19.16 | abhi2011 | i changed the c function name of course in the .c file |
| 19:24.10 | brlcad | kunigami_: just to be sure, you have seen http://code.google.com/p/openshadinglanguage/w/list y es? |
| 19:24.54 | bhinesley | brlcad: #define HAVE_TERMIO_H 1\n#define HAVE_TERMIOS_H 1 |
| 19:26.52 | kunigami | brlcad: yup. I didn't read the light path expression because I thought that was not a feature that would be useful for brlcad, or am I wrong? |
| 19:29.28 | abhi2011 | brlcad: hmm I went through the CMakeLists.txt file in the brlcad top level directory, there does not appear to be a place to add a mged command there |
| 19:29.38 | abhi2011 | for example I dont see tire anywhere |
| 19:29.58 | abhi2011 | *mged application wrapper i mean, not a command |
| 19:36.29 | brlcad | abhi2011: not following |
| 19:36.35 | brlcad | you add it to libged's file |
| 19:36.35 | CIA-62 | BRL-CAD: 03brlcad * r45716 10/brlcad/trunk/src/other/ (CMakeLists.txt libz/CMakeLists.txt): test to see what breaks. leave the zconf.h file alone, don't abort if it exists. |
| 19:37.43 | bhinesley | abhi2011: I think you're looking for libged/CMakeList.txt |
| 19:38.46 | abhi2011 | ah yes, |
| 19:38.57 | brlcad | starseeker: I'll give that a go with some testing, but that should be a pretty safe/easy change |
| 19:39.07 | abhi2011 | I have added it to setup.c in src/mged/ |
| 19:39.17 | abhi2011 | and now I want to add it to the build logic |
| 19:39.27 | brlcad | because zconf.h isn't "actually" autogenerated .. at least zconf.h.in doesn't have any substitution patterns, so it's just a copy |
| 19:39.49 | brlcad | which means there could be a million copies in a million include dirs and it won't affect build in the least |
| 19:40.01 | brlcad | testing now though |
| 19:40.31 | abhi2011 | so I guess the right place to add the the new c file that implements runphysics (i.e. src/libged/runphysics.c), to the build logic is libged/CMakeList.txt |
| 19:42.06 | CIA-62 | BRL-CAD: 03brlcad * r45717 10/brlcad/trunk/src/other/libz/zconf.h.cmakein: remove the _LARGEFILE64_SOURCE hack from the cmake template too. causes build problems with system headers that also define it. |
| 19:46.30 | abhi2011 | ok thats done, now the autotools build has to know about the new c file as well |
| 19:46.50 | abhi2011 | So I guess the new filename should go into Makefile.am |
| 19:46.58 | abhi2011 | in the top level directory |
| 19:47.11 | bhinesley | nope, in libged/Makefile.am |
| 19:47.30 | abhi2011 | ah yes there is one there too...right of course |
| 19:47.37 | bhinesley | haha |
| 19:47.44 | abhi2011 | :P |
| 19:48.20 | abhi2011 | these make files and cmake files are all over the place ! |
| 19:49.13 | ``Erik | hm, cmake seems to do everything in it's power to prevent a profiling build |
| 20:00.09 | starseeker | brlcad: yeah, I actually have added the two define options in the cmakein file in the CMakeLists.txt file as definitons, which means we don't need that file at all. |
| 20:00.56 | CIA-62 | BRL-CAD: 03starseeker * r45718 10/brlcad/trunk/src/other/ (libz/CMakeLists.txt libz/zconf.h.cmakein libz.dist): Eliminate the need for a separate zconf.h.cmakein file by simply adding the definitions at the CMakeLists.txt level if they are needed. |
| 20:03.53 | starseeker | looks at cssprop.tcl, tokenlist.txt to see if he can get them to change |
| 20:11.12 | CIA-62 | BRL-CAD: 03r_weiss * r45719 10/brlcad/trunk/src/librt/primitives/nmg/nmg_tri.c: |
| 20:11.12 | CIA-62 | BRL-CAD: Updated the prototype version of function 'cut_unimonotone' within file |
| 20:11.12 | CIA-62 | BRL-CAD: 'nmg_tri.c'. This function supports the prototype version of function |
| 20:11.12 | CIA-62 | BRL-CAD: 'nmg_triangulate_fu'. Improved the error checking and the logic to cleanup |
| 20:11.12 | CIA-62 | BRL-CAD: problem loopuse. Also did some code cleanup. This change is disabled by default. |
| 20:11.12 | CIA-62 | BRL-CAD: This is a work in progress. |
| 20:19.07 | starseeker | ``Erik: here's a good quote for you: |
| 20:19.11 | starseeker | "You don't make a good language by smashing a bunch of "projects" together. If you do that, you end up with C++." |
| 20:21.36 | CIA-62 | BRL-CAD: 03bhinesley * r45720 10/brlcad/trunk/src/libged/edit.c: Changed all union edit_cmd args to pointers. Kinda liked the idea of them being automatic, as it would simplify building commands, but we need to be able to shuffle them around easily for the *_add_arg functions. |
| 20:22.57 | CIA-62 | BRL-CAD: 03bhinesley * r45721 10/brlcad/trunk/src/ (libdm/dm-ogl.c libtclcad/tclcad_obj.c): Quiet some compiler warnings about unused variables. |
| 21:04.42 | CIA-62 | BRL-CAD: 03starseeker * r45722 10/brlcad/trunk/src/other/libpng/configure.ac: autogen failed - add back in what seem to be the related differences from the previous libpng configure.ac |
| 21:06.33 | starseeker | in case anyone else wants profiling w/cmake, it's BRLCAD-ENABLE_PROFILING |
| 21:09.00 | ``Erik | yeh, srry, found that var earlier, only mentioned it to starseeker in person |
| 21:17.32 | CIA-62 | BRL-CAD: 03starseeker * r45723 10/brlcad/trunk/src/other/libpng/configure.ac: whoops, typo |
| 21:21.41 | starseeker | cool - with that zconf.h change, in principle the CMake build should now leave behind a pristine source tree |
| 21:33.23 | CIA-62 | BRL-CAD: 03starseeker * r45724 10/brlcad/trunk/configure.ac: need both source and build dirs as includes now for libpng |
| 21:35.44 | CIA-62 | BRL-CAD: 03starseeker * r45725 10/brlcad/trunk/NEWS: Upgraded libpng to 1.5.4 |
| 21:36.53 | starseeker | brlcad: yeah, I'm not seeing any changes to the tkhtml files here doing both an autotools and cmake out of dir build... |
| 21:37.14 | starseeker | guess the next thing to try is in dir... |
| 21:50.59 | ``Erik | starseeker: the slashdot comments on java7 release? |
| 21:53.08 | starseeker | heh - yeah |
| 21:54.50 | CIA-62 | BRL-CAD: 03erikgreenwald * r45726 10/brlcad/trunk/src/libgcv/bottess.c: cleanup, more style normalization, removal of some dead code |
| 21:55.38 | starseeker | that should take care of libpng, unless another platform exposes some issue - working on Linux now |
| 22:01.44 | CIA-62 | BRL-CAD: 03starseeker * r45727 10/brlcad/trunk/misc/CMake/CompilerFlags.cmake: Don't add omit-frame-pointer if we're profiling - things are Not Happy. |
| 22:53.28 | CIA-62 | BRL-CAD: 03r_weiss * r45728 10/brlcad/trunk/src/librt/primitives/nmg/nmg_tri.c: Updated the prototype version of function 'nmg_triangulate_fu' within file 'nmg_tri.c'. The logic was simplified and code cleanup was done. This change is disabled by default. This is a work in progress. |
| 23:41.10 | *** join/#brlcad LainIwakuraX (~yuki@d24-57-80-191.home.cgocable.net) | |