| 00:16.57 | CIA-28 | BRL-CAD: 03brlcad * r48092 10/brlcad/trunk/src/libbu/test_escape.c: simplify testing, generalizing for bu_str_escape() cases |
| 00:32.28 | CIA-28 | BRL-CAD: 03brlcad * r48093 10/brlcad/trunk/src/libbu/test_escape.c: add escape test cases |
| 00:46.24 | CIA-28 | BRL-CAD: 03starseeker * r48094 10/brlcad/trunk/regress/repository.sh: remove the INSTALL check, doesn't apply in this form and its breaking distcheck. Leave the Makefile.am check until there aren't any more Makefile.am files... |
| 01:06.57 | CIA-28 | BRL-CAD: 03brlcad * r48095 10/brlcad/trunk/src/libbu/escape.c: yay for unit testing doing its job. if there's a slash at the end, we might run past the buffer end so make sure we don't. |
| 01:07.46 | CIA-28 | BRL-CAD: 03brlcad * r48096 10/brlcad/trunk/src/libbu/test_escape.c: a few more enhanced tests to check for round-trip behavior |
| 01:48.34 | *** join/#brlcad scooby (~Robert@host-92-21-209-117.as13285.net) | |
| 02:22.41 | *** join/#brlcad Technicus (~Technicus@DSLPool-net208-2.wctc.net) | |
| 05:05.26 | brlcad | starseeker: did you sync the doc files before moving the .cmake files into place? |
| 05:10.51 | brlcad | just a double-check since there've been a lot of edits since they were first added |
| 05:13.07 | brlcad | a build system functionality assertion came to mind earlier today, making sure the build still works and runs correctly on a non-X11 build |
| 05:13.43 | starseeker | brlcad: yeah - did a diff on them, synced a fair bit of stuff |
| 05:13.44 | brlcad | temporarily renaming/moving Xlib.h or libX11.so should do the trick |
| 05:13.48 | brlcad | awesome |
| 05:14.23 | starseeker | figured you'd want to do a read-through anyhow - I've been doing the CMake stuff so long I'm not the best guy for an intro anymore |
| 05:14.43 | brlcad | I do/am/will, but wanted to check on that status before I get dirty |
| 05:14.45 | starseeker | updated all the platform readme's at the same time |
| 05:14.50 | starseeker | nods |
| 05:15.40 | starseeker | I tried disabling X11, I think... haven't done a full "move the X11 lib and header" test though |
| 05:15.54 | brlcad | fwiw, the src/other/step/express declaration you added masked a bug |
| 05:16.03 | starseeker | yeah, was afraid of that... |
| 05:16.15 | brlcad | that function is called with two args and three args |
| 05:16.43 | starseeker | has no clue why gcc wasn't barfing... |
| 05:16.59 | brlcad | there's nothing wrong if the types happen to be coercable |
| 05:17.08 | brlcad | C allows feeding too few |
| 05:17.10 | starseeker | is betting most of the changes needed for a non-Tk build apply to the non-X11 build... |
| 05:17.33 | brlcad | not an important issue, just noteworthy |
| 05:18.01 | brlcad | I wouldn't look into it myself until nick is done and we're merged with the git branch |
| 05:18.04 | starseeker | nods - didn't want to dig too hard into it, since we've got to sync with the github version at some point and I think that's diverged pretty significantly |
| 05:18.08 | starseeker | er, yeay :-) |
| 05:18.26 | brlcad | mental check for later though, as that's a crasher |
| 05:18.35 | brlcad | or rather, a memory corruption |
| 05:18.54 | starseeker | is of the opinion that codebase needs a thorough housecleaning |
| 05:19.51 | starseeker | hopefully the github work will help some, but I must admit that "we yanked frees to avoid crashes and the memory usage exploded" wasn't particularly reassuring |
| 05:20.34 | brlcad | grain of salt |
| 05:20.54 | brlcad | there's a couple weeks of reviewing each commit one by one ahead |
| 05:21.16 | brlcad | preceeded by a week or two setting up regression tests for step-g |
| 05:21.27 | brlcad | er, s/week/day/ |
| 05:21.42 | starseeker | winces... that'll be fun (in a pulling teeth kinda way...) |
| 05:22.31 | starseeker | does want to check out the ctest setup they have for testing |
| 05:22.48 | brlcad | meh |
| 05:25.10 | CIA-28 | BRL-CAD: 03starseeker * r48097 10/brlcad/trunk/src/other/CMakeLists.txt: only look for tk.h if we actually want Tk... |
| 05:38.55 | CIA-28 | BRL-CAD: 03starseeker * r48098 10/brlcad/trunk/misc/CMake/BRLCAD_Options.cmake: If it walks like a bool and quacks like a bool, call it a bool |
| 06:07.29 | CIA-28 | BRL-CAD: 03starseeker * r48099 10/brlcad/trunk/ (CMakeLists.txt src/libfb/tcl.c src/mged/doevent.c): These tweaks get things building without X11 headers on Gentoo linux... |
| 06:20.39 | starseeker | woo-hoo! make regress passed on an X11-disabled build (after the above changes) |
| 06:21.02 | starseeker | build with the X11 headers and /usr/lib64/libX11.so moved |
| 06:21.06 | starseeker | s/build/built |
| 06:21.37 | starseeker | wonders how long it's been since that config was tested... or the non-Tk one, for that matter... lot of the changes were C code... |
| 06:22.22 | brlcad | they were all strict issues, which wasn't in place before this year |
| 06:22.58 | brlcad | my last non-x build was probably 2 years ago |
| 06:23.08 | brlcad | mged works? |
| 06:23.21 | brlcad | mged test.g ... should kick off classic iirc |
| 06:26.42 | starseeker | uh... it launches mged with the nu display manager |
| 06:26.55 | brlcad | right, good |
| 06:27.07 | brlcad | nu = null |
| 06:27.11 | starseeker | does prompt first, which is a bit silly when nu is the only option |
| 06:31.51 | CIA-28 | BRL-CAD: 03starseeker * r48100 10/brlcad/trunk/CMakeLists.txt: Disable opengl like we mean it if the required criteria aren't met |
| 06:32.29 | starseeker | actually didn't expect all of regress to pass - figured the gui or loadtk commands would have an issue |
| 06:33.34 | starseeker | well, another checkbox ticked :-) |
| 06:33.36 | starseeker | zzzzz |
| 06:40.36 | *** join/#brlcad jordisayol (~jordisayo@unaffiliated/jordisayol) | |
| 07:03.12 | brlcad | it's worked in the past so even if it didn't work, wouldn't likely have been anything significant -- usually just code creep from that mode not getting exercised regularly |
| 07:03.43 | brlcad | nice to have that baseline confirmed working again, though and in strict nonetheless |
| 07:04.11 | brlcad | though those fb funcs shouldn't exist public (missing fb callbacks) |
| 08:55.24 | brlcad | calls it, wanders |
| 10:16.53 | *** join/#brlcad Technicus (~Technicus@DSLPool-net208-2.wctc.net) | |
| 14:12.11 | ``Erik | heh http://brlcad.org/~erik/brlcad.svg |
| 14:16.02 | archivist | monitor not wide enough error at line one |
| 14:21.22 | ``Erik | heh, it's a mess, and it's the cleanest one from the base graphviz algorithm set |
| 15:16.33 | brlcad | ``Erik: funny but more useful would be seeing just one tool instead of 400 .. that's most of the complexity |
| 15:17.21 | brlcad | there's approximately 25 base libraries, so one tool is going to have somewhere around that many lines anyways |
| 15:17.26 | brlcad | ~400 * 25 |
| 15:17.26 | ibot | 10000 |
| 15:21.24 | ``Erik | I don't see any obvious way to do that, this was just "cmake --graphviz=brlcad.dot /path/to/brlcad" |
| 15:22.21 | ``Erik | they may be add-on generators to cmake *shrug* |
| 15:28.31 | starseeker | yawns |
| 15:49.48 | CIA-28 | BRL-CAD: 03starseeker * r48101 10/brlcad/trunk/src/other/step/src/express/ (CMakeLists.txt expprint.c): Nick says he created this for debugging purposes and it can go. |
| 15:55.19 | CIA-28 | BRL-CAD: 03starseeker * r48102 10/brlcad/trunk/ (3 files in 3 dirs): |
| 15:55.19 | CIA-28 | BRL-CAD: Do a little rework on the lemon target macro - saw an error: Error renaming from |
| 15:55.19 | CIA-28 | BRL-CAD: 'expparse.c' to 'expparse.c': No such file or directory - this might happen if |
| 15:55.19 | CIA-28 | BRL-CAD: lemon does something wrong, but it could also mean lemon isn't done and the copy |
| 15:55.19 | CIA-28 | BRL-CAD: command tries to proceed anyway, so split out the steps to make intermediate |
| 15:55.20 | CIA-28 | BRL-CAD: file dependencies explicit - may help. |
| 15:56.25 | kanzure | hello world |
| 16:17.19 | CIA-28 | BRL-CAD: 03n_reed * r48103 10/brlcad/trunk/src/other/perplex/scanner_template.c: better to create string scanner from pointer and length |
| 16:26.23 | brlcad | hello kanzure |
| 16:37.35 | CIA-28 | BRL-CAD: 03n_reed * r48104 10/brlcad/trunk/src/other/perplex/scanner_template.c: copy input string to buffer so it can be modified if necessary |
| 16:37.47 | CIA-28 | BRL-CAD: 03brlcad * r48105 10/brlcad/trunk/regress/mged.sh: don't need two tests just to make sure mged will receive commands. keep the more complex example since it creates geometry. |
| 16:39.11 | CIA-28 | BRL-CAD: 03r_weiss * r48106 10/brlcad/trunk/src/librt/primitives/nmg/nmg_info.c: Updated function 'nmg_find_pt_in_lu' in file 'nmg_info.c'. Made changes to improve performance. |
| 16:42.43 | CIA-28 | BRL-CAD: 03n_reed * r48107 10/brlcad/trunk/src/other/perplex/scanner_template.c: avoid mixing code and declarations |
| 16:45.43 | CIA-28 | BRL-CAD: 03r_weiss * r48108 10/brlcad/trunk/src/librt/primitives/nmg/nmg_info.c: Updated function 'nmg_find_pt_in_face' in file 'nmg_info.c'. Made changes to improve performance. |
| 16:48.27 | CIA-28 | BRL-CAD: 03tbrowder2 * r48109 10/brlcad/trunk/regress/mged.sh: only one test tgm now |
| 17:03.35 | CIA-28 | BRL-CAD: 03n_reed * r48110 10/brlcad/trunk/src/other/perplex/scanner_template.c: added an unput routine similar to lex unput |
| 18:49.03 | CIA-28 | BRL-CAD: 03n_reed * r48111 10/brlcad/trunk/src/other/perplex/scanner_template.c: add missing prototype |
| 18:57.12 | CIA-28 | BRL-CAD: 03brlcad * r48112 10/brlcad/trunk/regress/mged.sh: readd an even simpler test that makes sure mged will run and exit before we start piping in commands |
| 19:24.25 | CIA-28 | BRL-CAD: 03brlcad * r48113 10/brlcad/trunk/src/librt/primitives/nmg/nmg_info.c: (log message trimmed) |
| 19:24.25 | CIA-28 | BRL-CAD: magic number checking overhaul. remove most of the interior loop and interior |
| 19:24.25 | CIA-28 | BRL-CAD: logic magic number checking. it's important to perform magic number checks as |
| 19:24.25 | CIA-28 | BRL-CAD: part of input validation (akin to assert()) but need not be part of ongoing |
| 19:24.25 | CIA-28 | BRL-CAD: calculations. checking inputs insures that we'll at least narrow in on memory |
| 19:24.26 | CIA-28 | BRL-CAD: corruption to a function scope, which is usually good enough. technically, this |
| 19:24.26 | CIA-28 | BRL-CAD: may introduce a logic change if there is some nasty code relying on a bu_bomb() |
| 20:27.44 | CIA-28 | BRL-CAD: 03brlcad * r48114 10/brlcad/trunk/src/other/perplex/mbo_getopt.cpp: make the mbo_getopt replacement func return -1 like getopt(3), not EOF |
| 20:28.57 | CIA-28 | BRL-CAD: 03brlcad * r48115 10/brlcad/trunk/src/other/perplex/ (parser.y perplex.cpp scanner.re scanner_template.c): fgetc() returns an int, not a char so capture the EOF return value being cast through unsigned char as an int instead of a char (255) |
| 20:36.38 | *** join/#brlcad alex_joni (~alex_joni@emc/board-of-directors/alexjoni) | |
| 20:42.38 | CIA-28 | BRL-CAD: 03starseeker * r48116 10/brlcad/trunk/regress/weight.sh: |
| 20:42.38 | CIA-28 | BRL-CAD: Add a (commented out, for now) additional test for rtweight that feeds it a |
| 20:42.38 | CIA-28 | BRL-CAD: more... quirky density file. As rtweight's parsing of density files is |
| 20:42.38 | CIA-28 | BRL-CAD: currently set up, this will infinite loop (and fill up your hard drive) but |
| 20:42.38 | CIA-28 | BRL-CAD: after rtweight is improved enable this test (will need to replace the current |
| 20:42.39 | CIA-28 | BRL-CAD: 'results text' for weight2 with the correct output. |
| 21:00.43 | CIA-28 | BRL-CAD: 03brlcad * r48117 10/brlcad/trunk/src/librt/prcomb.c: file is unused |
| 21:06.25 | CIA-28 | BRL-CAD: 03brlcad * r48118 10/brlcad/trunk/src/libicv/Makefile.am: manually include the png dirs |
| 21:36.48 | starseeker | brlcad: does the Clarified Artistic License pose any problems for us? http://www.ncftp.com/ncftp/doc/LICENSE.txt |
| 21:55.22 | brlcad | starseeker: given it's a license we don't presently use or have to manage, absolutely .. it'd be yet another with potential incompatibility subtleties |
| 21:55.47 | brlcad | reading the history, the license is an improvmement but was later replaced by the artistic 2.0 license |
| 21:55.56 | brlcad | currently the osi-recommended one to use |
| 21:56.31 | brlcad | still, I'd be leary simply because it's "yet another" .. something would have to be darn worthy and that .. seems unlikely |
| 22:04.54 | starseeker | OK, kinda figured... |
| 22:06.21 | starseeker | nuts |
| 22:06.32 | brlcad | from my quick layman reading.. |
| 22:06.40 | brlcad | it seems to me like it's entirely gpl-comaptible |
| 22:06.50 | brlcad | but not necessarily lgpl compatible |
| 22:08.17 | starseeker | alrightie. Not terribly critical - the elvis clone of Vi has a Win32 port and uses that license. |
| 22:08.28 | brlcad | hehe |
| 22:08.57 | starseeker | ? |
| 22:09.11 | brlcad | nothing :) |
| 22:09.17 | brlcad | I'd just agree |
| 22:09.23 | brlcad | not terribly critical :P |
| 22:09.37 | starseeker | ah |
| 22:11.53 | starseeker | just thought I'd ask - jove is ever more glaring on the "thorns in the side of the Windows port" list |
| 22:12.26 | CIA-28 | BRL-CAD: 03bob1961 * r48119 10/brlcad/trunk/src/tclscripts/lib/Ged.tcl: Modified the signature of the polygon callback. Added calls to polygon callback in end_poly_move. |
| 22:12.56 | brlcad | http://developer.qt.nokia.com/doc/qt-4.8/widgets-codeeditor.html |
| 22:13.18 | brlcad | or even http://developer.qt.nokia.com/doc/qt-4.8/qtextedit.html#id-2c12966c-5a94-46ac-a1ef-dc375be82992 |
| 22:14.48 | CIA-28 | BRL-CAD: 03bob1961 * r48120 10/brlcad/trunk/src/libtclcad/tclcad_obj.c: Added functionality to get/set the polygon list in view coordinates. |
| 22:52.53 | CIA-28 | BRL-CAD: 03n_reed * r48121 10/brlcad/trunk/src/other/ (10 files in 3 dirs): initial build of step express parser using perplex scanner |
| 23:26.42 | CIA-28 | BRL-CAD: 03starseeker * r48122 10/brlcad/trunk/TODO: Add note to work on rtweight/density file parsing. |
| 23:42.02 | CIA-28 | BRL-CAD: 03Tbrowder 07http://brlcad.org * r3258 10/wiki/Contributor_Quickies: correct typo |