| 02:25.03 | *** join/#brlcad CIA-57 (~CIA@cia.atheme.org) | |
| 02:31.10 | CIA-57 | BRL-CAD: 03starseeker * r48202 10/brlcad/trunk/ (misc/CMake/DiffCache.cmake src/libged/CMakeLists.txt): Couple more fixes to ensure re-running cmake doesn't result in rebuild without an actual change. |
| 03:16.14 | *** join/#brlcad yiyus (~124271242@je.je.je) | |
| 05:21.29 | *** join/#brlcad juanman (~quassel@unaffiliated/juanman) | |
| 06:49.55 | *** join/#brlcad dtidrow (~dtidrow@c-68-84-167-135.hsd1.mi.comcast.net) | |
| 09:38.59 | *** join/#brlcad jordisayol (~jordisayo@unaffiliated/jordisayol) | |
| 11:20.23 | *** join/#brlcad juanman (~quassel@unaffiliated/juanman) | |
| 11:42.21 | *** join/#brlcad juanman (~quassel@201.255.13.200) | |
| 11:42.30 | *** join/#brlcad juanman (~quassel@unaffiliated/juanman) | |
| 12:42.25 | *** join/#brlcad juanman (~quassel@186.136.169.88) | |
| 12:42.30 | *** join/#brlcad juanman (~quassel@unaffiliated/juanman) | |
| 13:31.33 | *** join/#brlcad d_rossberg (~rossberg@BZ.BZFLAG.BZ) | |
| 14:32.35 | CIA-57 | BRL-CAD: 03erikgreenwald * r48203 10/brlcad/trunk/src/libicv/fileformat.c: free filename in bif to avoid memory leak. Print filename before freeing. (coverity 1718). |
| 15:01.10 | CIA-57 | BRL-CAD: 03starseeker * r48204 10/brlcad/trunk/ (4 files in 3 dirs): Minor header restructuring to avoid recursive inclusion of bu.h in magic.h - Run 2, CIT 438 |
| 15:26.35 | CIA-57 | BRL-CAD: 03erikgreenwald * r48205 10/brlcad/trunk/src/libanalyze/CMakeLists.txt: test_analyze.c doesn't exist. Comment out for now. |
| 15:41.44 | CIA-57 | BRL-CAD: 03starseeker * r48206 10/brlcad/trunk/doc/README.Linux: Add g++ explicitly for Ubuntu (it's apparently a separately installed package) |
| 15:43.26 | ``Erik | cl |
| 15:45.08 | CIA-57 | BRL-CAD: 03starseeker * r48207 10/brlcad/trunk/src/libwdb/dynamic_geometry.c: Don't assign to dp when we don't need to (while we're at it, pull the other dp assignment out of the if statement). Run 2 CID 1712 |
| 15:45.42 | CIA-57 | BRL-CAD: 03bob1961 * r48208 10/brlcad/trunk/src/libdm/dm-ogl.c: CID 1698, uninspected variable. void the return of callback_funtion(). |
| 15:48.15 | CIA-57 | BRL-CAD: 03starseeker * r48209 10/brlcad/trunk/src/libwdb/dynamic_geometry.c: Don't assign to dp_tmp - not used. Run 2 CID 1711 |
| 15:54.42 | CIA-57 | BRL-CAD: 03starseeker * r48210 10/brlcad/trunk/src/librt/primitives/pipe/pipe_brep.cpp: Don't need to assign to face - Run 2 CID 1710 |
| 15:54.48 | CIA-57 | BRL-CAD: 03erikgreenwald * r48211 10/brlcad/trunk/NEWS: mention crash fix from icv_image write on bad file |
| 16:04.13 | CIA-57 | BRL-CAD: 03bob1961 * r48212 10/brlcad/trunk/src/libdm/ (dm-X.c dm-plot.c dm-ps.c dm-tk.c): run 2, CID #'s (1697, 1699, 1700, 1701), uninspected variable. void the return of callback_funtion(). |
| 16:05.12 | CIA-57 | BRL-CAD: 03erikgreenwald * r48213 10/brlcad/trunk/src/adrt/librender/camera.c: dlclose on bad plugin lookup (coverity 2-461) |
| 16:05.59 | CIA-57 | BRL-CAD: 03starseeker * r48214 10/brlcad/trunk/src/librt/primitives/nmg/nmg_fcut.c: prev_lu isn't used - remove not only assignment but lookup if it's not being used. Run 2 CID 1708 |
| 16:08.36 | CIA-57 | BRL-CAD: 03erikgreenwald * r48215 10/brlcad/trunk/src/adrt/librender/camera.c: explicitely promote time sizes (unsigned shorts) to unsigned int (coverity 2-1256) |
| 16:13.43 | CIA-57 | BRL-CAD: 03starseeker * r48216 10/brlcad/trunk/src/libanalyze/ (CMakeLists.txt test_density.c): Go ahead and stuff in the test_density.c file, but add it to CMAKEFILES since it's not in a working state. |
| 16:25.45 | CIA-57 | BRL-CAD: 03bob1961 * r48217 10/brlcad/trunk/src/gtools/g_diff.c: run 2, CID 1696, uninspected variable. Now only using the return value of db_lookup() to compare to RT_DIR_NULL (i.e. no longer assigning return of db_lookup to a variable) |
| 16:27.01 | CIA-57 | BRL-CAD: 03erikgreenwald * r48218 10/brlcad/trunk/src/adrt/librender/depth.c: remove unused variable (coverity 2-1674) |
| 16:29.38 | CIA-57 | BRL-CAD: 03erikgreenwald * r48219 10/brlcad/trunk/src/adrt/librender/flos.c: remove unused variable (coverity 2-1675) |
| 16:29.54 | CIA-57 | BRL-CAD: 03starseeker * r48220 10/brlcad/trunk/src/vdeck/vdeck.c: sprint->snprintf Run 2 CID 1254 |
| 16:35.51 | CIA-57 | BRL-CAD: 03erikgreenwald * r48221 10/brlcad/trunk/src/adrt/librender/grid.c: remove unused variable (coverity 2-1676) |
| 16:39.24 | CIA-57 | BRL-CAD: 03erikgreenwald * r48222 10/brlcad/trunk/src/adrt/librender/surfel.c: remove unused variable (coverity 2-1677) |
| 16:42.11 | CIA-57 | BRL-CAD: 03erikgreenwald * r48223 10/brlcad/trunk/src/adrt/librender/path.c: initialize variable (coverity 2-1597) |
| 16:48.49 | CIA-57 | BRL-CAD: 03erikgreenwald * r48224 10/brlcad/trunk/src/adrt/load_g.c: Check db_lookup return value for NULL (bad .g file) (coverity 2-396) |
| 17:14.31 | CIA-57 | BRL-CAD: 03indianlarry * r48225 10/brlcad/trunk/src/librt/primitives/brep/brep.cpp: Restructured 'if' statement to pull embedded assignment from conditional. Run 2 CID 1707 |
| 17:36.20 | CIA-57 | BRL-CAD: 03erikgreenwald * r48226 10/brlcad/trunk/src/libbn/tabdata.c: test return value of bu_vls_gets() (coverity 2-130) |
| 17:46.10 | CIA-57 | BRL-CAD: 03erikgreenwald * r48227 10/brlcad/trunk/src/librt/primitives/bot/tie.c: fill in uninitialized struct (coverity 2-1596 and 2-1625) |
| 18:27.08 | CIA-57 | BRL-CAD: 03erikgreenwald * r48228 10/brlcad/trunk/src/librt/primitives/brep/brep.cpp: indent |
| 18:44.57 | CIA-57 | BRL-CAD: 03indianlarry * r48229 10/brlcad/trunk/src/librt/primitives/pipe/pipe_brep.cpp: Added 'void' cast call of non-void returning function, avoids possible compiler warnings about caused unused return values. Extends Run 2 CID 1710 |
| 18:45.04 | CIA-57 | BRL-CAD: 03erikgreenwald * r48230 10/brlcad/trunk/src/vdeck/vdeck.c: minor tweak to make slightly more readable |
| 18:56.02 | CIA-57 | BRL-CAD: 03bob1961 * r48231 10/brlcad/trunk/src/librt/vlist.c: run 2, CID 114. Put the return of getc() into an int and check for EOF. |
| 19:08.14 | CIA-57 | BRL-CAD: 03starseeker * r48232 10/brlcad/trunk/misc/CMake/ (ThirdParty.cmake ThirdParty_TCL.cmake): Restore the CMake gui dropdown behavior - may have fixed some other behavior issues, needs more testing. |
| 19:22.47 | CIA-57 | BRL-CAD: 03erikgreenwald * r48233 10/brlcad/trunk/ (NEWS src/sig/d2-c.c): For the first time ever, handle imaginary component correctly. (coverity 2-1645) |
| 19:53.57 | CIA-57 | BRL-CAD: 03r_weiss * r48234 10/brlcad/trunk/src/librt/primitives/nmg/nmg_misc.c: Updated file 'nmg_misc.c' functions 'nmg_make_faces_within_tol' and 'nmg_calc_face_plane'. Initialized variables, did some code cleanup and fixed a float compare to '0.0'. |
| 20:00.34 | CIA-57 | BRL-CAD: 03erikgreenwald * r48235 10/brlcad/trunk/src/util/random.c: Remove 'cleverness' that caused dead code paths. Cov2-231 |
| 20:03.43 | CIA-57 | BRL-CAD: 03erikgreenwald * r48236 10/brlcad/trunk/src/rt/do.c: flip conditions to allow >512*512 to trigger (dead code fix, cov2-227) |
| 20:10.24 | CIA-57 | BRL-CAD: 03starseeker * r48237 10/brlcad/trunk/src/conv/comgeom/cvt.c: |
| 20:10.24 | CIA-57 | BRL-CAD: Check returns on sscanf - test to see if Coverity will accept sscanf if we both |
| 20:10.24 | CIA-57 | BRL-CAD: have length specifications on all our percent-type format items and check the |
| 20:10.24 | CIA-57 | BRL-CAD: return type - patch-g.c was the only case previously where both of those things |
| 20:10.24 | CIA-57 | BRL-CAD: were true. Run 2 CID 633, but has much broader implications. |
| 20:11.56 | CIA-57 | BRL-CAD: 03erikgreenwald * r48238 10/brlcad/trunk/src/conv/g-egg.c: regions_tried is never updated, so eliminate code looking for that info. Cov2-172 |
| 20:15.48 | starseeker | postes this link for future consideration: http://stackoverflow.com/questions/1621394/how-to-prevent-scanf-causing-a-buffer-overflow-in-c |
| 20:25.01 | CIA-57 | BRL-CAD: 03erikgreenwald * r48239 10/brlcad/trunk/src/librt/primitives/metaball/metaball_tri.c: fix region null testing. Cov2-303 |
| 20:27.54 | CIA-57 | BRL-CAD: 03n_reed * r48240 10/brlcad/trunk/include/ (bu.h fb.h): rename __BU_ATTR_FORMAT* to _BU_ATTR_PRINTF* and _BU_ATTR_SCANF* to support scan scanf checks |
| 20:28.57 | CIA-57 | BRL-CAD: 03erikgreenwald * r48241 10/brlcad/trunk/src/adrt/isst_tcltk.c: fix paren placement problem, strlen(str+1) != strlen(str)+1. Cov3-1721 |
| 20:30.35 | CIA-57 | BRL-CAD: 03bob1961 * r48242 10/brlcad/trunk/src/libged/ (glob.c qray.c): run 3, CID 155, 156. Calling GED_INITIALIZED within GED_CHECK_DATABASE_OPEN is bad (i.e. gedp could be NULL). |
| 20:31.42 | CIA-57 | BRL-CAD: 03erikgreenwald * r48243 10/brlcad/trunk/src/adrt/isst_tcltk.c: set buf[0] to 0. Cov3-1801 |
| 20:34.58 | CIA-57 | BRL-CAD: 03r_weiss * r48244 10/brlcad/trunk/src/librt/primitives/nmg/nmg_mk.c: Updated 'nmg_demote_lu' in file 'nmg_mk.c'. Fixed a possible 'use after free' error. |
| 20:35.28 | CIA-57 | BRL-CAD: 03erikgreenwald * r48245 10/brlcad/trunk/src/libicv/fileformat.c: fclose the freopened descriptors? Cov3-479 |
| 20:38.16 | CIA-57 | BRL-CAD: 03erikgreenwald * r48246 10/brlcad/trunk/src/libicv/fileformat.c: fclose the freopened descriptors? Cov3-480 |
| 20:43.55 | *** join/#brlcad merzo (~merzo@221-161-133-95.pool.ukrtel.net) | |
| 20:45.30 | *** join/#brlcad piksi (piksi@pi-xi.net) | |
| 20:59.40 | CIA-57 | BRL-CAD: 03bob1961 * r48247 10/brlcad/trunk/src/conv/g-egg.c: Removed unused variables. |
| 21:02.52 | CIA-57 | BRL-CAD: 03bob1961 * r48248 10/brlcad/trunk/src/libged/cat.c: run3, CID 194. Removed unnecessary check or argc. |
| 21:05.59 | CIA-57 | BRL-CAD: 03erikgreenwald * r48249 10/brlcad/trunk/src/librt/db5_io.c: eliminate unused assign. Cov3-1678 |
| 21:06.53 | CIA-57 | BRL-CAD: 03starseeker * r48250 10/brlcad/trunk/src/librt/ (db_open.c wdb.c): Add some null checks (attempt at addressing Run3 CID 1771) |
| 21:06.59 | CIA-57 | BRL-CAD: 03erikgreenwald * r48251 10/brlcad/trunk/src/librt/db5_io.c: eliminate unused assign. Cov3-1679 |
| 21:09.31 | CIA-57 | BRL-CAD: 03erikgreenwald * r48252 10/brlcad/trunk/src/conv/asc/asc2g.c: eliminate unused assignment. Cov3-1682 |
| 21:10.31 | CIA-57 | BRL-CAD: 03erikgreenwald * r48253 10/brlcad/trunk/src/conv/asc/asc2g.c: remove double alloc. Cov3-1683 |
| 21:12.36 | CIA-57 | BRL-CAD: 03erikgreenwald * r48254 10/brlcad/trunk/src/librt/db5_io.c: remove unused assign. Cov3-1680 |
| 21:14.57 | CIA-57 | BRL-CAD: 03erikgreenwald * r48255 10/brlcad/trunk/src/librt/primitives/nmg/nmg_misc.c: remove unused assign. Cov3-1687 |
| 21:17.11 | CIA-57 | BRL-CAD: 03erikgreenwald * r48256 10/brlcad/trunk/src/libged/edit.c: remove unused assign. Cov3-1821 |
| 21:20.55 | CIA-57 | BRL-CAD: 03starseeker * r48257 10/brlcad/trunk/src/fbserv/server.c: Add a series of checks for null buffers in fbserv |
| 21:26.33 | CIA-57 | BRL-CAD: 03bob1961 * r48258 10/brlcad/trunk/src/libged/comb_std.c: run 3, CID 196. dp is tested in several places after being set to RT_DIR_NULL. Removed code that can never be reached. |
| 21:36.50 | CIA-57 | BRL-CAD: 03starseeker * r48259 10/brlcad/trunk/src/fbserv/server.c: While we're at it, check pcp |
| 21:55.28 | CIA-57 | BRL-CAD: 03starseeker * r48260 10/brlcad/trunk/src/librt/search.c: Initialize tmp.flags - Run 3 CID 1619 |
| 22:15.01 | CIA-57 | BRL-CAD: 03starseeker * r48261 10/brlcad/trunk/src/librt/search.c: Analysis indicates by this point we're definitely BRLCAD_OK, so don't bother with the check Run 3 CID 201 |
| 22:16.58 | CIA-57 | BRL-CAD: 03brlcad * r48262 10/brlcad/trunk/bench/pixcmp.c: if skip2 is null but skip1 is not, don't dereference and segfault (cov run 3 cid 1738) |
| 22:20.57 | CIA-57 | BRL-CAD: 03starseeker * r48263 10/brlcad/trunk/src/librt/search.c: Check return of rt_db_get_internal - just return if we don't get anything and move on. Run 3 CID 144. |
| 22:26.11 | CIA-57 | BRL-CAD: 03starseeker * r48264 10/brlcad/trunk/src/librt/search.c: Check return value of db5_get_attributes. Run 3 CID 143 |
| 22:26.35 | CIA-57 | BRL-CAD: 03brlcad * r48265 10/brlcad/trunk/src/libged/edit.c: if we're not going to test the memchr() result, then there's no reason to even call it. related to cov run 3 cid 1821, r48256. |