| 00:02.33 | CIA-57 | BRL-CAD: 03starseeker * r48455 10/brlcad/trunk/src/librt/tree.c: No tsp, no use tsp. CID 307 |
| 00:10.52 | CIA-57 | BRL-CAD: 03starseeker * r48456 10/brlcad/trunk/src/mged/animedit.c: Coverity found a path that gets to this point in animedit with test_hold null - check for the null, but may be symptomatic of deeper issue. CID 309 |
| 00:12.52 | CIA-57 | BRL-CAD: 03brlcad * r48457 10/brlcad/trunk/src/libbu/fnmatch.c: initialize the checkfun callback even though we don't use it for sanity. coverity UNINIT (cid 1616). |
| 00:13.27 | CIA-57 | BRL-CAD: 03starseeker * r48458 10/brlcad/trunk/src/mged/animedit.c: for good measure, check second usage. |
| 00:21.02 | CIA-57 | BRL-CAD: 03starseeker * r48459 10/brlcad/trunk/src/mged/dodraw.c: Another check the tsp first case - CID 310 |
| 00:30.22 | CIA-57 | BRL-CAD: 03starseeker * r48460 10/brlcad/trunk/src/mged/ (CMakeLists.txt hideline.c): Remove hideline.c - function within it flagged by Coverity, no use of any code in file - CID 311 |
| 00:32.26 | CIA-57 | BRL-CAD: 03brlcad * r48461 10/brlcad/trunk/CMakeLists.txt: test for the mmsystem.h windows header so we can conditionalize on feature instead of platform. |
| 00:32.31 | *** join/#brlcad cadman (~Adium@64.178.177.71) | |
| 00:35.10 | CIA-57 | BRL-CAD: 03brlcad * r48462 10/brlcad/trunk/src/libbu/timer.c: |
| 00:35.11 | CIA-57 | BRL-CAD: Restructure and cleanup. conditionalize on feature instead of platform and pull |
| 00:35.11 | CIA-57 | BRL-CAD: the logging statement into a fall-back case so we'll know at compile-time if we |
| 00:35.11 | CIA-57 | BRL-CAD: end up in an undefined state. handles coverity UNREACHABLE issue (cid 1669). |
| 00:36.24 | CIA-57 | BRL-CAD: 03starseeker * r48463 10/brlcad/trunk/src/mged/setup.c: If interpreter is NULL, that's a Bad Thing - warn and return without trying anything fancy. CID 312 |
| 00:51.50 | CIA-57 | BRL-CAD: 03starseeker * r48464 10/brlcad/trunk/src/nirt/command.c: No rtip, no shoot - CID 313 |
| 00:52.24 | CIA-57 | BRL-CAD: 03brlcad * r48465 10/brlcad/trunk/src/libbu/test_htond.c: naive attempt to quell coverity DEADCODE warning (cid 1731). the sizeof() constant is expectedly causing unreachable code. |
| 00:53.04 | CIA-57 | BRL-CAD: 03starseeker * r48466 10/brlcad/trunk/src/nirt/command.c: properly mark buffer and ctp as unused |
| 00:59.06 | CIA-57 | BRL-CAD: 03starseeker * r48467 10/brlcad/trunk/src/proc-db/pipe.c: Don't call Make_name if we've got a sphere - CID 315 |
| 00:59.10 | CIA-57 | BRL-CAD: 03brlcad * r48468 10/brlcad/trunk/src/libbu/test_htond.c: try a lil harder, make len volatile |
| 01:03.17 | CIA-57 | BRL-CAD: 03starseeker * r48469 10/brlcad/trunk/src/remrt/remrt.c: only try things with fp if it's not NULL - CID 317 |
| 01:19.40 | CIA-57 | BRL-CAD: 03starseeker * r48470 10/brlcad/trunk/ (NEWS src/shapes/coil.c): Fixed a crash condition in coil where the combination of the -S and -l options would result in an attempt to dereference a NULL variable. CID 318 |
| 01:21.33 | CIA-57 | BRL-CAD: 03brlcad * r48471 10/brlcad/trunk/src/libbu/vls.c: |
| 01:21.33 | CIA-57 | BRL-CAD: fix for an off-by-one strncpy() error reported by coverity via OVERRUN_STATIC |
| 01:21.33 | CIA-57 | BRL-CAD: check. my own bad even after numerous terrible refactorings. it was writing |
| 01:21.33 | CIA-57 | BRL-CAD: one byte too many after the fbuf format buffer for long format strings. few |
| 01:21.33 | CIA-57 | BRL-CAD: more iterations and might get it right eventually. (cid 1747) |
| 01:22.14 | CIA-57 | BRL-CAD: 03brlcad * r48472 10/brlcad/trunk/src/libbu/vls.c: what's a few more bytes amongst friends |
| 01:25.21 | CIA-57 | BRL-CAD: 03starseeker * r48473 10/brlcad/trunk/src/libged/wdb_obj.c: Can't report that wdbp is null to the interpreter when the data structure containing the pointer to the interpreter (wdbp) is null - just return TCL_ERROR. CID 1740 |
| 01:26.49 | CIA-57 | BRL-CAD: 03brlcad * r48474 10/brlcad/trunk/src/libbu/temp.c: |
| 01:26.49 | CIA-57 | BRL-CAD: dereferencing the popped list value without actually checking if it's null |
| 01:26.49 | CIA-57 | BRL-CAD: (although the loop iterator does this for us, so not technically an issue). |
| 01:26.49 | CIA-57 | BRL-CAD: simplify the logic. should fix coverity REVERSE_INULL issue. (cov cid 1758) |
| 01:36.26 | CIA-57 | BRL-CAD: 03brlcad * r48475 10/brlcad/trunk/src/libbu/test_htond.c: try a trivial quellage for coverity TAINTED_SCALAR issue. given the unit test is not standalone, though, it could use some improvement love or get removed. (cid 1767) |
| 01:46.54 | CIA-57 | BRL-CAD: 03starseeker * r48476 10/brlcad/trunk/src/libged/edit.c: Correct test for subcmd.cmd - CID 1741 |
| 01:49.33 | CIA-57 | BRL-CAD: 03starseeker * r48477 10/brlcad/trunk/src/libged/png.c: more pt_prev checks - CID 1742 |
| 01:51.40 | CIA-57 | BRL-CAD: 03starseeker * r48478 10/brlcad/trunk/src/libged/ps.c: more pt_prev checks - CID 1743 |
| 01:54.27 | CIA-57 | BRL-CAD: 03starseeker * r48479 10/brlcad/trunk/src/rt/heatgraph.c: Check fbp for NULL - CID 1745 |
| 02:07.00 | CIA-57 | BRL-CAD: 03brlcad * r48480 10/brlcad/trunk/src/shapes/fence.c: |
| 02:07.00 | CIA-57 | BRL-CAD: fixes for coverity FORWARD_NULL and RESOURCE_LEAK defects (cid 1848,1849,1878) |
| 02:07.00 | CIA-57 | BRL-CAD: where we kept processing if a db operation failed. memory leak was a malloc() |
| 02:07.00 | CIA-57 | BRL-CAD: that snuck past libbu memory allocation conversion reviews somehow. |
| 05:08.54 | *** join/#brlcad cadman (~Adium@64.178.177.71) | |
| 05:12.45 | *** part/#brlcad cadman (~Adium@64.178.177.71) | |
| 05:15.12 | *** join/#brlcad cadman (~Adium@64.178.177.71) | |
| 06:15.40 | *** join/#brlcad juanman (~quassel@unaffiliated/juanman) | |
| 07:16.10 | *** join/#brlcad jordisayol (~jordisayo@unaffiliated/jordisayol) | |
| 08:07.52 | *** join/#brlcad merzo (~merzo@193.254.217.44) | |
| 11:22.04 | CIA-57 | BRL-CAD: 03indianlarry * r48481 10/brlcad/trunk/src/conv/step/ (11 files): Cleaned up coverity identified memory leaks. These relate to Run 6 CIDs: 1865-76. |
| 12:22.54 | starseeker | O.o http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=617613#119 |
| 13:45.16 | CIA-57 | BRL-CAD: 03n_reed * r48482 10/brlcad/trunk/src/fb/pp-fb.c: need to compare getchar return to EOF, CID 113 |
| 13:47.01 | CIA-57 | BRL-CAD: 03starseeker * r48483 10/brlcad/trunk/src/libged/wdb_bigE.c: Checking is pointless - eptr is always null in this case - CID 2063 |
| 13:51.45 | CIA-57 | BRL-CAD: 03starseeker * r48484 10/brlcad/trunk/src/libged/bigE.c: Checking is pointless - eptr is always null in this case - CID 2062 |
| 14:02.06 | CIA-57 | BRL-CAD: 03erikgreenwald * r48485 10/brlcad/trunk/src/conv/g-egg.c: move the argv test to after the advance. Cov1524 |
| 14:04.55 | CIA-57 | BRL-CAD: 03r_weiss * r48486 10/brlcad/trunk/src/conv/obj-g.c: Updated file 'obj-g.c' to remove potential of dereferencing a null pointer. Coverity CID 1739. |
| 14:09.07 | CIA-57 | BRL-CAD: 03starseeker * r48487 10/brlcad/trunk/src/libged/edit.c: Make sure we have kp_v before we de-reference it - CID 1846 |
| 14:14.19 | CIA-57 | BRL-CAD: 03n_reed * r48488 10/brlcad/trunk/src/util/sun-pix.c: need to compare getc returns to EOF, CID 117 |
| 14:17.52 | *** join/#brlcad jordisayol (~jordisayo@unaffiliated/jordisayol) | |
| 14:21.17 | CIA-57 | BRL-CAD: 03starseeker * r48489 10/brlcad/trunk/src/fb/gif2fb.c: Do the NULL check. CID 397 |
| 14:21.45 | CIA-57 | BRL-CAD: 03erikgreenwald * r48490 10/brlcad/trunk/src/burst/ui.c: close colorfile after reading it (resource leak Cov462) |
| 14:23.36 | CIA-57 | BRL-CAD: 03erikgreenwald * r48491 10/brlcad/trunk/src/conv/fast4-g.c: close file after reading colors. Cov463 |
| 14:24.47 | *** join/#brlcad jordisayol (~jordisayo@unaffiliated/jordisayol) | |
| 14:47.28 | *** join/#brlcad jordisayol (~jordisayo@188.119.210.222.dynamic.eurona.net) | |
| 14:47.33 | *** join/#brlcad jordisayol (~jordisayo@unaffiliated/jordisayol) | |
| 14:52.42 | CIA-57 | BRL-CAD: 03bob1961 * r48492 10/brlcad/trunk/src/conv/intaval/tgf-g.cpp: Undo the last two commits because they didn't satisfy covarity. We have another lower level fix that should suffice. |
| 15:04.18 | CIA-57 | BRL-CAD: 03n_reed * r48493 10/brlcad/trunk/src/vdeck/vdeck.c: check getchar return for EOF, and ensure dest string is not overrun, CID 118 |
| 15:05.04 | CIA-57 | BRL-CAD: 03erikgreenwald * r48494 10/brlcad/trunk/src/libged/view_obj.c: set default view pt. CID 1622 |
| 15:08.29 | CIA-57 | BRL-CAD: 03erikgreenwald * r48495 10/brlcad/trunk/src/libged/view_obj.c: initialize var. CID1621 |
| 15:12.51 | CIA-57 | BRL-CAD: 03erikgreenwald * r48496 10/brlcad/trunk/src/librt/shoot.c: zero out shootray status memory. Cov1627 |
| 15:14.54 | CIA-57 | BRL-CAD: 03erikgreenwald * r48497 10/brlcad/trunk/src/librt/primitives/dsp/dsp.c: zero out hit structs. Cov1626 |
| 15:16.36 | CIA-57 | BRL-CAD: 03erikgreenwald * r48498 10/brlcad/trunk/src/librt/bundle.c: zero out shootray status memory. Cov1624 |
| 15:22.08 | CIA-57 | BRL-CAD: 03brlcad * r48499 10/brlcad/trunk/src/libbu/test_htond.c: 48475 didn't fix it, revert |
| 15:22.27 | CIA-57 | BRL-CAD: 03starseeker * r48500 10/brlcad/trunk/ (include/bu.h src/libbu/brlcad_path.c src/libbu/file.c): Wrap realpath/GetFullPathName logic into a bu routine for re-use in other locations - move it out of brlcad_path.c |
| 15:22.30 | CIA-57 | BRL-CAD: 03erikgreenwald * r48501 10/brlcad/trunk/src/librt/vlist.c: Pull magic values out to ../src/librt/bundle.cdefines. Zero out all carg/carg memory. Cov1617 |
| 15:25.57 | CIA-57 | BRL-CAD: 03n_reed * r48502 10/brlcad/trunk/src/fb/gif-fb.c: s/==/=, CID 154 |
| 15:35.48 | CIA-57 | BRL-CAD: 03erikgreenwald * r48503 10/brlcad/trunk/src/librt/bundle.c: include string for memset |
| 15:37.06 | CIA-57 | BRL-CAD: 03bob1961 * r48504 10/brlcad/trunk/src/irprep/shapefact.c: run 6, CID 1926, tainted scalar. Check upper and lower bound of loops. Also change loops and r to size_t instead of double. |
| 15:44.57 | CIA-57 | BRL-CAD: 03n_reed * r48505 10/brlcad/trunk/src/librt/primitives/nmg/nmg_ck.c: remove unnecessary null check, CID 163 |
| 15:48.28 | CIA-57 | BRL-CAD: 03bob1961 * r48506 10/brlcad/trunk/src/librt/primitives/obj_vshot.c: run 6, CID 1850, infinite loop. |
| 15:50.28 | CIA-57 | BRL-CAD: 03starseeker * r48507 10/brlcad/trunk/ (5 files in 2 dirs): rename to bu_realpath. |
| 15:53.40 | CIA-57 | BRL-CAD: 03brlcad * r48508 10/brlcad/trunk/src/libbu/ (CMakeLists.txt Makefile.am test_htond.c): remove test_htond since it has a coverity issue and usage is not obvious given it requires some specific input fed via stdin. |
| 15:58.54 | CIA-57 | BRL-CAD: 03bob1961 * r48509 10/brlcad/trunk/src/libdm/query.c: run 6, CID 1818, unreachable. |
| 16:01.44 | CIA-57 | BRL-CAD: 03n_reed * r48510 10/brlcad/trunk/src/conv/comgeom/solid.c: prevent leak, remove dead free, CID 165 |
| 16:12.36 | CIA-57 | BRL-CAD: 03bob1961 * r48511 10/brlcad/trunk/src/shapes/window_frame.c: run 6, CID 1812, UNINIT. |
| 16:16.53 | CIA-57 | BRL-CAD: 03bob1961 * r48512 10/brlcad/trunk/src/shapes/gastank.c: run 6, CID 1811, UNINIT. |
| 16:18.50 | CIA-57 | BRL-CAD: 03erikgreenwald * r48513 10/brlcad/trunk/src/librt/db5_io.c: test lenbuf after fread to verify an actual number is there before decoding the length. Cov1459 |
| 16:22.30 | CIA-57 | BRL-CAD: 03bob1961 * r48514 10/brlcad/trunk/src/shapes/gastank.c: run 6, CID 1810, UNINIT. |
| 16:27.02 | CIA-57 | BRL-CAD: 03bob1961 * r48515 10/brlcad/trunk/src/shapes/gastank.c: run 6, CID 1809, UNINIT. |
| 16:29.19 | CIA-57 | BRL-CAD: 03erikgreenwald * r48516 10/brlcad/trunk/src/librt/db5_io.c: test for possible overflow on pointer advance. Cov322 |
| 16:36.02 | CIA-57 | BRL-CAD: 03erikgreenwald * r48517 10/brlcad/trunk/src/librt/db5_io.c: force addr/phony to unsigned explicitely to avoid coverity warning about a possible negative later. CID 368 |
| 16:36.11 | CIA-57 | BRL-CAD: 03starseeker * r48518 10/brlcad/trunk/src/shapes/coil.c: Dead code - is_start is either true or it isn't. CID 1672 |
| 16:37.52 | CIA-57 | BRL-CAD: 03starseeker * r48519 10/brlcad/trunk/src/shapes/coil.c: Same deal - is_start is either true or false, so one of the two if conditions will return. CID 1673 |
| 16:45.14 | CIA-57 | BRL-CAD: 03bob1961 * r48520 10/brlcad/trunk/include/raytrace.h: Added RT_CURVATURE_INIT_ZERO. |
| 16:46.26 | CIA-57 | BRL-CAD: 03bob1961 * r48521 10/brlcad/trunk/src/rt/rtshot.c: run 6, CID 1806, UNINIT. |
| 16:48.43 | CIA-57 | BRL-CAD: 03n_reed * r48522 10/brlcad/trunk/src/librt/primitives/nmg/nmg_rt_isect.c: bad control logic, CID 167 |
| 16:50.41 | CIA-57 | BRL-CAD: 03erikgreenwald * r48523 10/brlcad/trunk/src/librt/db5_io.c: fix up handling of length reading. Cov1459. |
| 16:53.16 | CIA-57 | BRL-CAD: 03erikgreenwald * r48524 10/brlcad/trunk/src/librt/db_scan.c: check return value of ftell. Cov369 |
| 16:54.36 | CIA-57 | BRL-CAD: 03bob1961 * r48525 10/brlcad/trunk/src/librt/bool.c: run 6, CID 1804/5, UNINIT. |
| 16:58.30 | CIA-57 | BRL-CAD: 03erikgreenwald * r48526 10/brlcad/trunk/src/liboptical/photonmap.c: actually return on failed irradiance cache read instead of just reporting failure and attempting to continue... |
| 17:06.50 | CIA-57 | BRL-CAD: 03erikgreenwald * r48527 10/brlcad/trunk/src/liboptical/photonmap.c: test I1 values. Cov1483 |
| 17:13.14 | CIA-57 | BRL-CAD: 03erikgreenwald * r48528 10/brlcad/trunk/src/librt/db_lookup.c: minor cleanup for readability. Explicitly cast char to long for hash (Cov1257) |
| 17:13.50 | CIA-57 | BRL-CAD: 03bob1961 * r48529 10/brlcad/trunk/src/irprep/shapefact.c: clamp loops to UINT32_MAX. |
| 17:23.39 | CIA-57 | BRL-CAD: 03starseeker * r48530 10/brlcad/trunk/src/irprep/shapefact.c: scanf failures are bad - if we aren't giving them another chance to enter info, exit instead of just printing an error. |
| 17:25.57 | CIA-57 | BRL-CAD: 03bob1961 * r48531 10/brlcad/trunk/src/conv/g-vrml.c: run 6, CID 1762,3,4. SIZEOF_MISMATCH. |
| 17:26.45 | CIA-57 | BRL-CAD: 03n_reed * r48532 10/brlcad/trunk/src/conv/asc/asc2g.c: missing break, CID 335 |
| 17:41.22 | CIA-57 | BRL-CAD: 03n_reed * r48533 10/brlcad/trunk/src/conv/iges/iges.c: replace multi-case switch with single if. CID 337 |
| 17:47.25 | CIA-57 | BRL-CAD: 03n_reed * r48534 10/brlcad/trunk/src/conv/nastran-g.c: missing break CID 338 |
| 17:50.24 | CIA-57 | BRL-CAD: 03erikgreenwald * r48535 10/brlcad/trunk/src/librt/primitives/revolve/revolve.c: remove test to see if nhits > MAX_HITS, as nhits is set to 0 before. Cov211 |
| 17:54.45 | CIA-57 | BRL-CAD: 03indianlarry * r48536 10/brlcad/trunk/src/libbu/ (mappedfile.c realpath.c): Attempt to fix most of the TAINTED_STRING issues. Currently only testing call to bu_realpath() in bu_open_mapped_file(). |
| 17:55.44 | CIA-57 | BRL-CAD: 03bob1961 * r48537 10/brlcad/trunk/src/liboptical/material.c: run 6, CID 1754, RESOURCE LEAK. |
| 17:58.10 | CIA-57 | BRL-CAD: 03starseeker * r48538 10/brlcad/trunk/src/libgcv/wfobj/obj_parser_state.h: initialize the parser - CID 1933 |
| 17:58.25 | *** join/#brlcad KimK (~Kim__@209.248.147.2.nw.nuvox.net) | |
| 17:58.38 | CIA-57 | BRL-CAD: 03erikgreenwald * r48539 10/brlcad/trunk/src/librt/primitives/bot/bot.c: bn_dist_pt2_lseg2 returns [-2,3], so cases 4 and 5 can never be reached. Comment them out for now. Cov354 |
| 18:00.19 | CIA-57 | BRL-CAD: 03erikgreenwald * r48540 10/brlcad/trunk/src/librt/primitives/bot/bot.c: comment out unused variables |
| 18:02.24 | CIA-57 | BRL-CAD: 03bob1961 * r48541 10/brlcad/trunk/src/libged/color.c: run 6, CID 1753, RESOURCE LEAK. |
| 18:04.08 | CIA-57 | BRL-CAD: 03n_reed * r48542 10/brlcad/trunk/src/conv/nmg/g-nmg.c: missing break CID 339 |
| 18:14.49 | *** join/#brlcad jordisayol (~jordisayo@unaffiliated/jordisayol) | |
| 18:18.58 | CIA-57 | BRL-CAD: 03n_reed * r48543 10/brlcad/trunk/src/conv/patch/rpatch.c: fall-through from default case CID 340 |
| 18:19.26 | CIA-57 | BRL-CAD: 03erikgreenwald * r48544 10/brlcad/trunk/src/librt/primitives/dsp/dsp.c: add missing break Cov356 |
| 18:20.38 | CIA-57 | BRL-CAD: 03erikgreenwald * r48545 10/brlcad/trunk/src/librt/primitives/dsp/dsp.c: add missing break Cov355 |
| 18:20.51 | CIA-57 | BRL-CAD: 03starseeker * r48546 10/brlcad/trunk/src/other/lemon/lempar.c: do the check before using the index value, to avoid a possible negative index value - CID 1883 |
| 18:22.34 | CIA-57 | BRL-CAD: 03erikgreenwald * r48547 10/brlcad/trunk/src/util/pixdsplit.c: test argv before trying to open Cov1582 |
| 18:23.06 | CIA-57 | BRL-CAD: 03starseeker * r48548 10/brlcad/trunk/ (3 files in 3 dirs): Go ahead and depend on the template file when running lemon - it's usually static, but we just had a case where it WAS changed, so check in the future. |
| 18:23.47 | CIA-57 | BRL-CAD: 03erikgreenwald * r48549 10/brlcad/trunk/src/util/pixdsplit.c: NULL -> '\0' |
| 18:26.36 | CIA-57 | BRL-CAD: 03erikgreenwald * r48550 10/brlcad/trunk/src/util/dsp_add.c: stat after the open, hopefully avoiding the race condition. Cov1592 |
| 18:26.44 | CIA-57 | BRL-CAD: 03n_reed * r48551 10/brlcad/trunk/src/fb/fbzoom.c: fall-through from default case CID 341 |
| 18:35.30 | *** join/#brlcad merzo (~merzo@69-227-133-95.pool.ukrtel.net) | |
| 18:37.40 | CIA-57 | BRL-CAD: 03starseeker * r48552 10/brlcad/trunk/src/librt/opennurbs_ext.cpp: Free before returning null - CID 1873 |
| 18:39.51 | CIA-57 | BRL-CAD: 03brlcad * r48553 10/brlcad/trunk/src/libbu/mappedfile.c: |
| 18:39.51 | CIA-57 | BRL-CAD: twice as long, but should be much more readable than the convoluted mess it was. |
| 18:39.51 | CIA-57 | BRL-CAD: still room for improvement and several bits of replication but it should be |
| 18:39.51 | CIA-57 | BRL-CAD: equivalent. consequently fixes a TOCTOU issue reported by coverity due to the |
| 18:39.51 | CIA-57 | BRL-CAD: stat that was followed by a later open call. (cid 1587) |
| 18:39.55 | CIA-57 | BRL-CAD: 03bob1961 * r48554 10/brlcad/trunk/src/libged/vdraw.c: run 6, CID 1752, OVERRUN STATIC. |
| 18:42.05 | *** join/#brlcad merzo (~merzo@98-201-201-46.pool.ukrtel.net) | |
| 18:45.53 | CIA-57 | BRL-CAD: 03indianlarry * r48555 10/brlcad/trunk/src/libged/ (make.c typein.c): Fixed case where sizeof(fastf_t **)should be sizeof(fastf_t *) as picked up by coverity. Resolves Run 6 CIDs: 1267-8. |
| 18:49.55 | *** join/#brlcad b0ef (~b0ef@241.194.251.212.customer.cdi.no) | |
| 18:50.17 | CIA-57 | BRL-CAD: 03erikgreenwald * r48556 10/brlcad/trunk/src/librt/primitives/bot/bot.c: change logical op to bitwise op for setting bit flags. Cov153 |
| 18:50.47 | CIA-57 | BRL-CAD: 03n_reed * r48557 10/brlcad/trunk/src/fb/pp-fb.c: remove unnecessary quit flag to get pure fall-through. CID 344 |
| 18:52.35 | CIA-57 | BRL-CAD: 03starseeker * r48558 10/brlcad/trunk/src/other/lemon/lempar.c: Make sure yyruleno is sane - CID 1860 |
| 19:17.38 | *** join/#brlcad cadman (~Adium@64.178.177.71) | |
| 19:18.37 | *** part/#brlcad cadman (~Adium@64.178.177.71) | |
| 19:19.03 | *** join/#brlcad cadman (~Adium@64.178.177.71) | |
| 19:28.50 | CIA-57 | BRL-CAD: 03erikgreenwald * r48559 10/brlcad/trunk/src/libged/edit.c: coverity says this necessarily passes, so if0 it out. Cov1727 |
| 19:31.58 | CIA-57 | BRL-CAD: 03erikgreenwald * r48560 10/brlcad/trunk/src/librt/primitives/nmg/nmg.c: add test to verify that count > 0. Cov572 |
| 19:37.58 | CIA-57 | BRL-CAD: 03erikgreenwald * r48561 10/brlcad/trunk/src/librt/comb/db_comb.c: set string terminator Cov111 |
| 19:38.45 | CIA-57 | BRL-CAD: 03erikgreenwald * r48562 10/brlcad/trunk/src/librt/comb/db_comb.c: set string terminator Cov107 |
| 19:47.27 | CIA-57 | BRL-CAD: 03erikgreenwald * r48563 10/brlcad/trunk/src/conv/asc/asc2g.c: remove unreachable line Cov1667 |
| 19:48.54 | CIA-57 | BRL-CAD: 03erikgreenwald * r48564 10/brlcad/trunk/src/conv/g-acad.c: remove unreachable chunk (longjmp) Cov1668 |
| 19:54.31 | brlcad | hi cadman |
| 19:56.01 | *** topic/#brlcad by brlcad -> BRL-CAD Open Source Solid Modeling || http://brlcad.org || logs: http://ibot.rikers.org/%23brlcad/ || BRL-CAD release 7.22.0 is forthcoming || fixing all our Coverity Scan Initiative defects | |
| 19:56.35 | CIA-57 | BRL-CAD: 03erikgreenwald * r48565 10/brlcad/trunk/src/lgt/do_options.c: bump args by one to handle "! cmd" case. Stash the args ptr in case args is advanced and free it on exit. Cov399 |
| 19:58.34 | CIA-57 | BRL-CAD: 03erikgreenwald * r48566 10/brlcad/trunk/src/libged/get_solid_kp.c: if0 unreachable code out until pipe origin setting fixed. Cov78 |
| 19:59.43 | CIA-57 | BRL-CAD: 03erikgreenwald * r48567 10/brlcad/trunk/src/rttherm/ssampview.c: remove unreachable colorspace checking code. Cov1671 |
| 20:03.17 | CIA-57 | BRL-CAD: 03erikgreenwald * r48568 10/brlcad/trunk/src/mged/mged.c: if0 logging code out until it's re-enabled with optimized. Cov1670 |
| 20:07.42 | CIA-57 | BRL-CAD: 03erikgreenwald * r48569 10/brlcad/trunk/src/librt/comb/db_comb.c: oops, s/namebuf/name/ |
| 20:10.38 | CIA-57 | BRL-CAD: 03starseeker * r48570 10/brlcad/trunk/src/shapes/window_frame.c: Initialize some variables in window_frame.c CID 1814-1816 |
| 20:11.27 | CIA-57 | BRL-CAD: 03erikgreenwald * r48571 10/brlcad/trunk/ (include/raytrace.h src/librt/comb/db_comb.c): drop const since it's edited |
| 20:13.39 | CIA-57 | BRL-CAD: 03brlcad * r48572 10/brlcad/trunk/src/libbu/convert.c: cast value to unsigned long before shift to avoid implicit sign extension. detected by converity SIGN_EXTENSION check (cid 1258). |
| 20:16.33 | CIA-57 | BRL-CAD: 03starseeker * r48573 10/brlcad/trunk/src/util/pixuntile.c: Initialize FILE array. CID 1646 |
| 20:18.12 | CIA-57 | BRL-CAD: 03n_reed * r48574 10/brlcad/trunk/src/libged/clone.c: intentional fall-through, see if adding comment quiets issue CID 348 |
| 20:19.39 | CIA-57 | BRL-CAD: 03erikgreenwald * r48575 10/brlcad/trunk/ (include/raytrace.h src/librt/db_io.c): alter db_fwrite_external to remove const name |
| 20:21.24 | CIA-57 | BRL-CAD: 03n_reed * r48576 10/brlcad/trunk/src/libged/comb.c: remove fall-through from default case CID 348 |
| 20:22.38 | CIA-57 | BRL-CAD: 03starseeker * r48577 10/brlcad/trunk/src/shapes/window.c: Initialize some variables - CID 1640-1644 |
| 20:24.05 | CIA-57 | BRL-CAD: 03brlcad * r48578 10/brlcad/trunk/src/libbu/parse.c: |
| 20:24.05 | CIA-57 | BRL-CAD: we're setting the 32-bit or'd buffer value into a size_t so have to be careful |
| 20:24.05 | CIA-57 | BRL-CAD: about implicit sign extension going from unsigned char to int for the shift to |
| 20:24.05 | CIA-57 | BRL-CAD: size_t (unsigned). cast to size_t before the shift to keep it unsigned. |
| 20:24.05 | CIA-57 | BRL-CAD: detected by coverity SIGN_EXTENSION check (cid 1259,1260,1261,1262). |
| 20:26.14 | CIA-57 | BRL-CAD: 03n_reed * r48579 10/brlcad/trunk/src/libged/combmem.c: missing breaks. CID 349, CID 350 |
| 20:28.54 | CIA-57 | BRL-CAD: 03starseeker * r48580 10/brlcad/trunk/src/shapes/handle.c: Initialize some varibles in handle - CID 1635-1639 |
| 20:32.20 | CIA-57 | BRL-CAD: 03erikgreenwald * r48581 10/brlcad/trunk/ (3 files in 3 dirs): undo the const dropping |
| 20:33.02 | CIA-57 | BRL-CAD: 03n_reed * r48582 10/brlcad/trunk/src/libged/put_comb.c: remove fall-through from default case CID 351 |
| 20:37.51 | CIA-57 | BRL-CAD: 03starseeker * r48583 10/brlcad/trunk/src/rt/viewray.c: Initialize some vect_t variables. CID 1634 |
| 20:38.52 | CIA-57 | BRL-CAD: 03brlcad * r48584 10/brlcad/trunk/misc/enigma/enigma.c: fix coverity reported BUFFER_SIZE_WARNING complaining about strncpy being used without ensuring nul termination. terminate and done. (cid 106) |
| 20:40.15 | CIA-57 | BRL-CAD: 03n_reed * r48585 10/brlcad/trunk/src/libged/wdb_obj.c: remove fall-through from default case. CID 353 |
| 20:44.39 | CIA-57 | BRL-CAD: 03bob1961 * r48586 10/brlcad/trunk/src/libfft/ifftc.c: run 6, CID 1769, TAINTED SCALAR. |
| 20:45.44 | CIA-57 | BRL-CAD: 03brlcad * r48587 10/brlcad/trunk/misc/enigma/enigma.c: crypt() manpage says it will return 13 or 30 bytes plus nul terminator, so make the buffers bigger. |
| 20:45.50 | CIA-57 | BRL-CAD: 03bob1961 * r48588 10/brlcad/trunk/src/libfft/fftc.c: run 6, CID 1768, TAINTED SCALAR. |
| 20:48.20 | CIA-57 | BRL-CAD: 03erikgreenwald * r48589 10/brlcad/trunk/src/librt/comb/db_comb.c: set terminators on strings after NAMEMOVE |
| 20:50.49 | CIA-57 | BRL-CAD: 03erikgreenwald * r48590 10/brlcad/trunk/src/libged/get_solid_kp.c: comment out unused vars |
| 20:52.15 | CIA-57 | BRL-CAD: 03n_reed * r48591 10/brlcad/trunk/misc/enigma/enigma.c: typo |
| 20:56.22 | CIA-57 | BRL-CAD: 03erikgreenwald * r48592 10/brlcad/trunk/src/librt/primitives/nmg/nmg_tri_mc.c: bomb on bad face calc. Cov1835 |
| 20:58.02 | CIA-57 | BRL-CAD: 03starseeker * r48593 10/brlcad/trunk/src/conv/intaval/read_dra.cpp: Make sure form.id doesn't end up uninitialized - CID 1610 |
| 20:59.59 | CIA-57 | BRL-CAD: 03indianlarry * r48594 10/brlcad/trunk/src/libpc/pcVariable.h: std::list:erase() returns next iterator or list::end() so removed increment on erase parameter and assigned instead. Relates to Run 6 CID 333. |
| 21:06.58 | CIA-57 | BRL-CAD: 03starseeker * r48595 10/brlcad/trunk/src/mged/mged.c: Turn of the variables - we aren't using them. |
| 21:08.53 | CIA-57 | BRL-CAD: 03r_weiss * r48596 10/brlcad/trunk/src/libged/nmg_simplify.c: Rewrote function 'ged_nmg_simplify'. Coverity CID 199. |
| 21:09.06 | CIA-57 | BRL-CAD: 03starseeker * r48597 10/brlcad/trunk/src/ (10 files in 7 dirs): Use the VINIT_ZERO define and friends. |
| 21:15.54 | CIA-57 | BRL-CAD: 03bob1961 * r48598 10/brlcad/trunk/src/libged/move_arb_edge.c: run 6, CID 412, OVERRUN STATIC. |
| 21:17.16 | CIA-57 | BRL-CAD: 03n_reed * r48599 10/brlcad/trunk/src/libtclcad/tclcad_obj.c: missing breaks. CID 359 |
| 21:17.21 | CIA-57 | BRL-CAD: 03starseeker * r48600 10/brlcad/trunk/src/rt/rtscale.c: initialize new_min and new_max - CID 1631, 1632 |
| 21:27.46 | CIA-57 | BRL-CAD: 03n_reed * r48601 10/brlcad/trunk/src/libtclcad/tclcad_obj.c: missing breaks. CID 361, CID 362 |
| 21:32.46 | CIA-57 | BRL-CAD: 03n_reed * r48602 10/brlcad/trunk/src/mged/edsol.c: missing break. CID 363 |
| 21:34.22 | CIA-57 | BRL-CAD: 03brlcad * r48603 10/brlcad/trunk/src/rt/do.c: rewrite the snippet of code in rt that detects a partial result in order to avoid a time-of-call, time-of-use race condition. (cov 1591) |
| 21:38.42 | CIA-57 | BRL-CAD: 03n_reed * r48604 10/brlcad/trunk/src/util/asc-pl.c: missing breaks. CID 364 |
| 21:40.42 | CIA-57 | BRL-CAD: 03brlcad * r48605 10/brlcad/trunk/src/rt/do.c: whoa nelly, fix them errors on the right side |
| 21:54.51 | CIA-57 | BRL-CAD: 03r_weiss * r48606 10/brlcad/trunk/src/libged/nmg_simplify.c: Update to function 'ged_nmg_simplify'. Improved success of ARB and TGC simplification. |
| 21:56.28 | CIA-57 | BRL-CAD: 03OStaceyrtzs 07http://brlcad.org * r3267 10/wiki/Questions_to_ask_Before_Buying_the_Kindle_Device: New page: Truly does the [http://www.squidoo.com/where_to_buy_amazon_kindle Purchase Kindle] have all the features you are searching for within a ebook reader? Continue reading to make a decision if... |