| 00:42.15 | starseeker | ``Erik: NOW what did you do to it?? |
| 03:41.01 | CIA-130 | BRL-CAD: 03tbrowder2 * r48933 10/brlcad/trunk/regress/vls.sh: add some more robustness: report if all expected failure pass |
| 04:03.34 | brlcad | starseeker: export VAR=value is bash-specific |
| 04:03.42 | brlcad | use two-lines |
| 04:03.46 | brlcad | VAR=value |
| 04:03.48 | brlcad | export VAR |
| 05:07.12 | *** join/#brlcad archivist (~archivist@host81-149-189-98.in-addr.btopenworld.com) | |
| 05:34.39 | CIA-130 | BRL-CAD: 03brlcad * r48934 10/brlcad/trunk/src/conv/asc/pix2asc.c: revert r48777 that maybe quelled a TAINTED_SCALAR coverity warning since it causes a compilation warning (it's always true). cleanup. |
| 05:56.18 | *** join/#brlcad KimK (~Kim__@209.248.147.2.nw.nuvox.net) | |
| 09:41.30 | *** join/#brlcad piksi (piksi@pi-xi.net) | |
| 10:38.43 | *** join/#brlcad louipc (~louipc@archlinux/fellow/louipc) | |
| 10:39.59 | *** join/#brlcad archivist (~archivist@host81-149-189-98.in-addr.btopenworld.com) | |
| 13:05.12 | ``Erik | starseeker: "make -j3 all benchmark"... that's it *shrug* |
| 13:12.20 | ``Erik | 'faster than fourier transform' O.o |
| 13:12.56 | CIA-130 | BRL-CAD: 03starseeker * r48935 10/brlcad/trunk/regress/red.sh: try not to use bash specific syntax... |
| 13:13.48 | CIA-130 | BRL-CAD: 03tbrowder2 * r48936 10/brlcad/trunk/regress/mged.sh: correct test to remove only if not FAILED |
| 13:13.51 | ``Erik | starseeker: "bash +B" puts you in posix compatibility mode, or hop on a fbsd box and use /bin/sh |
| 13:44.31 | CIA-130 | BRL-CAD: 03erikgreenwald * r48937 10/brlcad/trunk/src/libfb/tcl.c: erm, argv[0] is not a static string and this is not tcl, redo the bu_log string for proper format/varargs handling |
| 13:48.01 | CIA-130 | BRL-CAD: 03erikgreenwald * r48938 10/brlcad/trunk/src/libged/analyze.c: quell uninitialized var warning |
| 15:17.30 | CIA-130 | BRL-CAD: 03erikgreenwald * r48939 10/brlcad/trunk/src/libgcv/test_bottess.c: macro up face detection |
| 15:39.06 | brlcad | starseeker: hm, the struct detection in astyle isn't nearly as clear-cut as the indenting was |
| 17:09.21 | brlcad | woot, fixed |
| 17:12.56 | brlcad | four lines of code |
| 17:59.33 | CIA-130 | BRL-CAD: 03brlcad * r48940 10/brlcad/trunk/regress/mged.sh: don't pop up a window on commands that want to try, set display to null. also, delete output file(s) before writing them |
| 18:02.21 | CIA-130 | BRL-CAD: 03brlcad * r48941 10/brlcad/trunk/CMakeLists.txt: looks like cmake has a mechanism for checking headers that require other headers (at least CHECK_INCLUDE_FILES() does). list them before the header, separated with semicolons. should fix the issue prompted by r48886. |
| 18:19.37 | CIA-130 | BRL-CAD: 03brlcad * r48942 10/brlcad/trunk/ (CMakeLists.txt misc/CMake/BRLCAD_CheckFunctions.cmake): |
| 18:19.37 | CIA-130 | BRL-CAD: didn't get the commit e-mail, and missed the new BRLCAD_INCLUDE_FILE_WINDOWS() |
| 18:19.37 | CIA-130 | BRL-CAD: macro. looks like BRLCAD_INCLUDE_FILE does just pass it though, so the |
| 18:19.37 | CIA-130 | BRL-CAD: windows-specific macro shouldn't be needed. awaiting windows build |
| 18:19.37 | CIA-130 | BRL-CAD: verification. |
| 18:50.05 | *** join/#brlcad jordisayol (~jordisayo@unaffiliated/jordisayol) | |
| 20:10.30 | starseeker | brlcad: sweet, thanks! |
| 20:10.39 | starseeker | tests astyle again... |
| 20:26.29 | CIA-130 | BRL-CAD: 03starseeker * r48943 10/brlcad/trunk/misc/CMake/ThirdParty.cmake: Swap the order of checks 2 and 3 - if we're explicitly turning something off, even NOSYS isn't enough to save it - this was true anyway, so make the ordering clearer. |
| 20:26.53 | *** join/#brlcad Stattrav (~Stattrav@unaffiliated/stattrav) | |
| 20:28.42 | CIA-130 | BRL-CAD: 03starseeker * r48944 10/brlcad/trunk/misc/astyle.opt: |
| 20:28.42 | CIA-130 | BRL-CAD: Tweak the astyle opt file - for the moment, remove align-pointer since it's |
| 20:28.42 | CIA-130 | BRL-CAD: changing some stuff in if conditionals (for example, avs.c line 45) that look |
| 20:28.42 | CIA-130 | BRL-CAD: like maybe they shouldn't be changed. Sean fixed astyle, so turn on kr styling. |
| 20:28.43 | CIA-130 | BRL-CAD: The pad-oper setting appears to work as advertised, the question is whether we |
| 20:28.43 | CIA-130 | BRL-CAD: want to apply it globally... |
| 20:30.49 | starseeker | brlcad: ok, with those settings, 49 files in libbu get modified running astyle and 36 don't... |
| 20:41.42 | CIA-130 | BRL-CAD: 03starseeker * r48945 10/brlcad/trunk/include/rtgeom.h: Need to start way simpler here... |
| 21:24.13 | *** join/#brlcad cadman (~Adium@mwg-w02.infosec.fedex.com) | |
| 21:44.45 | CIA-130 | BRL-CAD: 03erikgreenwald * r48946 10/brlcad/trunk/CMakeLists.txt: Bump requried CMake version to 2.8.4. osX couldn't find dependancies (namely xsl-expand while building docbook articles) even though the dep worked as a target on 2.8.3. |
| 21:45.55 | CIA-130 | BRL-CAD: 0368.34.98.23 07http://brlcad.org * r3269 10/wiki/Code_Cleanup: /* Duplication Reduction */ export not necessary |
| 21:46.51 | CIA-130 | BRL-CAD: 0368.34.98.23 07http://brlcad.org * r3270 10/wiki/Code_Cleanup: /* Duplication Reduction */ readd space |
| 21:47.16 | *** join/#brlcad cadman (~Adium@mwg-e01.infosec.fedex.com) | |
| 22:00.42 | brlcad | starseeker: interesting, can you post a diff of one of those 49 up somewhere? |
| 22:01.15 | brlcad | libbu shouldn't really have any changes since it's been the best reviewed style-wise |
| 22:06.50 | *** join/#brlcad cadman (~Adium@mwg-e01.infosec.fedex.com) | |
| 22:16.51 | starseeker | brlcad: sure: http://pastebin.mozilla.org/1456753 (avs.c) |
| 22:18.16 | starseeker | http://pastebin.mozilla.org/1456755 (backtrace.c) |
| 22:20.07 | starseeker | think I might know what the backtrace.c one is... |
| 22:22.15 | CIA-130 | BRL-CAD: 03starseeker * r48947 10/brlcad/trunk/misc/CMake/ThirdParty.cmake: Warn if a NOSYS library is turned off - Bad Things expected. |
| 22:23.05 | CIA-130 | BRL-CAD: 03starseeker * r48948 10/brlcad/trunk/misc/astyle.opt: Ah hah - we want to indent the cases of a switch statement |
| 22:27.10 | CIA-130 | BRL-CAD: 03starseeker * r48949 10/brlcad/trunk/misc/astyle.opt: don't want extra default indentation of conditionals |
| 22:30.39 | CIA-130 | BRL-CAD: 03starseeker * r48950 10/brlcad/trunk/misc/astyle.opt: Allow deeper indenting |
| 22:30.55 | starseeker | down to 38 modified... |
| 22:34.44 | starseeker | avs.c is still changed, and here are a couple more that are still there: |
| 22:34.48 | starseeker | http://pastebin.mozilla.org/1456763 |
| 22:35.33 | starseeker | doubt there's an option to not break out single line case statements... |
| 22:36.44 | starseeker | I'll bet those if bracket moves are the k&r style formatter |
| 22:40.16 | starseeker | brlcad: nevermind the pastebins - heres the full libbu diff, with astyle.opt as of r48950: http://bzflag.bz/~starseeker/astyle_libbu_diff.txt |
| 23:47.22 | brlcad | starseeker: heh okay |