| 00:04.18 | *** join/#brlcad npcdoom (~npcdoom@190.39.142.150) | |
| 00:04.18 | *** join/#brlcad npcdoom (~npcdoom@gugve/developer/npcdoom) | |
| 01:08.32 | brlcad | starseeker: confirmed reproducible |
| 01:09.19 | brlcad | starseeker: unrelated, nice demonstration why it's not at all hard to render text into 3d (e.g., for annotations) in the latest ioccc |
| 01:10.05 | brlcad | zucker was one of the winning entries, raytracer in 19 lines of code that does exactly that: http://brlcad.org/tmp/zucker.png |
| 01:11.49 | *** join/#brlcad jordisayol (~jordisayo@unaffiliated/jordisayol) | |
| 01:20.05 | *** join/#brlcad jordisayol (~jordisayo@unaffiliated/jordisayol) | |
| 03:51.03 | *** join/#brlcad Stattrav_ (~Stattrav@61.12.114.82) | |
| 04:09.30 | *** join/#brlcad stevegt_1 (~stevegt@c-69-181-134-76.hsd1.ca.comcast.net) | |
| 04:41.05 | brlcad | starseeker: took a couple hours to see it, but the bug injected (that should have been benign) exposed a different bug in rtedge |
| 04:47.51 | CIA-128 | BRL-CAD: 03brlcad * r50206 10/brlcad/trunk/src/rt/viewedge.c: |
| 04:47.51 | CIA-128 | BRL-CAD: if the database is fresh, we have to build the directory before we can find any |
| 04:47.51 | CIA-128 | BRL-CAD: objects. this bug was uncovered by a change in libbu that caused mapped files |
| 04:47.51 | CIA-128 | BRL-CAD: to not get reused. rtedge was previously working only because it was reopening |
| 04:47.51 | CIA-128 | BRL-CAD: the (previously dirbuilt) database |
| 04:58.56 | CIA-128 | BRL-CAD: 03brlcad * r50207 10/brlcad/trunk/src/libbu/mappedfile.c: looks like r48552 introduced a bug causing mapped files to not get reused. if we find a match, return it instead of opening another one. |
| 04:58.59 | brlcad | that does the fix, twice over |
| 05:26.08 | CIA-128 | BRL-CAD: 03brlcad * r50208 10/brlcad/trunk/src/libgcv/bottess.c: the for loop already catches the case where nfaces==0 so eliminate the wrapping conditional. let the optimizer figure out that i isn't used. should fix UNREACHABLE cid 2115. |
| 05:33.30 | CIA-128 | BRL-CAD: 03brlcad * r50209 10/brlcad/trunk/src/librt/primitives/sketch/sketch.c: make sure we don't dereference null. cid 2114, reverse_inull |
| 05:41.08 | CIA-128 | BRL-CAD: 03brlcad * r50210 10/brlcad/trunk/src/sig/imod.c: INT_MAX-1 isn't the upper bound. stop when we get to the max size of the buffer. cid 2113, OVERRUN_STATIC. |
| 05:48.27 | CIA-128 | BRL-CAD: 03brlcad * r50211 10/brlcad/trunk/src/conv/vdeck/vdeck.c: make sure ftell doesn't fail before we later use it in an fseek. cid 2112, negative_returns. |
| 05:52.54 | CIA-128 | BRL-CAD: 03brlcad * r50212 10/brlcad/trunk/src/libbn/msr.c: do what the function comment says should happen if null is passed, return 1. addresses cid 2111 forward_null check. |
| 05:55.09 | CIA-128 | BRL-CAD: 03brlcad * r50213 10/brlcad/trunk/src/libbn/msr.c: few more cases. cid 2110 forward_null check. |
| 05:57.58 | CIA-128 | BRL-CAD: 03brlcad * r50214 10/brlcad/trunk/src/conv/iges/iges.c: if it's null, avoid crashing. cid 2109 forward_null. |
| 06:01.52 | CIA-128 | BRL-CAD: 03brlcad * r50215 10/brlcad/trunk/src/librt/db_tree.c: use rt_uniresource regardless if ncpu is 1 or rtip is null. cid 2108 forward_null. |
| 06:04.35 | CIA-128 | BRL-CAD: 03brlcad * r50216 10/brlcad/trunk/src/conv/vdeck/vdeck.c: wrong var. check the offset, not the file pointer. |
| 06:07.43 | CIA-128 | BRL-CAD: 03brlcad * r50217 10/brlcad/trunk/src/librt/db_tree.c: same as cid 2108 in r50215. forward_null in cid 2107. use the uniresource, luke. |
| 06:12.59 | *** join/#brlcad cristina (c1e71414@gateway/web/freenode/ip.193.231.20.20) | |
| 06:19.44 | CIA-128 | BRL-CAD: 03brlcad * r50218 10/brlcad/trunk/src/libtclcad/tclcad_obj.c: coverity is right, deadcode on the found_top test since we just tested it and the loop doesn't proceed. |
| 06:22.10 | CIA-128 | BRL-CAD: 03brlcad * r50219 10/brlcad/trunk/src/librt/vshoot.c: HeadSeg cannot be null. cid 2104 deadcode. |
| 06:24.25 | CIA-128 | BRL-CAD: 03brlcad * r50220 10/brlcad/trunk/src/libged/dg_obj.c: make sure we don't try to close a null fd. cid 2073 forward_null. |
| 06:25.21 | *** part/#brlcad cristina (c1e71414@gateway/web/freenode/ip.193.231.20.20) | |
| 06:32.53 | CIA-128 | BRL-CAD: 03brlcad * r50221 10/brlcad/trunk/src/fb/gif2fb.c: make sure our line index doesn't exceed the buffer size. assume dumbly clamping it is sufficient. cid 2059 overrun_static. |
| 06:36.14 | CIA-128 | BRL-CAD: 03brlcad * r50222 10/brlcad/trunk/src/other/step/src/clstepcore/ExpDict.h: initialize all of the class members. cid 2014 UNINIT_CTOR. |
| 06:40.15 | CIA-128 | BRL-CAD: 03brlcad * r50223 10/brlcad/trunk/src/other/ (lemon/lempar.c sqlite3/sqlite3.c): checking it for negative implies it might be negative, so change the order of the yytos usage to not set the yytos variable until after we check it. |
| 06:46.07 | *** join/#brlcad andrei (~andrei@188.25.158.46) | |
| 06:55.39 | CIA-128 | BRL-CAD: 03brlcad * r50224 10/brlcad/trunk/src/other/lemon/lempar.c: cid 1860 OVERRUN_STATIC. make sure we don't exceed the size of the yyRuleInfo array. |
| 06:58.54 | *** join/#brlcad d_rossberg (~rossberg@BZ.BZFLAG.BZ) | |
| 07:13.48 | CIA-128 | BRL-CAD: 03brlcad * r50225 10/brlcad/trunk/src/other/lemon/lempar.c: er, not size-1 here because we're testing whether yyruleno is less. avoid infinite loop. |
| 07:22.07 | CIA-128 | BRL-CAD: 03brlcad * r50226 10/brlcad/trunk/src/conv/euclid/euclid-g.c: avoid bu_exit() so we can avoid coverity false positive (doesn't know bu_bomb() doesn't return), cid 1766 TAINTED_SCALAR. return a return code.conv |
| 07:38.23 | CIA-128 | BRL-CAD: 03brlcad * r50227 10/brlcad/trunk/src/libged/vdraw.c: simplify vlist subcommand argument processing a little to avoid deadcode condition, cid 1737 |
| 07:41.09 | CIA-128 | BRL-CAD: 03brlcad * r50228 10/brlcad/trunk/src/libpc/pcVariable.cpp: initialize all of the Variable constructor members. cid 1659, UNINIT_CTOR. |
| 07:44.47 | CIA-128 | BRL-CAD: 03brlcad * r50229 10/brlcad/trunk/src/libpc/pcNetwork.cpp: initialize v and e in constructor per cid 1656 UNINIT_CTOR |
| 07:50.48 | CIA-128 | BRL-CAD: 03brlcad * r50230 10/brlcad/trunk/src/conv/intaval/regtab.h: initialize material member in constructors. cid 1647 UNINIT_CTOR. |
| 07:51.39 | CIA-128 | BRL-CAD: 03brlcad * r50231 10/brlcad/trunk/src/libged/vdraw.c: typos ftl |
| 07:54.15 | CIA-128 | BRL-CAD: 03brlcad * r50232 10/brlcad/trunk/src/irprep/firpass.c: initialize curvature. cid 1615, UNINIT. |
| 07:56.19 | CIA-128 | BRL-CAD: 03brlcad * r50233 10/brlcad/trunk/src/vfont/getfont.c: initialize the vfont to zero. cid 1613, UNINIT |
| 08:03.34 | CIA-128 | BRL-CAD: 03brlcad * r50234 10/brlcad/trunk/src/util/dsp_add.c: avoid a time-of-call time-of-use race condition (TOCTOU cid 1592) detected by coverity by calling fstat() instead of stat() after the fopen() calls. |
| 08:14.39 | CIA-128 | BRL-CAD: 03brlcad * r50235 10/brlcad/trunk/src/conv/iges/g-iges.c: use libbu instead of directly calling access() to hopefully hide the innocuous TOCTOU issue detected in cid 1588. |
| 08:25.54 | CIA-128 | BRL-CAD: 03brlcad * r50236 10/brlcad/trunk/src/vfont/getfont.c: take the address of font so we can do the right thing. |
| 08:26.16 | CIA-128 | BRL-CAD: 03brlcad * r50237 10/brlcad/trunk/src/rttherm/ssampview.c: call bu_realpath() to sanitize path |
| 08:28.59 | CIA-128 | BRL-CAD: 03brlcad * r50238 10/brlcad/trunk/src/rttherm/ssampview.c: er, dead if statement?? init datafile_basename to zero so we don't try to free static memory |
| 08:31.53 | CIA-128 | BRL-CAD: 03brlcad * r50239 10/brlcad/trunk/src/rttherm/ssamp-bw.c: do the same for ssamp-bw, sanitizing through bu_realpath() and releasing our now-copied memory. |
| 08:34.49 | CIA-128 | BRL-CAD: 03brlcad * r50240 10/brlcad/trunk/src/nirt/command.c: more tainted_string sanitization through bu_realpath() for cid 1560. |
| 08:40.25 | CIA-128 | BRL-CAD: 03brlcad * r50241 10/brlcad/trunk/src/util/ttcp.c: avoid calling exit even if cid 1513 looks like a false positive. |
| 08:51.25 | CIA-128 | BRL-CAD: 03brlcad * r50242 10/brlcad/trunk/src/util/pixhist3d.c: sanitize the rgb color values even if we do expect the entire range. hopefully quell cid 1511 TAINTED_SCALAR with explicit effectively no-op range checks. |
| 08:58.36 | CIA-128 | BRL-CAD: 03brlcad * r50243 10/brlcad/trunk/src/util/imgdims.c: more realpath cleansing. cid 1505 TAINTED_SCALAR. |
| 09:01.24 | *** join/#brlcad jordisayol (~jordisayo@unaffiliated/jordisayol) | |
| 09:04.30 | CIA-128 | BRL-CAD: 03brlcad * r50244 10/brlcad/trunk/src/util/decimate.c: bounds check the input sizes along with the output sizes |
| 09:06.19 | CIA-128 | BRL-CAD: 03brlcad * r50245 10/brlcad/trunk/src/util/decimate.c: don't forget to check nbytes too, cid 1502 TAINTED_SCALR |
| 09:10.50 | *** join/#brlcad kane (~Kane@wprt-4db6cb9d.pool.mediaWays.net) | |
| 09:12.19 | *** join/#brlcad kane_ (~Mesut@wprt-4db6cb9d.pool.mediaWays.net) | |
| 09:14.50 | d_rossberg | good morning kane_ |
| 09:15.26 | kane_ | good morning |
| 09:15.42 | kane_ | great to meet you. |
| 09:16.51 | d_rossberg | don't worry if i'm not online, i read the logs at rikers.org |
| 09:17.40 | CIA-128 | BRL-CAD: 03brlcad * r50246 10/brlcad/trunk/src/ (libbu/convert.c util/cv.c): looks benign, but go ahead and add some extra sanitization on the input/output patterns to cv in response to cid 15000 (TAINTED_SCALAR). |
| 09:18.37 | kane_ | ah ok. I have spoken with Sean about the next steps. |
| 09:19.36 | kane_ | I will prepare a patch, i am looking now about a good subject related to the Display Manager. |
| 09:30.46 | d_rossberg | that's good |
| 09:31.11 | d_rossberg | you should try to get the build working on Linux too |
| 09:31.58 | d_rossberg | because Linux is the OS where most of BRL-CAD's features will work |
| 09:32.15 | kane_ | ok, i will directly work on linux/ubuntu |
| 09:32.30 | CIA-128 | BRL-CAD: 03brlcad * r50247 10/brlcad/trunk/src/util/bwcrop.c: check the range of xnum/ynum image bounds for TAINTED_SCALAR loop detected by cid 1496. |
| 09:33.15 | kane_ | i have multiboot system win/mac/lin, for the whole brlcad i will use linux... |
| 09:36.11 | d_rossberg | ok, then you should try the different display managers which are already implemented |
| 09:37.48 | CIA-128 | BRL-CAD: 03brlcad * r50248 10/brlcad/trunk/src/sig/smod.c: more range checking for tainted_scalar gunk. cid 1493. |
| 09:49.11 | CIA-128 | BRL-CAD: 03brlcad * r50249 10/brlcad/trunk/src/util/cv.c: need string.h for strlen() |
| 09:50.44 | CIA-128 | BRL-CAD: 03brlcad * r50250 10/brlcad/trunk/src/shapes/wire.c: take crazy measures to make it clear we're sanitizing the user-provided input. might end up with a dead-code condition now since the loop should catch them, or the definite scanf separation might do the trick.. |
| 09:59.09 | CIA-128 | BRL-CAD: 03brlcad * r50251 10/brlcad/trunk/src/rt/rtshot.c: consolidate the input sanitization before use so hopefully it's more clear that inputs are clean. responding to cid 1488 (tainted_scalar). |
| 10:03.38 | CIA-128 | BRL-CAD: 03brlcad * r50252 10/brlcad/trunk/src/mged/mged.c: add some explicit sanitization for cid 1485, TAINTED_SCALAR |
| 10:08.18 | CIA-128 | BRL-CAD: 03brlcad * r50253 10/brlcad/trunk/src/liboptical/photonmap.c: check the upper bounds too, cid 1483 tainted_scalar... that finishes up run 11. |
| 10:12.47 | brlcad | woot, that's all of them |
| 10:12.51 | brlcad | starting run12 |
| 10:59.42 | *** join/#brlcad stas_ (~stas@82.208.133.12) | |
| 11:38.31 | CIA-128 | BRL-CAD: 03starseeker * r50254 10/brlcad/trunk/src/tclscripts/rtwizard/lib/PictureTypeBase.itcl: Use bu_brlcad_root to find rtedge. The quotes seem to be interfering with the oo definition, so remove them. |
| 11:56.44 | CIA-128 | BRL-CAD: 03tbrowder2 * r50255 10/brlcad/trunk/src/conv/comgeom/solid.c: ws |
| 11:58.28 | *** join/#brlcad kane_ (6d540011@gateway/web/freenode/ip.109.84.0.17) | |
| 12:06.04 | CIA-128 | BRL-CAD: 03tbrowder2 * r50256 10/brlcad/trunk/src/conv/comgeom/solid.c: ws, remove debugging statement |
| 12:07.50 | *** join/#brlcad Jak_o_Shadows (~Fake@unaffiliated/jak-o-shadows/x-0479135) | |
| 12:51.28 | starseeker | brlcad: nice |
| 13:12.48 | *** join/#brlcad cristina (~cristina@188.24.66.134) | |
| 13:12.52 | cristina | hi |
| 13:47.18 | brlcad | hello cristina |
| 13:50.57 | CIA-128 | BRL-CAD: 03brlcad * r50257 10/brlcad/trunk/src/libgcv/bottess.c: ah, that's why coverity is barking. there's a return statement exiting the function early. cid 2115. |
| 14:13.12 | CIA-128 | BRL-CAD: 03brlcad * r50258 10/brlcad/trunk/src/util/sun-pix.c: more TAINTED_SCALAR insanity, hopefully the last of it. cid 1512 caugh more loops for ras_maplength show check those too (along with all the other header fields) |
| 14:14.29 | starseeker | brlcad: thanks for tracking down that rtedge issue - basic tests seem to be functioning now, just need to figure out why it's printing all the messages about assigning temp names |
| 14:18.05 | CIA-128 | BRL-CAD: 03brlcad * r50259 10/brlcad/trunk/src/util/loop.c: reserve the last possible value so we can bounds check cid 1506 |
| 14:23.25 | CIA-128 | BRL-CAD: 03brlcad * r50260 10/brlcad/trunk/src/util/loop.c: range check argv[1][1] for cid 1506 too |
| 14:35.13 | CIA-128 | BRL-CAD: 03brlcad * r50261 10/brlcad/trunk/src/libbu/convert.c: another attempt at making sure we don't seem to use tainted data as an index in the isdigit() call. |
| 14:35.48 | CIA-128 | BRL-CAD: 03brlcad * r50262 10/brlcad/trunk/src/libbu/convert.c: sans p |
| 14:40.52 | CIA-128 | BRL-CAD: 03brlcad * r50263 10/brlcad/trunk/src/util/bwmod.c: check the lower bounds too, cid 1498 |
| 14:55.33 | CIA-128 | BRL-CAD: 03brlcad * r50264 10/brlcad/trunk/src/util/sun-pix.c: typo |
| 14:57.02 | CIA-128 | BRL-CAD: 03brlcad * r50265 10/brlcad/trunk/src/libgcv/bottess.c: couple more unused args now with the block commented out |
| 14:58.17 | CIA-128 | BRL-CAD: 03brlcad * r50266 10/brlcad/trunk/src/util/bwcrop.c: more tainted data crap. hopefully last attempt at cid 1496. |
| 15:03.05 | *** join/#brlcad kane_ (~Mesut@e181171013.adsl.alicedsl.de) | |
| 15:03.59 | CIA-128 | BRL-CAD: 03brlcad * r50267 10/brlcad/trunk/src/util/bwcrop.c: do the scanf case too. looks like many of the scanf return counts were wrong anyways. fixed. |
| 15:12.38 | CIA-128 | BRL-CAD: 03brlcad * r50268 10/brlcad/trunk/src/rt/rtshot.c: more tainted data checks, trying to be a little more explicit. cid 1488 |
| 15:25.04 | CIA-128 | BRL-CAD: 03brlcad * r50269 10/brlcad/trunk/src/librt/opennurbs_ext.cpp: free the parent, revengences of leaked memory. cid 488. |
| 15:33.09 | CIA-128 | BRL-CAD: 03brlcad * r50270 10/brlcad/trunk/src/util/sun-pix.c: different range check, smaller limit for cid 332 (INTEGER_OVERFLOW) |
| 15:38.23 | CIA-128 | BRL-CAD: 03brlcad * r50271 10/brlcad/trunk/src/liboptical/sh_toyota.c: calculate the ratio first. probably still insufficient for cid328 (INTEGER_OVERFLOW) |
| 15:51.47 | *** join/#brlcad kane_ (~Mesut@wprt-4db6cb9d.pool.mediaWays.net) | |
| 16:26.34 | *** join/#brlcad phoenixyjll (7319d80b@gateway/web/freenode/ip.115.25.216.11) | |
| 17:00.03 | *** join/#brlcad stevegt_1 (~stevegt@cislunar.TerraLuna.Org) | |
| 17:21.02 | Al_Da_Best | <PROTECTED> |
| 17:21.13 | Al_Da_Best | Yeah, all builds succesful |
| 17:24.48 | Al_Da_Best | (Prof version, using x64) |
| 17:26.48 | CIA-128 | BRL-CAD: 03mendesr * r50272 10/jbrlcad/trunk/pom.xml: 1.1 release |
| 17:50.34 | *** join/#brlcad andrei (~andrei@188.25.162.168) | |
| 18:49.42 | CIA-128 | BRL-CAD: 03mendesr * r50273 10/jbrlcad/tags/1.1/: Tag version for 1.1 release |
| 19:03.34 | CIA-128 | BRL-CAD: 03mendesr * r50274 10/jbrlcad/trunk/ (3 files in 3 dirs): MUVES-1685; Added Muves to Orca matrix, to assist in translating Orca components in MUVES-3 |
| 19:32.15 | CIA-128 | BRL-CAD: 03tbrowder2 * r50275 10/brlcad/trunk/regress/tgms/cgtest.cg: make comgeom-g test target use only recognized GIFT primitives that should successfully convert to .g format |
| 19:34.34 | CIA-128 | BRL-CAD: 03tbrowder2 * r50276 10/brlcad/trunk/regress/comgeom.sh: make comgeom-g regression check more robust by adding a test for failed conversions |
| 19:35.30 | CIA-128 | BRL-CAD: 03tbrowder2 * r50277 10/brlcad/trunk/TODO: add enhancements needed for vdeck/comgeom-g |
| 20:31.39 | *** join/#brlcad merzo (~merzo@125-76-133-95.pool.ukrtel.net) | |
| 21:16.50 | *** join/#brlcad stas_ (~stas@188.24.35.114) | |
| 21:54.48 | CIA-128 | BRL-CAD: 03n_reed * r50278 10/brlcad/trunk/src/other/step/src/ (5 files in 2 dirs): changes based on SCL git d35f73f and 696d8e3 |
| 22:00.13 | *** join/#brlcad Jak_o_Shadows (~Fake@unaffiliated/jak-o-shadows/x-0479135) | |
| 22:17.09 | CIA-128 | BRL-CAD: 03n_reed * r50279 10/brlcad/trunk/src/other/step/src/ (4 files in 3 dirs): some const char corrections including remaining changes from SCL git 4cf16d7 |
| 22:56.48 | *** join/#brlcad louipc (~louipc@archlinux/fellow/louipc) | |
| 23:14.36 | *** join/#brlcad jordisayol (~jordisayo@unaffiliated/jordisayol) | |
| 23:29.47 | *** join/#brlcad jordisayol (~jordisayo@unaffiliated/jordisayol) | |
| 23:48.48 | *** join/#brlcad jordisayol (~jordisayo@unaffiliated/jordisayol) | |
