| 01:38.06 | Notify | 03BRL-CAD:brlcad * 54730 brlcad/trunk/NEWS: nick added level-of-detail support to mged and archer's wireframe infrastructure. it dynamically adjusts the wireframe detail based on the pixel dimensions and quality parameters (samples per curve and curve density). there's a new configuration panel to adjust the values. |
| 01:43.37 | Notify | 03BRL-CAD:brlcad * 54731 brlcad/trunk/src/util/plrot.c: convert fprintf(stderr) calls to bu_log(), use %zd for off_t (%jd is a better fit, but untested) |
| 02:47.54 | Notify | 03BRL-CAD:brlcad * 54732 (brlcad/trunk/src/conv/dbupgrade.c brlcad/trunk/src/conv/intaval-g.py and 17 others): Usage consistency |
| 03:09.57 | Notify | 03BRL-CAD:brlcad * 54733 brlcad/trunk/src/librt/primitives/extrude/extrude.c: warrants manual testing but there's no reason to allocate a specific structure on the heap, put on the stack and update calls accordingly. BU_PUT() the real extrude_specific struct. |
| 03:13.10 | Notify | 03BRL-CAD:brlcad * 54734 (brlcad/trunk/src/librt/primitives/ehy/ehy.c brlcad/trunk/src/librt/primitives/eto/eto.c and 4 others): BU_PUT() the *_specific structs since they are created/destroyed locally behind API. |
| 03:19.09 | starseeker | hmm - apparently our fedex_plus conversion has a bug that wasn't triggered by ap203 |
| 03:23.11 | Notify | 03BRL-CAD:brlcad * 54735 brlcad/trunk/src/librt/primitives/cline/cline.c: put the cline_specific but alloc the wdb_pipepts |
| 03:27.21 | Notify | 03BRL-CAD:brlcad * 54736 (brlcad/trunk/src/librt/primitives/bspline/bspline.cpp brlcad/trunk/src/librt/primitives/ebm/ebm.c and 13 others): BU_PUT() the *_specific structs since they are created/destroyed locally behind API. |
| 03:29.13 | Notify | 03BRL-CAD:brlcad * 54737 brlcad/trunk/src/librt/primitives/nmg/nmg_tri.c: unclear where this memory is getting or should be released, so call BU_ALLOC() accoridngly |
| 03:29.39 | Notify | 03BRL-CAD:brlcad * 54738 brlcad/trunk/src/librt/primitives/nmg/nmg_fuse.c: not destroyed locally, call BU_ALLOC() |
| 03:30.55 | Notify | 03BRL-CAD:brlcad * 54739 brlcad/trunk/src/librt/primitives/bot/bot.c: BU_ALLOC() all of the rt_bot_list structures since they seem to be accessed elsewhere. |
| 03:33.14 | Notify | 03BRL-CAD:brlcad * 54740 brlcad/trunk/src/librt/primitives/bot/g_bot_include.c: follow form, BU_PUT() our bot_specific data. this really begs for extending BU_GET() support to arrays since normals are prime candidates for fast bucket allocations. |
| 03:34.26 | Notify | 03BRL-CAD:brlcad * 54741 brlcad/trunk/src/librt/primitives/dsp/dsp.c: another case where we can undo having a dsp_specific be allcoated on the heap for calculating the bounding box. put it on the stack and BU_PUT() the specific |
| 03:36.17 | Notify | 03BRL-CAD:brlcad * 54742 brlcad/trunk/src/librt/primitives/pipe/pipe.c: lil bit of everything. convert allocations of individual structs to BU_GET() and call BU_PUT accordingly to release. same for *_specific. warrants testing. |
| 03:37.25 | Notify | 03BRL-CAD:brlcad * 54743 brlcad/trunk/src/librt/primitives/vol/vol.c: comment on the pointer stealing, but add some checks anyways. also BU_PUT() the rt_vol_specific |
| 03:38.41 | Notify | 03BRL-CAD:brlcad * 54744 brlcad/trunk/src/librt/primitives/hyp/hyp.c: more memory allocation cleanup. another struct heap removal and BU_PUT'ing of the _specific. |
| 03:39.38 | Notify | 03BRL-CAD:brlcad * 54745 brlcad/trunk/src/librt/primitives/submodel/submodel.c: have to BU_ALLOC() our resource structs, but we can call BU_PUT() on the specific |
| 04:52.22 | *** join/#brlcad maths22 (~gcimaths@66-118-151-70.static.sagonet.net) | |
| 05:44.13 | *** join/#brlcad n_reed (~molto_cre@66-118-151-70.static.sagonet.net) | |
| 06:24.29 | *** join/#brlcad merzo (~merzo@142-166-133-95.pool.ukrtel.net) | |
| 10:52.37 | *** join/#brlcad milamber (~devlin@d118-75-244-176.try.wideopenwest.com) | |
| 11:43.03 | *** join/#brlcad milamber (~devlin@d118-75-244-176.try.wideopenwest.com) | |
| 12:28.24 | *** join/#brlcad milamber (~devlin@d118-75-244-176.try.wideopenwest.com) | |
| 13:37.47 | *** join/#brlcad milamber (~devlin@d118-75-244-176.try.wideopenwest.com) | |
| 14:01.30 | Notify | 03BRL-CAD:brlcad * 54746 brlcad/trunk/src/librt/search.c: memory allocation cleanup. allocate the db_path_t objects with BU_GET/PUT, but not the rest since they are returned to caller. |
| 14:05.09 | Notify | 03BRL-CAD:brlcad * 54747 (brlcad/trunk/src/librt/shoot.c brlcad/trunk/src/librt/tol.c and 3 others): returned to caller or otherwised released elsewhere, so call BU_ALLOC() |
| 14:06.36 | Notify | 03BRL-CAD:brlcad * 54748 brlcad/trunk/src/conv/vdeck/vextern.h: conflicting savsol type declarations (off_t vs long), so remove the apparantly unnecessary vextern.h one and keep the vdeck.c one |
| 14:08.54 | Notify | 03BRL-CAD:brlcad * 54749 brlcad/trunk/src/util/hex.c: print a big number |
| 14:19.06 | Notify | 03BRL-CAD:mendesr * 54750 (jbrlcad/trunk/pom.xml jbrlcad/trunk/src/main/java/org/brlcad/info/RegionInfo.java): MUVES-2488; create regionInfo regionless solids |
| 14:21.59 | Notify | 03BRL-CAD:mendesr * 54751 NIL: Tag version for 1.3 release |
| 14:22.42 | Notify | 03BRL-CAD:mendesr * 54752 jbrlcad/trunk/pom.xml: Update version to 1.4-SNAPSHOT |
| 14:23.29 | Notify | 03BRL-CAD:brlcad * 54753 brlcad/trunk/src/libtclcad/cmdhist_obj.c: save to BU_PUT() here because nobody else peeks at the bu_cmdhist_obj objects, unlike the bu_cmdhist objects |
| 14:34.11 | Notify | 03BRL-CAD:bob1961 * 54754 brlcad/trunk/src/tclscripts/archer/Archer.tcl: Modify Archer's "p" command to call editMotionDeltaCallback or handleObjCenter. Also altered Archer::handleObjCenter to take two more args (i.e. _dosnap and _viewz). |
| 14:41.31 | Notify | 03BRL-CAD:brlcad * 54755 brlcad/trunk/src/remrt/rtsrv.c: looks like the pkg_queue are isolated here, and can be released with BU_PUT |
| 14:50.38 | Notify | 03BRL-CAD:brlcad * 54756 (brlcad/trunk/src/libtclcad/tclcad_obj.c brlcad/trunk/src/libwdb/dynamic_geometry.c and 15 others): looks like the remainder all convert to BU_ALLOC() for myriad reasons |
| 15:20.48 | Notify | 03BRL-CAD:brlcad * 54758 (brlcad/trunk/src/adrt/librender/spall.c brlcad/trunk/src/adrt/librender/surfel.c and 12 others): more BU_ALLOC() conversions. will be interesting to see if zero-init has any impact. |
| 15:27.45 | Notify | 03BRL-CAD:brlcad * 54759 brlcad/trunk/src/conv/g-shell-rect.c: switch to BU_ALLOC() instead of the local complexity |
| 15:48.57 | Notify | 03BRL-CAD Wiki:Navz143143 * 0 /wiki/User:Navz143143: |
| 15:49.55 | Notify | 03BRL-CAD:brlcad * 54760 (brlcad/trunk/src/bwish/cmd.c brlcad/trunk/src/conv/asc/asc2g.c and 6 others): more BU_ALLOC() conversions where we only allocate a single structure. |
| 15:49.57 | Notify | 03BRL-CAD:brlcad * 54757 (brlcad/trunk/src/adrt/isst_tcltk.c brlcad/trunk/src/adrt/librender/camera.c and 3 others): allocate single structures with BU_ALLOC(). get rid of unnecessary null checks since libbu guarantees that won't happen. |
| 15:53.42 | Notify | 03BRL-CAD:brlcad * 54761 (brlcad/trunk/include/bn.h brlcad/trunk/include/bu.h and 3 others): simplify, allocate via BU_ALLOC(). update docs to reflect that option too. |
| 16:20.59 | Notify | 03BRL-CAD:brlcad * 54762 brlcad/trunk/include/nurb.h: missing comma |
| 16:24.01 | *** join/#brlcad Skriptkid (~Skriptkid@59.93.66.3) | |
| 16:29.55 | Notify | 03BRL-CAD:brlcad * 54763 brlcad/trunk/src/libdm/dm-plot.c: reallocation leak, remove calloc |
| 16:35.33 | *** join/#brlcad milamber (~devlin@d118-75-244-176.try.wideopenwest.com) | |
| 16:39.38 | Notify | 03BRL-CAD:brlcad * 54764 brlcad/trunk/src/libged/bot_merge.c: calloc params should count then size |
| 16:42.11 | Notify | 03BRL-CAD:brlcad * 54765 brlcad/trunk/src/libbn/mat.c: type consistency, unhappy converting a mat_t* to a matp_t without explicit cast, so add it. use MAT_COPY while we're at it instead of memcpy in case the representation ever changes. |
| 16:43.12 | Notify | 03BRL-CAD:brlcad * 54766 brlcad/trunk/include/raytrace.h: typo, missing paren |
| 16:45.39 | ``Erik | http://www.nasa.gov/mission_pages/voyager/voyager20121203.html neat, new layer to the solar system |
| 16:46.47 | *** join/#brlcad caen23 (~cezar@92.81.219.106) | |
| 17:02.29 | Notify | 03BRL-CAD:brlcad * 54767 brlcad/trunk/src/conv/iges/readtree.c: another type mismatch, make it the equivalent pointer type instead of the typedef. maybe matp_t should die. |
| 17:18.17 | Notify | 03BRL-CAD:brlcad * 54768 (brlcad/trunk/src/conv/comgeom/solid.c brlcad/trunk/src/conv/g-x3d.c and 61 others): big conversion of single structure allocations to BU_ALLOC(). doesn't change behavior (except zero-init in some cases) but does improve readability and brevity. this is about a third of them. |
| 17:22.06 | Notify | 03BRL-CAD:brlcad * 54769 brlcad/trunk/src/libged/bot_merge.c: revert, wasn't supposed to be committed |
| 17:29.15 | Notify | 03BRL-CAD:brlcad * 54770 brlcad/trunk/src/libged/brep.c: gah my fingers and their auto-saving habit. commit the rest that removes the allocation of a brep *pointer* on the stack. doesn't seem to be a reason for that other than brep_conversion() needing the address of the pointer so that it can set its value. we can do that without a double-pointer here. |
| 17:38.36 | Notify | 03BRL-CAD:brlcad * 54771 brlcad/trunk/src/libged/combmem.c: allocate a mat_t, not 16 fastf_t |
| 17:42.16 | Notify | 03BRL-CAD:brlcad * 54772 brlcad/trunk/src/libged/gqa.c: calloc is count then size |
| 17:46.52 | *** join/#brlcad merzo (~merzo@142-166-133-95.pool.ukrtel.net) | |
| 17:52.41 | ``Erik | brlcad: 54749 breaks on 64b linux: src/util/hex.c:80: warning: format '%08llx' expects type 'long long unsigned int', but argument 2 has type 'off_t' |
| 18:00.06 | Notify | 03BRL-CAD:mendesr * 54773 jbrlcad/trunk/pom.xml: Updating JScience version, and adding webdav stuff for deployment also moving to 1.4 |
| 18:03.19 | Notify | 03BRL-CAD:mendesr * 54774 jbrlcad/trunk/pom.xml: Updating to version 1.5-SNAPSHOT |
| 18:10.06 | Notify | 03BRL-CAD:brlcad * 54775 brlcad/trunk/src/librt/cut.c: BU_ALLOC() in a couple places, and swap calloc for count then size |
| 19:18.10 | Notify | 03BRL-CAD:brlcad * 54776 brlcad/trunk/src/librt/primitives/bot/tie_kdtree.c: call BU_ALLOC() where we can (single struct allocation) and use libbu memory management consistency (bu_malloc() instead of malloc()) |
| 19:20.54 | Notify | 03BRL-CAD:brlcad * 54777 brlcad/trunk/src/librt/primitives/generic.c: calloc is count then size |
| 19:26.09 | Notify | 03BRL-CAD:brlcad * 54778 brlcad/trunk/src/librt/primitives/nmg/nmg_ck.c: calloc is count then size |
| 19:35.55 | Notify | 03BRL-CAD:brlcad * 54779 brlcad/trunk/src/librt/primitives/nmg/nmg_ck.c: good catch nick, it was already countsize. make explicit with sizeof(char). |
| 20:03.50 | Notify | 03BRL-CAD:brlcad * 54780 brlcad/trunk/src/librt/shoot.c: another calloc count then size fix |
| 20:12.03 | Notify | 03BRL-CAD:brlcad * 54781 brlcad/trunk/src/mged/points/count.c: BU_ALLOC for brevity |
| 20:14.10 | Notify | 03BRL-CAD:brlcad * 54782 (brlcad/trunk/src/mged/points/count.c brlcad/trunk/src/mged/points/count.h and 4 others): remove authorship from source files, revision control holds the history |
| 20:19.03 | *** join/#brlcad milamber (~devlin@d118-75-244-176.try.wideopenwest.com) | |
| 20:37.28 | *** join/#brlcad milamber (~devlin@d118-75-244-176.try.wideopenwest.com) | |
| 20:41.52 | *** join/#brlcad KimK (~Kim__@wsip-184-176-200-171.ks.ks.cox.net) | |
| 20:55.06 | Notify | 03BRL-CAD:brlcad * 54783 (brlcad/trunk/src/libged/brep.c brlcad/trunk/src/libged/cc.c and 121 others): mass conversion of nearly all the 2277 instances of bu_malloc() and bu_calloc() where there were single structure allocations to BU_ALLOC(). this has the main benefit of brevity, helping with maintainability and readability. it reduced 20k chars and eliminated over 1.5 lines (same # statements, they just tended to |
| 20:55.08 | Notify | span multiple lines because they were so wordy). about 500 instances are converted. the one logical change is that BU_ALLOC() ensures zero-initialization via bu_calloc() and that should generally be a good thing for structures, maybe even fix an obscure bug or two. |
| 21:16.14 | Notify | 03BRL-CAD:brlcad * 54784 brlcad/trunk/src/librt/cut.c: no longer BU_GET()ing union cutter objects, release normally via bu_free() |
| 21:17.25 | Notify | 03BRL-CAD:brlcad * 54785 brlcad/trunk/src/libged/push.c: there is no ged_push |
| 21:17.56 | Notify | 03BRL-CAD:brlcad * 54786 brlcad/trunk/src/librt/primitives/pipe/pipe.c: linear_pipe should be lin_pipe too |
| 21:20.20 | Notify | 03BRL-CAD:brlcad * 54787 brlcad/trunk/src/librt/primitives/nmg/nmg_mk.c: call NMG_GETSTRUCT() since we don't directly call BU_GET() on a model |
| 21:26.48 | Notify | 03BRL-CAD:brlcad * 54788 brlcad/trunk/src/librt/primitives/nmg/nmg_fuse.c: BU_GET() the nmg_radial structs since we found the pairing |
| 21:28.00 | Notify | 03BRL-CAD:brlcad * 54789 brlcad/trunk/src/liboptical/sh_stxt.c: type typo, stxt_specific |
| 21:41.59 | Notify | 03BRL-CAD:brlcad * 54790 brlcad/trunk/include/bu.h: intentionally but innocuosly use the type so we can catch errors |
| 21:50.55 | Notify | 03BRL-CAD:brlcad * 54791 brlcad/trunk/include/bu.h: using the type in an rvalue is a bad idea since it conflicts with type punned pointers. use in lvalue cast instead in what should be a safe way. |
| 21:55.28 | Notify | 03BRL-CAD:brlcad * 54792 brlcad/trunk/include/bu.h: make the heap pool version match to avoid confusion, cleanup docs |
| 22:01.44 | Notify | 03BRL-CAD:brlcad * 54793 brlcad/trunk/src/libbu/hook.c: ws |
| 22:03.13 | Notify | 03BRL-CAD:brlcad * 54794 brlcad/trunk/src/anim/chan_permute.c: indent |
| 22:24.14 | Notify | 03BRL-CAD:brlcad * 54795 (brlcad/trunk/include/brep.h brlcad/trunk/include/raytrace.h and 43 others): more ws cleanup, been a little while |