00:50.35 |
Notify |
03BRL-CAD Wiki:Vladbogolin * 5987
/wiki/User:Vladbogolin/GSoC2013/Logs: /* Week 9 */ |
01:58.05 |
Notify |
03BRL-CAD:starseeker * 56881
brlcad/trunk/src/libbn/tests/CMakeLists.txt: Apply patch #223 by
Nyah Check |
02:46.36 |
brlcad |
Izak_: did you apply as an
individual? |
02:46.56 |
brlcad |
and no, students are not allowed to attend the
mentor summit |
02:47.19 |
brlcad |
feel free to confirm with google, but that is
my understanding |
02:48.23 |
*** join/#brlcad KimK
(~Kim__@wsip-184-176-200-171.ks.ks.cox.net) |
02:48.53 |
Notify |
03BRL-CAD Wiki:118.99.65.7 * 5988
/wiki/Mailing_Lists: |
02:49.51 |
Notify |
03BRL-CAD Wiki:Sean * 5989
/wiki/Mailing_Lists: Reverted edits by
[[Special:Contributions/118.99.65.7|118.99.65.7]] ([[User
talk:118.99.65.7|talk]]) to last revision by
[[User:184.95.55.18|184.95.55.18]] |
02:50.55 |
Notify |
03BRL-CAD Wiki:Sean * 0
/wiki/User:118.99.65.7: Spamming links to external sites |
02:51.33 |
Notify |
03BRL-CAD Wiki:Sean * 0
/wiki/User:184.95.55.18: Spamming links to external sites |
02:53.07 |
Notify |
03BRL-CAD Wiki:Sean * 5990
/wiki/Mailing_Lists: Reverted edits by
[[Special:Contributions/Sean|Sean]] ([[User talk:Sean|talk]]) to
last revision by [[User:118.99.65.7|118.99.65.7]] |
02:54.05 |
Notify |
03BRL-CAD Wiki:Sean * 5991
/wiki/Mailing_Lists: Undo revision 5990 by
[[Special:Contributions/Sean|Sean]] ([[User
talk:Sean|talk]]) |
02:54.28 |
Notify |
03BRL-CAD Wiki:Sean * 5992
/wiki/Mailing_Lists: |
03:22.26 |
Notify |
03BRL-CAD:phoenixyjll * 56882
brlcad/trunk/src/libbrep/boolean.cpp: m_t_for_rank is of type
double. Cannot use the result of minus (and implicit conversion to
int) to report the comparison. |
03:38.38 |
Notify |
03BRL-CAD:phoenixyjll * 56883
brlcad/trunk/src/libbrep/boolean.cpp: Eliminate the usage of
sorted_pointers[] because once the array intersect[] is enlarged
(with a new capacity), the pointers stored in sorted_pointers[] is
no longer valid. |
03:47.00 |
Notify |
03BRL-CAD:phoenixyjll * 56884
brlcad/trunk/src/libbrep/boolean.cpp: Don't output the error
message if Split() is not called. |
04:00.11 |
*** join/#brlcad kesha_
(~kesha@14.139.122.114) |
04:12.52 |
Notify |
03BRL-CAD:phoenixyjll * 56885
brlcad/trunk/src/libbrep/boolean.cpp: Don't called IsClosed(),
which includes other tests rather than testing the distance between
start point and end point. |
05:30.56 |
Notify |
03BRL-CAD:phoenixyjll * 56886
brlcad/trunk/src/libbrep/boolean.cpp: Add comment for
get_subcurve_inside_faces(). |
05:38.20 |
*** join/#brlcad caen23
(~caen23@92.83.160.208) |
07:01.18 |
*** join/#brlcad d_rossberg
(~rossberg@66-118-151-70.static.sagonet.net) |
08:24.09 |
Notify |
03BRL-CAD Wiki:Phoenix * 5993
/wiki/User:Phoenix/GSoc2013/Reports: /* Week 9 */ |
08:49.42 |
*** join/#brlcad zero_level
(~mohit@66-118-151-70.static.sagonet.net) |
09:32.37 |
*** join/#brlcad Ch3ck_
(~Ch3ck@66-118-151-70.static.sagonet.net) |
11:03.18 |
Notify |
03BRL-CAD:tbrowder2 * 56887
brlcad/trunk/misc/auto-man-page/README.auto-man-page-handling:
clarify format of the string variables |
11:20.39 |
starseeker |
brlcad: to clarify, is the Google Doc Sprint
to create a book, or some other form of documentation? |
12:05.10 |
Notify |
03BRL-CAD:tbrowder2 * 56888
brlcad/trunk/misc/auto-man-page/README.auto-man-page-handling:
remove redundant translation section; fix spelling |
13:39.36 |
Notify |
03BRL-CAD:carlmoore * 56889
brlcad/trunk/misc/auto-man-page/README.auto-man-page-handling:
remove a trailing blank, and reword a line (please make sure my
rewording is OK) |
13:45.19 |
Notify |
03BRL-CAD:carlmoore * 56890
(brlcad/trunk/src/libbn/tests/CMakeLists.txt
brlcad/trunk/src/libbn/tests/bn_poly_add.c and 2 others): fix
spelling, remove trailing blanks/tabs, and add a period; I assumed
'infor' should be 'info', short for 'information' |
14:27.25 |
brlcad |
starseeker: yes |
14:27.59 |
Notify |
03BRL-CAD:starseeker * 56891
brlcad/trunk/src/conv/step/ON_Brep.cpp: Ick - apparently need to
work directly with the STEPattribute instances in the complex
type. |
14:30.44 |
brlcad |
starseeker: that is usually decided during the
sprint similar to the unconference agenda |
14:30.47 |
brlcad |
see
https://developer.mozilla.org/en-US/docs/Project:Doc_sprint_planning_guide |
14:32.52 |
brlcad |
my inclination right now is a beginner's guide
since we don't really have one, a scripting guide, or one of the
other docs listed in TODO |
14:41.46 |
Notify |
03BRL-CAD:starseeker * 56892
brlcad/trunk/src/conv/step/ON_Brep.cpp: This gets some of the
values assigned, but not the references to objects. |
14:42.06 |
starseeker |
nods |
14:43.04 |
starseeker |
basing the guide on the Archer
interface? |
15:09.01 |
brlcad |
certainly an option |
15:12.30 |
Notify |
03BRL-CAD:starseeker * 56893
brlcad/trunk/src/conv/step/ON_Brep.cpp: Will need to create valid
entities for the other entries before I can go any further
here... |
15:41.03 |
Notify |
03BRL-CAD:starseeker * 56894
brlcad/trunk/src/conv/step/ON_Brep.cpp: figured out how to get the
uncertainty aggregate into the global uncertainty assigned
context. |
15:53.37 |
Ch3ck_ |
starseeker: finished fixing the
bn_synthetic_divsion unit test should work perfectly now
;) |
17:52.40 |
*** join/#brlcad kesha_
(~kesha@14.139.122.114) |
18:07.35 |
Notify |
03BRL-CAD Wiki:NyahCh3ck20 * 5994
/wiki/User:NyahCh3ck20/GSoc2013/Coding_Repor: /* 12 August - 18
August */ |
18:34.23 |
Notify |
03BRL-CAD Wiki:IIIzzzaaakkk * 5995
/wiki/User:Izak/GSOC_2013_logs: /* August 12th to August 17th
*/ |
18:44.15 |
Notify |
03BRL-CAD Wiki:KeshaSShah * 5996
/wiki/User:KeshaSShah/GSoC13/Reports: /* Week 9 */ |
18:45.10 |
*** join/#brlcad kesha__
(~kesha@14.139.122.114) |
18:48.08 |
*** join/#brlcad caen23_
(~caen23@92.83.177.156) |
19:00.23 |
Notify |
03BRL-CAD:starseeker * 56895
brlcad/trunk/src/conv/step/ON_Brep.cpp: Create the complex type for
holding unit info |
19:09.56 |
Notify |
03BRL-CAD:brlcad * 56896
brlcad/trunk/src/libbn/tests/CMakeLists.txt: accept sf patch #225
from Ch3ck (Nyah) though there are several minor problems with the
patch. certainly getting better with consistency. |
19:10.43 |
Notify |
03BRL-CAD:brlcad * 56897
brlcad/trunk/src/libbn/tests/bn_poly_synthetic_div.c: fix ws
inconsistencies |
19:47.02 |
*** join/#brlcad brlcad
(~sean@66-118-151-70.static.sagonet.net) |
19:48.21 |
*** join/#brlcad n_reed
(~molto_cre@66-118-151-70.static.sagonet.net) |
19:48.33 |
*** join/#brlcad ejno
(~ejno@unaffiliated/kazaik) |
19:48.41 |
*** join/#brlcad Izak
(~Izak@66-118-151-70.static.sagonet.net) |
19:48.41 |
*** join/#brlcad starseeker
(~starseeke@66-118-151-70.static.sagonet.net) |
19:49.01 |
*** join/#brlcad maths22
(~gcimaths@66-118-151-70.static.sagonet.net) |
19:49.12 |
*** join/#brlcad Ch3ck
(~Ch3ck@66-118-151-70.static.sagonet.net) |
19:49.38 |
*** join/#brlcad zero_level
(~mohit@66-118-151-70.static.sagonet.net) |
19:49.40 |
*** join/#brlcad Ch3ck_
(~Ch3ck@66-118-151-70.static.sagonet.net) |
20:03.42 |
brlcad |
network hiccup |
20:06.01 |
brlcad |
Ch3ck_: you're definitely improving |
20:07.58 |
*** join/#brlcad Ch3ck__
(~Ch3ck@195.24.220.16) |
20:09.06 |
Ch3ck__ |
brlcad: there are some patches like 226 which
closed but not applied, and 227 has been applied but not
closed |
20:09.13 |
Ch3ck__ |
i don't understand |
20:26.34 |
brlcad |
Ch3ck__: what do you not understand? |
20:30.28 |
brlcad |
looks like 226 was perhaps confused with
227 |
20:31.36 |
Ch3ck__ |
well they are different |
20:31.51 |
Ch3ck__ |
227 has 2 unit tests.. |
20:32.00 |
Ch3ck__ |
Check |
20:33.51 |
*** join/#brlcad Notify
(~notify@66-118-151-70.static.sagonet.net) |
20:34.34 |
Notify |
03BRL-CAD:brlcad * 56900
brlcad/trunk/src/libbn/tests/bn_poly_synthetic_div.c: remove the
bn_Zero_poly global, use static initialization. |
20:34.36 |
Notify |
03BRL-CAD:brlcad * 56898
brlcad/trunk/src/libbn/tests/bn_poly_synthetic_div.c: eliminate the
dead code condition |
20:34.43 |
Notify |
03BRL-CAD:brlcad * 56906
brlcad/trunk/src/libbn/tests/CMakeLists.txt: make the test match
the source name so they're easier to find |
20:35.01 |
*** join/#brlcad Ch3ck__
(~Ch3ck@195.24.220.16) |
20:35.31 |
brlcad |
Ch3ck_: i'm not sure how them being different
matters .. easy to close one patch thinking it was another when
you're working on multiple patches simultaneously |
20:35.58 |
brlcad |
your description alone makes it sound like
that is exactly what happened |
20:36.25 |
Ch3ck__ |
yeah probably |
20:36.25 |
Notify |
03BRL-CAD:starseeker * 56904
brlcad/trunk/src/conv/step/ON_Brep.cpp: Add footer |
20:36.31 |
brlcad |
still, what's the point? |
20:36.46 |
Ch3ck__ |
just wanted 226 to be applied since its
already closed |
20:36.57 |
Notify |
03BRL-CAD:brlcad * 56902
brlcad/trunk/src/libbn/tests/bn_poly_synthetic_div.c: might as well
initialize both for good measure |
20:36.59 |
Notify |
03BRL-CAD:brlcad * 56899
brlcad/trunk/include/bn.h: provide a static initializer for bn_poly
structs |
20:37.04 |
Ch3ck__ |
and 227 officially closed since its been
applied |
20:39.13 |
Notify |
03BRL-CAD:brlcad * 56907
brlcad/trunk/src/libbn/tests/CMakeLists.txt: shortening the file
names primarily obfuscates what is being tested and is not worth
the 16 bytes safed. rename them to the functions being
tested. |
20:39.28 |
brlcad |
Ch3ck_: I commented on 226 |
20:39.40 |
brlcad |
it (and 227) has a long list of issues like
225 had |
20:40.10 |
brlcad |
I applied and fixed 225 myself, but that
doesn't mean it was okay |
20:41.05 |
brlcad |
if you fix up 226, i'll give it a
review/apply |
20:42.14 |
Ch3ck__ |
ok |
20:42.15 |
Notify |
03BRL-CAD:brlcad * 56908
brlcad/trunk/src/libbn/tests/bn_poly_add.c: ws |
20:42.39 |
brlcad |
Ch3ck_: review all of the commits that
occurred after r56896 to see what the issues were |
20:43.16 |
brlcad |
it looks like all of your tests still have
these problems, so it may take some practice for you to get
it |
20:44.29 |
Notify |
03BRL-CAD:brlcad * 56909
(brlcad/trunk/src/libbn/tests/bn_poly_multiply.c
brlcad/trunk/src/libbn/tests/bn_tri_tri_isect.c
brlcad/trunk/src/libbn/tests/bn_tri_tri_isect_coplanar.c): fix
indentation |
20:46.34 |
Notify |
03BRL-CAD:brlcad * 56901
brlcad/trunk/src/libbn/tests/bn_poly_synthetic_div.c: fix the
header, remove the now unused global |
20:49.57 |
Ch3ck__ |
thinking of a spell for
making perfect patches ;) |
20:58.58 |
Guest6230 |
Ch3ck__: Spell is understanding the HACKING
file |
21:01.11 |
Notify |
03BRL-CAD:starseeker * 56910
brlcad/trunk/src/conv/step/ON_Brep.cpp: Need to check with Mark
about t_plane_angle_measure - it *looks* like it should be a
SelectTypeDescriptor, but it's currently just a
TypeDescriptor. |
21:01.25 |
Ch3ck__ |
exit |
21:01.34 |
Ch3ck__ |
quit |
21:03.14 |
brlcad |
I have considered creating a code cleanup
checklist |
21:03.18 |
brlcad |
all the things that jump out at me when I open
a file |
21:04.39 |
brlcad |
but it would be more efficient to automate
code cleanup reliably/consistently |
21:16.19 |
*** join/#brlcad mpictor
(~mark@2601:d:b280:b5:d63d:7eff:fe2d:2505) |
21:19.13 |
*** join/#brlcad caen23
(~caen23@92.83.177.156) |
21:26.52 |
Notify |
03BRL-CAD:carlmoore * 56911
brlcad/trunk/src/conv/g-nff.c: remove unneeded braces; also remove
a trailing blank from printf, to reduce output! |
21:34.59 |
*** join/#brlcad caen23
(~caen23@92.83.177.156) |
21:38.10 |
brlcad |
Izak_: it's also remembering |
21:38.56 |
brlcad |
one might understand that HACKING says to take
off your shoes before entering this house, but you also have to
remember to take them off |
21:39.20 |
brlcad |
which can be especially hard if one is not
used to taking their shoes off |
21:41.54 |
Notify |
03BRL-CAD:starseeker * 56912
brlcad/trunk/src/conv/step/ON_Brep.cpp: need to figure out why I
can't create a PLANE_ANGLE_MEASURE instance |
21:42.19 |
brlcad |
starseeker: what in the world do you need one
of those for? :) |
21:44.17 |
Notify |
03BRL-CAD:starseeker * 56913
brlcad/trunk/src/conv/step/ON_Brep.cpp: explain the
number |
21:44.19 |
brlcad |
I can't think of place where we use that
construct where you'd need to export an angle .. maybe with a
constraint object later |
21:44.54 |
brlcad |
DEG2RAD |
21:45.02 |
brlcad |
constant in vmath.h |
21:45.35 |
starseeker |
it's part of the STEP header |
21:45.50 |
starseeker |
mandatory even |
21:45.53 |
brlcad |
really? how so? |
21:46.03 |
brlcad |
creating a ground plane coordinate system or
something? |
21:46.21 |
starseeker |
I think so - I haven't unraveled all of this
header stuff as yet |
21:47.27 |
starseeker |
or rather, not the header per-say but the
context in which an advanced brep is defined |
21:47.51 |
brlcad |
sounds wonky |
21:48.17 |
starseeker |
I'm wondering if fedex_plus isn't seeing a
part of the TYPE...SELECT definition in the exp file |