| 00:22.23 | Notify | 03BRL-CAD:tbrowder2 * 57152 brlcad/trunk/src/libged/attr.c: expand comment |
| 00:22.55 | Notify | 03BRL-CAD:tbrowder2 * 57153 brlcad/trunk/src/libged/attr.c: improve grammar |
| 00:30.53 | Notify | 03BRL-CAD:brlcad * 57154 brlcad/trunk/src/libbu/sscanf.c: ws indent formatting |
| 00:33.00 | Notify | 03BRL-CAD:tbrowder2 * 57155 brlcad/trunk/src/libged/attr.c: ws, style |
| 00:50.38 | Notify | 03BRL-CAD:starseeker * 57156 (brlcad/trunk/src/conv/step/CMakeLists.txt brlcad/trunk/src/conv/step/g-step/CMakeLists.txt brlcad/trunk/src/conv/step/step-g/CMakeLists.txt): Sigh. The 'only generate it once' solution didn't work with the Ninja generator - do things the 'proper' way and provide sources for each executable target. |
| 00:53.09 | Notify | 03BRL-CAD:tbrowder2 * 57157 brlcad/trunk/TODO: use current attr syntax |
| 01:26.45 | Notify | 03BRL-CAD:brlcad * 57158 brlcad/trunk/src/adrt/master/master.c: eliminated gratuitous spaces after function names and other ws style indent problems |
| 01:28.52 | Notify | 03BRL-CAD:brlcad * 57159 brlcad/trunk/src/adrt/master/master.c: cppcheck recognizes the range check and usage, check range first. |
| 01:43.07 | brlcad | zero_level: can you be more specific? what was the changes to the usage synopsis? |
| 01:45.00 | brlcad | there is nothing inherent about supporting pipes that implies a change to the synopsis is "necessary" |
| 02:36.32 | Notify | 03BRL-CAD:brlcad * 57160 brlcad/trunk/src/adrt/slave/slave.c: move variable declaration into the ifdef with the use. |
| 02:50.40 | Notify | 03BRL-CAD:brlcad * 57161 brlcad/trunk/src/adrt/master/master.c: work table is no more |
| 02:51.43 | Notify | 03BRL-CAD:brlcad * 57162 brlcad/trunk/src/adrt/master/tienet_master.c: missing semicolon, reduce scope of some vars |
| 02:56.05 | Notify | 03BRL-CAD:brlcad * 57163 (brlcad/trunk/src/adrt/master/compnet.c brlcad/trunk/src/adrt/master/dispatcher.c and 3 others): ws style cleanup |
| 03:10.14 | Notify | 03BRL-CAD:brlcad * 57164 brlcad/trunk/NEWS: mohit changed the bwfilter tool, renaming the -o offset option to -O so that -o can be retained as an output file name option |
| 03:13.59 | Notify | 03BRL-CAD:brlcad * 57165 brlcad/trunk/src/libbn/tests/CMakeLists.txt: patch not yet applied, remove the tests |
| 03:17.26 | Notify | 03BRL-CAD:brlcad * 57166 (brlcad/trunk/src/adrt/librender/cut.c brlcad/trunk/src/adrt/librender/flos.c and 2 others): convert to bu_sscanf() |
| 04:32.43 | Notify | 03BRL-CAD:brlcad * 57167 brlcad/trunk/src/libged/draw.c: wrap the innocuous debug printing within #ifdefs with a simple trigger. probably worth having a bu routine to calculate h:m:s from a time delta. curiously encountered a regress-solids failure due to the GED_HELP return code making the draw call presssume it failed. |
| 04:35.49 | Notify | 03BRL-CAD:brlcad * 57168 (brlcad/trunk/src/burst/Hm.c brlcad/trunk/src/burst/grid.c brlcad/trunk/src/bwish/tcl.c): reduce variable scope |
| 04:51.40 | Notify | 03BRL-CAD:brlcad * 57169 brlcad/trunk/src/conv/3dm/3dm-g.cpp: prefer prefix increment for non-pod and loop vars |
| 05:08.19 | Notify | 03BRL-CAD:phoenixyjll * 57170 brlcad/trunk/src/libbrep/boolean.cpp: Don't always flip that face. We should decide whether it's necessary to flip according to the operation. |
| 06:16.51 | *** join/#brlcad d_rossberg (~rossberg@66-118-151-70.static.sagonet.net) | |
| 08:20.47 | zero_level | Earlier the input arguments where paresed with loops runnung all through and checking values of argv[][] mannually. This indeed didnt allow the arguments to be passed in any order. |
| 08:22.45 | zero_level | I have used bu_getopt. But using this changing the input arguments for instance "-ntsc" now becomens "-n". |
| 08:23.16 | zero_level | We have to specify weights with every channel. For eg -R 0.0 / |
| 08:24.07 | zero_level | I have to change the man pages, but just waiting for the consent. (If we can improve it further) |
| 08:41.03 | Notify | 03BRL-CAD Wiki:Edatamarkets * 0 /wiki/User:Edatamarkets: |
| 09:39.02 | Notify | 03BRL-CAD Wiki:NyahCh3ck20 * 6041 /wiki/User:NyahCh3ck20/GSoc2013/Coding_Repor: |
| 09:52.26 | Notify | 03BRL-CAD Wiki:NyahCh3ck20 * 6042 /wiki/User:NyahCh3ck20/GSoc2013/Coding_Repor: /* Aug 26 - Sept 01 */ |
| 10:08.31 | *** join/#brlcad Izak (~Izak@195.24.220.16) | |
| 10:18.07 | *** join/#brlcad Ch3ck_ (~Ch3ck@195.24.220.16) | |
| 10:18.36 | *** join/#brlcad Izak__ (~Izak@195.24.220.16) | |
| 10:20.25 | Notify | 03BRL-CAD Wiki:IIIzzzaaakkk * 6043 /wiki/User:Izak/GSOC_2013_logs: /* August 19th to August 24th */ |
| 10:55.52 | *** join/#brlcad mpictor_ (~mpictor_@2600:1015:b10c:6682:0:3:9def:3501) | |
| 11:17.59 | *** join/#brlcad ``Erik (~erik@pool-173-67-38-235.bltmmd.fios.verizon.net) | |
| 11:33.19 | *** join/#brlcad Izak (~Izak@195.24.220.16) | |
| 11:33.38 | *** join/#brlcad Ch3ck_ (~Ch3ck@195.24.220.16) | |
| 12:19.46 | brlcad | zero_level: we need to document exactly what that change is |
| 12:20.10 | brlcad | from a users perspective, that is |
| 12:20.29 | brlcad | what is the synopsis now? what was the synopsis before? |
| 12:21.24 | brlcad | as the regression tests are broken at the moment, this is top priority to fix, update, or revert |
| 12:22.08 | brlcad | a "consent" on whether what you've done is okay requires more information (the synopses) |
| 12:25.55 | brlcad | see http://www.tldp.org/LDP/intro-linux/html/intro-linux.html for a description of a synopsis, and http://www-hermes.desy.de/Unixhelp/manual_4.1.2.html |
| 12:27.24 | brlcad | need to know what it was before your change and what it is now with your change |
| 12:28.04 | *** join/#brlcad mpictor_ (~mpictor_@2600:1015:b10c:6682:0:3:9def:3501) | |
| 12:28.06 | brlcad | Ch3ck_: I count no fewer than 10 errors in your reply, but thank you for finally getting back to me |
| 12:28.27 | Ch3ck_ | which reply? |
| 12:28.30 | Ch3ck_ | the email? |
| 12:28.35 | brlcad | yes |
| 12:28.39 | Ch3ck_ | ok |
| 12:28.42 | brlcad | :) |
| 12:28.54 | Ch3ck_ | i realised the error when i'd already pressed send! :( |
| 12:29.03 | ``Erik | brlcad: is bz getting dumps done? |
| 12:29.06 | brlcad | "the error"? |
| 12:29.13 | brlcad | there are many :) |
| 12:29.26 | Ch3ck_ | what kind of errors? actually |
| 12:29.32 | Ch3ck_ | typo? or grammatical? |
| 12:29.40 | brlcad | yes |
| 12:30.16 | Ch3ck_ | will correct and resend |
| 12:30.19 | brlcad | ``Erik: I'm not 100% positive but I don't think so |
| 12:30.27 | brlcad | Ch3ck_: no, don't bother |
| 12:30.37 | Ch3ck_ | so what do i do now? :( |
| 12:31.08 | brlcad | the gist is there, just ironic given your whole point was how excellent your writing skills are ... yet it contained so many mistakes :) |
| 12:31.12 | brlcad | just humorous |
| 12:31.42 | Ch3ck_ | but you could look at the article i gave |
| 12:32.08 | Ch3ck_ | which was sociological perspective on the Global village ;) |
| 12:32.08 | brlcad | i'm sure you are *capable* of writing better |
| 12:32.37 | Ch3ck_ | :) |
| 12:32.37 | brlcad | especially when you have time to work through drafts, scrutinize details |
| 12:32.46 | Ch3ck_ | yeah.. |
| 12:32.49 | brlcad | you should try to learn to write critically all the time |
| 12:33.13 | brlcad | it's just like with your code, learning to notice where the commas are missing or a space isn't right |
| 12:33.24 | brlcad | or words are repeated.. :) |
| 12:33.29 | brlcad | documentation Documentation |
| 12:33.45 | Ch3ck_ | was just doing some emphasis there.. ;) |
| 12:33.54 | brlcad | right.. |
| 12:35.07 | brlcad | also, no way to say this more plainly but |
| 12:35.11 | brlcad | "alot" is not a word |
| 12:35.55 | brlcad | one of many things I tend to be pedantic about |
| 12:36.25 | Ch3ck_ | yeah |
| 12:38.58 | brlcad | hilarious commentary: http://hyperboleandahalf.blogspot.com/2010/04/alot-is-better-than-you-at-everything.html |
| 12:43.20 | Ch3ck_ | well i guess it's been in popular use due to the evolution of blogs and social networks which encourage an informal atmosphere |
| 12:44.02 | Ch3ck_ | well guess this has somehow been detrimental to language proficiency for some. I guess :) |
| 12:50.23 | brlcad | it's nothing at all new |
| 12:51.24 | brlcad | I had teachers 30 years ago giving lectures about how "alot" is not a word even though plenty used it as one and seemed to think it was |
| 12:53.05 | brlcad | it's one that just doesn't even make any sense, you'd wouldn't say "ahot day" or "alittle bit" |
| 12:55.50 | Ch3ck_ | well rapstars can't let that go ;) |
| 12:57.59 | ``Erik | looking to a rap star for grammatical correctness is like looking to a modern art painter for photographic reproduction correctness O.o |
| 12:59.00 | Ch3ck_ | yeah |
| 12:59.43 | Ch3ck_ | well nowadays with the proliferation of movies; in fact the entertainment industry. Someone with a solid grammatical foundation will have severe problems in English language |
| 13:00.00 | Ch3ck_ | i mean without |
| 13:00.05 | Ch3ck_ | a foundation |
| 13:01.10 | Ch3ck_ | especially when referencing to movies and stuff for pronunciation ;) |
| 13:06.39 | *** join/#brlcad mpictor_ (~mpictor_@2600:1015:b10c:6682:0:3:9def:3501) | |
| 13:14.46 | Ch3ck_ | brlcad: succeeded in extracted the matrix transformation for the basic primitives. But need some assistance in generating the matrix transformation from a arb8 and arbn |
| 13:16.24 | Notify | 03BRL-CAD:phoenixyjll * 57171 brlcad/trunk/src/libbrep/boolean.cpp: Make use of the connectivity graph to reduce inside/outside tests. |
| 13:23.01 | *** join/#brlcad caen23 (~caen23@92.85.89.89) | |
| 13:30.41 | Notify | 03BRL-CAD Wiki:Phoenix * 0 /wiki/File:Sph_sph.png: |
| 13:31.04 | Notify | 03BRL-CAD Wiki:Phoenix * 0 /wiki/File:Sph_sph_inter.png: |
| 13:31.34 | Notify | 03BRL-CAD Wiki:Phoenix * 0 /wiki/File:Ehy_tor.png: |
| 13:32.19 | Notify | 03BRL-CAD Wiki:Phoenix * 0 /wiki/File:Ehy_tor_inter.png: |
| 13:32.45 | Notify | 03BRL-CAD Wiki:Phoenix * 0 /wiki/File:Arb8_ehy.png: |
| 13:33.08 | Notify | 03BRL-CAD Wiki:Phoenix * 0 /wiki/File:Arb8_ehy_inter.png: |
| 13:35.05 | Notify | 03BRL-CAD Wiki:Phoenix * 6050 /wiki/User:Phoenix/GSoc2013/Reports: /* Week 11 */ |
| 13:38.10 | Notify | 03BRL-CAD Wiki:Phoenix * 6051 /wiki/User:Phoenix/GSoc2013/Reports: /* Test Results */ |
| 13:39.18 | Notify | 03BRL-CAD Wiki:Phoenix * 6052 /wiki/User:Phoenix/GSoc2013/Reports: /* Test Results */ |
| 14:15.32 | brlcad | hah, that is awesome wu |
| 14:37.08 | ``Erik | awesome, looks like apple's xcode team is deprecating sbrk()... http://paste.lisp.org/display/138646 |
| 14:39.15 | ``Erik | looks like we only use it for verbose stats, the mem= field in memory_summary() |
| 14:45.19 | *** join/#brlcad mpictor_ (~mpictor_@2600:1015:b10c:6682:0:3:9def:3501) | |
| 14:46.11 | Notify | 03BRL-CAD:starseeker * 57172 brlcad/trunk/TODO: Add a note to figure out why the initialization of stp->st_path is the way it is. |
| 14:46.23 | brlcad | ``Erik: interesting, I'd just get rid of it |
| 14:46.39 | Notify | 03BRL-CAD:starseeker * 57173 brlcad/trunk/regress/CMakeLists.txt: add asc2g as a dependency for a couple more of the targets |
| 14:49.08 | brlcad | starseeker: the bu_htond/bu_ntohd issue is a lot more clear now |
| 14:49.23 | Notify | 03BRL-CAD:n_reed * 57174 (brlcad/trunk/src/libdm/dm-ogl.c brlcad/trunk/src/libdm/dm-wgl.c): revert r57140, we need a general way to change point size |
| 14:49.37 | brlcad | msvc didn't change anything, they now implement a function that didn't previously exist and we have a name conflict |
| 14:50.18 | brlcad | moreover, it reminds us that our version isn't consistent with the others so probably shouldn't be named that way anyways |
| 14:52.15 | caen23 | are there any statistics regarding what operating systems brl-cad is run on? |
| 14:53.50 | Notify | 03BRL-CAD:erikgreenwald * 57175 (brlcad/trunk/CMakeLists.txt brlcad/trunk/include/config_win.h and 2 others): remove sbrk() as it is marked deprecated in the new xcode5 mac stuff and we don't really use it much |
| 14:55.03 | brlcad | caen23: not any current |
| 14:56.32 | caen23 | then do you have an idea about how many people use it on something other than mac win linux/unix? |
| 14:58.43 | ``Erik | I think once every 3-4 years, brlcad compiles it on haiku... that's probably a significant portion of BRL-CAD usage outside of win/mac/linux/unix/bsd... :D |
| 15:00.47 | ``Erik | "what do we want?" "time travel!" "when do we want it?" "it's irrelevant!" |
| 15:03.07 | caen23 | the reason i was asking is because i know the debug version at least is compiled with the c89 flag, and i was wondering if it's intended to be run on platforms where a more recent compiler isn't available |
| 15:05.39 | Notify | 03BRL-CAD:tbrowder2 * 57176 (brlcad/trunk/include/bu.h brlcad/trunk/src/libbu/CMakeLists.txt): add function to provide an ISO time (planned to be used for attribute mod and creation times); will provide a regression test later |
| 15:10.58 | Notify | 03BRL-CAD:r_weiss * 57177 brlcad/trunk/src/other/stepcode/src/clutils/dirobj.cc: Update to stepcode function 'DirObj::CheckIndex' to quiet a valgrind 'mismatched free' warning. |
| 15:15.58 | *** join/#brlcad caen23 (~caen23@92.85.89.89) | |
| 15:19.06 | Notify | 03BRL-CAD:carlmoore * 57178 (brlcad/trunk/doc/docbook/system/man1/en/g-egg.xml brlcad/trunk/doc/docbook/system/man1/en/g-nmg.xml): make fixes to g-egg and g-xml man pages (g-egg: shorten -P writeup; g-nmg: provide missing period and -P writeup |
| 15:31.17 | Ch3ck_ | brlcad: starseeker: ``Erik: i'm currently implementing the pull_leaf() I'm supporing the following primitives(EHY, ELL, SPH, ARB8, EPA, ETO,EXTRUDE, HYP, PARTICLE, RPC, RHC, SUPERELL,TGC,TOR, ARBN).I just wish to ask if this is ok? for GSoC or i'll need to provide support for all primitives. Since I want to focus now on testing and completing the pull routine. |
| 15:31.46 | Ch3ck_ | and debugging and testing my pull_leaf() |
| 15:33.01 | Ch3ck_ | However due to the complexity of some primitives like(SUPERELL,TOR,ARBN, PART, RHC, RPC) I'll not be able to extract all aspects of the primitive. due to their inherent complexities. |
| 15:36.34 | Notify | 03BRL-CAD:n_reed * 57179 brlcad/trunk/src/libdm/dm-wgl.c: restore wgl implementation of BN_VLIST_POINT_DRAW |
| 15:36.47 | Notify | 03BRL-CAD:iiizzzaaakkk * 57180 brlcad/trunk/src/librt/primitives/hrt/hrt.c: Correcting sextic equation in comment preceeding rt_hrt_shot() implementation |
| 15:43.57 | zero_level | brlcad , ``Erik : I am not able to find the cause of regress (failure). |
| 15:44.16 | zero_level | I believe to find it i have to understand the architecture regress-dsp. |
| 15:44.40 | zero_level | Because this time all I did was chage the usage type of a utility. |
| 15:44.53 | zero_level | Utility (pix-bw). |
| 15:45.43 | zero_level | brlcad : I am in a process of changing the synopsis. |
| 16:28.25 | brlcad | caen23: it's more about code compliance |
| 16:30.38 | brlcad | caen23: the intention has always been to be able to run on any (desktop/server) platform available for use |
| 16:32.04 | brlcad | the standards-compliance certainly affects that end, but it of lesser concern -- we'll be adopting c99 as soon as we fully validate as strictly c89-compliant and we're willing to adopt the msvc issues |
| 16:32.35 | brlcad | we're probably less than a week's worth of work away from demonstrating strict c89 compilation |
| 16:33.33 | brlcad | Ch3ck_: what do you pull from the leaf? |
| 16:34.57 | brlcad | whatever you do for any primitives really needs to be done for all primitives or that feature cannot be used |
| 16:35.30 | brlcad | it'd be better to handle no primitives (e.g., combs only) and pull to be otherwise complete/robust/documented |
| 16:35.31 | Ch3ck_ | well there are some really complicated primitives like metball |
| 16:35.49 | brlcad | metaball |
| 16:35.51 | brlcad | brep/nurbs |
| 16:35.56 | brlcad | nmg |
| 16:36.04 | brlcad | there are a half dozen really complex primitives |
| 16:36.35 | Ch3ck_ | well for some primitives; you can't get all the matrix informations like scale, rotation and translation |
| 16:36.41 | Ch3ck_ | but i could get the translations for most. |
| 16:36.49 | brlcad | right |
| 16:36.55 | brlcad | so you'd either do nothing |
| 16:36.58 | brlcad | or do translations |
| 16:37.07 | Ch3ck_ | exactly |
| 16:37.47 | Ch3ck_ | well since i figured pulling from the leaf nodes is extracting all the matrix information available like translation components, scale and rotation components |
| 16:38.02 | Ch3ck_ | but not all primitives will have all three |
| 16:38.45 | brlcad | no primitive really has any of those |
| 16:38.58 | Ch3ck_ | yeah directly |
| 16:39.12 | Ch3ck_ | but you could get some of this data indirectly from some of the primitives |
| 16:39.21 | Ch3ck_ | that's what i'm currently doing and |
| 16:39.26 | brlcad | well, yes and no |
| 16:39.32 | brlcad | you don't "get that" from them |
| 16:39.37 | brlcad | you're defining it for them |
| 16:39.46 | brlcad | you could define it to be something else in theory |
| 16:39.47 | Ch3ck_ | yeah based on what they have |
| 16:39.58 | Ch3ck_ | stored in them. |
| 16:40.16 | Ch3ck_ | so what do i do in this case? |
| 16:40.32 | Ch3ck_ | concerning the primitives |
| 16:40.43 | brlcad | like I said, you can either ignore them (for now) and focus on finalizing pull |
| 16:40.53 | Ch3ck_ | ok |
| 16:41.00 | brlcad | or just implement support for translations since nearly all primitives have a notion of an origin |
| 16:41.15 | brlcad | and you can easily pull the origin to 0,0,0 to extract a translation |
| 16:41.34 | Ch3ck_ | well i've supported translations for almost all primitives and here is the code |
| 16:41.44 | brlcad | almost all is not all :) |
| 16:41.54 | Ch3ck_ | yeah |
| 16:41.59 | brlcad | so can it be all? |
| 16:42.05 | Ch3ck_ | yeah |
| 16:42.10 | Ch3ck_ | almost can be for all |
| 16:42.18 | brlcad | what? |
| 16:42.23 | brlcad | all != almost all |
| 16:42.32 | brlcad | can it be ALL of them or only almost all of them? |
| 16:42.38 | Ch3ck_ | no |
| 16:42.52 | brlcad | I asked "A or B" and you said "no" |
| 16:43.39 | Ch3ck_ | http://paste.kde.org/p541faed2/ |
| 16:43.55 | Ch3ck_ | no for both a and b |
| 16:44.28 | Ch3ck_ | all != almost all (correct |
| 16:44.32 | brlcad | that code doesn't answer my question |
| 16:44.56 | brlcad | that code is merely the state of where you're at, my question is where are we able to go |
| 16:45.38 | Ch3ck_ | well we'll be able to add support for extracting translation components for primitives |
| 16:46.02 | brlcad | is it possible to extract translation components for ALL primitives or only most of them or do you not know? |
| 16:46.21 | Ch3ck_ | well I can't extract for all |
| 16:46.36 | Ch3ck_ | since they're alot of complexities with some of them |
| 16:46.49 | brlcad | give me an example |
| 16:46.53 | Ch3ck_ | the one's currently implemented are the ones i best understand |
| 16:47.06 | Ch3ck_ | ok with the metaball forexample |
| 16:48.26 | Ch3ck_ | given the equation of the plane in arbn. I have no idea to define the translation components here |
| 16:48.29 | Ch3ck_ | thats why |
| 16:49.24 | brlcad | answering my own question then, your answer should have been "I do not know" |
| 16:50.09 | brlcad | again, you're defining it for the primitives |
| 16:50.29 | brlcad | not knowing how to define it for a particular primitive is not surprising |
| 16:51.08 | Ch3ck_ | well i am working with each primitive at a time |
| 16:51.19 | brlcad | of course, how else would you work with them? :) |
| 16:51.43 | Ch3ck_ | and given there are over 40 of them. I don't really know if I'll have to define them for all of them |
| 16:51.58 | brlcad | well I answered that for you |
| 16:52.13 | Ch3ck_ | yeah you said all |
| 16:52.18 | brlcad | if it's going to be defined for some of them, it should be defined for all of them |
| 16:52.31 | brlcad | some of them will be tricky to define, but not impossibly hard |
| 16:52.41 | Ch3ck_ | yeah |
| 16:52.42 | brlcad | metaball is a good example because it doesn't track a V position |
| 16:52.54 | brlcad | but you can certainly pick a position |
| 16:53.03 | brlcad | the centroid of the points or the first point, for example |
| 16:54.08 | Ch3ck_ | But since I could implement for some and get started with the routine working extracting only for some particular primitives. Could I not define for some and continue adding support for the other primitives. while integrating the command into the software completely |
| 16:54.32 | Ch3ck_ | and finalizing the pull |
| 16:54.45 | brlcad | it's a problem of usability to approach in that order |
| 16:54.59 | Ch3ck_ | knowing i'll only have to add support for the primitives i've not defined yet. |
| 16:55.02 | Ch3ck_ | ok |
| 16:55.06 | brlcad | from a users perspective, it'd be bad design if pull only sometimes worked |
| 16:55.26 | Ch3ck_ | so what do i do in this case |
| 16:55.36 | Ch3ck_ | forget about the primitives completely? |
| 16:55.45 | Ch3ck_ | and focus on combinations only? |
| 16:55.46 | brlcad | no |
| 16:56.18 | brlcad | I suggest focusing on the pull interface, synopsis, docs, full integration, maybe test cases first |
| 16:57.09 | Ch3ck_ | ok |
| 16:57.10 | brlcad | then you could integrate your existing primitive code into the functab later to capture them |
| 16:57.24 | brlcad | having a switch statement in pull_leaf() won't work long-term |
| 16:57.41 | brlcad | the primitives themselves need to define that code |
| 16:57.57 | Ch3ck_ | so whats the best approach here? |
| 16:58.14 | brlcad | for? |
| 16:58.23 | brlcad | proceeding or primitives? |
| 16:58.26 | Ch3ck_ | in the switch statement |
| 16:58.35 | brlcad | the switch disappears |
| 16:58.44 | brlcad | they become functions in each primitive |
| 16:58.54 | Ch3ck_ | ok yeah |
| 16:59.42 | Ch3ck_ | so i'll have to integrate the code in each of the primitives? |
| 16:59.56 | Ch3ck_ | or subroutines in pull itself? |
| 17:00.01 | Ch3ck_ | i mean pull.c |
| 17:01.04 | brlcad | the code belongs with the primitives |
| 17:01.08 | Notify | 03BRL-CAD:n_reed * 57181 (brlcad/trunk/include/bn.h brlcad/trunk/include/raytrace.h and 5 others): Make it possible to specify a point size or line width within a vlist. Implemented for ogl vlist drawing. |
| 17:01.31 | brlcad | still, this is out of order work if there's still other pull interface work needing to be done |
| 17:02.23 | Ch3ck_ | ok |
| 17:02.37 | Ch3ck_ | could you please give me an example to demonstate how this could be done? |
| 17:02.41 | Ch3ck_ | ;) |
| 17:04.34 | brlcad | when it's time, absolutely ;) |
| 17:05.13 | caen23 | brlcad: thanks for your earlier explanations |
| 17:05.37 | Ch3ck_ | ok |
| 17:06.01 | Ch3ck_ | brlcad: will start working on the pull interface, synopsis, docs, and others |
| 17:06.10 | Ch3ck_ | before falling back to primitives ;) |
| 17:06.18 | brlcad | sounds good |
| 17:06.41 | brlcad | and perfect patches ... i'm hoping the ones you have open apply cleanly |
| 17:07.12 | brlcad | I think you might have the record (ever) for number of patches with mistakes |
| 17:07.29 | brlcad | it's quite impressive :) |
| 17:07.40 | Ch3ck_ | what? really ! |
| 17:08.00 | Ch3ck_ | didn't want to have that kind of record! |
| 17:08.03 | Ch3ck_ | ;) |
| 17:08.47 | Ch3ck_ | actually my patches applying cleanly is no longer a problem the nut is white space and indentation which i've cracked ;)\ |
| 17:10.37 | brlcad | cracked is one way to describe it ... :) |
| 17:11.57 | brlcad | not just style though, you've had bad return codes, dead code, lazy comments, wrong dates, ... it's a lot you've clearly not had to think about bmuch before |
| 17:13.38 | Ch3ck_ | well was copying from the current state of the code. I mean the dates ;) |
| 17:13.46 | Ch3ck_ | didn't manufacture them.. |
| 17:14.02 | Ch3ck_ | copied mostly from how it was in the push.c file |
| 17:20.24 | brlcad | so? |
| 17:20.49 | brlcad | just means you're not scrutizing and checking lines in files that you are copy-pasting |
| 17:20.54 | brlcad | and you should be |
| 17:21.29 | Ch3ck_ | well was using it as reference actually |
| 17:21.36 | Ch3ck_ | since i thought it was up to date ;) |
| 17:21.50 | brlcad | it was up to date for the file you copied it from |
| 17:22.01 | brlcad | you assumed it meant one thing when it meant another |
| 17:23.12 | brlcad | would have been an excellent question to ask |
| 17:23.36 | Ch3ck_ | ok |
| 17:23.48 | brlcad | still, that was just one of a dozen little issues |
| 17:24.00 | brlcad | nothing major obviously, just a lot of small cuts |
| 17:24.45 | brlcad | like I said, clearly a lot you've not had to think about much before is all |
| 17:26.08 | brlcad | running as root is a similar issue.. |
| 17:26.20 | brlcad | you would have, nay, SHOULD have gotten yelled at by your peers for doing that! |
| 17:27.14 | Notify | 03BRL-CAD:n_reed * 57182 brlcad/trunk/src/libdm/dm-wgl.c: Copy implementation of vlist point size and line width specification to wgl. |
| 17:27.58 | brlcad | any third or fourth year CS student should have been all over ingraining a sense of guilt into first and second year students, I know my uni sure did :) |
| 17:31.22 | *** join/#brlcad caen23 (~caen23@92.85.89.89) | |
| 17:33.30 | Ch3ck_ | well thats not the case here ;) |
| 17:34.29 | Ch3ck_ | I mean its really hard! I mean hard! here to find programmers like us ;) |
| 17:35.02 | Ch3ck_ | everyone is kinda luke-warm towards programming talk less of hacking Linux ;) |
| 17:39.13 | Ch3ck_ | brlcad: i've added the pull_comb() routine to the pull ticket on sf. Waiting for it to be reviewed and applied ;) |
| 17:50.43 | brlcad | I get notification every time you do, someone will get to it asap |
| 17:53.21 | Ch3ck_ | ;) |
| 18:08.17 | Notify | 03BRL-CAD Wiki:NyahCh3ck20 * 6053 /wiki/User:NyahCh3ck20/GSoc2013/Coding_Repor: /* Aug 26 - Sept 01 */ |
| 18:15.31 | Notify | 03BRL-CAD Wiki:IIIzzzaaakkk * 6054 /wiki/User:Izak/GSOC_2013_logs: /* August 26th to August 27th */ |
| 18:31.07 | Notify | 03BRL-CAD Wiki:IIIzzzaaakkk * 6055 /wiki/User:Izak/GSOC_2013_logs: /* August 26th to August 27th */ |
| 18:41.12 | Notify | 03BRL-CAD:n_reed * 57183 (brlcad/trunk/src/libdm/dm-ogl.c brlcad/trunk/src/libdm/dm-wgl.c): distinguish between indexing and dereferencing |
| 19:01.33 | Notify | 03BRL-CAD:n_reed * 57184 brlcad/trunk/src/libdm/dm-X.c: implement vlist point size specification for dm-x |
| 19:14.39 | Notify | 03BRL-CAD:starseeker * 57185 brlcad/trunk/src/tclscripts/CMakeLists.txt: Don't just print the error if the file isn't found, return an error code |
| 19:24.00 | Ch3ck_ | running to bed ;) |
| 19:28.55 | brlcad | zero_level: what progress have you made? |
| 19:34.26 | zero_level | I was recheking with grep. |
| 19:43.36 | zero_level | The only subsequent usage I could find was in tclscripts/lib/RtImage.tcl |
| 19:43.57 | zero_level | wonders if this is really called in the regress! |
| 19:51.37 | ``Erik | zero_level: what does the machine say the problem is? |
| 19:52.17 | zero_level | ``Erik it gives a syntax |
| 19:52.32 | zero_level | error while running regress-dsp |
| 19:52.41 | ``Erik | what error does it say? |
| 19:52.52 | zero_level | It is probably because i changed input parameters. |
| 19:53.22 | ``Erik | which parameters did you change? can you find those in the regress-dsp call chain? |
| 19:53.57 | zero_level | ``Erik http://paste.kde.org/p5c66dee9/ |
| 19:54.32 | zero_level | call chain ? These are alien words to me. |
| 19:54.38 | ``Erik | so 'expr' is giving a syntax error, this is a bash script issue, right? |
| 19:54.49 | zero_level | yes I guess so, |
| 19:55.27 | ``Erik | regress-dsp calls a shell script, you can run that shell script manually... if you do that, you can do awesome stuff like add flags for debugging |
| 19:55.27 | zero_level | ``Erik : do u get such error ? |
| 19:55.45 | zero_level | do u mean regress/dsp.sh ? |
| 19:55.46 | ``Erik | actually, I saw a slew of errors before the bash error when I ran regress |
| 19:55.59 | ``Erik | but I'm teaching you how to find the issue, not finding the issue for you :D |
| 19:56.28 | ``Erik | yeh, regress/dsp.sh is the shell script in the call chain that the error shows up in |
| 19:56.42 | zero_level | was it this error http://paste.kde.org/p20e8292d/ ? |
| 19:57.03 | ``Erik | no |
| 19:57.06 | zero_level | ok. |
| 19:57.26 | ``Erik | bash has two flags I recommend you read about in the man page, '-x' and '-e' |
| 19:57.55 | ``Erik | since you know which script the error shows up in, I think this is enough for you right now :) |
| 19:58.53 | ``Erik | drops the mic and walks off the stage |
| 20:01.09 | zero_level | is still on the stage :) |
| 20:03.35 | ``Erik | did you find the documentation for the two flags? |
| 20:04.09 | zero_level | There is no call to pix-bw in the dsp.sh file. |
| 20:05.02 | zero_level | u meant man page of bash ? |
| 20:05.08 | ``Erik | yeah, man page of bash |
| 20:05.50 | zero_level | i am afraid bt i see -i,r,l,s,D options |
| 20:06.13 | ``Erik | hm, sometimes bash ships with a differnet manpage... http://serverfault.com/questions/391255/what-does-passing-the-xe-parameters-to-bin-bash-do |
| 20:07.36 | zero_level | ok. I understand you were suggesting a scheme for debugging ? |
| 20:07.46 | ``Erik | btw, a 'call chain' is a way to refer to the list of functions/programs/scripts/etc that are executed... a(){b();} b(){ c();} so a() would have a call chain of a->b->c |
| 20:07.53 | ``Erik | yes |
| 20:08.06 | ``Erik | and in this case, a script calls a script calls a script calls pix-bw |
| 20:09.09 | zero_level | I guessed that. |
| 20:09.28 | ``Erik | aight, then you're set! good luck finding it :D |
| 20:09.44 | zero_level | but i wonder grep should have shown some results. |
| 20:10.25 | brlcad | zero_level: if I grep pix-bw in regress/ it's used |
| 20:10.29 | brlcad | it's the first hit |
| 20:11.00 | ``Erik | hm, grep has a -r flag that you may not have used |
| 20:11.30 | brlcad | ``Erik: it's stashed in a variable, so he probably missed it |
| 20:12.07 | brlcad | zero_level: grep pix-bw regress/* |
| 20:12.25 | brlcad | notice the first line |
| 20:12.26 | ``Erik | which, literal pix-bw? |
| 20:12.38 | zero_level | if you are guys are pointing towards asc2dsp.sh ? Then I saw it. But i hardly see any arguments passed ! |
| 20:12.42 | ``Erik | grep line is wrong if we have the same src |
| 20:13.05 | ``Erik | "grep pix-bw regress/*/*" or "grep -r pix-bw regress" |
| 20:13.27 | brlcad | eh? |
| 20:13.34 | brlcad | it's not in a regress subdir |
| 20:14.00 | ``Erik | hm, it is on my checkout |
| 20:14.01 | brlcad | ah, I see there's ANOTHER usage there |
| 20:14.06 | brlcad | in the dsp subdir |
| 20:14.24 | ``Erik | oh, heh, two of 'em |
| 20:14.35 | brlcad | zero_level: what arguments are you seeing passed in asc2dsp.sh? |
| 20:14.55 | brlcad | what's the actual line that invokes pix-bw? |
| 20:15.05 | zero_level | P2B="`ensearch pix-bw`" |
| 20:15.36 | brlcad | nope |
| 20:15.41 | brlcad | that's a very important line |
| 20:15.43 | ``Erik | looks like asc2dsp.sh is called by regress-asc2dsp but not regress-dsp |
| 20:15.44 | brlcad | but not the line where it's run |
| 20:16.14 | brlcad | this is shell scripting, so you're forgiven ;) |
| 20:16.35 | zero_level | ok. u mean it is run on line:67 in asc2dsp.sh |
| 20:16.49 | zero_level | sees brlcad is being nice. Thanks :) |
| 20:17.09 | brlcad | nop, not 67 |
| 20:17.12 | ``Erik | someone musta left the scotch cabinet unlocked O.o |
| 20:17.22 | brlcad | that line is running a shell function called "ensearch" which is given an argument of "pix-bw" |
| 20:17.27 | zero_level | I got it this time |
| 20:17.31 | zero_level | 95. |
| 20:17.33 | brlcad | and setting a variable P2B to the result |
| 20:17.40 | brlcad | bingo |
| 20:17.57 | zero_level | What is ensearch meant for ? |
| 20:18.05 | brlcad | it's running a function to find the pix-bw tool .. sets the result to that variable, then just calls the variable |
| 20:18.07 | zero_level | googled it. didnt f |
| 20:18.16 | zero_level | ok. |
| 20:18.18 | brlcad | heh |
| 20:19.49 | brlcad | google should be the second or third idea that comes to mind |
| 20:19.59 | brlcad | first should have been to just grep for it |
| 20:20.08 | brlcad | grep -r ensearch regress |
| 20:20.17 | brlcad | you would have found it in library.sh |
| 20:20.37 | starseeker | ensearch may go away in the future, actually - it dates from the days when we needed to find commands in the source tree. These days, the build directory layout duplicates the relative hierarchy found in the actual BRL-CAD install |
| 20:20.41 | brlcad | and still, all you would have found was the implementation |
| 20:21.10 | brlcad | starseeker: meh, it ain't broken yet ;) |
| 20:21.23 | starseeker | brlcad: lines of code reducation :-P |
| 20:21.29 | brlcad | bigger fish |
| 20:21.34 | starseeker | zero_level: so what do the scripts do with P2B? |
| 20:21.42 | brlcad | that aren't likely to cause breakage |
| 20:22.00 | zero_level | brlcad: just mis interperated it as a keyword. |
| 20:22.05 | ``Erik | suddenly, I'm in the mood for seared ahi |
| 20:22.36 | brlcad | zero_level: and I know you keep saying you're changing the synopsis, but you haven't told me what it was before your change? |
| 20:23.02 | brlcad | changes are usually made very intentionally and per a policy |
| 20:23.27 | brlcad | especially once we test or publish them |
| 20:23.54 | brlcad | Izak_: did you test whether the root solever is behaving? |
| 20:25.15 | zero_level | brlcad : Do u mean before making the change ? or before chaning the synopsis ? |
| 20:25.52 | zero_level | brlcad : Can you point me to a way where string can be passed as input arguments ? |
| 20:26.03 | ``Erik | zero_level: changes to the user interface are very serious and usually go through a deprecation sequence |
| 20:26.18 | ``Erik | (options and arguments qualify as user interface) |
| 20:26.52 | zero_level | ``Erik, brlcad : ok. |
| 20:26.59 | zero_level | In the case of pix-bw |
| 20:27.06 | brlcad | zero_level: yes, before making the change |
| 20:27.20 | Notify | 03BRL-CAD:brlcad * 57186 brlcad/trunk/TODO: get rid of all the -P options |
| 20:27.34 | brlcad | what is/was the synopsis |
| 20:28.02 | zero_level | ix-bw [-ntsc] [-crt] [-R [num]] [-G [num]] [-B [num]] [in.pix] > out.bw |
| 20:28.22 | ``Erik | obviously, the command line arguments to pix-bw broke, thus breaking the regress script... just fixing the regress script is inadequate, as third party programs may be calling pix-bw and will need warning before jerking the carpet out from under them :) |
| 20:28.32 | ``Erik | s/broke/changes/ |
| 20:28.53 | brlcad | zero_level: is that after or before your change? |
| 20:29.05 | zero_level | it is before the changes. |
| 20:29.33 | zero_level | Now I must confess i dont have experience with arguments parsing. |
| 20:29.41 | zero_level | So few questions i wanted to ask. |
| 20:30.01 | zero_level | 1) Is there a way where we can parse a string from command line arguments. |
| 20:30.15 | zero_level | like -ntsc |
| 20:30.21 | zero_level | or like -crt |
| 20:30.46 | brlcad | 1) yes, don't use getopt |
| 20:30.55 | brlcad | getopt will treat that as -n -t -s -c |
| 20:31.17 | brlcad | still, have to understand the changes |
| 20:31.21 | brlcad | what's the new synopsis |
| 20:31.41 | zero_level | 2) is there a way where we could have a handle say -R and make it a flag for both an argument and without argument |
| 20:32.03 | zero_level | like pix-bw -R eg.pix > eg.bw |
| 20:32.15 | brlcad | Prior Usage: pix-bw [-ntsc -crt -R[#] -G[#] -B[#]] [in.pix] > out.bw |
| 20:32.21 | brlcad | slightly different from what you wrote |
| 20:32.35 | brlcad | might have been carl or tom though |
| 20:32.45 | zero_level | and pix-bw -R 1.2 eg.pix > eg.bw |
| 20:33.23 | zero_level | brlcad i hope i was able to convey my question 2. ? |
| 20:33.39 | brlcad | 2) probably not reliably (at least not with getopt) |
| 20:33.48 | brlcad | yep, optional arg |
| 20:34.09 | brlcad | getopt just has the ':' to say argument or no argument |
| 20:34.19 | brlcad | anything else you have to customize |
| 20:34.26 | zero_level | ok. |
| 20:34.34 | brlcad | but I wouldn't without knowing more about the problem |
| 20:34.52 | brlcad | what is the difference between "-R" and "-R 1.4" |
| 20:35.01 | zero_level | The reason i wanted to use getopt here was because we could pass the arguments in any order. |
| 20:35.15 | zero_level | but customization was tedious here. |
| 20:35.38 | ``Erik | we have bu_getopt() |
| 20:35.40 | zero_level | and it mades sense using -N instead -ntsc |
| 20:36.11 | brlcad | most tools should stick to lowercase unless it's a boolean on/off toggle |
| 20:36.38 | zero_level | It was just because -n is used for width of input files. |
| 20:36.45 | brlcad | or unless there's some established precedent like -P and -C |
| 20:37.49 | brlcad | note that you could still handle -ntsc and/or -crt in an argument processing loop |
| 20:38.03 | brlcad | the loop just changes slightly |
| 20:38.31 | zero_level | Also in any way we have to take the input file size from the user, if we wish to use icv in current form. That is icv_read(.); icv_rgb2gray(); icv_write(.)... |
| 20:39.45 | brlcad | while(1) { if (BU_STR_EQUAL(optarg, "-ntsc")) ... else if (BU_STR_EQUAL(optarg, "-crt")) ... else if (bu_getopt(...)) {...} } |
| 20:39.45 | zero_level | brlcad : are you suggesting looping in bw_getopt(..) or in a customized manner ? |
| 20:40.30 | brlcad | just notional, but the idea is to check any non-getopt args before calling getopt |
| 20:40.46 | brlcad | alternatively, handle them in the getopt error handler |
| 20:41.57 | zero_level | alright. For the time being I am resurrecting the regress. And then i will start working on minimizing usage changes for pix-bw. |
| 20:42.09 | zero_level | brlcad : I hope this is fine ? |
| 20:42.25 | brlcad | yep, regress is top priority |
| 20:42.38 | brlcad | we cannot release until regress is fixed |
| 20:42.52 | zero_level | are we making a release point ? |
| 20:43.17 | brlcad | yes |
| 20:43.29 | zero_level | schedule ? |
| 20:43.48 | brlcad | going to sync to a release branch this thursday/friday |
| 20:44.15 | brlcad | and tag it as soon as everything passes, documented, tested |
| 20:44.37 | brlcad | so looking at the regress, the problem is probably -B |
| 20:45.02 | zero_level | yeah i see that. |
| 20:45.10 | brlcad | your current usage is |
| 20:45.10 | zero_level | Just testing on bix |
| 20:45.11 | brlcad | pix-bw [-h] [squaresize] [-w width] [-n height] [ [-N] [-C] [-R red_weight] [-G green_weight] [-B blue_weight] ] [-o out_file.bw] [file.bw] > [out_file.bw] |
| 20:45.30 | zero_level | c/bix/bz |
| 20:45.51 | brlcad | by the way, that usage does not look right |
| 20:46.12 | brlcad | [squaresize] |
| 20:48.01 | brlcad | also, -C means something else, so if they're going to change I would suggest something like [-e [ntsc|crt]] |
| 20:48.51 | brlcad | rather: [-e {ntsc|crt}] |
| 20:49.05 | brlcad | that keeps it minimally impacting |
| 20:49.57 | brlcad | in order to capture [-R[#]], I suggest breaking them out into separate options like -r -g -b and -R# -G# -B# |
| 20:50.13 | brlcad | the first specifying which channels to use, the latter specifying what weight |
| 20:50.15 | zero_level | this looks fine to me. |
| 20:50.38 | brlcad | then fixing the regression scripts also becomes minimally impacting |
| 20:50.52 | brlcad | (see CHANGES file for the definition of minimally impacting) |
| 20:52.12 | zero_level | alright,. |
| 20:54.31 | brlcad | and note that there was a second P2B usage |
| 20:56.36 | brlcad | starseeker: to answer your question, depends what you mean by initializing it |
| 20:57.01 | brlcad | starseeker: no problem zero-initializing (with a valid magic) and that *should* be happening already since it's not a pointer |
| 20:57.12 | brlcad | if it's not, that's a problem |
| 20:57.31 | brlcad | filling in that structure all the time would probably be a performance problem |
| 20:58.06 | brlcad | at least enough to warrant timeing and testing |
| 20:59.09 | brlcad | should be visible on db load and prep timing for big targets |
| 21:16.20 | Notify | 03BRL-CAD:starseeker * 57187 brlcad/trunk/src/librt/search.c: More thinking about what will needed for db_search function |
| 21:21.12 | *** join/#brlcad mpictor (~mark@2601:d:b280:3d4:d63d:7eff:fe2d:2505) | |
| 21:53.47 | Notify | 03BRL-CAD:carlmoore * 57188 brlcad/trunk/src/conv/g-obj.c: minor formatting changes, including removal of a trailing blank |
| 23:17.42 | ``Erik | "where's waldo: the audiobook" |