| 00:00.05 | Notify | 03BRL-CAD:brlcad * 57892 brlcad/trunk/HACKING: document the new release steps and how they pertain to the new RELEASE branch. make progress on turning the release steps into a proper shell script that is partially automatable, imminently copy-pasteable. still more work needed, but checkpointing. |
| 00:26.43 | starseeker | hmm. So I can go ahead and rip out all that CMake alias stuff? |
| 00:27.12 | starseeker | actually uses ENABLE_ALL instead of BRLCAD_BUNDLED_LIBS... |
| 03:11.36 | brlcad | don't have to, but I've not (yet) seen the benefits and there are several downsides being realized |
| 03:13.04 | brlcad | good motivation to review all the names for consistency/conciseness |
| 03:14.50 | brlcad | now that's pretty cool... ``Erik: got an account on an old pdp10 |
| 03:15.40 | brlcad | took me a few minutes to remember some of the old vms commands, but was able to write out, compile, link, and run a little hello world program |
| 03:18.34 | kesha_ | brlcad: There ? I want to abt discuss my patches. |
| 03:22.25 | brlcad | kesha_: i'm in the middle of several things at the moment, but discussion I have a little time for, what's up? |
| 03:24.37 | kesha_ | brlcad: The deadline is near close and I suspect all pending and open patches should be reviewed and merged by 27th 19:00 i.e. before final eval. Isn't it ? |
| 03:25.27 | kesha_ | brlcad: Thats why I am a bit worried. |
| 03:26.26 | brlcad | kesha_: worried about what? |
| 03:27.07 | brlcad | you will be submitting your code modifications through melange regardless of any review, merging, or evaluation |
| 03:27.25 | kesha_ | brlcad: worried that if the patches don't get merged, they won't consider that as my work. I might be wrong. |
| 03:27.40 | brlcad | yes, that's not right |
| 03:28.11 | brlcad | your work is what you did, that is what you'll prepare and submit |
| 03:28.33 | kesha_ | oh, okay. Still if it gets reviewed once if you get a little time, I can work upon improving them. :) |
| 03:29.09 | brlcad | it'll certainly get reviewed as soon as someone can, and hopefully you'll be on hand to improve them |
| 03:29.30 | brlcad | if you know things wrong with them or how to improve them, you certainly should not wait for me or someone else to point them out to you |
| 03:30.27 | kesha_ | I am unsure abt the technique I applied for checking float. What I did is , truncated the part after decimal and added one. Compared the value <=1 instead of <=0. Is it a bad practice or alright ? As it was not allowing me to compare float values with any other float/int |
| 03:30.57 | brlcad | it actually gets very frustrating when there are simple mistakes that have to be pointed out, so hopefully you have checked your worked, rechecked it, compiled, tested, run it |
| 03:31.04 | brlcad | things that clearly don't even compile are a complete waste of time to review |
| 03:31.47 | brlcad | I need some context to understand what your'e talking about with the float checking |
| 03:32.22 | kesha_ | No, I have checked and compiled and tested. It runs correct with showing right output and saw the files created in .g format with mged. The geometry also confirmed with that showed in image given. |
| 03:32.44 | brlcad | did you specifically exercise the code that you modified? |
| 03:33.16 | kesha_ | I needed to check volume <=0 -> error. But the average volume which was caluated was in float. |
| 03:33.18 | brlcad | i.e., you performed some run-time test that you are certain called the code you modified in a way that demonstrates it is correct |
| 03:34.39 | brlcad | you're talking about the regression script you were working on, verifying that it converted to something? |
| 03:35.27 | kesha_ | I compiled and ran 'make regress-step2g'. The way in which I modified CMakeLists.txt, it made a folder in build directory after compilation and had some .log files and .g files which my script produces. And checking those files. |
| 03:35.39 | kesha_ | Yes, I am talking abt it . |
| 03:36.11 | brlcad | you should start with that information, give context to what you're talking about :) |
| 03:37.15 | kesha_ | Oh, ya. Forget to mention abt that specifically. ! |
| 03:37.56 | kesha_ | So , is that method alright or shall I look for other options to compare float value with zero ? |
| 03:38.33 | brlcad | well that entirely depends |
| 03:38.44 | brlcad | on the surface, in this context |
| 03:39.01 | brlcad | truncation isn't necessarily a bad idea .. weak but not bad |
| 03:39.58 | brlcad | did you look at some of the other regression tests to see how other tests might deal with similar comparison needs? |
| 03:42.30 | kesha_ | I worked with my own way of coding and it worked. Though I had just an upper glance at other tests. |
| 03:44.41 | kesha_ | Most of the tests like comgeom , fastgen etc don't seem to check the geometry of the model. they just check if the conversion took place. |
| 03:47.18 | brlcad | each test has a slightly different purpose |
| 03:47.37 | brlcad | there's no test that matches exactly what your needed to do, but there are various elements that are identical |
| 03:49.04 | brlcad | should always consult similar sources, to make sure you're consistent |
| 03:49.59 | kesha_ | I agree, but the point is they don't verify the underlying model. They just exit after checking the file was created successfully. |
| 03:50.23 | brlcad | working in your own way is only useful for homework projects, not code that others will be reading and maintaining indefinitely |
| 03:50.27 | brlcad | sure, they didn't need to |
| 03:52.04 | kesha_ | hmm .. alright. |
| 03:54.04 | brlcad | like I said, all the tests have somewhat different purposes |
| 03:55.00 | brlcad | tend to create tests for issues that occur multiple times |
| 03:55.09 | brlcad | fastgen test isn't at all concerned with whether it succeeded, for example |
| 03:55.53 | brlcad | that's an old tool that's been working for decades .. it's testing whether a text fastgen file with DOS line endings will convert the same as one with UNIX line endings |
| 03:57.06 | kesha_ | okay.. I think I get the point. thanks :) |
| 03:57.40 | brlcad | kesha_: if your method works and each section makes sense and you've tested it, and documented it, and you think it's otherwise perfect .. it's probably godo |
| 03:57.54 | brlcad | good to go |
| 03:58.48 | brlcad | just make sure you're not using any bash extensions .. needs to be posix compliant |
| 03:59.56 | brlcad | if you follow/followed the patterns in the other scripts, it will be |
| 04:01.28 | kesha_ | I have already tested and added lines of comment, still I will relook once. I will also see if I haven't used the bash extensions once. Yes, I followed the format of other codes whereever it was suitable, so there wouldn't be any issue. :) |
| 04:03.45 | brlcad | you say that now ... and you've said that before :) |
| 04:04.49 | brlcad | I'm not sure I've seen a patch from you (or Ch3ck) still that hasn't had some issue... something to definitely work on improving |
| 04:05.16 | brlcad | takes time, practice, and lots of writing AND reading code with concentration and attention to detail |
| 04:10.05 | kesha_ | yupp .. indeed I realize that fact through the project |
| 08:10.37 | *** join/#brlcad Ch3ck_ (~Shadownet@195.24.220.16) | |
| 08:14.32 | *** join/#brlcad kesha (~kesha@1.38.31.243) | |
| 11:10.34 | Notify | 03BRL-CAD:tbrowder2 * 57893 NIL: add dir for compat functions for strict POSIX use similar to tcl/compat |
| 11:17.07 | *** join/#brlcad d_rossberg (~rossberg@66-118-151-70.static.sagonet.net) | |
| 11:36.55 | Notify | 03BRL-CAD:tbrowder2 * 57894 brlcad/trunk/CMakeLists.txt: update |
| 12:52.56 | ``Erik | pdp10? a real one? wasn't that like 36b or something? |
| 12:53.31 | ``Erik | (and vms commands, or very very old bsd commands?) |
| 13:37.33 | Notify | 03BRL-CAD:carlmoore * 57895 (brlcad/trunk/CMakeLists.txt brlcad/trunk/HACKING and 4 others): remove trailing blanks/tabs; fix spellings |
| 14:00.00 | Notify | 03BRL-CAD:starseeker * 57896 (brlcad/trunk/src/other/poly2tri/poly2tri/common/shapes.cc brlcad/trunk/src/other/poly2tri/poly2tri/common/shapes.h and 10 others): Add newlines at end of files |
| 14:02.15 | brlcad | ``Erik: yep, real one |
| 14:02.28 | brlcad | also two others |
| 14:05.46 | brlcad | a toad-1, a 2065, and a VAX 11/785 |
| 14:07.14 | Notify | 03BRL-CAD:starseeker * 57897 (brlcad/trunk/src/other/stepcode/src/cllazyfile/headerSectionReader.h brlcad/trunk/src/other/stepcode/src/cllazyfile/instMgrHelper.h and 13 others): Add newlines to end of files |
| 14:27.20 | Notify | 03BRL-CAD:carlmoore * 57898 brlcad/trunk/configure: auto-updated configure file |
| 14:27.39 | *** join/#brlcad kesha (~kesha@14.139.122.114) | |
| 14:28.21 | *** join/#brlcad Gaganjyot (~gagan@125.62.120.247) | |
| 14:44.55 | ``Erik | huh, 11/785? wasn't vgr an insanely souped up 11/780? |
| 14:48.46 | Notify | 03BRL-CAD:d_rossberg * 57899 brlcad/trunk/src/libged/search.c: for MSVS 2008: moved variable declarations to the beginning of the block |
| 14:51.28 | Notify | 03BRL-CAD Wiki:Applied3dim * 0 /wiki/User:Applied3dim: |
| 15:13.16 | brlcad | yep |
| 15:13.47 | brlcad | cept, this 11/785 is running vms (boo hiss) instead of vgr's bsd |
| 15:26.45 | *** join/#brlcad FLOSSrookie (~brian@107-200-34-111.lightspeed.tulsok.sbcglobal.net) | |
| 16:48.18 | *** join/#brlcad caen23 (~caen23@92.85.89.94) | |
| 17:15.15 | *** join/#brlcad kesha (~kesha@14.139.122.114) | |
| 17:23.27 | *** join/#brlcad Gaganjyot (~gagan@125.62.120.247) | |
| 17:42.19 | *** join/#brlcad kesha (~kesha@14.139.122.114) | |
| 18:04.11 | *** part/#brlcad Gaganjyot (~gagan@125.62.120.247) | |
| 18:11.53 | Notify | 03BRL-CAD Wiki:Silvane2013 * 0 /wiki/User:Silvane2013: |
| 18:22.00 | *** join/#brlcad Gaganjyot (~gagan@125.62.120.247) | |
| 18:41.07 | *** join/#brlcad Gaganjyot (~gagan@125.62.120.247) | |
| 19:51.20 | *** part/#brlcad Gaganjyot (~gagan@125.62.120.247) | |
| 20:21.57 | *** join/#brlcad tbrowder2 (4c0304df@gateway/web/freenode/ip.76.3.4.223) | |
| 20:59.45 | *** join/#brlcad kesha (~kesha@14.139.122.114) | |
| 22:19.48 | Notify | 03BRL-CAD:n_reed * 57900 (brlcad/trunk/include/raytrace.h brlcad/trunk/src/librt/primitives/table.c): add notional rt structs and functab entries to support selection of subcomponents of primitives |
| 22:27.00 | n_reed | brlcad: so that's a slightly expanded & refined version of what I'd hacked up that I think will work for my purposes; please feel free to comment by committing changes =) |
| 23:45.31 | brlcad | okie dokie |