IRC log for #brlcad on 20141219

00:18.12 *** join/#brlcad chick_ (~capslock@41.205.22.41)
00:26.36 *** join/#brlcad kintel (~kintel@unaffiliated/kintel)
02:11.33 starseeker andromeda-galaxy: not at all
02:13.02 starseeker andromeda-galaxy: once we get the next wave of GCI tasks queued up, we're going to add a task to figure out what's going on with the arbs in the model you got working with comgeom-g
02:13.41 starseeker if the wireframes are there in principle it should be able to generate arbs... may be the points are out of order or some such....
02:14.21 starseeker or the version 1 support in comgeom-g has a bug
02:26.53 Notify 03BRL-CAD:starseeker * 63787 brlcad/trunk/db/CMakeLists.txt: Add the five NIST PMI step files to the sample dbs, and set up to compile them to .g files.
03:20.10 Notify 02GCI:mjuvekar7 * 4824199776436224 : Claim Removed - The claim on this task has been removed, someone else can claim it now.
03:28.16 Notify 02GCI:mjuvekar7 * 6057763171991552 : Task Claimed - I would like to work on this task.
03:29.33 *** join/#brlcad YashM (~YashM@117.222.21.100)
03:40.04 Notify 02GCI:fernozzle * 5836136417067008 : Claim Removed - The claim on this task has been removed, someone else can claim it now.
03:46.51 *** join/#brlcad mandarj (~mandar@117.195.47.89)
03:46.55 Notify 02GCI:brlcad * 6057763171991552 : Task Assigned - This task has been assigned to mandarj. You have 100 hours to complete this task, good luck!
03:47.45 mandarj I am working on the task at https://www.google-melange.com/gci/task/view/google/gci2014/6057763171991552
03:47.46 gcibot Doxygen cleanup for LIBWDB
03:47.46 gcibot Status: Claimed (4 days 3 hrs 58 min)
03:47.46 gcibot Mentor(s): Sean, Mihai Neacsu
03:48.05 mandarj How do I generate the Doxyfiles?
03:48.22 mandarj (a mentor told me to use CMake but how?)
03:50.21 Notify 02GCI:mjuvekar7 * 6057763171991552 : Claim Removed - The claim on this task has been removed, someone else can claim it now.
03:50.41 Notify 02GCI:brlcad * 5231299258220544 : Task Closed - Congratulations, this task has been completed successfully.
03:50.56 Notify 02GCI:mjuvekar7 * 6057763171991552 : None - Sorry, have to go out of town for 4 days. Can I claim the task once I come back?
03:51.20 Notify 02GCI:mjuvekar7 * 6057763171991552 : None - I mean claim the task *again* when I come back?
03:56.11 Notify 02GCI:brlcad * 5231299258220544 : looks great! - sharan, thanks -- this looks neat! I like how the nose could be a separate (main) gun and the side other (secondary) guns.
04:05.39 Notify 02GCI:brlcad * 5832406154084352 : Task Needs More Work - One of the mentors has sent this task back for more work. Talk to the mentor(s) assigned to this task to satisfy the requirements needed to...
04:10.55 Notify 02GCI:brlcad * 5832406154084352 : definitely on the right track - This is looking good and you're on the right track, but you're testing a few things that probably don't make sense to test and...
04:13.10 Notify 02GCI:brlcad * 6094206841913344 : Task Needs More Work - One of the mentors has sent this task back for more work. Talk to the mentor(s) assigned to this task to satisfy the requirements needed to...
04:23.46 Notify 02GCI:brlcad * 6094206841913344 : transcript - Ekamjot, I suggest submitting a text file transcript for the video (like a screen play) before re-rendering a second video. This looks okay, but...
04:46.08 *** join/#brlcad kintel (~kintel@unaffiliated/kintel)
05:24.20 Notify 02GCI:o7p9bxbnyj * 5900544686161920 : Ready for review - The work on this task is ready to be reviewed.
05:25.06 Notify 02GCI:brlcad * 5900544686161920 : Task Closed - Congratulations, this task has been completed successfully.
05:29.00 *** join/#brlcad chick_ (~capslock@41.205.22.41)
05:34.34 andromeda-galaxy brlcad: sorry, I just realized that the patch for 5900544686161920 has changes in naca456.c that aren't quite done yet (hence the #if 1/#else)... I'll claim the #4 conversion task that involves finishing those now...
05:35.01 Notify 02GCI:o7p9bxbnyj * 5283618133901312 : Task Claimed - I would like to work on this task.
05:37.49 *** join/#brlcad MarcUNIX (5679c4d5@gateway/web/cgi-irc/kiwiirc.com/ip.86.121.196.213)
05:38.38 MarcUNIX G'morning
05:40.14 MarcUNIX brlcad: Thanks for the feedback on my test, thought the logic behind it is the same as in BRL-CAD, with it being a standalone program.
05:43.58 MarcUNIX Any mentor here who knows how BRLCAD::Database works in r^3?
05:47.58 *** join/#brlcad andrei_ (c35a6e7d@gateway/web/freenode/ip.195.90.110.125)
05:50.51 Notify 02GCI:popescuandrei * 5283618133901312 : Task Assigned - This task has been assigned to Andromeda Galaxy. You have 100 hours to complete this task, good luck!
05:55.50 *** join/#brlcad FreezingCold (~FreezingC@135.0.41.14)
06:35.57 YashM i am not able to delete a point by pressing delete button in archer, anyone know why?
06:39.04 andrei_ I assume you should file a bug?
06:39.15 Notify 02GCI:fernozzle * 5836136417067008 : Too busy to continue with the Google Code-In - Sorry, I don't think I'll be able to continue working on tasks with school ramping up this year. I'll work on...
06:39.46 YashM maybe its not a bug?
06:46.17 Notify 02GCI:popescuandrei * 5836136417067008 : None - Michael, On the contrary, we really appreciate you reaching out and letting us know! Thanks for your involvement so far! While we do feel sorry to...
06:50.16 MarcUNIX andrei_ , regarding the Sphere.cpp test, is http://pastebin.com/7h4NRJt0 okay? These are 7 functions being tested here : setCenter,setRadus,isValid,Type,ClassName,Center,Radius. After looking at Sphere.cpp there are two more functions I can unit test for : Clone & Set
06:50.48 MarcUNIX Would that be okay?
06:50.57 andrei_ yes, I believe
06:51.04 andrei_ that's everything you can test
06:51.12 andrei_ that + copy constructor
06:51.27 andrei_ because you re testing the default one implicitly(with isValid)
06:51.38 MarcUNIX Before asking the copy constructor, the Clone function returns an object type
06:52.09 MarcUNIX For me to check, let's say its Y coordinate I should call
06:52.19 MarcUNIX sph.clone().coordinates[1]?
06:52.53 andrei_ the copy constructor
06:52.58 andrei_ and clone don't have the same behaviour
06:53.08 MarcUNIX Yes
06:53.15 andrei_ also, sph.clone().coordinates[1]?
06:53.16 MarcUNIX I am asking regarding the clone one
06:53.18 andrei_ if you d do this
06:53.25 andrei_ you d clone each time you test a member
06:53.30 MarcUNIX oh okay
06:53.32 andrei_ so you have to assign
06:53.33 MarcUNIX can I do
06:53.40 MarcUNIX BRLCAD::Sphere clone; clone=sph.clone();?
06:53.55 andrei_ yeah, I believe you should
06:54.02 MarcUNIX I see the "=" operator is over-written
06:54.03 andrei_ it might need BRLCAD::Sphere *clone;
06:54.05 MarcUNIX for Spheres
06:54.13 MarcUNIX so it should work
06:54.19 MarcUNIX why "*"?
06:54.37 andrei_ argh
06:54.38 andrei_ wait a sec
06:54.49 andrei_ emacs keeps opening even if I want to open sublime
06:55.29 MarcUNIX is there a sublime release for linux?
06:55.32 MarcUNIX actually let me check
06:55.41 andrei_ of course :p
06:55.41 MarcUNIX oh there is :O
06:55.49 MarcUNIX bye bye gedit
06:55.54 andrei_ haha
06:55.59 andrei_ but why not vim
06:56.05 MarcUNIX I'm used to sublime
06:56.08 andrei_ type in to your console
06:56.09 MarcUNIX It fels like home
06:56.12 andrei_ vim new_file
06:56.17 andrei_ see how it looks ;
06:56.21 MarcUNIX I tested both vim & nano
06:56.23 MarcUNIX did not like either
06:56.31 andrei_ how did you manage to exit vim ? :))
06:57.07 MarcUNIX not sure
06:57.14 MarcUNIX think I left it open and restarted my PC to get into windows
06:57.19 andrei_ you ve asked why "*"
06:57.23 andrei_ Object* Sphere::Clone
06:57.36 MarcUNIX wait
06:57.37 MarcUNIX what
06:57.43 MarcUNIX Why not BRLCAD::Sphere clone
06:58.09 andrei_ because it returns a pointer to the newly allocated sphere
06:58.14 andrei_ I m not sure how you could do it otherwise?
06:58.29 MarcUNIX I don't want a pointer
06:58.33 MarcUNIX let me just write a fast pastebin
06:58.46 andrei_ what do you mean you don t want a pointer?
07:00.21 *** join/#brlcad mihaineacsu (~mihaineac@92.85.30.25)
07:00.53 andrei_ " it's not what you want it's what you need '
07:01.31 MarcUNIX http://pastebin.com/ZPvujaT8
07:01.33 MarcUNIX something like that
07:01.48 MarcUNIX the if is humongous but that's because I'm not sure whether the "==" operator is over-written
07:01.53 MarcUNIX and I'm not taking any chances
07:02.37 andrei_ where us
07:02.42 andrei_ where is Vector3D defined
07:02.53 MarcUNIX what do you mean
07:02.58 MarcUNIX this is a function that would go into my existing code
07:03.13 andrei_ I know
07:03.28 andrei_ I ve asked where is Vector3D defined, to see if there is some kind of operator overload
07:03.38 MarcUNIX the "==" operator might be overloaded, but this works either way
07:03.41 andrei_ if there is not, you should write a utility function
07:03.54 andrei_ to compare a 3 elements array
07:03.59 MarcUNIX Yeah it should be easy
07:04.06 MarcUNIX But is the declaration of sph2 okay?
07:04.24 andrei_ you can compile and tell me that
07:04.33 MarcUNIX can't compile at the moment :-s
07:04.35 andrei_ but as I said, I m quite sure it will need a pointer
07:04.40 MarcUNIX have some issues with my environment
07:04.48 MarcUNIX there might be an issue though
07:04.54 MarcUNIX return new Sphere(*this); is what clone returns
07:04.54 andrei_ need help with anything?
07:04.58 andrei_ yeah
07:05.03 MarcUNIX emphasis on "new"
07:05.10 andrei_ it calls the copy constructor
07:05.14 andrei_ on itself
07:05.17 MarcUNIX ah okay
07:05.49 MarcUNIX Would BRLCAD::Sphere *sph2; work then?
07:06.46 andrei_ yeah, it should
07:06.50 andrei_ I m not entirely sure without a compiler
07:07.04 MarcUNIX I'll try to fix my environment after this
07:07.06 MarcUNIX to test it
07:07.34 andrei_ as I said previously
07:07.37 andrei_ need help with fixing it?
07:07.39 andrei_ what's wrong
07:09.52 MarcUNIX nah, I just need to get my g++ up to date probably
07:10.58 andrei_ sudo apt-cache search libstdc++
07:11.51 MarcUNIX shouldn't I sudo apt-get install/update g++ ?
07:11.58 MarcUNIX depending on if it's installed on my machine or not
07:12.04 andrei_ you probably have it
07:12.07 andrei_ but yeah, do that
07:14.03 MarcUNIX what does apt-cache search do?
07:14.50 andrei_ it searches
07:14.53 andrei_ fofor a package
07:16.30 MarcUNIX andrei_, while I figure out what my environment's issue is can you check http://pastebin.com/ygamaJ1y out?
07:18.44 *** join/#brlcad kesha_ (~kesha@106.51.132.236)
07:18.49 andrei_ as I've said
07:18.53 andrei_ there are too many cascading if's
07:19.07 MarcUNIX what is the alternative?
07:19.15 andrei_ brb, meeting, I ll tell you when I get vack
07:19.17 andrei_ back
07:26.08 andrei_ there
07:26.12 andrei_ you could do
07:26.41 andrei_ if (condition fails){ cout << "where did test fail"; return -1; }
07:26.45 andrei_ instead of cascading
07:26.50 andrei_ cascading would work for Sphere
07:26.55 andrei_ but for other primitives, such as Sketch
07:26.58 andrei_ or Pipe
07:27.04 andrei_ it wouldn't, they are too complex
07:27.17 andrei_ and you d get like 30 levels of imbrication
07:34.34 *** join/#brlcad roonyh (~aruna@220.247.238.241)
07:35.57 *** part/#brlcad roonyh (~aruna@220.247.238.241)
07:37.38 Notify 02GCI:pranavmanchanda * 5220441446678528 : Task Claimed - I would like to work on this task.
07:39.03 Notify 02GCI:popescuandrei * 5220441446678528 : Task Assigned - This task has been assigned to Pranav Manchanda. You have 100 hours to complete this task, good luck!
07:39.57 MarcUNIX ah okay
07:40.04 MarcUNIX thought you wanted a more radical change to the code
07:40.08 MarcUNIX that should be pretty easy to do
07:40.27 MarcUNIX want me to also implement a test for the copy constructor? If yes, please tell me how a constructor is called ( the syntax )
07:41.25 andrei_ it s something like
07:41.33 MarcUNIX andrei_, there is an issue with not cascading ifs though. How do I add my object to the database? I need to know that all the conditions were met. Should I take a boolean variable and put it on 1 when one test fails, and only add it to the database if my boolean is 0?
07:41.43 andrei_ no
07:41.51 andrei_ if you return -1
07:41.56 andrei_ whenever the condition is not met
07:42.01 MarcUNIX argh
07:42.06 andrei_ you will simply not reach the adding database point
07:42.09 MarcUNIX wanted to have a void function though
07:42.14 MarcUNIX that does not return anything
07:42.20 MarcUNIX like the halfspace test
07:42.20 andrei_ then you can do it with a boolean
07:42.23 MarcUNIX okay
07:42.27 MarcUNIX want to be consistent :D
07:43.06 andrei_ if you see daniel(d_rossberg) around
07:43.13 andrei_ you can and should ask him too
07:43.20 andrei_ he's more experienced in rt^3 than me
07:43.43 MarcUNIX what about the constructor?
07:43.49 MarcUNIX syntax please :D
07:44.31 andrei_ BRL-CAD::Sphere newsph(oldsph);
07:45.02 MarcUNIX is that it?#
07:46.14 andrei_ yeah
07:46.26 MarcUNIX well then I'll have this patch finished in less than 15 minutes then
07:46.27 MarcUNIX :D
07:46.48 andrei_ damn, it s the last working day before Chirstmas holiday
07:46.53 andrei_ I ve got absolutely nothing to do
07:47.03 andrei_ and the time seems to be passing so slowly that it's almost frozen
07:47.18 MarcUNIX www.tetrisfriends.com
07:47.18 MarcUNIX ?
07:47.22 MarcUNIX Competitive tetris
07:47.39 andrei_ that's ... unexpected
07:47.39 MarcUNIX nothing can go wrong with tetris
07:47.59 andrei_ I can't play at work
07:48.05 andrei_ I mean I can, but it's not exactly ok
07:48.14 MarcUNIX Ow
07:48.18 MarcUNIX That's unfortunate
07:48.47 Stragus But it's... you know, team building. :)
07:48.52 andrei_ hahaha
07:49.13 andrei_ there are like 3 people on the whole building floor
07:49.15 Stragus SURVICE used to have LAN parties at lunch hours
07:50.04 andrei_ I usually play on my phone
07:50.13 andrei_ but for some reason I never put too many games on it
07:50.42 MarcUNIX because android games have been really bad in the past few months I guess
07:50.42 Stragus Ah yes, I probably spend ~1 hour playing Chess daily
07:51.10 andrei_ my mind is quite numb right now, I'm sleeping inside
07:52.17 andrei_ some games have really cool graphics
07:52.46 andrei_ but I prefer the ones more arcade-ish
07:52.52 andrei_ like wannabe super mario's
07:52.55 andrei_ and stuff like that
07:53.21 MarcUNIX check out piano tiles
07:53.23 MarcUNIX great time killer
07:53.32 MarcUNIX not arcade-y though
07:53.37 andrei_ I was playing that
07:53.40 andrei_ "cut the rope" thing
07:53.48 MarcUNIX oh
07:53.57 MarcUNIX Yeah, I got bored of that pretty quickly
07:54.17 andrei_ there was a game where you had to put cogs and mechanisms into the right position
07:54.26 andrei_ and it was pretty cool
07:54.29 andrei_ but I can t remember it s name
07:54.55 andrei_ I don t get what's up with the android users in Romania
07:55.04 andrei_ the top suggestion is always that
07:55.06 andrei_ talking tom cat stuff
07:55.11 Notify 02GCI:Melange * 5817378281619456 : Task Reopened - Melange has detected that the final deadline has passed and it has reopened the task.
07:55.28 MarcUNIX andrei_, BRL-CAD::Sphere newsph(oldsph); are you sure this is the correct constructor for copying a sphere?
07:55.39 MarcUNIX Can't find anything like this declared in Sphere.cpp
07:55.41 andrei_ this is correct for calling a C++ copy constructor
07:56.09 MarcUNIX there is this though
07:56.10 MarcUNIX const Object& Sphere::operator=
07:56.10 MarcUNIX (
07:56.10 MarcUNIX <PROTECTED>
07:56.10 MarcUNIX ) throw(bad_alloc) {
07:56.10 MarcUNIX <PROTECTED>
07:56.10 MarcUNIX <PROTECTED>
07:56.10 MarcUNIX <PROTECTED>
07:56.11 MarcUNIX <PROTECTED>
07:56.11 MarcUNIX <PROTECTED>
07:56.12 MarcUNIX }
07:56.31 andrei_ that's the overloaded assign operator
07:56.34 MarcUNIX yeah
07:56.46 MarcUNIX which "copies" a sphere into another
07:58.01 andrei_ it doesn't copy
07:58.08 andrei_ it changes a refference
07:58.11 andrei_ you can see there is no alloc :)
07:58.26 Notify 02GCI:mihaineacsu29 * 6057763171991552 : None - Sure, go ahead and claim the task when you're ready to work on it :).
07:58.37 MarcUNIX Take a look over the code and tell me if there's any function other than : IsValid, Center, Radius, ClassName, Type, Set, SetCenter, SetRadius, Clone that I should test
07:58.39 MarcUNIX Not sur
07:58.48 MarcUNIX Not sure about what you meant by testing the copy constructor
07:58.53 andrei_ calling it
07:59.04 andrei_ then seeing that the "newsph"
07:59.06 andrei_ isn't null :)
07:59.16 andrei_ and calling it with a null refference
07:59.21 andrei_ and see if the program breaks
08:00.30 *** join/#brlcad d_rossberg (~rossberg@66-118-151-70.static.sagonet.net)
08:00.37 MarcUNIX BRLCAD::Sphere newsph(oldsph); copies oldsph into newsph
08:00.48 MarcUNIX so checking if their centers & radius are the same would work too, right?
08:00.53 MarcUNIX I men that's it purpose
08:01.00 MarcUNIX it's*
08:01.09 MarcUNIX its**
08:01.25 andrei_ mean***
08:01.59 andrei_ yeah
08:02.00 andrei_ it does
08:02.06 andrei_ I mean, you could check that too
08:02.21 andrei_ also, Daniel joined IRC, so you can ask him too :)
08:03.22 MarcUNIX d_rossberg, for testing the copy constructor of a sphere in rt^3, calling BRLCAD::Sphere newsph(oldsph) and then checking if the two are equal works, right?
08:04.19 d_rossberg sounds good
08:04.24 MarcUNIX great
08:05.32 d_rossberg how do you want to check for equalness?
08:07.37 MarcUNIX Well, just like I did previously with two other spheres
08:07.54 MarcUNIX Surely there should be an "==" overload defined somewhere, but just in case it is not I went the basic way
08:08.15 MarcUNIX http://pastebin.com/qK3n9LTS
08:11.46 d_rossberg Hmm, there is no BRLCAD::Object::clone() but a BRLCAD::Object::Clone() and the == operator for BRLCAD::Object is really not overloaded
08:12.14 MarcUNIX oh yeah that's my bad
08:12.17 MarcUNIX the capital letter part
08:12.42 MarcUNIX Maybe a task for overloading the BRLCAD::Object == operator?
08:12.50 MarcUNIX should be pretty straight forward
08:13.29 d_rossberg no, it isn't :|
08:14.07 MarcUNIX Okay, overloading each primitive operator then?
08:14.11 MarcUNIX BRLCAD::Sphere for texample
08:14.25 MarcUNIX implies comparing eight variables
08:15.03 d_rossberg you wrote a test for equalness of sheres which is a very simple primitive, doing this for all is absolutely not trivial
08:15.31 MarcUNIX why is that?
08:16.42 MarcUNIX also d_rossberg,andrei_, in /tests/coreinterface/cmakelists.txt what is the syntax for adding another test? I already added it under the set sources part, not sure what the next 3 lines of code are for
08:17.25 d_rossberg e.g. when are two bots equal? when they define the same trianles? how do you handle the order of the triangles?
08:17.34 d_rossberg that't not so easy
08:17.49 MarcUNIX bots?
08:17.51 MarcUNIX what are those?#
08:18.04 andrei_ bags of triangle
08:18.25 andrei_ some primitives that resemble a shape made up by a list of triangles, called faces
08:18.47 andrei_ What Daniel meant is that equalness is not easy to determine for all primitives
08:18.51 andrei_ sphere is the simplest one :)
08:19.26 d_rossberg your test should be similar to the halfspace one, so put your source where halfspace.cpp is (to the ciTests_SRC)
08:21.15 MarcUNIX d_rossberg: that's it?
08:21.30 MarcUNIX that is what I've done but there are some other calls after that
08:21.36 MarcUNIX for primitives
08:21.57 MarcUNIX ooooh right I should also edit primitives.cpp
08:22.27 d_rossberg äh, yes
08:22.34 MarcUNIX just one line of code though
08:22.44 MarcUNIX because I changed everything so that my test fits into primitives.cpp
08:22.49 MarcUNIX and I almost forgot to add it there
08:22.50 MarcUNIX :-s
08:23.18 d_rossberg and don't forger primitives.h :)
08:23.33 d_rossberg (forget)
08:23.39 andrei_ Daniel, I ve noticed that you have cascading if's in halfspace
08:23.50 andrei_ if(valid) .. if (name) ...
08:23.51 andrei_ and so forth
08:24.05 andrei_ I ve told Marc that it s too much to have about 8 imbricated if's
08:24.29 andrei_ http://pastebin.com/ygamaJ1y
08:24.30 andrei_ have a look
08:24.51 andrei_ I told him that if a sub test fails he can simply exit function
08:24.53 andrei_ do you agree?
08:25.59 MarcUNIX My current source has a boolean ok that goes to 1 if a test fails, and the sphere is only added to the database if it passes all the tests ( aka ok=0 after all the tests )
08:26.16 MarcUNIX so that I keep the function void, like halfspace, to be consistent :D
08:26.21 MarcUNIX let me just submit my patch to melange
08:28.15 Notify 02GCI:tannousmarc * 5832406154084352 : IRC - Andrei and D_Rossberg provided great help via IRC, submitted a patch according to what we discussed and Sean's comment here on my task. No cascading...
08:28.16 Notify 02GCI:tannousmarc * 5832406154084352 : Ready for review - The work on this task is ready to be reviewed.
08:30.54 andrei_ Marc, in principle, the test looks ok to me
08:31.09 andrei_ I m just waiting for Daniel's opinion on how I ve told you to deal with cascading ifs
08:32.44 andrei_ I'm very surprised about the lack of activity
08:32.50 andrei_ at Code-in in this period
08:33.02 andrei_ since it s winter holiday, I would've expected lots of students as well
08:33.19 MarcUNIX seems to be lots of activity over at haiku
08:33.34 MarcUNIX and ignacio has something like 40 tasks done over at sugar labs
08:34.17 andrei_ so what?
08:34.25 andrei_ I mean, you can t really compare
08:35.33 andrei_ if I'm correct, BRL-CAD seems to be in #2 place as number of tasks completed
08:35.35 andrei_ after Haiku
08:35.54 MarcUNIX there are lots of sutdents at haiku with a low number of tasks tho
08:36.10 MarcUNIX Haiku: 250 finished tasks
08:36.16 d_rossberg the reason for my cascading if was that a further test doesn't make sense if the inertial object is bad
08:36.33 MarcUNIX ^ +1
08:36.44 andrei_ d_rossberg: yeah, but you achieve the same if you return from function
08:36.52 andrei_ like
08:36.57 d_rossberg i think i'll review the patch and comment it
08:37.04 andrei_ if(!sph.isValid) return;
08:37.17 d_rossberg me has to leave in 20 min
08:37.29 MarcUNIX if you have the time please review it before you leave
08:38.01 d_rossberg andrei_: my philosophy is to have exactly one return in a function
08:38.11 d_rossberg this makes debugging easier
08:38.23 andrei_ ah, that complicates the design however
08:38.35 andrei_ he has like 10 cascading if's
08:38.38 d_rossberg but i don't require this from other (here)
08:38.43 andrei_ which will eventually go out of screen
08:40.21 d_rossberg gotos aren't always bad ;)
08:40.40 andrei_ ah, ok
08:40.51 andrei_ if you re ok with goto's it s simple
08:40.54 MarcUNIX wait what
08:41.02 MarcUNIX gotos aren't like really really really bad practice?
08:41.16 andrei_ they are taught that way because
08:41.24 andrei_ you really really have to know when to use them
08:41.31 andrei_ but no, linux kernel has plenty goto's
08:41.35 andrei_ almost every driver has goto's
08:41.42 andrei_ actually a driver is written like this
08:41.52 andrei_ do stufff; if stuff fails goto error_section;
08:41.55 andrei_ error_section:
08:42.00 andrei_ output_log;
08:42.15 d_rossberg Stroustrup advice nr. 2 in section 14.11 (at least in my book)
08:44.54 andrei_ d_rossberg: if you got time, review Marc's patch, I ll help him get it right :)
08:46.04 d_rossberg just looking at it ...
08:46.17 andrei_ ah, awesome
08:57.29 Notify 02GCI:rossberg * 5832406154084352 : Task Needs More Work - One of the mentors has sent this task back for more work. Talk to the mentor(s) assigned to this task to satisfy the requirements needed to...
08:57.41 Notify 02GCI:rossberg * 5832406154084352 : Some issues - Coding style: I know that the core interface itself follows a slightly different coding convention than the brlcad main trunk. But the test program...
08:58.15 MarcUNIX wat
09:12.11 *** join/#brlcad ries (~ries@D979C47E.cm-3-2d.dynamic.ziggo.nl)
09:15.32 Notify 02GCI:tannousmarc * 5832406154084352 : Fixed - Coding style: Fixed, if braces are now on the same line, function braces on a new line. Constructor created sphere : Tested for validness. ...
09:15.38 Notify 02GCI:tannousmarc * 5832406154084352 : Ready for review - The work on this task is ready to be reviewed.
09:18.48 Notify 02GCI:popescuandrei * 5832406154084352 : Task Needs More Work - One of the mentors has sent this task back for more work. Talk to the mentor(s) assigned to this task to satisfy the requirements...
09:19.13 Notify 02GCI:popescuandrei * 5832406154084352 : None - You ve got two lines spanning at ~ 230 characters, that's way too much, try keeping them around 100 please
09:26.42 Notify 02GCI:tannousmarc * 5832406154084352 : Ready for review - The work on this task is ready to be reviewed.
09:35.34 Notify 02GCI:popescuandrei * 5832406154084352 : Task Needs More Work - One of the mentors has sent this task back for more work. Talk to the mentor(s) assigned to this task to satisfy the requirements...
09:41.20 Notify 02GCI:tannousmarc * 5832406154084352 : Spacing - Fixed the spacing & indenting issues, sorry for those, was in a hurry. Regards, Marc
09:41.23 MarcUNIX I'm out guys,have a great day
09:41.35 Notify 02GCI:tannousmarc * 5832406154084352 : Ready for review - The work on this task is ready to be reviewed.
09:42.20 Notify 02GCI:popescuandrei * 5832406154084352 : Task Closed - Congratulations, this task has been completed successfully.
09:46.52 *** join/#brlcad chick_ (~capslock@41.205.22.41)
09:49.55 *** join/#brlcad merzo (~merzo@user-94-45-58-138-1.skif.com.ua)
09:58.07 Notify 02GCI:jatish * 5311760286351360 : Task Claimed - I would like to work on this task.
10:01.23 Notify 02GCI:popescuandrei * 5311760286351360 : Task Assigned - This task has been assigned to jatish. You have 100 hours to complete this task, good luck!
10:11.51 Notify 02GCI:rishisharma7361 * 5779545307217920 : Task Claimed - I would like to work on this task.
10:12.36 Notify 02GCI:popescuandrei * 5779545307217920 : Task Assigned - This task has been assigned to Rishi. You have 100 hours to complete this task, good luck!
10:16.16 *** join/#brlcad chick_ (~capslock@41.205.22.41)
10:38.22 Notify 02GCI:rishisharma7361 * 5779545307217920 : Ready for review - The work on this task is ready to be reviewed.
10:39.07 Notify 02GCI:mehak_s * 6359310477033472 : Ready for review - The work on this task is ready to be reviewed.
10:40.24 Notify 02GCI:mehak_s * 6359310477033472 : Thank You - Thank You for extending my deadline. I have completed my task an hope you like it. :)
10:42.04 Notify 02GCI:popescuandrei * 5779545307217920 Design Coreinterface logo #2 https://www.google-melange.com/gci/task/view/google/gci2014/5779545307217920: None Rishi, you re supposed to come up with an...
10:42.05 Notify 02GCI:popescuandrei * 5779545307217920 : Task Needs More Work - One of the mentors has sent this task back for more work. Talk to the mentor(s) assigned to this task to satisfy the requirements...
10:42.33 andrei_ yet another forge, awesome ..
10:58.45 *** join/#brlcad mehak_s (mehak_s@59.89.27.187)
11:00.33 mehak_s Is Mihai Neacsu here??
11:03.30 *** join/#brlcad ries (~ries@D979C47E.cm-3-2d.dynamic.ziggo.nl)
12:11.57 *** join/#brlcad konrado (~root@195.24.216.138)
12:13.33 *** join/#brlcad albertcoder (~albertcod@117.228.191.172)
12:14.20 *** join/#brlcad rohitagarwal (~Rohit@49.249.55.212)
13:17.51 ``Erik hah hah, grinch vulnerabili... oh no, git vuln!
13:20.13 Notify 02GCI:tannousmarc * 5900674122383360 : Task Claimed - I would like to work on this task.
13:20.35 MarcUNIX sup ``Erik
13:28.01 Notify 02GCI:ch3ck * 5900674122383360 : Task Assigned - This task has been assigned to Marc Tannous. You have 100 hours to complete this task, good luck!
13:29.21 Notify 02GCI:shrey123 * 4531831353376768 : yes - sorry to bother u
13:31.14 Ch3ck_ waves
13:31.33 MarcUNIX hey
13:32.10 Ch3ck_ MarcUNIX: so how is the unit testing going this time?
13:32.20 MarcUNIX Just completed one for spheres
13:32.25 MarcUNIX Cones should be a bit harder
13:33.14 MarcUNIX but now I know the source code better than yesterday
13:33.17 MarcUNIX so things will be fine :D
13:34.08 Ch3ck_ MarcUNIX: good to hear
13:43.22 MarcUNIX Ch3ck_: you around?
13:44.22 *** join/#brlcad YashM (~YashM@117.222.21.100)
13:44.25 Ch3ck_ yeah MarcUNIX although partially
13:44.27 MarcUNIX :-s
13:44.46 Ch3ck_ is doingsomework
13:44.51 MarcUNIX rt^3/src/coreinterface/Cone.cpp has 5 ways of defining cones
13:45.13 MarcUNIX do I have to make every test run on every possible definition of a cone?
13:46.14 Ch3ck_ try with one MarcUNIX and see how it we can build from there
13:46.43 Ch3ck_ let one definition work first then increment to include the others
13:47.04 MarcUNIX but in a final form
13:47.21 MarcUNIX how would the "main" go? Declaring all 5 types of cones and running the types of tests on all of them?
13:47.23 Ch3ck_ yeah it will need to be complete
13:47.44 Ch3ck_ well i guess those cones have different structures right?
13:48.00 Ch3ck_ checks source code
13:48.10 MarcUNIX they have different parametres
13:48.40 MarcUNIX can be defined as : Basepoint+height+semiprincipalAxisA+semiprinicipalAxisB or Basepoint+height+radiusbase+radiustop
13:48.45 MarcUNIX oor 3 other forms#
13:52.29 MarcUNIX Ch3ck_, any idea why the height is defined as a Vector3D?
13:52.32 MarcUNIX shouldn't it be a double?
13:55.32 Ch3ck_ MarcUNIX: give me the location where the cone defined
13:56.04 MarcUNIX rt^3/src/coreinterface/Cone.cpp line 61 for example
13:56.14 MarcUNIX the very first definition
13:56.26 Ch3ck_ start from the root directory
13:56.34 MarcUNIX Vector3D is defined as an array with coordinates[0],coordinates[1],coordinates[2] which are X,Y,Z
13:56.35 MarcUNIX erm
13:56.38 Ch3ck_ i don't see rt^3
13:56.51 MarcUNIX rt^3 is not in BRL-CAD
13:56.55 Ch3ck_ could just grep the thx, may be im just lazy
13:57.11 Notify 02GCI:shrey123 * 4531831353376768 : Ready for review - The work on this task is ready to be reviewed.
13:57.34 MarcUNIX Ch3ck_, svn checkout https://svn.code.sf.net/p/brlcad/code/rt^3/trunk rt^3
14:03.17 MarcUNIX What do you think?
14:07.21 Notify 02GCI:helix * 5823454855036928 : Task Claimed - I would like to work on this task.
14:09.48 Ch3ck_ MarcUNIX: looking at it now
14:10.12 Notify 02GCI:ch3ck * 5823454855036928 : Task Assigned - This task has been assigned to Yash. You have 100 hours to complete this task, good luck!
14:18.19 *** join/#brlcad smt (~smt@117.205.177.70)
14:22.41 Ch3ck_ MarcUNIX: looked at the Code so what was your question
14:22.51 MarcUNIX 1. why is height a vector3D
14:23.18 Ch3ck_ i have seen the definitions of the various codes, they all have the same parameters and return the same structure
14:23.35 MarcUNIX isn't height a single value?
14:23.39 MarcUNIX such as, I don't know, 13
14:23.49 MarcUNIX vector3D is a 3 dimensional point in space
14:24.12 Ch3ck_ the yeah, but are allthe 3D args defined?
14:24.22 MarcUNIX what do you mean
14:24.54 Ch3ck_ it may be a vector3D but not all the vectors are used
14:25.22 Ch3ck_ there are many reasons why Vector3D could be used to denote height
14:28.19 Ch3ck_ MarcUNIX: Vector3D may contain values for the other aspects of an object which may be later on useful
14:28.53 Ch3ck_ like length and width, but can't say for sure, i think d_rossberg or brlcad may have further data on this
14:31.49 Ch3ck_ hey MarcUNIX gotta run c ya
14:31.59 MarcUNIX have a good day!
14:55.27 Notify 02GCI:tannousmarc * 5900674122383360 : Feedback - Hello, I set up the tests for Cone's functions from Cone.cpp, now all I have to do is add them to my "main" function, where I run all of them and...
14:55.32 Notify 02GCI:tannousmarc * 5900674122383360 : Ready for review - The work on this task is ready to be reviewed.
14:59.10 *** join/#brlcad aditya (dce32db2@gateway/web/cgi-irc/kiwiirc.com/ip.220.227.45.178)
15:22.36 *** join/#brlcad kintel (~kintel@unaffiliated/kintel)
15:31.36 *** join/#brlcad mehak_s (~sarthak@117.207.61.139)
15:33.36 Notify 02GCI:rohit_agarwal * 6349681697226752 : A Request - Sir, can you please extend the deadline of this task by 1 or 2 days. I got busy with my school assessments and could not complete the video. I...
15:37.55 *** join/#brlcad chick_ (~capslock@41.205.22.41)
15:44.42 Notify 02GCI:sfurti06 * 5828248575410176 : Task Claimed - I would like to work on this task.
15:45.53 Notify 02GCI:mihaineacsu29 * 5828248575410176 : Task Assigned - This task has been assigned to Sfurti Dawle. You have 100 hours to complete this task, good luck!
15:46.48 Notify 02GCI:mihaineacsu29 * 6349681697226752 : Deadline extended - The deadline of the task has been extended with 2 days and 0 hours.
15:51.44 Notify 02GCI:mihaineacsu29 * 6349681697226752 : None - Extended, if you need more let us know :). You can export it in any format which is common for video playback such as .flv, .mpeg4, .mp4, .wmv. You...
15:52.37 *** join/#brlcad MarcWindows (5679c4d5@gateway/web/cgi-irc/kiwiirc.com/ip.86.121.196.213)
16:02.47 *** join/#brlcad FreezingCold (~FreezingC@135.0.41.14)
16:07.58 Notify 03BRL-CAD:ejno * 63788 (brlcad/trunk/src/libged/simulate/physics_world.cpp brlcad/trunk/src/libged/simulate/simulate.cpp): improve attribute-based configuration system
16:09.16 Notify 03BRL-CAD:ejno * 63789 brlcad/trunk/src/libgcv/bot_solidity.c: fix parentheses
16:12.26 *** join/#brlcad mehak_s (mehak_s@59.89.24.244)
16:17.09 *** join/#brlcad mehak_s (mehak_s@117.200.61.28)
16:20.01 Notify 02GCI:adityagulati * 5839755866537984 : Ready for review - The work on this task is ready to be reviewed.
16:20.34 *** join/#brlcad adityagulati (dce32db2@gateway/web/cgi-irc/kiwiirc.com/ip.220.227.45.178)
16:22.04 adityagulati https://www.google-melange.com/gci/task/view/google/gci2014/5839755866537984 could someone review my work and tell me what changes do I need to make next?
16:22.05 gcibot Create a production-quality version of our logo #5
16:22.05 gcibot Status: NeedsReview (26 hrs 7 min)
16:22.05 gcibot Mentor(s): Daniel_R, Gauravjeet Singh
16:28.57 mehak_s https://www.google-melange.com/gci/task/view/google/gci2014/6359310477033472
16:28.58 gcibot Design a banner for our Facebook page (and/or other social media sites) #3
16:28.58 gcibot Status: NeedsReview (7 hrs 48 min)
16:28.58 gcibot Mentor(s): Isaac Kamga, Sean
16:29.14 mehak_s need work to be checked :)
16:33.48 Notify 02GCI:adityagulati * 5839755866537984 : New Files - Sir, I have uploaded the new files. I cannot change the height if I base it on the file provided, as I have done right now. I reduced the size...
16:42.22 andromeda-galaxy I'm having a little bit of trouble figuring out which standard __VA_ARGS__ for macros was introduced in; is it okay to use it in my new src/proc-db/naca code?
16:48.35 *** join/#brlcad archivist (~archivist@host81-149-189-98.in-addr.btopenworld.com)
16:54.20 MarcWindows things I do while waiting for tasks to be reviewed http://codepen.io/marctannous/pen/ogLMxy :(
16:55.31 *** join/#brlcad darshpreets (~darshpree@202.164.53.117)
16:58.28 mihaineacsu <PROTECTED>
16:58.45 MarcWindows I don't even know
16:58.56 MarcWindows Literally tried every single command out there trying to make some cool loaders
16:58.57 MarcWindows I think
16:59.26 MarcWindows last summer
16:59.31 mehak_s mihai?
16:59.42 mihaineacsu Yes, hi there mehak_s
16:59.44 mehak_s could you check my task?
16:59.59 mehak_s https://www.google-melange.com/gci/task/view/google/gci2014/6359310477033472
17:00.00 mihaineacsu looking at it as we speak
17:00.01 gcibot Design a banner for our Facebook page (and/or other social media sites) #3
17:00.01 gcibot Status: NeedsReview (7 hrs 16 min)
17:00.01 gcibot Mentor(s): Isaac Kamga, Sean
17:00.14 mehak_s ok
17:02.41 mihaineacsu mehak_s, you use photoshop, right?
17:03.06 mehak_s yes
17:03.15 mehak_s my friend taught me
17:15.19 *** join/#brlcad darshpreets (~darshpree@202.164.53.117)
17:16.25 Notify 02GCI:mihaineacsu29 * 6359310477033472 Design a banner for our Facebook page (and/or other social media sites) #3 https://www.google-melange.com/gci/task/view/google/gci2014/6359310477033472: None...
17:18.15 Notify 02GCI:mihaineacsu29 * 6359310477033472 : Task Needs More Work - One of the mentors has sent this task back for more work. Talk to the mentor(s) assigned to this task to satisfy the requirements...
17:18.50 Notify 02GCI:mihaineacsu29 * 6359310477033472 : Deadline extended - The deadline of the task has been extended with 1 days and 12 hours.
17:22.50 *** join/#brlcad winghouchan (~winghouch@2.218.248.68)
17:23.40 Notify 02GCI:mehak_s * 6359310477033472 : None - Okay I will look after it tomorrow cause I am going to sleep now.. Thanks. :)
17:24.53 Notify 02GCI:mihaineacsu29 * 5839755866537984 : Task Closed - Congratulations, this task has been completed successfully.
17:26.04 Notify 03BRL-CAD:starseeker * 63790 (brlcad/trunk/db/nist/NIST_MBE_PMI_1.stp brlcad/trunk/db/nist/NIST_MBE_PMI_2.stp and 3 others): Put the strings all on one line for these two labels.
17:26.06 Notify 02GCI:mihaineacsu29 * 5839755866537984 : None - Excellent progress, Aditya! I really like how it turned out!
17:32.58 Notify 03BRL-CAD:starseeker * 63791 (brlcad/trunk/db/nist/CMakeLists.txt brlcad/trunk/src/conv/step/step-g/step-g.cpp): Need to overwrite old outputs when step imports change (and it's a frequent need during development too) so add a -O output specifier to step-g that overwrites the old file.
17:34.33 MarcWindows mihaineacsu, can you check out my task?
17:34.43 MarcWindows regarding the cone unit test
17:37.07 mihaineacsu MarcWindows: did Andrei help you on this one?
17:37.15 MarcWindows nope
17:37.32 MarcWindows but he gave me a lot of information regarding the first one so this one was pretty similar
17:37.44 MarcWindows however there are a couple of issues, and wanted to know how I should go about approaching them
17:37.54 mihaineacsu because it looks more like his domain
17:38.01 MarcWindows oh
17:38.09 MarcWindows np then, I'll ask him in the morning
17:38.17 MarcWindows or rossberg or Sean
17:38.19 MarcWindows whoever comes first
17:38.21 MarcWindows :D
17:48.05 *** join/#brlcad smt (~smt@117.200.239.55)
17:49.34 *** join/#brlcad ankesh11 (uid8015@gateway/web/irccloud.com/x-wzyuxhahtcmfgtsf)
18:10.07 *** join/#brlcad chick_ (~capslock@41.205.22.41)
18:35.51 *** join/#brlcad infobot (ibot@rikers.org)
18:35.51 *** topic/#brlcad is Topic for #brlcad: BRL-CAD || http://brlcad.org || logs: http://ibot.rikers.org/%23brlcad/ || Welcome GCI 2014 participants! If you're participating, be patient when asking questions... we're very busy and sometimes have packed schedules. We will respond if you are still on IRC: learn screen+irssi.
18:39.32 MarcWindows so quiet
18:44.25 Notify 02GCI:judebirch * 5857438834098176 : Task Claimed - I would like to work on this task.
19:06.42 *** join/#brlcad javampir1 (~javampire@v10024.1blu.de)
19:28.14 Notify 03BRL-CAD:carlmoore * 63792 (brlcad/trunk/db/nist/NIST_MBE_PMI_1.stp brlcad/trunk/db/nist/NIST_MBE_PMI_2.stp and 3 others): remove trailing blanks/tabs
19:45.36 Notify 02GCI:gylianne16 * 5271024618700800 : Task Claimed - I would like to work on this task.
19:52.13 Notify 02GCI:gylianne16 * 5271024618700800 : Claim Removed - The claim on this task has been removed, someone else can claim it now.
20:00.11 Notify 02GCI:gylianne16 * 5271024618700800 : Task Claimed - I would like to work on this task.
20:04.09 *** join/#brlcad winghouchan_ (~winghouch@2.218.248.68)
20:13.12 Notify 02GCI:mihaineacsu29 * 5271024618700800 : Task Assigned - This task has been assigned to Gigi. You have 100 hours to complete this task, good luck!
20:13.28 Notify 02GCI:mihaineacsu29 * 5857438834098176 : Task Assigned - This task has been assigned to Jude. You have 100 hours to complete this task, good luck!
20:17.43 Notify 02GCI:judebirch * 5857438834098176 : Ready for review - The work on this task is ready to be reviewed.
20:24.38 *** join/#brlcad chick_ (~capslock@41.205.22.41)
20:40.26 MarcWindows good night guys
20:40.32 MarcWindows good luck with your tasks!
21:07.09 *** join/#brlcad kintel (~kintel@unaffiliated/kintel)
21:13.10 Notify 03BRL-CAD:ejno * 63793 (brlcad/trunk/src/libged/simulate/physics_world.cpp brlcad/trunk/src/libged/simulate/physics_world.hpp brlcad/trunk/src/libged/simulate/simulate.cpp): scale everything; trying to find source of incorrect behavior (in progress)
21:18.49 Notify 03BRL-CAD:carlmoore * 63794 brlcad/trunk/src/util/pixborder.c: shorten the 'case' statement
22:06.05 *** join/#brlcad kintel (~kintel@unaffiliated/kintel)
22:11.08 Notify 03BRL-CAD:n_reed * 63795 brlcad/trunk/src/libbu/y2038/time64.c: suppress compiler warning about potentially using a struct uninitialized
22:38.20 *** join/#brlcad KimK (~Kim__@ip68-102-30-143.ks.ok.cox.net)
22:48.28 *** join/#brlcad kintel (~kintel@unaffiliated/kintel)
22:50.48 *** join/#brlcad kintel (~kintel@unaffiliated/kintel)
23:12.11 Notify 03BRL-CAD:carlmoore * 63796 brlcad/trunk/doc/docbook/system/man1/en/pixborder.xml: supply the writeup of missing options in this manpage

Generated by irclog2html.pl Modified by Tim Riker to work with infobot.