00:18.39 |
maths22 |
Kris_: install xquartz; that may fix
it |
00:18.53 |
Kris_ |
if you donât mind, whats xquartz? |
00:19.04 |
maths22 |
http://xquartz.macosforge.org/ |
00:24.31 |
andromeda-galaxy |
maths22, mpictor: any idea how to compile
coreInterface? when I point it at the install dir for my brlcad
trunk checkout,it configures successfully but running make gives
could not find -lcoreinterface from ld |
00:26.42 |
andromeda-galaxy |
the README/INSTALL/HACKING files all seem
outdated & refer to autotools |
01:31.02 |
*** join/#brlcad gcibot
(ignacio@unaffiliated/ignaciouy/bot/gcibot) |
01:31.46 |
ignacio |
gcibot, merry xmas |
01:31.47 |
gcibot |
ignacio, merry christmas! |
02:32.01 |
*** join/#brlcad indianlarry
(~indianlar@66-118-151-70.static.sagonet.net) |
02:34.24 |
*** join/#brlcad archivist_
(~archivist@host81-149-189-98.in-addr.btopenworld.com) |
02:45.29 |
*** join/#brlcad KimK_
(~Kim__@ip68-102-30-143.ks.ok.cox.net) |
02:54.04 |
*** join/#brlcad Notify
(~notify@66-118-151-70.static.sagonet.net) |
03:54.40 |
*** join/#brlcad
andromeda_galaxy
(~andromeda@108-225-17-54.lightspeed.sntcca.sbcglobal.net) |
04:32.18 |
*** join/#brlcad gcibot
(ignacio@unaffiliated/ignaciouy/bot/gcibot) |
04:49.43 |
andromeda-galaxy |
Shouldn't line 152 of rt^3's FindBRLCAD.cmake
be "FIND_PROGRAM(BRLCAD_CONFIGEXE brlcad-config ${BRLCAD_BIN_DIR})"
instead of "FIND_PROGRAM(BRLCAD_CONFIGEXE brlcad-config)"? On my
system, an svn checkout of rt^3 has the latter, which causes the
configuration to fail if only BRLCAD_BASE_DIR has been
set |
05:01.00 |
andromeda-galaxy |
d_rossberg: also, I'm a little confused about
the rt^3 test system --- it looks like the primitive tests indicate
success by only adding the object to the db if successful, but the
main primitive tester never checks the result (I tried modifying
isValid() on halfspaces to make it always return false, and the
fact that the test shouldn't have worked was logged, but the test
still passed) |
05:01.22 |
andromeda-galaxy |
~seen d_rossberg |
05:01.22 |
infobot |
d_rossberg
<~rossberg@66-118-151-70.static.sagonet.net> was last seen on
IRC in channel #brlcad, 2d 11h 44m 7s ago, saying: 'that's the base
for writing code for it'. |
05:05.18 |
*** join/#brlcad YashM
(~YashM@117.222.20.249) |
05:29.02 |
*** join/#brlcad teepee
(~teepee@gateway/tor-sasl/teepee) |
05:44.12 |
Notify |
03BRL-CAD Wiki:Stattrav * 7843
/wiki/User:Stattrav: Blanked the page |
06:09.10 |
Notify |
03BRL-CAD Wiki:Stattrav * 7844
/wiki/Stattrav_proposal_2012: Blanked the page |
06:09.39 |
Notify |
03BRL-CAD Wiki:Stattrav * 0
/wiki/Stattrav_proposal_2012: |
06:09.47 |
Notify |
03BRL-CAD Wiki:Stattrav * 0
/wiki/User:Stattrav: |
06:10.40 |
Notify |
03BRL-CAD Wiki:Stattrav * 0
/wiki/User:SJ: |
07:13.59 |
*** join/#brlcad YashM_
(~YashM@117.222.69.145) |
08:04.11 |
*** join/#brlcad merzo
(~merzo@139-27-132-95.pool.ukrtel.net) |
08:08.44 |
*** join/#brlcad rohitagarwal
(~Rohit@49.249.53.14) |
08:11.22 |
*** join/#brlcad alisha
(~alisha@115.245.153.2) |
09:06.27 |
*** join/#brlcad alisha
(~alisha@115.241.247.194) |
10:06.08 |
*** join/#brlcad alisha
(~alisha@115.245.177.140) |
10:35.07 |
*** join/#brlcad archivist
(~archivist@host81-149-189-98.in-addr.btopenworld.com) |
10:49.17 |
*** join/#brlcad adityagulati
(6ac09536@gateway/web/cgi-irc/kiwiirc.com/ip.106.192.149.54) |
10:49.24 |
*** join/#brlcad ries
(~ries@D979C47E.cm-3-2d.dynamic.ziggo.nl) |
10:49.42 |
adityagulati |
Could someone review my task
http://www.google-melange.com/gci/task/view/google/gci2014/5873244582182912 |
10:49.42 |
gcibot |
Design Coreinterface logo #5 |
10:49.42 |
gcibot |
Status: NeedsReview (2 days 8 hrs 19
min) |
10:49.42 |
gcibot |
Mentor(s): Isaac Kamga, Ishwerdas |
11:13.17 |
*** join/#brlcad ries
(~ries@D979C47E.cm-3-2d.dynamic.ziggo.nl) |
11:17.30 |
*** join/#brlcad merzo
(~merzo@161-9-132-95.pool.ukrtel.net) |
11:21.55 |
*** join/#brlcad winghouchan
(~winghouch@2.120.148.188) |
11:36.23 |
*** join/#brlcad mihaineacsu
(~mihaineac@92.81.152.5) |
12:14.33 |
*** join/#brlcad gcibot
(ignacio@unaffiliated/ignaciouy/bot/gcibot) |
13:08.29 |
*** join/#brlcad ries
(~ries@D979C47E.cm-3-2d.dynamic.ziggo.nl) |
13:27.37 |
*** join/#brlcad adityagulati
(dce32db2@gateway/web/cgi-irc/kiwiirc.com/ip.220.227.45.178) |
13:28.23 |
adityagulati |
could someone review my task please?
https://www.google-melange.com/gci/task/view/google/gci2014/5873244582182912 |
13:28.24 |
gcibot |
Design Coreinterface logo #5 |
13:28.24 |
gcibot |
Status: NeedsReview (2 days 5 hrs 41
min) |
13:28.24 |
gcibot |
Mentor(s): Isaac Kamga, Ishwerdas |
13:31.15 |
adityagulati |
is any mentor online |
14:08.27 |
Notify |
02GCI:hrishi1304 * 4928791491117056 : Claim
Removed - The claim on this task has been removed, someone else can
claim it now. |
14:25.32 |
maths22 |
andromeda-galaxy: are those tests ready to
commit? |
14:38.51 |
*** join/#brlcad shardulc
(b6461acc@gateway/web/freenode/ip.182.70.26.204) |
14:39.23 |
MarcTannous |
maths22: what tests are you reffering
to? |
14:39.41 |
maths22 |
A fix andromeda-galaxy had for the quat
tests |
14:40.57 |
shardulc |
hello everybody, I'm a GCI student |
14:41.05 |
andromeda_galaxy |
maths22:yes they are, I was busier than
expected yesterday |
14:41.12 |
shardulc |
could someone review my task please? it's
https://www.google-melange.com/gci/task/view/google/gci2014/6620713125412864 |
14:41.13 |
gcibot |
Write manual page documentation (for
archer) |
14:41.13 |
gcibot |
Status: NeedsReview (22 hrs 20 min) |
14:41.13 |
gcibot |
Mentor(s): Popescu Andrei, Jacob B |
14:41.18 |
maths22 |
andromeda_galaxy: it's fine, I'm just
checking |
14:41.35 |
andromeda_galaxy |
I should be able to sometime soon |
14:42.00 |
andromeda_galaxy |
(In the next ~1h) |
14:42.23 |
maths22 |
OK |
14:52.09 |
*** join/#brlcad chick_
(~capslock@41.205.22.41) |
15:03.13 |
andromeda-galaxy |
maths22: by the way, is CDash hooked into
Notify yet? I'm interested in seeing the build results after my
change... |
15:03.31 |
maths22 |
andromeda-galaxy: not yet. I have to write
some sort of IRC plugin for it |
15:03.47 |
maths22 |
once you commit, I will trigger a build, and
once it builds, I will post the results |
15:03.52 |
andromeda-galaxy |
maths22: great! |
15:04.10 |
andromeda-galaxy |
did you mention something the other day about
a url you had set up that allows anyone to trigger a
build? |
15:06.47 |
Notify |
03BRL-CAD:peter-sa * 63845
brlcad/trunk/src/libbu/scan.c: Apply GCI task
http://www.google-melange.com/gci/task/view/google/gci2014/4967862338846720
that fixes bu_scan_fastf_t by updating the value that it checks
return value of scanf() against when scanning the
delimiter. |
15:06.48 |
gcibot |
Fix any failing unit test #8 |
15:06.48 |
gcibot |
Status: Closed |
15:06.48 |
gcibot |
Mentor(s): Deepak, Hardeep Singh Rai |
15:06.51 |
andromeda-galaxy |
maths22: done! |
15:07.25 |
maths22 |
andromeda-galaxy: build queued |
15:07.37 |
andromeda-galaxy |
maths22: thanks! |
15:08.12 |
andromeda-galaxy |
does this still work for other people to
trigger builds:http://brlcad.org/svn/triggerBuild.php? |
15:09.03 |
MarcTannous |
andromeda-galaxy: "command returned
0" |
15:09.16 |
andromeda-galaxy |
MarcTannous: hmm? |
15:09.26 |
MarcTannous |
the link you sent |
15:10.51 |
*** join/#brlcad ChanServ
(ChanServ@services.) |
15:10.51 |
*** mode/#brlcad [+o ChanServ]
by sendak.freenode.net |
15:10.54 |
andromeda-galaxy |
sorry, which one? |
15:11.04 |
MarcTannous |
http://brlcad.org/svn/triggerBuild.php? |
15:11.20 |
andromeda-galaxy |
ah, okay --- I thought you were talking about
rt^3, sorry |
15:12.15 |
andromeda-galaxy |
ahh.. .I don't know whether that's expected
behavior or not... maths22, are you still here? |
15:12.32 |
maths22 |
andromeda-galaxy: that is what it should
say |
15:12.57 |
*** join/#brlcad ries
(~ries@D979C47E.cm-3-2d.dynamic.ziggo.nl) |
15:12.59 |
andromeda-galaxy |
ah, okay ---- just curious, does it trigger a
build on the freebsd or linux builders? |
15:12.59 |
maths22 |
I have a lock so multiple people triggering it
won't start lots of simulaneous builds |
15:13.05 |
maths22 |
andromeda-galaxy: freebsd |
15:13.16 |
maths22 |
It is on bz itself only for now. |
15:13.25 |
andromeda-galaxy |
ahh... |
15:17.34 |
andromeda-galaxy |
any idea how to quiet the naca456 function
defined but not used? I added thoseb ecause they were there in the
Fortran with the comment that they'd likely be useful
soon. |
15:24.50 |
andromeda-galaxy |
maths22: so did we decide on trying to run
both buildbot and CDash? |
15:25.04 |
MarcTannous |
Guys, if you have 30 seconds, can you please
tell me if http://codepen.io/marctannous/full/RNGjmz/
loads under 5 seconds in your browser? |
15:27.47 |
*** join/#brlcad YashM
(~YashM@59.88.24.219) |
15:28.39 |
maths22 |
andromeda-galaxy: I think that is the
plan |
15:28.49 |
maths22 |
For right now, I am just working with
CDash |
15:29.10 |
maths22 |
by the way, if you ever want to submit to
CDash, just go into your build directory and run the following
command |
15:29.39 |
maths22 |
ctest -D Experimental -LE
NOT_WORKING |
15:30.23 |
maths22 |
andromeda-galaxy: all tests passed! http://brlcad.org/CDash/buildSummary.php?buildid=25 |
15:30.33 |
andromeda-galaxy |
sound's good! CDash at least gets us a good
set of tests pass/failing... |
15:30.51 |
andromeda-galaxy |
great! what happened to the two build
errors? |
15:31.29 |
maths22 |
what errors? |
15:32.11 |
andromeda-galaxy |
well, it looks tome like the previous build
has two errors: |
15:32.26 |
andromeda-galaxy |
http://brlcad.org/CDash/viewBuildError.php?buildid=24 |
15:33.18 |
maths22 |
that is a environment variable issue; it will
be fixed by tonight |
15:33.29 |
andromeda-galaxy |
ahhh... is it already fixed? I don't see those
errors on 25 |
15:34.26 |
andromeda-galaxy |
I'm glad the tests are all passing now,
though |
15:35.53 |
andromeda-galaxy |
so does the ctest submit command require that
you've just done a clean build? |
15:35.58 |
shardulc |
could someone review my task please? it's
https://www.google-melange.com/gci/task/view/google/gci2014/6620713125412864 |
15:35.58 |
gcibot |
Write manual page documentation (for
archer) |
15:35.59 |
gcibot |
Status: NeedsReview (21 hrs 26 min) |
15:35.59 |
gcibot |
Mentor(s): Popescu Andrei, Jacob B |
15:43.23 |
maths22 |
that command more or less runs the
following: |
15:43.46 |
maths22 |
cmake, then make, then make test, then a
submission script |
15:44.09 |
maths22 |
It does not require a clean build, although
you can run make clean first if you want to capture all the
warnings |
15:44.24 |
andromeda-galaxy |
ahhh... okay, thanks for the information! that
makes sense... |
15:47.22 |
MarcTannous |
Nobody? :( |
15:49.35 |
maths22 |
MarcTannous: yes for me |
15:50.27 |
andromeda-galaxy |
MarcTannous: not sure, but I think that it
took almost exactly 5 or a little bit more |
15:50.58 |
MarcTannous |
just one more thing, does it create a new one
on page refresh? |
15:51.01 |
MarcTannous |
It should |
15:52.15 |
andromeda-galaxy |
I think so |
15:53.18 |
*** join/#brlcad sofat
(~sofat@202.164.45.204) |
15:54.01 |
*** join/#brlcad sofat
(~sofat@202.164.45.204) |
15:56.55 |
andromeda-galaxy |
o |
15:57.34 |
andromeda-galaxy |
MarcTannous: I know you've been doing some
stuff with the rt^3 tests, do you have any idea about the concerns
with the test system that I put up last night? |
15:58.35 |
MarcTannous |
Nope, what did you put up? |
15:58.54 |
andromeda-galaxy |
Shouldn't line 152 of rt^3's FindBRLCAD.cmake
be "FIND_PROGRAM(BRLCAD_CONFIGEXE brlcad-config ${BRLCAD_BIN_DIR})"
instead of "FIND_PROGRAM(BRLCAD_CONFIGEXE brlcad-config)"? On my
system, an svn checkout of rt^3 has the latter, which causes the
configuration to fail if only BRLCAD_BASE_DIR has been
set |
15:59.01 |
andromeda-galaxy |
and d_rossberg: also, I'm a little confused
about the rt^3 test system --- it looks like the primitive tests
indicate success by only adding the object to the db if successful,
but the |
15:59.06 |
andromeda-galaxy |
<PROTECTED> |
15:59.10 |
andromeda-galaxy |
<PROTECTED> |
16:01.32 |
andromeda-galaxy |
MarcTannous: the second issue was my main
concern (sorry for the formatting) |
16:01.59 |
MarcTannous |
did not look into |
16:02.02 |
*** join/#brlcad sofat
(~sofat@202.164.45.204) |
16:02.06 |
andromeda-galaxy |
ah |
16:02.08 |
MarcTannous |
saw that all the tests are adding the object
to the database, did the same with mine |
16:02.31 |
MarcTannous |
but my tests always check isvalid |
16:02.33 |
MarcTannous |
before adding it |
16:02.36 |
andromeda-galaxy |
I'm also not entirely convinced that having
only *one* cmake-level test target for *all* the primitives is the
best idea... |
16:02.48 |
andromeda-galaxy |
indeed, the problem is that primitives.cpp
doesn't check if it was added or not! |
16:06.13 |
andromeda-galaxy |
maths22:by the way, the reason that I was
asking about buildbot earlier is that it seems like the buildbot
waterfall might be nicer for looking at a history of builds over a
number of builders than the interface for CDAsh |
16:08.38 |
*** join/#brlcad FreezingCold
(~FreezingC@135.0.41.14) |
16:09.05 |
*** join/#brlcad sofat
(~sofat@202.164.45.204) |
16:24.43 |
maths22 |
andromeda-galaxy: I agree |
16:25.11 |
maths22 |
I'm actually hoping to extend CDash to create
a waterfall view |
16:25.14 |
maths22 |
It should be fun |
16:25.18 |
andromeda-galaxy |
that sounds interesting |
16:25.49 |
andromeda-galaxy |
does CDash have a plugin
architecture? |
16:26.46 |
maths22 |
No |
16:27.10 |
maths22 |
but there is no reason I can't create and
modify their php scripts |
16:27.45 |
andromeda-galaxy |
ahh |
16:27.53 |
maths22 |
https://github.com/Kitware/CDash |
16:28.12 |
andromeda-galaxy |
right |
16:28.25 |
andromeda-galaxy |
I was just curious whether or not they had a
way to add it on... apparently ot |
16:28.27 |
andromeda-galaxy |
*not |
16:29.27 |
andromeda-galaxy |
by the way, if I remember correctly, last time
we were doing CI stuff it was mutch more focused on buildbot...
what's the advantage of cdash? |
16:29.51 |
maths22 |
anyone can contribute |
16:29.58 |
maths22 |
buildslaves are easier to set up |
16:30.05 |
andromeda-galaxy |
true |
16:30.07 |
maths22 |
It integrates nicely with ctest |
16:30.54 |
andromeda-galaxy |
makes sense... maybe next time I do a commit
I'll run a clean + ctest -Dexperimental -LE NOT_WORKING and submit
my results |
16:31.13 |
maths22 |
not -Dexperimental |
16:31.16 |
maths22 |
-D Experimental |
16:31.26 |
maths22 |
the space matters |
16:35.32 |
andromeda-galaxy |
ah, yes, of course |
16:35.33 |
andromeda-galaxy |
sorry |
16:36.40 |
maths22 |
it's fine |
16:36.53 |
maths22 |
Once I have everything worked out, I'll write
up some documentation |
16:37.38 |
andromeda-galaxy |
sounds good |
16:43.43 |
*** join/#brlcad ries
(~ries@D979C47E.cm-3-2d.dynamic.ziggo.nl) |
17:02.15 |
MarcTannous |
oh damn |
17:02.16 |
MarcTannous |
I got the #1 codepen pick for the
day |
17:02.16 |
MarcTannous |
http://codepen.io/ |
17:02.16 |
MarcTannous |
This is amazing |
17:03.59 |
YashM |
MarcTannous, is it just me or the pen doesn't
load for anyone? |
17:06.05 |
andromeda-galaxy |
YashM: it loads foro me |
17:06.39 |
YashM |
I don't know but I allowed to load 2 times for
5 minutes |
17:07.03 |
YashM |
I'll try another browser |
17:11.19 |
YashM |
Nope, empty |
17:46.20 |
*** join/#brlcad kintel
(~kintel@unaffiliated/kintel) |
17:58.51 |
*** join/#brlcad ries
(~ries@D979C47E.cm-3-2d.dynamic.ziggo.nl) |
18:55.29 |
``Erik |
neat, nasa posted the model for the 3d printed
wrench |
19:19.28 |
andromeda-galaxy |
``Erik: interesting... do you know anything
about rt^3? |
19:19.43 |
starseeker |
wishes NASA would poste step
and/or iges files... |
19:21.59 |
andromeda-galaxy |
only STL... it's probably because most of the
printer controllers only know how to slice stl |
19:32.27 |
``Erik |
andromeda-galaxy: a little, not much... it was
an experiment that I don't think ever got to "production"
quality? |
19:32.49 |
andromeda-galaxy |
ahhh |
19:33.16 |
andromeda-galaxy |
I'm working on some of the unit test GCI
tasks, but am slightly confused by the test build
system... |
19:33.39 |
andromeda-galaxy |
all the primitives are bundled together in one
test, and the main code never seems to check the test results from
each primitive test |
19:33.54 |
``Erik |
gci task for rt^3? O.O |
19:37.14 |
andromeda-galaxy |
http://www.google-melange.com/gci/task/view/google/gci2014/5795100017819648 |
19:37.15 |
gcibot |
Write CoreInterface unit test #2 |
19:37.15 |
gcibot |
Status: Claimed (3 days 5 hrs 25
min) |
19:37.15 |
gcibot |
Mentor(s): Popescu Andrei, Mihai
Neacsu |
19:37.27 |
andromeda-galaxy |
``Erik: at least, the url given is for
rt^3 |
19:39.49 |
``Erik |
ah, I thought the geomcore stuff was supposed
to have been split off into another repo |
19:40.47 |
andromeda-galaxy |
hmmm |
19:40.50 |
``Erik |
src/coreInterface/ should be the only
directory you'd need to worry about |
19:41.09 |
andromeda-galaxy |
indeed... for this one, I'm writing tests for
coreInterface |
19:41.37 |
andromeda-galaxy |
(test/coreInterface) but I'm a little bit
confused by the test system, which doesn't really seem to work, so
I was wondering if anyone knew if I was missing something |
19:41.37 |
``Erik |
ah, tests/coreInterface as well |
19:42.24 |
``Erik |
looks like it doesn't use ctest, just makes a
ciTest executable |
19:42.36 |
``Erik |
primitives.cpp is the entry point, and the
only test is for halfspace |
19:43.06 |
``Erik |
and it doesn't return pass/fail, it just
prints the results... eck |
19:43.16 |
*** join/#brlcad MarcTannous
(5679c4d5@gateway/web/freenode/ip.86.121.196.213) |
19:43.18 |
andromeda-galaxy |
right... |
19:43.23 |
andromeda-galaxy |
it is kindof hooked into cTest
though |
19:43.26 |
andromeda-galaxy |
there is an add_Test() call |
19:43.47 |
MarcTannous |
andromeda-galaxy: Did you figure out a way to
solve the addition to database in rt^3 tests? |
19:43.47 |
andromeda-galaxy |
but that seems somewhat useless since it
doesn't seem to be checking the results for the return
status |
19:44.09 |
andromeda-galaxy |
MarcTannous: right now, just trying to make
sure that I'm not missing somewhete that it does something to check
results, but I don't think I am |
19:44.14 |
``Erik |
yeah, the executable does not comply to ctests
requirements... |
19:44.18 |
andromeda-galaxy |
I was talking to ``Erik just now in case he
knew something I didn't |
19:44.23 |
``Erik |
that'll need to be fixed :) |
19:44.54 |
andromeda-galaxy |
indeed :-) if this task doesn't take too long,
I'll make a second patch for it that both adds the Ellipsoid test
and reorganizes the test system to fit with ctest better |
19:44.55 |
MarcTannous |
``Erik: You got 2 minutes to check out a
simple UI design task so that I can jump aboard the rt^3 unit test
tasks again ?:) |
19:44.59 |
andromeda-galaxy |
more like the libbn/libbu tests,
maybe |
19:45.30 |
andromeda-galaxy |
MarcTannous: if I do manage to reorganize the
tests, you might want to wait until that's committed |
19:46.02 |
``Erik |
MarcTannous: I'm design/ui/ux retarded, I'm
recusing myself of any design related stuff, sorry |
19:46.02 |
MarcTannous |
andromeda-galaxy: As far as I am concerned, if
I understood what you wanted to do correctly, my tests would only
have to be modified slightly |
19:46.18 |
andromeda-galaxy |
not sure... |
19:46.29 |
MarcTannous |
As they are a hybrid between the
libbn/libbu/librt tests and the ones here in rt^3 |
19:46.45 |
andromeda-galaxy |
mostly just modifications to the main entry
point I guess... but the test functions would have to scan their
input |
19:46.48 |
andromeda-galaxy |
from a string |
19:46.57 |
``Erik |
goes back to happy fun
cl-mongo stuff o.O |
19:47.08 |
MarcTannous |
well the ones in libbn/libbu/librt were taking
an argc and argv in main as the "test" and then running it through
the test which consisted of testing all the functions of a
file |
19:47.14 |
andromeda-galaxy |
``Erik: that sounds interesting |
19:47.21 |
andromeda-galaxy |
MarcTannous: right... |
19:47.27 |
MarcTannous |
My test functions already take parametres,
except they are defined locally |
19:47.39 |
andromeda-galaxy |
then argc/argv were passed to each individual
test function, and the test function itself parsed its arguments
from argc/argv |
19:47.51 |
MarcTannous |
so all I'd have to do is call my so-called
main with an argc and argv and set my tests on the given
values |
19:48.21 |
MarcTannous |
at the moment my objects were defined like
BRLCAD::Sphere sph; sph.Set(parametres) |
19:48.46 |
MarcTannous |
So instead of giving my sph.Set stuff like
Vector 3D(1.0,1.0,1.0) I'd give it argv[0] |
19:48.55 |
andromeda-galaxy |
right, but then |
19:49.06 |
andromeda-galaxy |
the inside of each function has to be modified
to do something like |
19:49.39 |
andromeda-galaxy |
bu_scan_fastf_t to get the string into
doubles |
19:49.43 |
andromeda-galaxy |
*fastf_ts |
19:49.52 |
andromeda-galaxy |
is bu_scan_fastf_t accessible? |
19:50.00 |
MarcTannous |
no idea, but you're right |
19:50.13 |
*** join/#brlcad merzo
(~merzo@161-9-132-95.pool.ukrtel.net) |
19:50.19 |
MarcTannous |
however that'll just be done in main though
instead of doing it in every function |
19:50.33 |
MarcTannous |
as I have lots of them, cone.cpp had like 5
constructors and each of them had to be tested |
19:50.37 |
andromeda-galaxy |
no, because each function takes a different
number & type of arguments |
19:50.52 |
andromeda-galaxy |
at least, that is how it always ended up being
done in lib* tests |
19:51.13 |
MarcTannous |
in the tasks in gci we are asked to do tests
for basic primitives such as cone or spheres |
19:51.30 |
MarcTannous |
and most functions take as arguments the
object and its parametres |
19:51.43 |
andromeda-galaxy |
right, but the parameters are different for
each function |
19:51.43 |
MarcTannous |
such as radius, height, semiprincipalaxisA and
so on and so forth |
19:51.47 |
MarcTannous |
<PROTECTED> |
19:51.59 |
andromeda-galaxy |
ellipsoid example(that's what I'm doing
now) |
19:52.13 |
andromeda-galaxy |
Set() takes a point and 3 vectors |
19:52.15 |
MarcTannous |
I divided my functions in two types: those
that only take the object as a parameter and those that also take
its dimensions as parametres |
19:52.27 |
andromeda-galaxy |
SetSphere() takes a point and a
double |
19:52.33 |
MarcTannous |
yeah, and stuff like ClassName or Type take
only the object |
19:53.00 |
andromeda-galaxy |
so main() can't know whether to scan 4 sets of
3 points or 1 set of 3 points and 1 singl enumber |
19:53.06 |
andromeda-galaxy |
*of 3 numbers |
19:53.20 |
MarcTannous |
well you're parsing the input (argv array)
into variables in your main upon reading them and then send these
into the functions |
19:53.48 |
andromeda-galaxy |
say "test_ellipsoid 0 a,b,c d,e,f g,h,i
j,k,l" |
19:53.55 |
MarcTannous |
let me set up a quick paste bin because that
should make my point clear |
19:53.55 |
andromeda-galaxy |
or "test_ellipsoid 1 a,b,c r" |
19:54.14 |
andromeda-galaxy |
in main, before switch/case on function_num,
you don't know which format to scan the numbers in |
19:54.44 |
andromeda-galaxy |
wait... do ellipsoids have no getCenter
method? |
20:01.46 |
MarcTannous |
here you go |
20:01.46 |
MarcTannous |
http://pastebin.com/a1CF6WKV |
20:02.06 |
MarcTannous |
andromeda-galaxy: this is what I
meant |
20:03.07 |
andromeda-galaxy |
but in some cases, "center" and "height"might
not be what you want: you might want either "pt, veca, vecb, vecc"
or "pt, radius" (but not one string cotnaining both) |
20:03.10 |
andromeda-galaxy |
for ellipsoid |
20:03.36 |
MarcTannous |
have not worked on ellipsoid yet, this is a
sample for Sphere |
20:03.47 |
MarcTannous |
if you want more, you just parse them locally
from argv to local variables to use in your functions |
20:04.08 |
MarcTannous |
in my example it is not very efficient, but
when you have 30+ functions, this works wonders |
20:05.01 |
andromeda-galaxy |
right, it just doesn't necessarily work for
all the primitives |
20:05.24 |
MarcTannous |
you mean you have more constructors for an
ellipsoid? |
20:05.43 |
MarcTannous |
so an ellipsoid can be defined with a b c d
but also with a b x y z? |
20:06.03 |
andromeda-galaxy |
a b c d, a r, a b r... |
20:06.28 |
MarcTannous |
yeah, just like I had to do in my cone
tests |
20:06.53 |
MarcTannous |
so you will take as argv everything, a b c d r
x y z whatever and then split it up into local values for ease of
use |
20:07.07 |
MarcTannous |
but yeah, that's a lot of code to write, my
cone test had like 500 lines |
20:08.00 |
andromeda-galaxy |
right, and the nevery function has to have
scanning added if we decide to go that way... |
20:08.35 |
MarcTannous |
did you talk to rossberg about this? |
20:08.52 |
MarcTannous |
or Sean |
20:10.10 |
andromeda-galaxy |
not yet, I've been waiting since yesterday but
neither of them have been in here |
20:10.19 |
andromeda-galaxy |
that's why I was just talking to
``Erik |
20:10.59 |
andromeda-galaxy |
<PROTECTED> |
20:11.31 |
MarcTannous |
There should be plenty of time until 2-3
January if I guess correctly |
20:11.41 |
MarcTannous |
everyone is busy with holidays &
family |
20:12.53 |
andromeda-galaxy |
probably |
20:13.00 |
*** join/#brlcad ries
(~ries@D979C47E.cm-3-2d.dynamic.ziggo.nl) |
22:06.37 |
*** join/#brlcad mihaineacsu
(~mihaineac@92.81.152.5) |
22:18.19 |
*** join/#brlcad FreezingCold
(~FreezingC@135.0.41.14) |
23:56.08 |
*** join/#brlcad mihaineacsu
(~mihaineac@92.81.152.5) |