Daniel Rossberg (Apr 30 2020 at 06:56): Daniel Rossberg (Apr 30 2020 at 06:56):I want to make sure that the brlcad.dll works with the next release (7.30.8). What's the best branch to test it? The code seems to go from trunk to RELEASE to STABLE to tags. I.e., RELEASE or STABLE would be a good candidate, or?
starseeker (Apr 30 2020 at 12:34):Right now, I'd go with RELEASE
starseeker (Apr 30 2020 at 12:35):I think I'm synced to stable, but would need to double check - you may want to wait until we decide what to do about the iges-g OSX bug report in case that requires code changes prior to release.
starseeker (Apr 30 2020 at 12:38):@Sean Quickhull.hpp is one of the files behind the bot chull command. A quick Linux test seems to work fine, but Windows is the one I'd want to check for that sort of change - IIRC it was the most work to get going originally. I'll see if I'm in a building state with trunk on Windows...
starseeker (Apr 30 2020 at 14:00):Seems to be OK on Windows.
Daniel Rossberg (Apr 30 2020 at 15:19):Okay, thanks, will test RELEASE then.
Daniel Rossberg (May 04 2020 at 15:35):Hmm, RELEASE doesn't contain the off_t for Windows fixes. I can't build the 32 bit version with Visual Studio.
Daniel Rossberg (May 04 2020 at 15:46):Another issue is the zlib in openNURBS: openNURBS-static is linked with zlib, i.e. the shared library version of it. This is not optimal for the brlcad.dll. I think, a static library shouldn't be linked with something else. This has to be done by the linker of the binary using the static library.
(I'm not sure, will test what happens.)
starseeker (May 05 2020 at 01:30):@Daniel Rossberg I did some updates to RELEASE today - do they help? (not sure yet what to do about openNURBS, but I did notice the off_t wasn't in there so I've tried to backport it.)
Daniel Rossberg (May 05 2020 at 14:08):Unfortunately, it still doesn't work. E.g., src/libbu/vls.c doesn't compile.
I could find differences in include/config_win.h.in, include/bu/glob.h, and include/bu/vls.h which could be of relevance, but replacing them didn't fixed it. I wasn't able to find the difference between revision 75083b(my reference) which breaks the build yet.
BTW, don't take care of the "zlib in openNURBS" thing. I can easily fix it for my purpose, and if it works I can regularly commit it to the trunk.
starseeker (May 05 2020 at 16:18):@Daniel Rossberg I think I may have had to start from a clean build directory.
starseeker (May 05 2020 at 16:19):@Daniel Rossberg are you working with RELEASE or trunk?
starseeker (May 05 2020 at 16:19):RELEASE is the one I thought I got working yesterday with the off_t updates...
Daniel Rossberg (May 05 2020 at 16:49):Daniel Rossberg are you working with RELEASE or trunk?
I did the tests with RELEASE, but compared them with a revision from the trunk where I know it works.
Daniel Rossberg (May 05 2020 at 16:52):Daniel Rossberg I think I may have had to start from a clean build directory.
From which revision did you forked the RELEASE? The last one before the TCL upgrades?
Maybe, you can choose a revision from the trunk for the fork, and I test this revision in advance if it works for me.
starseeker (May 05 2020 at 17:44):RELEASE was forked a long time back - we periodically merge from trunk. The last big merge was well before the Tcl upgrade.
starseeker (May 05 2020 at 17:46):Can you tell me what build error you were seeing with a vanilla RELEASE checkout that's current as of this morning? Most likely culprit is something to do with the regex.h header...
starseeker (May 05 2020 at 19:24):@Daniel Rossberg I think I got past the libbu issue - let me know if that does it for you
Daniel Rossberg (May 06 2020 at 08:58):RELEASE compiles now with VS2019, both 32 and 64 bit.
starseeker (May 06 2020 at 13:01):Excellent, thanks! Everything look like it is working OK?
Daniel Rossberg (May 06 2020 at 13:06):Until now: Yes.
I haven't done much tests yet, but the BrlCadViewer seems to work, at least.
starseeker (May 06 2020 at 13:07):Sounds good.
Daniel Rossberg (May 06 2020 at 13:09):Thanks! :)
starseeker (May 06 2020 at 13:14):np - thank you for catching it before we released! trunk is still shaking down from a lot of changes, so I'd like 7.30.8 to be working as widely as possible while we work through the updates.
Daniel Rossberg (May 06 2020 at 15:24):This time I want to build a new brlcad.dll from the release. We found some bugs in the old one (from 2016?) and I would like to have an official new one.
starseeker (May 06 2020 at 15:44):very good - let me know if you have any trouble getting the dll to build from RELEASE branch. I'm not ready to tag yet anyway, so there's still time to address any issues.
Last updated: Oct 09 2024 at 00:44 UTC