starseeker (Dec 03 2023 at 17:52): starseeker (Dec 03 2023 at 17:52):Cool - looks like there is some progress towards M1 runners for Github Actions with the Mac, although it's not on the free accounts yet: https://github.com/actions/runner-images/issues/8439#issuecomment-1755601587
Sean (Jan 09 2024 at 15:44):@starseeker Dunno if this is M1/M2-specific, but I'm getting a build error on brlcad_externals in libpng:
[ 60%] Building C object CMakeFiles/png.dir/png.c.o
/Library/Developer/CommandLineTools/usr/bin/cc -DPNG_ARM_NEON_OPT=2 -Dpng_EXPORTS -I/Users/morrison/brlcad_ext/install/include -I/Users/morrison/brlcad_externals/.build/png/PNG_BLD-prefix/src/PNG_BLD-build -I/Users/morrison/brlcad_externals/.build/png/PNG_BLD-prefix/src/PNG_BLD -arch arm64 -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX13.3.sdk -fPIC -MD -MT CMakeFiles/png.dir/png.c.o -MF CMakeFiles/png.dir/png.c.o.d -o CMakeFiles/png.dir/png.c.o -c /Users/morrison/brlcad_externals/.build/png/PNG_BLD-prefix/src/PNG_BLD/png.c
-- stderr output is:
In file included from /Users/morrison/brlcad_externals/.build/png/PNG_BLD-prefix/src/PNG_BLD/png.c:14:
/Users/morrison/brlcad_externals/.build/png/PNG_BLD-prefix/src/PNG_BLD/pngpriv.h:911:4: error: ZLIB_VERNUM != PNG_ZLIB_VERNUM "-I (include path) error: see the notes in pngpriv.h"
# error ZLIB_VERNUM != PNG_ZLIB_VERNUM \
^
1 error generated.
That's with
cmake .. -DENABLE_ALL=ON
starseeker (Jan 10 2024 at 20:36):IIRC that may come from getting system zlib and bundled zlib stuff mixed... I've seen it before, but I don't recall offhand what the specific issue was. I'm still more or less offline for the next few days - I may be able to have a go at it Friday or Monday
Sean (Jan 11 2024 at 19:29):Okay, yeah, let me know if you can check it out or point me at a file. I'm still using src/other elsewhere in the meantime, but couldn't find the delta.
Sean (Jan 11 2024 at 19:29):Hope you feel better!
starseeker (Jan 19 2024 at 14:25):@Sean , I just realized something - your directory name is brlcad_externals for this build. Are you using https://github.com/BRL-CAD/bext for the third party repo? I've got the brlcad_externals repo archived, since it didn't use the submodule approach. brlcad_externals shouldn't be used - I just left it up for now in case we needed anything in it for reference.
starseeker (Jan 19 2024 at 14:25):If you are using bext, can you send me the pnglibconf.h file the build generates?
Sean (Jan 23 2024 at 15:38):I have it rebuilding fresh to check current status since it's been a couple weeks. do you know why the submodules would report as modified? I cleared their status by blowing away the build, but I'm guessing some sort of submodule update is needed:
morrison@Miniagua brlcad.bext % git status
On branch main
Your branch is up to date with 'origin/main'.
Changes not staged for commit:
(use "git add <file>..." to update what will be committed)
(use "git restore <file>..." to discard changes in working directory)
modified: lmdb/lmdb (new commits)
modified: netpbm/netpbm (new commits)
modified: opencv/opencv (new commits)
modified: openmesh/OpenMesh (new commits)
modified: opennurbs/opennurbs (new commits)
modified: patch/patch (new commits)
modified: png/libpng (new commits)
modified: proj/PROJ (new commits)
modified: pugixml/pugixml (new commits)
no changes added to commit (use "git add" and/or "git commit -a")
Sean (Jan 23 2024 at 15:44):probably not related to the prior error, but I did notice that libpng and opencv both throw cmake warnings about "Argument not separated from previous token by whitespace"
Sean (Jan 23 2024 at 15:45):looking at the generated cmake scripts, it looks like a syntax error (quotes within a quoted string) in both
/Users/morrison/brlcad.bext/.build/png/PNG_BLD-prefix/src/PNG_BLD-stamp/PNG_BLD-configure-.cmake
and
/Users/morrison/brlcad.bext/.build/opencv/OPENCV_BLD-prefix/src/OPENCV_BLD-stamp/OPENCV_BLD-configure-.cmake
starseeker (Jan 23 2024 at 20:42):For the submodules, I think this might be the line for updating:
git submodule update --recursive
starseeker (Jan 23 2024 at 20:50):Looks like the cmake errors were a quoting problem passing in empty args via "" in our files - I've committed what should be a fix.
starseeker (Jan 24 2024 at 01:04):@Sean I'm curious if the latest bext still has the PNG_ZLIB_VERNUM issue - I'm not quite seeing where it would come from in the code, unless pnglibconf.h.prebuilt is getting used.
Last updated: Oct 09 2024 at 00:44 UTC