Stream: brlcad

Topic: code reviews, patches, pull requests

Sean (Jul 09 2019 at 01:00):

Hey all, looking for feedback on https://sourceforge.net/p/brlcad/code/HEAD/tree/brlcad/trunk/doc/checklist.txt

Feel free to point out any mistakes, essential criteria missing, or items you think don't belong.

Daniel Rossberg (Jul 28 2019 at 15:15):

In my opinion, it needs some polishing. It's in the state between a list of criteria and a check list where I can tick the items.

For example, I'm already stuck in the first point 00. Are all changes legally compatible? Per COPYING, assigned or 0BSD/PD.. What shall I do here? Three checks come into my mind:

• Has the contributor consented to BRL-CAD's copyright and license?
• If it's a new file, does it have appropriate copyright and license header? (There should be a list of appropriate headers.)
• Has code taken from other projects a compatible license?

But it could be more.

Sean (Jul 31 2019 at 16:23):

thanks for the feedback, definitely do wanting a checklist that can be ticked and not subjective criteria

Sean (Jul 31 2019 at 16:34):

also trying to balance not having too many checklist entries, which is why legal was collapsed all into one item, and trying to avoid "if X then Y" checklist items that might not apply

Sean (Jul 31 2019 at 17:58):

updated the text of the first couple points to make them more testable and eliminate the conditional.

Last updated: Oct 09 2024 at 00:44 UTC