Stream: brlcad

Topic: commit review


view this post on Zulip Sean (Sep 30 2020 at 17:30):

Here's a general topic stream for discussing recent commit activity and commit review.

view this post on Zulip Sean (Sep 30 2020 at 17:33):

@starseeker question on 77287, is there perhaps another way to go about it? I've been working towards eliminating apps being aware of the compilation root. Any code making assumptions about prefix/root end up being problematic for creating relocatable binaries

view this post on Zulip Sean (Sep 30 2020 at 17:34):

That's why the new bu_dir() API didn't expose it, so new code wouldn't be written against it.

view this post on Zulip Sean (Sep 30 2020 at 17:34):

Is there some issue in archer? I did update and fix a slew of hard-coded assumptions throughout archer and may have missed some...

view this post on Zulip starseeker (Sep 30 2020 at 19:16):

I wanted it to conditionalize a more aggressive search behavior for init.tcl in the libtclcad initialization...

You can yank it from trunk if you want - I only did it there because I couldn't test it in the thirdparty branch due to breakage, and I've got it in there now as part of 77288.

view this post on Zulip starseeker (Sep 30 2020 at 19:19):

I'm a ways from the dust settling in thirdparty - arguably I'm not even to the hard part yet (making the final install packages and install targets for the superbuild). Once I've got something that actually works there and can boil it down to hard requirements it'll probably be more interesting/useful to consider how to handle certain issues.

view this post on Zulip starseeker (Sep 30 2020 at 19:23):

@Sean from a design perspective, I seem to recall early on that an awareness of what the intended install directory was for the application was considered important, to make sure the installed binary always grabbed its associated files/plugins/scripts.


Last updated: Oct 09 2024 at 00:44 UTC