Sean (May 05 2022 at 15:59): Sean (May 05 2022 at 15:59):@starseeker I really like that adaptive_plot2() is gone! I'm rather concerned about moving torus from an architecture perspective, though.
Sean (May 05 2022 at 15:59):That part doesn't make sense to me.. What's the thinking? By extension, all the implicits would end up in libbg and that doesn't seem like a good direction (it's de-encapsulating them). It's also expanding scope (redefining what basic means seemingly arbitrarily).
Sean (May 06 2022 at 05:47):@starseeker 5ad26ec3da9bfcf72d581241db25f8c6a46aeff6 really looks to be even more backwards... what's going on? Having libbg know anything about database entity minor type codes isn't right. earlier change de-encapsulated a single entity was backwards, but now having part of the file format itself be decomposed across libraries is really making a mess of things... all for lod? there's got to be a better way that doesn't keep packing on architecture debt.
starseeker (May 06 2022 at 11:23):@Sean I'll be backing it out the torus changes anyway - I didn't get the speedup I was trying for, so it's not worth fooling with. I suspect we may have some rather fundamentally different ideas about libbg/librt scope, but there's no need to try and hash it out now.
starseeker (May 06 2022 at 11:51):@Sean removed, 6849ae8bc6b1d4b60536c02af7716b26bfe8fa08
Last updated: Jan 09 2025 at 00:46 UTC