Sumagna Das (Mar 10 2021 at 19:17): Sumagna Das (Mar 10 2021 at 19:17):i have this patch of my old work from the end of the last year
Sumagna Das (Mar 10 2021 at 19:18):it had the
Sean (Mar 10 2021 at 19:19):what's this got to do with svn2git? :)
Sumagna Das (Mar 10 2021 at 19:19):Sean said:
what's this got to do with svn2git? :smile:
wrong topic name
Sumagna Das (Mar 10 2021 at 19:19):i couldnt work on these after that time because of exams and studies
Sumagna Das (Mar 10 2021 at 19:20):now after the migration from svn to github
Sumagna Das (Mar 10 2021 at 19:20):i wanted to transfer that work using this patch but seems like there had been changes to GCV
Sumagna Das (Mar 10 2021 at 19:22):so what can i do with those changes
the patch is not fully applying because of the changes to GCV and as a consequence changes to png_read plugin file
Sumagna Das (Mar 10 2021 at 19:22):the flattening part applied perfectly but the other changes arent applying
Sean (Mar 10 2021 at 19:23):@Sumagna Das great question.
Sumagna Das (Mar 10 2021 at 19:23):so should i work on the flattening part or is the problem with mime_types has been fixed?
Sean (Mar 10 2021 at 19:24):I'm not remembering all the details of the changes that were made. I think they were exploratory, not necessarily decisions set in stone.
Sean (Mar 10 2021 at 19:25):if we're not talking about a lot of code, it might be easier to review the changes manually and reapply what makes sense, test, and see if it's good to go.
really begs for an integration or unit test to make it clear what the implementation goal is.
Sumagna Das (Mar 10 2021 at 19:26):so for now, can i just ignore it and work on the plugin as i flattened the types because of a problem with image mime types?
Sumagna Das (Mar 10 2021 at 19:27):Sean said:
if we're not talking about a lot of code, it might be easier to review the changes manually and reapply what makes sense, test, and see if it's good to go.
really begs for an integration or unit test to make it clear what the implementation goal is.
it had a little bit of code as i had to change most of the parts which used mime_types
Sumagna Das (Mar 10 2021 at 19:38):also if this is of any need, here is the patch > git_patch.patch
Sumagna Das (Mar 10 2021 at 19:39):and from the patch, it seems like the last update i did was r78038
Sumagna Das (Mar 10 2021 at 19:40):and this was the last update for me which didnt have any conflicts
Last updated: Oct 09 2024 at 00:44 UTC