Code Break · Google Summer of Code

@Saran Narayan Could you please look into one of your commits pertaining to "check_overlaps.c" . The variable check_plot seems to be uninitialized in some cases where if() stands false, which is breaking the code. Please rectify the snippet. Cheers !

Saran Narayan (Jul 23 2018 at 19:19):

I think I found the derp I did https://hastebin.com/ligoxiwuya

Saran Narayan (Jul 23 2018 at 19:20):

but the error you say is different

Saran Narayan (Jul 23 2018 at 19:20):

I am wondering why the error never showed up to me while I was building

Shubham Rathore (Jul 23 2018 at 19:23):

What flags do you use with cmake ?

Saran Narayan (Jul 23 2018 at 19:24):

no flags :/ just cmake ..

Sean (Jul 23 2018 at 19:25):

different versions of gcc/llvm and different compilation settings produce different warnings (which we turn into failures in our build)

Sean (Jul 23 2018 at 19:25):

best to just fix them as you find them and not worry about it -- they're typically trivial to resolve

Sean (Jul 23 2018 at 19:26):

only way to be really sure is to make sure one has the very latest version of the compiler and compiles both with and without optimization enabled

Sean (Jul 23 2018 at 19:27):

and then do it all over again with the other compiler (gcc/llvm) ;)

Sean (Jul 23 2018 at 19:27):

four full builds is best automated

Saran Narayan (Jul 23 2018 at 19:30):

welp that is too much work

Sean (Jul 23 2018 at 19:30):

that's why it's best to just fix them as we find them ;)

Saran Narayan (Jul 23 2018 at 19:30):

yeah :) will commit it

Saran Narayan (Jul 23 2018 at 19:30):

but still not sure what the problem is :D

Shubham Rathore (Jul 23 2018 at 19:32):

commit it, lets see

Saran Narayan (Jul 23 2018 at 19:33):

svn up :)

Shubham Rathore (Jul 23 2018 at 19:57):

Works :simple_smile:

Saran Narayan (Jul 23 2018 at 19:57):

great. Thank you for testing :)

Shubham Rathore (Jul 29 2018 at 05:50):

@starseeker error: missing field 'cflag' initializer [-Werror,-Wmissing-field-initializers]
struct _ged_ls_flags ls_flags = {0};
Could you help me on this . :)

starseeker (Jul 29 2018 at 12:37):

@Shubham Rathore does r71296 fix it?

Shubham Rathore (Jul 29 2018 at 13:02):

Ah... initialization. Yes it does ! :)

Cezar (Aug 04 2018 at 17:18):

i can't build the code, because log_overlaps (and possibly others) is defined in both libged/check_overlaps.c and libged/check/check_overlaps.c. i don't know which one is the redundant one

Saran Narayan (Aug 04 2018 at 17:21):

oh okay on it :)

Cezar (Aug 04 2018 at 17:21):

thanks ^^

Saran Narayan (Aug 04 2018 at 17:21):

BTW @Cezar getting this build error:

/home/sharan/brlcad/mod_ssh/src/libbu/hook.c: In function ‘bu_hook_list_init’:
/home/sharan/brlcad/mod_ssh/src/libbu/hook.c:42:13: error: request for implicit conversion from ‘void *’ to ‘struct bu_hook *’ not permitted in C++ [-Werror=c++-compat]
  hlp->hooks = bu_malloc(
             ^
/home/sharan/brlcad/mod_ssh/src/libbu/hook.c: In function ‘bu_hook_add’:
/home/sharan/brlcad/mod_ssh/src/libbu/hook.c:56:13: error: request for implicit conversion from ‘void *’ to ‘struct bu_hook *’ not permitted in C++ [-Werror=c++-compat]
  hlp->hooks = bu_realloc(
             ^
cc1: all warnings being treated as errors