Oleksandr Dubenko (Feb 25 2018 at 00:01): Oleksandr Dubenko (Feb 25 2018 at 00:01):So I've looked into OGV behaviour with default g-obj
Oleksandr Dubenko (Feb 25 2018 at 00:02):And it failed :D
So I submitted small PR that fixes it https://github.com/BRL-CAD/OGV-meteor/pull/75
Oleksandr Dubenko (Feb 25 2018 at 00:05):Also I'd like to have permission to the OGV-meteor repo
Inder Singh (Feb 25 2018 at 03:06):Thanks Oleksandr :) I will write some feedback on PR very soon.
Sean (Feb 27 2018 at 06:49):note that g-obj (really all the g-* polygonal exporters) currently fail about 10% of the time on average -- it's not a reliable process to go from implicit geometry with booleans to triangles
Sean (Feb 27 2018 at 06:50):that's 10% for a random object. that percentage compounds as you go up a hierarchy, meaning the most important top-level objects we usually want to export will be more likely to fail. I think at last measurement, they were something like 80-85% probability
Inder Singh (Feb 27 2018 at 10:46):Hmm, can three.js-nurbs and three.js-csg help in that area?
Sean (Feb 27 2018 at 13:11):someone could certainly try. the problem of robust boolean evaluation is unsolved academically, but some libraries do better than 90%
Sean (Feb 27 2018 at 13:12):if the new js facilities worked well enough, we could even fund recoding it to c++ for the core utilities
Inder Singh (Mar 01 2018 at 13:19):(deleted)
Inder Singh (Mar 11 2018 at 06:39):I have updated it to meteor's latest version and submitted PR for the same. Please have a look at it >
(https://github.com/BRL-CAD/OGV-meteor/pull/76).
Yes, I have seen that. Thanks :)
Moreover, I have found many problems in development branch version. I have something to ask and something > to share.
What says let's have a group talk about this stuff.
@ih8sum3r Sure let's do it. I have moved the conversation to OGV topic on this stream. You got it perfectly right, there's a ton to do but we want to focus on very specific things this time. Can you create a list of things you think needs improvement on a wiki page? I will pick and convert them to issues as required. Also feel free to ask any questions here on this topic.
ih8sum3r (Mar 12 2018 at 05:39):I have updated it to meteor's latest version and submitted PR for the same. Please have a look at it >
(https://github.com/BRL-CAD/OGV-meteor/pull/76).
Yes, I have seen that. Thanks :)
Moreover, I have found many problems in development branch version. I have something to ask and something > to share.
What says let's have a group talk about this stuff.
@ih8sum3r Sure let's do it. I have moved the conversation to OGV topic on this stream. You got it perfectly right, there's a ton to do but we want to focus on very specific things this time. Can you create a list of things you think needs improvement on a wiki page? I will pick and convert them to issues as required. Also feel free to ask any questions here on this topic.
Alright then. How about this Wednesday? If any other day please let me know as there is a big time difference between IST and EDT :). Meanwhile, I'll try to enhance my suggestions/ideas more and try to focus on my next PR and also I'll create a list on the wiki page (thinks that we need to focus more on and the things that need to be enhanced more) by Wednesday as I have an exam to do.
Thank You!
Inder Singh (Mar 12 2018 at 16:08):How about you create the list of things that need improvement and other things that you want to share? And include a list of questions you have at the end. I will reply to them and comment on them and then if there's someplace where a discussion is an absolute necessity, we can do that. :)
Inder Singh (Mar 14 2018 at 14:40):https://brlcad.zulipchat.com/#narrow/stream/111975-Google-Summer.20of.20Code/subject/OGV/near/123614604 @ih8sum3r :)
ih8sum3r (Mar 14 2018 at 22:07):Sorry for the delay. I have an exam today, by tonight I'm all into it. I'll make a list of things as soon as possible and will share here the link for the same.
ih8sum3r (Mar 16 2018 at 03:49):Hello @pooh (inder)
I have made the list of things that I want to ask plus little of my plans for this GSoC please have a look at it ( https://docs.google.com/document/d/1qDQdraXjsiCnNFYThyoC1IgBplxHyOCHEFvj-o1Kcs0/edit?usp=sharing ). As for now, I have found only these things. I am diving more into it, as soon as I found more bugs/issue in it or if there is any new idea by which we can enhance OGV I'll add in that file. Sorry for the delay as I have exams going on I'll be free by Sunday. I hope you understand :). I'll keep working on it in my free time and post if I face any problem.
Thank You!
Inder Singh (Mar 16 2018 at 10:14):Sure, no problem. Thanks :simple_smile:
Aditya Gulati (Apr 14 2018 at 03:59):Hey, I wanted to start to work on OGV, could someone guide over where to start? @pooh (inder) @Panda (Gauravjeet Singh) @Sean
Sean (Apr 14 2018 at 04:13):it's a super busy weekend for me, so no help here (and it's a discussion that should have been had, but hopefully you can manage something
Oleksandr Dubenko (Apr 14 2018 at 09:59):Hi @Aditya Gulati , you can start from downloading and setting up OGV. Repo's readme should be enough, but there are also some documentation in docs/ folder. Ping me if you have any questions.
Aditya Gulati (Apr 14 2018 at 10:17):@Oleksandr Dubenko I have set it up and updated meteor to its latest version. I was trying to fix the Data not found error as of now.
Aditya Gulati (Apr 15 2018 at 03:04):Hey, I have added a new template for dataNotFound and made a pull request.
Inder Singh (Apr 15 2018 at 12:06):@Aditya Gulati That's superb!! Great job. I will look into it and let you know if it requires anything more. Thank you!
Aditya Gulati (Apr 15 2018 at 12:23):@pooh (inder) I have made another change. Initially, the landing page wasn't showing the error for "Check BRL-CAD installation on server.", now I have added that. Wait, I'll just make the change. Can't wait to work with you this summer.:blush:
Aditya Gulati (Apr 15 2018 at 12:37):@pooh (inder) I was looking through the edit link error, I found that the edit link only stops to work when we use it for a shared model. And it makes sense since someone sharing you model shouldn't be able to edit it. So, should I fix the edit button or should I completely remove it for shared models?
Aditya Gulati (Mar 11 2019 at 12:20):@pooh (inder) I was trying to set up the new version of OGV on my laptop but I keep getting this error when I try to run it after building it.
./run.sh
Note: you are using a pure-JavaScript implementation of bcrypt.
While this implementation will work correctly, it is known to be
approximately three times slower than the native implementation.
In order to use the native implementation instead, run
meteor npm install --save bcrypt
in the root directory of your application.
/Users/adityagulati/Desktop/GSoC'19/OGV-build-1103201903/bundle/programs/server/node_modules/fibers/future.js:280
throw(ex);
^
TypeError: Cannot read property 'username' of undefined
at Meteor.startup (imports/startup/server/smtp.js:30:39)
at Function.time (/Users/adityagulati/Desktop/GSoC'19/OGV-build-1103201903/bundle/programs/server/profile.js:309:28)
at /Users/adityagulati/Desktop/GSoC'19/OGV-build-1103201903/bundle/programs/server/boot.js:427:13
at /Users/adityagulati/Desktop/GSoC'19/OGV-build-1103201903/bundle/programs/server/boot.js:472:5
at Function.run (/Users/adityagulati/Desktop/GSoC'19/OGV-build-1103201903/bundle/programs/server/profile.js:510:12)
at /Users/adityagulati/Desktop/GSoC'19/OGV-build-1103201903/bundle/programs/server/boot.js:470:11
I am using a OSX Mojave
Inder Singh (Mar 11 2019 at 16:16):Hey aditya, yup you are supposed to get that error. Please install the bcrypt using npm install --save bcrypt as mentioned in that error. :)
Aditya Gulati (Mar 11 2019 at 16:55):@pooh (inder) In which directory should I do that...I tried it in the server, nothing happened.....Also, tried it in the base directory, nothing happened.
Aditya Gulati (Mar 11 2019 at 19:04):Tried it again, got this error
Adityas-MacBook-Pro:OGV-meteor adityagulati$ npm install --save bcrypt@1.0.2
npm WARN deprecated bcrypt@1.0.2: bcrypt < v2.0.0 is susceptible to bcrypt wrap-around bug. Upgrade to bcrypt >= v2.0.0 for improved support for newer bcrypt hashes
> bcrypt@1.0.2 install /Users/adityagulati/Desktop/GSoC'19/OGV-meteor/node_modules/bcrypt
> node-pre-gyp install --fallback-to-build
node-pre-gyp ERR! Tried to download(404): https://github.com/kelektiv/node.bcrypt.js/releases/download/v1.0.2/bcrypt_lib-v1.0.2-node-v64-darwin-x64.tar.gz
node-pre-gyp ERR! Pre-built binaries not found for bcrypt@1.0.2 and node@10.1.0 (node-v64 ABI) (falling back to source compile with node-gyp)
CXX(target) Release/obj.target/bcrypt_lib/src/blowfish.o
CXX(target) Release/obj.target/bcrypt_lib/src/bcrypt.o
CXX(target) Release/obj.target/bcrypt_lib/src/bcrypt_node.o
In file included from ../src/bcrypt_node.cc:1:
In file included from ../../nan/nan.h:190:
../../nan/nan_maybe_43_inl.h:88:15: error: no member named 'ForceSet' in 'v8::Object'
return obj->ForceSet(GetCurrentContext(), key, value, attribs);
~~~ ^
In file included from ../src/bcrypt_node.cc:1:
../../nan/nan.h:820:18: warning: 'MakeCallback' is deprecated: Use MakeCallback(..., async_context) [-Wdeprecated-declarations]
return node::MakeCallback(
^
/Users/adityagulati/.node-gyp/10.1.0/include/node/node.h:171:1: note: 'MakeCallback' has been explicitly marked deprecated here
NODE_DEPRECATED("Use MakeCallback(..., async_context)",
^
/Users/adityagulati/.node-gyp/10.1.0/include/node/node.h:88:20: note: expanded from macro 'NODE_DEPRECATED'
__attribute__((deprecated(message))) declarator
^
In file included from ../src/bcrypt_node.cc:1:
../../nan/nan.h:834:18: warning: 'MakeCallback' is deprecated: Use MakeCallback(..., async_context) [-Wdeprecated-declarations]
return node::MakeCallback(
^
/Users/adityagulati/.node-gyp/10.1.0/include/node/node.h:164:1: note: 'MakeCallback' has been explicitly marked deprecated here
NODE_DEPRECATED("Use MakeCallback(..., async_context)",
^
/Users/adityagulati/.node-gyp/10.1.0/include/node/node.h:88:20: note: expanded from macro 'NODE_DEPRECATED'
__attribute__((deprecated(message))) declarator
^
In file included from ../src/bcrypt_node.cc:1:
../../nan/nan.h:848:18: warning: 'MakeCallback' is deprecated: Use MakeCallback(..., async_context) [-Wdeprecated-declarations]
return node::MakeCallback(
^
/Users/adityagulati/.node-gyp/10.1.0/include/node/node.h:157:1: note: 'MakeCallback' has been explicitly marked deprecated here
NODE_DEPRECATED("Use MakeCallback(..., async_context)",
^
/Users/adityagulati/.node-gyp/10.1.0/include/node/node.h:88:20: note: expanded from macro 'NODE_DEPRECATED'
__attribute__((deprecated(message))) declarator
^
In file included from ../src/bcrypt_node.cc:1:
../../nan/nan.h:1451:31: warning: 'MakeCallback' is deprecated: Use MakeCallback(..., async_context) [-Wdeprecated-declarations]
return scope.Escape(node::MakeCallback(
^
/Users/adityagulati/.node-gyp/10.1.0/include/node/node.h:171:1: note: 'MakeCallback' has been explicitly marked deprecated here
NODE_DEPRECATED("Use MakeCallback(..., async_context)",
^
/Users/adityagulati/.node-gyp/10.1.0/include/node/node.h:88:20: note: expanded from macro 'NODE_DEPRECATED'
__attribute__((deprecated(message))) declarator
^
4 warnings and 1 error generated.
make: *** [Release/obj.target/bcrypt_lib/src/bcrypt_node.o] Error 1
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack at ChildProcess.onExit (/Users/adityagulati/.nvm/versions/node/v10.1.0/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:262:23)
gyp ERR! stack at ChildProcess.emit (events.js:182:13)
gyp ERR! stack at Process.ChildProcess._handle.onexit (internal/child_process.js:235:12)
gyp ERR! System Darwin 18.2.0
gyp ERR! command "/Users/adityagulati/.nvm/versions/node/v10.1.0/bin/node" "/Users/adityagulati/.nvm/versions/node/v10.1.0/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "build" "--fallback-to-build" "--module=/Users/adityagulati/Desktop/GSoC'19/OGV-meteor/node_modules/bcrypt/lib/binding/bcrypt_lib.node" "--module_name=bcrypt_lib" "--module_path=/Users/adityagulati/Desktop/GSoC'19/OGV-meteor/node_modules/bcrypt/lib/binding"
gyp ERR! cwd /Users/adityagulati/Desktop/GSoC'19/OGV-meteor/node_modules/bcrypt
gyp ERR! node -v v10.1.0
gyp ERR! node-gyp -v v3.8.0
gyp ERR! not ok
node-pre-gyp ERR! build error
node-pre-gyp ERR! stack Error: Failed to execute '/Users/adityagulati/.nvm/versions/node/v10.1.0/bin/node /Users/adityagulati/.nvm/versions/node/v10.1.0/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js build --fallback-to-build --module=/Users/adityagulati/Desktop/GSoC'19/OGV-meteor/node_modules/bcrypt/lib/binding/bcrypt_lib.node --module_name=bcrypt_lib --module_path=/Users/adityagulati/Desktop/GSoC'19/OGV-meteor/node_modules/bcrypt/lib/binding' (1)
node-pre-gyp ERR! stack at ChildProcess.<anonymous> (/Users/adityagulati/Desktop/GSoC'19/OGV-meteor/node_modules/node-pre-gyp/lib/util/compile.js:83:29)
node-pre-gyp ERR! stack at ChildProcess.emit (events.js:182:13)
node-pre-gyp ERR! stack at maybeClose (internal/child_process.js:957:16)
node-pre-gyp ERR! stack at Process.ChildProcess._handle.onexit (internal/child_process.js:246:5)
node-pre-gyp ERR! System Darwin 18.2.0
node-pre-gyp ERR! command "/Users/adityagulati/.nvm/versions/node/v10.1.0/bin/node" "/Users/adityagulati/Desktop/GSoC'19/OGV-meteor/node_modules/.bin/node-pre-gyp" "install" "--fallback-to-build"
node-pre-gyp ERR! cwd /Users/adityagulati/Desktop/GSoC'19/OGV-meteor/node_modules/bcrypt
node-pre-gyp ERR! node -v v10.1.0
node-pre-gyp ERR! node-pre-gyp -v v0.6.32
node-pre-gyp ERR! not ok
Failed to execute '/Users/adityagulati/.nvm/versions/node/v10.1.0/bin/node /Users/adityagulati/.nvm/versions/node/v10.1.0/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js build --fallback-to-build --module=/Users/adityagulati/Desktop/GSoC'19/OGV-meteor/node_modules/bcrypt/lib/binding/bcrypt_lib.node --module_name=bcrypt_lib --module_path=/Users/adityagulati/Desktop/GSoC'19/OGV-meteor/node_modules/bcrypt/lib/binding' (1)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! bcrypt@1.0.2 install: `node-pre-gyp install --fallback-to-build`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the bcrypt@1.0.2 install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR! /Users/adityagulati/.npm/_logs/2019-03-11T17_45_57_045Z-debug.log
Inder Singh (Mar 12 2019 at 06:54):@Aditya Gulati which branch are you using? and it looks like you still need to install bcrypt and other dependencies properly before you can run OGV. :)
Aditya Gulati (Mar 12 2019 at 07:02):@pooh (inder) I am using the update-latest branch.
Could I update the version of bcrypt as I guess that 1.0.3 is not compatible with my OS?
Inder Singh (Mar 12 2019 at 07:25):yeah, i think you can.
Aditya Gulati (Mar 16 2019 at 18:15):@pooh (inder) @Panda (Gauravjeet Singh) @Sean I have sent a pull request fixing 2 problems in OGV...Please take a look at it
Aditya Gulati (Mar 19 2019 at 17:47):@pooh (inder) @Panda (Gauravjeet Singh) @Sean @Daniel Rossberg I have sent a pull request fixing 2 problems in OGV...Please take a look at it.
Sean (Mar 19 2019 at 17:49):@Aditya Gulati been meaning to, can you summarize?
Aditya Gulati (Mar 19 2019 at 17:56):@Sean I updated meteor to the latest version, also I fixed the build.sh. I also added a data not found template and added a model graphic to it.
Sean (Mar 19 2019 at 18:29):merged!
Aditya Gulati (Mar 19 2019 at 18:34):Thank you!
Sean (Mar 19 2019 at 18:34):@Aditya Gulati also merged one of @pooh (inder) related commits -- please check the merged result? I haven't tested it.
Sean (Mar 19 2019 at 18:36):of the remaining pull requests -- they should really all be closed out before gsoc begins
Sean (Mar 19 2019 at 18:38):are you able to review and merge them? I know some of them have mixed changes (like File Manager) that have desirable changes (fewer notifications) but now in conflict
Aditya Gulati (Mar 19 2019 at 18:44):It works but some code is redundant.....I'll remove the redundant code with my next fix if that's ok?
Sean (Mar 19 2019 at 22:36):succinct and easy to review works best, however it's grouped :)
Inder Singh (Mar 21 2019 at 07:08):@Aditya Gulati apologies for the late response. The branch update-latest should have the latest meteor.
Inder Singh (Mar 21 2019 at 07:12):@Aditya Gulati Also, data not found error was already fixed. If you can please work on any of the issues in list named to-do high priority, that would be great. You can look at them arranged in priority here. https://github.com/BRL-CAD/OGV-meteor/projects/1
When you do pick a task please comment on the issue, so that I can assign it to you and put an in progress label. This will help prevent any duplicate work. Thank you for working with OGV. Really appreciate the contributions.
Sean (Mar 23 2019 at 03:15):@pooh (inder) is there a reason we still have multiple versions of OGV? Last I looked, there's 3 right?
Sean (Mar 23 2019 at 03:17):wouldn't want to delete useful features if some are a port-in-progress, but this is already demonstrably a problem and something should be done to not waste any other contributor's time if one is going to be "the latest" and the other two ignored
Inder Singh (Mar 23 2019 at 08:50):@Sean There's only one default version called "update-latest", which is the default branch at GitHub. I have been working with @Panda (Gauravjeet Singh) (a little bit) to merge as many features (PRs from the past and new ones) in this branch as possible. All PRs should ideally be made to this branch, and if we can have a protocol where contributors claim an issue before working on it (on github), that would prevent any duplicate work. I will also be more careful and proactive in asking students about what they are working on.
Sean (Mar 25 2019 at 04:38):@pooh (inder) I feel like that's an error-prone solution as it only prevents duplicate work if all parties know about the process, which (if I'm not mistaken) is not documented anywhere, and is not conventional arrangement regardless. we have "geometry_viewer" and "OGV-meteor" for starters -- should probably just have one named "OGV" or "OnlineGeometryViewer" or similar. Is there anything remaining from geometry_viewer that still needs migration?
Sean (Mar 25 2019 at 04:40):As for the branches, is there any reason the default (and all merges) can't or shouldn't go to one of the typical ones like development or master?
Inder Singh (Mar 25 2019 at 14:10):@Sean Aaah sorry, I thought you were talking about different versions under OGV-meteor. That got me confused.
Yes, I agree with that 100%, we should have only one repo, OGV.
I don't think we need that much code from geometry_viewer, but I would still keep it as legacy code but I am not sure. @Harmanpreet Singh would know more about that.
Regarding the branches, update-latest was the temporary name given to the branch we were preparing for GSoC Students. So, I will just go ahead and call it development from now onwards. I will also document the contribution guidelines in the readme.
Inder Singh (Mar 25 2019 at 14:35):https://github.com/BRL-CAD/OGV-meteor/pull/86 @Sean @Panda (Gauravjeet Singh) Please review and approve, it's just initial set of instructions to prevent any mishaps. I will add more as we go ahead. :pray:
Inder Singh (Mar 25 2019 at 14:36):Also merged update-latest to development, and made development the default branch so that its conventional. I deleted some old branches which had already been merged. I need to sync master and development, I will do that within a day or two.
Sean (Mar 25 2019 at 14:43):@pooh (inder) that looks good enough to me, merged
Inder Singh (Mar 25 2019 at 14:44):@Sean thanks! just saw that. Did I write too much? :D I was thinking I wrote too little :P _looking at other people's contribution guidelines_ :thinking:
Sean (Mar 25 2019 at 14:45):so we should figure out where to go with geometry_viewer. He's not going to necessarily be aware of everything that has happened since then with the meteor code and the people that have worked on OGV beyond the first conversion aren't going to be aware what it did -- they'll only know OGV. it was written many years ago at this point, and neither is live..
Sean (Mar 25 2019 at 14:46):too much for a readme, not too much for a contributor's guide
Sean (Mar 25 2019 at 14:46):readme's are the first impression
Sean (Mar 25 2019 at 14:48):there are some readme's that double as a contributor's guide too or include their community behavior rules or other information, of course. it just depends on the intent and what else is in the document. if a readme is full of process, that can be off-putting to some contributors. the best ones I've come across are very clever and concise.
Inder Singh (Mar 25 2019 at 14:48):I will make an issue regarding improving readme. If you can write down your suggestions, or point to a resource for excellent readme, I would love that.
Inder Singh (Mar 25 2019 at 14:49):regarding geometry_viewer, i will put a note in its readme in bold about what it is, and that there exists a more updated meteor version (and give a link to it).
Inder Singh (Mar 25 2019 at 14:52):https://github.com/BRL-CAD/OGV-meteor/issues/87
Inder Singh (Mar 25 2019 at 15:02):pooh (inder) is there a reason we still have multiple versions of OGV? Last I looked, there's 3 right?
which one is the third version? :thinking: I know OGV-meteor and geometry_viewer
Sean (Mar 25 2019 at 15:12):regarding
geometry_viewer, i will put a note in its readme in bold about what it is, and that there exists a more updated meteor version (and give a link to it).
I would like we figure out exactly what purpose it serves first, whether it can be removed. if there are things it does better than OGV, then we should capture them as issues and make them a priority -- if there's actually reusable code that needs to be migrated still, that's what is most concerning. I don't think we should just keep it around as a reference any longer though. keeping it has a cost (like this discussion).
Sean (Mar 25 2019 at 15:13):pooh (inder) is there a reason we still have multiple versions of OGV? Last I looked, there's 3 right?
which one is the third version? :thinking: I know OGV-meteor and
geometry_viewer
I was thinking whatever is on master/development and what was on the default branch.
Inder Singh (Mar 25 2019 at 15:20):regarding
geometry_viewer, I will put a note in its readme in bold about what it is, and that there exists a more updated meteor version (and give a link to it).I would like we figure out exactly what purpose it serves first, whether it can be removed. if there are things it does better than OGV, then we should capture them as issues and make them a priority -- if there's actually reusable code that needs to be migrated still, that's what is most concerning. I don't think we should just keep it around as a reference any longer though. keeping it has a cost (like this discussion).
Agreed. I just need some time to figure that all out. Until then a note in the readme I think would prevent any confusions regarding it (especially from GSoC students).
Sean (Mar 25 2019 at 15:21):okay, sounds good
Inder Singh (May 10 2019 at 12:02):Hi @Quentin Paden , yay! welcome to GSOC 2019 and congratulations on your selection. Community bonding period is the most important part of GSoC. I would love to have a talk with you about who I am, about this community and plan the next steps, let me know when you are up for it. I am really excited and hoping to have a productive summer this year. :pray:
Inder Singh (May 30 2019 at 19:05):Hi @Quentin Paden , I hope your problems with your computer are now solved. Let me know if I can help. I have been hoping to get more regular updates from you since you said in your email that you will be more active on zulip chat. I have been student myself, so I totally understand the hardships of balancing school with GSoC. I would advise you to talk to your mentors here so that we can help you with that balancing.
Also, You said that you are working on UI, let's please have a conversation around it. I would like to prioritize the functionality over UI. We have had many UI runs and would like some work on the functionality this year. :pray: I have a project , and issues planned in github if you need to see list of our priorities.
Quentin Paden (Jun 01 2019 at 03:02):I am learning to navigate the zulip mobile app and I now know where things are! I am replying publically here instead of privately through email.
That was my mistake, I am now making a lot of progress with three.js texturing functionality and fixing the authentication flow interaction with the backend so the UI lets you quickly get to uploading your .obj files for viewing and sharing
Quentin Paden (Jun 01 2019 at 03:03):There was a lot of confusion on my side with the preferred communication with answering things and I now understand Zulip is the main place to share things. I’m constructing some shareable gifs of more significant progress and some helpful tips
Quentin Paden (Jun 01 2019 at 03:04):This is all in good faith and I am extremely sorry for any delays
Quentin Paden (Jun 01 2019 at 03:04):Which have occurred but now I want to share progress more often on the UI and functionality starting this weekend
Sean (Jun 01 2019 at 16:31):@Quentin Paden this is probably your best dedicated space ;)
Quentin Paden (Jun 01 2019 at 16:36):Perfect! To start off https://github.com/BRL-CAD/OGV-meteor/issues/54 and https://github.com/BRL-CAD/OGV-meteor/issues/70 should be closed with me resubmitting https://github.com/BRL-CAD/OGV-meteor/pull/88
I plan on also following the schedule I layed out and showing the fork of the fix for the big issue https://github.com/BRL-CAD/OGV-meteor/issues/68
Quentin Paden (Jun 01 2019 at 16:40):
This is a model I kitbashed that I was able to upload with the newer version of OGV with the newer THREE.js and METEOR.js versions
With the new version of Three.js R103 I was able to load this 1,996,349 Vert / 698,843 Tri OBJ file much faster than the previous r100 and r90 versions
Quentin Paden (Jun 01 2019 at 16:42):I created that in April just to test the power of the OGV viewer. Honestly having online viewerable files of geometry on the web is essential to working and transfering work. My computer went through issues and my previous 3D development environment with MAYA and BLENDER was gone, but because of OGV storing the obj files and three.js having a good visualization, I was able to quickly retrieve the lost .OBJ file worked on
Quentin Paden (Jun 02 2019 at 01:03):I have been working on the mobile breakpoints and fixing backend authentication still today June 1st 2019. Planning on submitting a PR tommorow June 2nd 2019 and I'll also post some of my code in here later on. I am proud of using the Google Developer Tools, and I am having a lot of fun using the dark mode now that I have it running in localhost on cloud! Night mode in Zulip Chat is also amazing, I highly reccomend checking out the Zulip Chat Settings https://zulipchat.com/help/night-mode!
Quentin Paden (Jun 02 2019 at 01:03):9:03 EST
Quentin Paden (Jun 02 2019 at 20:34):Hello! Today I am continuing to finish up some things regarding the CSS breakpoints and auth flow like earlier
@pooh (inder) what do you think about using SCSS for a dark mode https://github.com/BRL-CAD/OGV-meteor/issues/58
https://github.com/BRL-CAD/OGV-meteor/issues/63is related to the auth flow error and backend bugs right now. I’m planning on creating a before and after comparison to show how to reproduce the big and the fix it and take not of other bugs I may see so I can note them as issues while I fix them.
The code I have been writing has just been beneficial tweaks to some already nice code written by those before me so I thank them:smiley:
Quentin Paden (Jun 02 2019 at 20:35):**i will fix it and take note of other bugs which are reproducible
Quentin Paden (Jun 03 2019 at 19:46):Greetings! I am currently working on studying https://docs.meteor.com/v1.7/ and doing some coding examples to better understand and get more into understanding how the Meteor.js Backend was contructed so I can fix some things without breaking the compile or causing unforeseen additional issues. I come from a React.js background instead of Meteor.js, It is exciting learning about a new framework. This is going to help me add better functionality through eliminating bakend authentication bugs faster! https://github.com/BRL-CAD/OGV-meteor/issues/63
Quentin Paden (Jun 03 2019 at 19:47):I am going to start commenting on some of the issues in OGV so they can get assigned to me!
Have been working on a couple different issues in the repository that I commented on previously and would like to get them assigned to Max2020q (my account)
Quentin Paden (Jun 03 2019 at 19:49):Going to update my wiki soon with the work I've been doing as well
Sean (Jun 03 2019 at 23:55):That sounds good to me, but I defer to your mentors. Assuming you have made code changes, be sure you test them well and submit them as a pull request so they can be integrated. If you've tested that one pending pull request and it works, please let me know and I'll merge it in.
Quentin Paden (Jun 04 2019 at 02:21):@ Sean Yes I have tested the pending merge. Two issues regarding updating meteor.js and three.js will be closed due things now working smooth with that version with new three.js and the new meteor version. I was excited to try to submit a new PR last weekend , but I made some mistakes anf want to really test my code just a bit more to make sure the fixes and ui breakpoints work on mobile devices on all browsers, that css changes dont have unintended effects on other UI configurations, and that the meteor ogv backend authentication and progress loading works in different environments and web browsers. Fixing the authentication issue lets me access other UI configurations that you can only see when you are authenticated so that is a big step in fully fixing the UI Responsiveness Issue!
Quentin Paden (Jun 04 2019 at 14:49):Hello!
Just to give a visualization of the reproudced bugs regarding authentication here they are:
1). "Check BRL Installation on server" alert pops up whenever you refresh the page unauthenticated and is not needed
Screen-Shot-2019-06-04-at-10.37.13-AM.png
2). "Internal Server Error" alert pops up anytime a user creates an account
Screen-Shot-2019-06-04-at-10.39.23-AM.png
EXTRA:
Screen-Shot-2019-06-04-at-10.43.21-AM.png
- Landscape mode UI is very nice on mobile, but portrait defaults to desktop site resolution, so I am custom making a mobile portrait version for vertical screen resolutions, which is taking some time to get right
Quentin Paden (Jun 04 2019 at 15:09):working on these issues today
Quentin Paden (Jun 05 2019 at 00:53):Updated the wiki devlog today with recent progress. Getting some well needed things done with this! :tada:
Quentin Paden (Jun 05 2019 at 01:16):@pooh (inder) @Panda (Gauravjeet Singh) I am noticing some models and images are not loading correctly on the site from the previously established backend with meteor and mongodb.
What do you think about transitioning 3D Object storage and authentication to Firebase for "Login in With Google" and better authentication?
I was additionally thinking about maybe changing the font for the OGV in the top left as well (functionality is more important) but I know the look of it may matter to you as well!
Looking forward to opinions. I will be submitting more PR's soon as I have been working on code this whole time, but the authentication bugs are really needed to be handled so the functionality is a bit more usable before seriously diving in to a full CSS to SCSS change or restructure
Quentin Paden (Jun 05 2019 at 01:17):Will be tackling this going forward. Making progress!
Quentin Paden (Jun 06 2019 at 03:58):@pooh (inder) @Panda (Gauravjeet Singh)
Through further research, I now understand that asking for this change may ultimately lead to larger and more complex overall code restructuring regarding the backend (storage/authentication).
Through some testing I have realized that some of the database persistence of 3D objects and images in its current state does not reliably load some images from the server. Right now the site boots up with an image from /icons/Error_graphic.png which seems incorrectly loading due to the actual content not loading from the mongodb server
Same with the 3D models, they will stay on the site due to the service worker, but if you try to load the model you posted on another account and look at it on another browser which wasn't involved with the previous service worker, the 3D model doesnt appear, signaling to me that something is going on with the persistence of the 3D model object data or something with how its labeled to load from the server.
Through working with loading 3D models from a server before, I know a possible solution may be editing the Cross-Origin Resource Sharing (CORS) CORS Configuration of backend storage Access-Control-Allow-Origin to get the issue with 3D content persistence solved
Quentin Paden (Jun 06 2019 at 04:03):I am most familiar with solving this issue with firebase storage. I need your help mentors @sean @pooh (inder) @Panda (Gauravjeet Singh) with deciding if this is the right path to take, or if I should just polish the current authentication a bit more and do storage on a seperate platform (or just learn how to fix the current storage persistence issue possibly due to the cors config with this backend api provider)
Quentin Paden (Jun 06 2019 at 04:07):I have fixed the improper alerts on the backend from the images before and started really digging into and working on getting the mobile version to load consistently on most major browsers and devices, but the 3D model persistence is a big issue which I would like to try to replicate one more time before fully putting it as a issue.
Inder Singh (Jun 06 2019 at 04:07):Hi @Quentin Paden I think we should prioritize the correct loading of models over polishing authentication or adding more ways to login. I would create an issue for CORS problem and solve it before that. We should always have the priority as bugs -> enhancements -> new features.
Inder Singh (Jun 06 2019 at 04:07):I will look into all your comments and PRs and provide you more info soon.
Quentin Paden (Jun 06 2019 at 04:17):@pooh (inder) Awesome answer! I hope you are good!
This is actually connected to the upload processes of the 3D model code and may affect solutions for other issues regarding that as well (progress bar and probably others).
I want to put this issue in github with a general place in the code where I think this is happening and write up some potential solutions to show you starting tommorow. The previous fixes with CSS and the alerts are minor compared to this 3D model upload issue! The upload process being smooth super important part of this application so I definitely want to reprioritize focus from UI temporarily on this and quickly get a update for a solution on it this week.
I am very interested in following that priority guide. I am going to document the 3D model data persistence issue starting today and replicate/try to find more direct code solutions to it tomorrow.
I was working on this at 8:00pm just discovered this at 11:00pm. It is now 12:11pm as I document this. Thank you for your support and patience with me, as it encourages me to work smarter.
Quentin Paden (Jun 06 2019 at 04:26):EDIT Thanks for the answer I hope you are feeling good.
Inder Singh (Jun 06 2019 at 05:02):Good job @Quentin Paden , have you set up your daily dev log somewhere? You can do it on wiki or may be a wordpress.com blog. Something that's easier to set up and get going would be cool.
Inder Singh (Jun 06 2019 at 05:02):Also I am on PST at the moment, just in case you want to sync up with me. What time zone are you in?
Inder Singh (Jun 06 2019 at 05:06):Oh never mind! I see that you have dev lot in wiki.
Inder Singh (Jun 06 2019 at 05:06):log*
Quentin Paden (Jun 06 2019 at 10:20):I'm in EST.
Quentin Paden (Jun 07 2019 at 17:26):Update: yesterday was dealing with serious internet issues and there was a pretty big storm down here. I’m going to be able to get a ton of work done now that the internet is fixed
Inder Singh (Jun 07 2019 at 17:58):Ohh! I hope you are alright
Inder Singh (Jun 07 2019 at 17:58):Take care, and thank you for the update.
Inder Singh (Jun 08 2019 at 01:42):@Quentin Paden I have merged your pull request for now. :) Would you be able to deploy it on a digital ocean server (I can get one for you). That would make it easier for everyone to see and test the progress.
Inder Singh (Jun 08 2019 at 15:25):@Quentin Paden I see that you have not been updating your dev log from last couple of days. What are you working on? Do you need any help?
Quentin Paden (Jun 10 2019 at 06:00):@pooh I will update my devlog. I thought you knew I was seriously working on revamping the object persistance and CORS issue with the 3D model persistance using firebase like we agreed on 3 days ago :( Working on fixing the bug with CORS 3D upload which is pretty much breaking the OGV site. Fixing this with firebase instead of the mongodb storage which doesnt persist properly. I will update the dev log to signal this change. I am confident I can solve this issue myself. If you look through the timeline I created, I'm actually supposed to be finishing fixing parts of the UI next week in regards to mobile and web functionality. I got rid of some alerts which stopped you from signing up and cleaned up the UI for some things alongside working on this issue.
If you would like to help, send me the complete information for the digital ocean server. And please tell me more information about how it would help, why it would help, and how you would like me to use it with you.
As of
Quentin Paden (Jun 10 2019 at 06:02):^ sorry didnt mean to send that as of there lol
Quentin Paden (Jun 10 2019 at 06:14):I have luckily worked with Google Cloud, Firebase, and 3D loaders with Three.js so this isn't hard for me, I just have to revamp the last persons previous mongodb code which is cool because it is challenging and fun.
Quentin Paden (Jun 10 2019 at 06:32):==June 7th==
*Testing 3D object storage due to a BIG issue regarding its persistence on different service workers and accounts
==June 8th==
*Planning to revamp the previous non-persistent mongodb 3d object uploader code due to the 3d objects not loading from the server properly (3d data object persistence issues)
==June 9th==
*Creating a separate cloud storage bucket for OGV Geometry Viewer with Google Cloud CORS setup fixed for 3D files persistence and loading
*Initializing firebase in the code
==June 10th==
*Switching upload process in code to include NEW 3d data upload to firebase storage through anonymous authentication for upload to cloud storage (able to still utilize the old authentication process and transition easily to using other login providers in the future)
*Able to load 3D files from cloud storage when interacting with other profiles and 3d Objects
Quentin Paden (Jun 10 2019 at 06:33):I want to be more transparent when showing you the fixes so I definately want to show PR's through Digital Ocean or Google Cloud Firebase Server.
Quentin Paden (Jun 10 2019 at 06:34):Can also try Kubernetes or Docker if needed
Quentin Paden (Jun 10 2019 at 06:35):Thanks for being there for me to help! @pooh (inder) I appreciate it and would like to talk further about showing development updates through the cloud
Panda (Gauravjeet Singh) (Jun 12 2019 at 04:54):@Quentin Paden Are you writing your daily logs in zulip chat only? Can you please setup a blog or a wiki page and write the daily log on that. Your daily log will get lost here in chat. If you already have a blog setup, can you please share a link to your daily log.
Sean (Jun 12 2019 at 05:25):dev log is at http://brlcad.org/wiki/User:Quentinpaden
Quentin Paden (Jun 12 2019 at 07:31):@pooh (inder) Good Evening. I just submitted https://github.com/BRL-CAD/OGV-meteor/pull/89
Would like to close :
https://github.com/BRL-CAD/OGV-meteor/issues/72
https://github.com/BRL-CAD/OGV-meteor/issues/70
https://github.com/BRL-CAD/OGV-meteor/pull/89
Quentin Paden (Jun 12 2019 at 07:39):Just opened up this issue for the BIG database persistence problem!
https://github.com/BRL-CAD/OGV-meteor/issues/90
I really want to get this one done this week as well
https://github.com/BRL-CAD/OGV-meteor/issues/63
Quentin Paden (Jun 12 2019 at 07:54):@Panda (Gauravjeet Singh)
I just updated it today! Check it out
http://brlcad.org/wiki/User:Quentinpaden
Sean (Jun 12 2019 at 13:50):Is firebase already in use? Do we have a list of OGV's dependencies itemized anywhere?
Panda (Gauravjeet Singh) (Jun 12 2019 at 17:55):Thank you @Quentin Paden for the PR, I will close the issue after reviewing/merging it.
AFAIK we are not using firebase in OGV, I think he might be proposing it as a solution.
Quentin Paden (Jun 12 2019 at 18:01):@sean @Panda (Gauravjeet Singh) I am proposing Firebase as a solution because I believe the 3D Data Object issue is related to a CORS cloud hosting issue with how images and files are loaded from the cloud. I belive utilizing Google Cloud will help quickly resolve any hosting, server, and storage issues related to OGV before moving forward with a larger revamp. additionally, this should let me share the site temporarily to share progress utilizing firebase hosting. in the future, people can easily add and connect there own firebase server an authentication as well.
The package.json file and node_modules folder should contain the list of dependencies.
Inder Singh (Jun 16 2019 at 18:46):Okay, let's work on such major changes (especially when they are architectural changes) after we have finished the high priority pressing bugs.
https://github.com/BRL-CAD/OGV-meteor/issues/53 -> what do you think about this? Can you take this on?
Quentin Paden (Jun 18 2019 at 01:32):@pooh Thank you for recommending this to me. I'm working a lot now on fixing these larger bugs and problems with meteor backend and mongodb backend and get multiple PRs done. I will update my devlog with recent progress on this front. I believe I am very close to fixing those problematic areas, so I can focus on other importants things such as making the README look better and the landing page CSS :tada: :working_on_it:
Inder Singh (Jun 18 2019 at 17:52):Okay, let's work on such major changes (especially when they are architectural changes) after we have finished the high priority pressing bugs.
https://github.com/BRL-CAD/OGV-meteor/issues/53 -> what do you think about this? Can you take this on?
@Quentin Paden did you get this?
Sean (Jun 19 2019 at 13:04):@sean Panda (Gauravjeet Singh) I am proposing Firebase as a solution because I believe the 3D Data Object issue is related to a CORS cloud hosting issue with how images and files are loaded from the cloud. I belive utilizing Google Cloud will help quickly resolve any hosting, server, and storage issues related to OGV before moving forward with a larger revamp. additionally, this should let me share the site temporarily to share progress utilizing firebase hosting. in the future, people can easily add and connect there own firebase server an authentication as well.
@Quentin Paden I'm not following.. can you elaborate? We're self-hosting OGV on our dedicated server. There isn't any loading from cloud happening now, so that's not likely the source of any problems and changing from local-hosting to cloud hosting has rather major implications, mostly undesirable ones at this point.
Sharing updates will be easier after you've provided a few pull requests. That's the steps to obtaining direct commit access so you can make changes that can be made live on the production server (brlcad.org).
Panda (Gauravjeet Singh) (Jun 19 2019 at 19:00):@Quentin Paden You haven't updated your dev log since June 12. Is everything fine?
Please be consistent with your logs, so that we know you are working. Try to write your experience of solving an issue, instead of just writing its title.
And if for some reason, you are not able to work, let us know.
Also, I have reviewed your pull request, please check my comment on Github.
Quentin Paden (Jun 20 2019 at 23:30):Here is the updated Devlog:
http://brlcad.org/wiki/User:Quentinpaden
I have not been feeling to well this week but I have been actively working on these 5 issues below:
https://github.com/BRL-CAD/OGV-meteor/issues/90
https://github.com/BRL-CAD/OGV-meteor/issues/53
https://github.com/BRL-CAD/OGV-meteor/issues/58
https://github.com/BRL-CAD/OGV-meteor/issues/63
https://github.com/BRL-CAD/OGV-meteor/issues/62
I would like these issues below to be closed in the repository now that they have been solved:
https://github.com/BRL-CAD/OGV-meteor/issues/64
https://github.com/BRL-CAD/OGV-meteor/issues/70
https://github.com/BRL-CAD/OGV-meteor/issues/72
https://github.com/BRL-CAD/OGV-meteor/issues/54
Quentin Paden (Jun 20 2019 at 23:31):@panda https://github.com/BRL-CAD/OGV-meteor/issues/64 is for one you have solved a while ago
Quentin Paden (Jun 20 2019 at 23:34):@Sean The CORS settings on the dedicated server doesnt allow for the persistence of 3D models reliably. Moving data storage into the cloud and fixing the CORS settings on the database will allow you to reliably store 3D models in the website database.
Quentin Paden (Jun 20 2019 at 23:35):The problem originates from the Three.js Loaders
Quentin Paden (Jun 20 2019 at 23:36):Prior to working a lot on OGV I have had many problems with THREE.js loader in the past from server and its mostly due to the config on the server for the database
Quentin Paden (Jun 20 2019 at 23:40):I have read the comment on https://github.com/BRL-CAD/OGV-meteor/pull/89
The current 404 page too me is not as good as the default landing page as the 404 because the home button routing does'nt actually work, and the image loaded there is not good.
Quentin Paden (Jun 20 2019 at 23:56):@pooh (inder) I commented in https://github.com/BRL-CAD/OGV-meteor/pull/89
I think not providing this from styles may be preventing this class from dynamically changing properly, but I think the fix for that is related to https://github.com/BRL-CAD/OGV-meteor/issues/58 for CSS code quality fix regarding the CSS styles in https://github.com/BRL-CAD/OGV-meteor/pull/89/files/51e2fcf4c951147f98ebf9f07be582cb07d1f533#diff-f862ecdc723359ef00a7470b9ae05cd2
</div>
<div class="row">
<div class="col-12 col-lg-3 col-sm-6">
Quentin Paden (Jun 20 2019 at 23:59):@Sean If I can edit the settings for your dedicated server I may be able to fix it, but that would take me more time than the fix I've been working on https://github.com/BRL-CAD/OGV-meteor/issues/90
Quentin Paden (Jun 21 2019 at 00:22):Upon researching further the CORS issue doesnt reliably reporduce on safari and the models I'm testing load in chrome and mozilla now.
The issue I did find however was that most of the model was scaled so low that it didn't fully load in console until zooming in
Panda (Gauravjeet Singh) (Jun 21 2019 at 00:58):Here is the updated Devlog:
http://brlcad.org/wiki/User:QuentinpadenI have not been feeling to well this week but I have been actively working on these 5 issues below:
Hey @Quentin Paden , hope you are feeling well now. Please stay in touch, as much as possible, and let us know beforehand if someday you can't work.
https://github.com/BRL-CAD/OGV-meteor/issues/90
https://github.com/BRL-CAD/OGV-meteor/issues/53
https://github.com/BRL-CAD/OGV-meteor/issues/58
https://github.com/BRL-CAD/OGV-meteor/issues/63
https://github.com/BRL-CAD/OGV-meteor/issues/62
I think if you pick one issue, and solve it, before moving on to next, it would be faster. This will keep you focussed on one issue, instead of getting distracted by multiple things.
I would like these issues below to be closed in the repository now that they have been solved:
https://github.com/BRL-CAD/OGV-meteor/issues/64
https://github.com/BRL-CAD/OGV-meteor/issues/70
https://github.com/BRL-CAD/OGV-meteor/issues/72
https://github.com/BRL-CAD/OGV-meteor/issues/54
Thank you for notifying. I like your interest in cleaning up the Github repo asap. I will close these issues once they are merged and tested. I think some of them are merged, will check once before closing them.
Regarding the CORS issue, I would suggest the same as @pooh (inder) suggested few days ago. Let's work on those major architectural changes after we have finished high priority bugs.
And, please let me know if you got my message of writing a little detailed experience of solving an issue, instead of just issue title in your daily log.
Quentin Paden (Jun 21 2019 at 01:09):Thank you for the quick response
Hope you have been well!
You are right, going forward I definately want to showcase the journey and detail of how I solve the issue and encounter an it. I think show that via image and description may help me communicate my progress and work more fluently
@Panda (Gauravjeet Singh)
I have been splitting my efforts between multiple issues and will start to focus on bugs in the repository before the architectural changes and style changes
Thank you for communicating this to me. I will change this habit and reflect this focus in my work moving forward!
Quentin Paden (Jun 21 2019 at 01:12):Sorry for the spelling errors I initially sent that response from my phone but I'm on the computer now
Correction from original:
Quentin Paden (Jun 21 2019 at 01:14): Sean (Jun 21 2019 at 19:13):So @Quentin Paden ... thank you for the update but big dumps like this after a week of disappearing is not cool. It's hard to have a productive conversation because there are more than a dozen topics listed with several warranting their own conversation. We also still need to talk about the issue that was e-mailed to you so please PM me when you are available.
The CORS settings on the dedicated server doesnt allow for the persistence of 3D models reliably.
It's not clear what you mean by this, please explain. What exactly is not reliable and why is it not reliable? You say settings -- so what setting? It would be absurd to adopt a new external cloud dependency that changes the entire backend architecture if there's an alternative that just adjusts a setting! Please be precise in what the problem actually is (and if you don't know, then what you're proposing is a non-solution).
Sean (Jun 21 2019 at 19:15):The current 404 page too me is not as good as the default landing page as the 404 because the home button routing does'nt actually work, and the image loaded there is not good.
Can you set up a side-by-side comparison? What does "routing doesn't actually work" mean -- please be more precise. Is it just a dead link that is pointing to the wrong place? Again that's a trivial fix if that's the case.
Quentin Paden (Jun 21 2019 at 19:22):@Sean I can set up a side by side comparison to be more precise. I will PM you about the email.
Sean (Jun 21 2019 at 19:24):I have also responded to issue #90 ... I don't feel like we know what the problem is yet.
Sean (Jun 21 2019 at 19:26):If it is known, please explain it in more specific detail. Not what's not happening, not what should be happening, but what is actually wrong and why it's wrong code-wise or setting-wise.
Quentin Paden (Jun 21 2019 at 21:02):I will work on fixing https://github.com/BRL-CAD/OGV-meteor/pull/89 today through using the template notFound in file 404.html on 404 error and fix the link to the home page is not clickable in that template.
Quentin Paden (Jun 22 2019 at 20:20):@Sean I have commented back on issue #90
I would like to research further into the issue with precise google chrome console logs and test another instance of safari once I solve https://github.com/BRL-CAD/OGV-meteor/pull/89 today.
Quentin Paden (Jun 24 2019 at 18:05):Hello, on saturday and sunday I have been working on ttps://github.com/BRL-CAD/OGV-meteor/pull/89 I truely and honestly plan on resubmitting the PR before 7:00 PM EST today on Monday. I got caught up in some family events over the weekend.
Quentin Paden (Jun 24 2019 at 18:06):Once I am done with this I am going to go forward and focus on https://github.com/BRL-CAD/OGV-meteor/issues/63
Panda (Gauravjeet Singh) (Jun 24 2019 at 18:24):Awesome! thanks for updating here. Looking forward to your PR.
Quentin Paden (Jun 24 2019 at 21:18):https://github.com/BRL-CAD/OGV-meteor/pull/89/commits
@Panda (Gauravjeet Singh)
I added some new commits for the PR.
I added the 404 page template to the error.html because error.html, error.js, and error.css control the 404 pages right now, and not all errors. Errors right now are actually controlled by alert notifications which I have to fix as well soon, because some of them come up at the wrong time, or are too intrusive.
When researching further into app.js and the relation 404.html has to it, the error.js is set as the default redirect and not 404.html. I believe the error.js implementation is actually set up as the 404 page due to how the set it up in Meteor in app.js
Quentin Paden (Jun 24 2019 at 21:20):To quickly solve this, I added the 404.html to the error.js, error.html to not break the routing with iron-router and fixed some style to center the content.
Quentin Paden (Jun 24 2019 at 21:22):Now the 404 properly displays when not going to an actual page, and shows the redirect link. When I tried the onclick option, function option through ID, and HREF it didnt work on my browser, but I'm going to try to test again soon.
I temporarily added a new solution with the onclick href on the link "go back to home page".
Quentin Paden (Jun 24 2019 at 21:23):The hardest part of this problem was going through the previous setup for 404.html and realizing the Error.js setup actually was the 404 page for the site.. 404.html was never set up in routing properly i think on the meteor.js side
Quentin Paden (Jun 24 2019 at 21:23):** going through the previous setup for 404.html in App.js (which for meteor connects all of the routing modules)
Quentin Paden (Jun 24 2019 at 21:30):^ that was what lead me to this solution
Quentin Paden (Jun 24 2019 at 21:36):Most of my time for the past few days was trying to find out why the routing for 404.html wasnt working, but then I realized it was setup through meteor for error.js error.html instead. That is why it took so long. I do not think solving the next one will take as long.
Quentin Paden (Jun 24 2019 at 21:49):Going to update my devlog tonight now that the wiki is back
Quentin Paden (Jun 24 2019 at 21:50):I'm going to try to add images this time to it
Panda (Gauravjeet Singh) (Jun 24 2019 at 23:17):Most of my time for the past few days was trying to find out why the routing for 404.html wasnt working, but then I realized it was setup through meteor for error.js error.html instead. That is why it took so long. I do not think solving the next one will take as long.
Awesome. I am glad that you are finding your way through the code. This is exactly the kind of thing I look for when reading your dev log.
So, are we now using error.html as 404 page?
If so, it's okay, go ahead and fix the later part of the issue. You can start studying the routing code in parallel, and then we can shift to the original 404 page directly. At some point, you might have to edit the routing, so it's better to start understanding now, in parallel.
Quentin Paden (Jun 24 2019 at 23:48):yes it seems like OGV is using error.js as the main routing for 404 errors. I’m studying more of “iron-router” and meteor.js to learn more about the codebase
I am currently testing the href link issue to go back to the home page on mozilla instead of chrome
Quentin Paden (Jun 24 2019 at 23:51):** href link on 404 page is unresponsive through the onclick, href, and id script
im going to try some other methods and see if I can edit the 404 page layout to see if anything related to the style is preventing it from working
I am going to update my devlog later tonight with a more concise description
Panda (Gauravjeet Singh) (Jun 25 2019 at 18:51):@Quentin Paden The wiki is back up now, you can now update your dev log.
Ping me here, after you are done with updating.
Quentin Paden (Jun 25 2019 at 19:10):@Panda (Gauravjeet Singh)
updated.
I am going to move onto https://github.com/BRL-CAD/OGV-meteor/issues/63 today after a bit of https://github.com/BRL-CAD/OGV-meteor/pull/89
Quentin Paden (Jun 25 2019 at 19:10):I like to post most of what I'm doing here before I update the devlog.
Quentin Paden (Jun 25 2019 at 19:11):I understand iron-router more now. Error.js is set up in this project as the 404 page as of now, so I dont think we should change the routing further on this.
Quentin Paden (Jun 25 2019 at 19:12):http://brlcad.org/wiki/User:Quentinpaden
Panda (Gauravjeet Singh) (Jun 25 2019 at 19:13):@Quentin Paden Did you fix the link to the home page in the 404 page? I would suggest to go on to the next issue, only when you have finished this issue completely.
Quentin Paden (Jun 25 2019 at 19:16):**I am going to move onto https://github.com/BRL-CAD/OGV-meteor/issues/63 today after a bit of https://github.com/BRL-CAD/OGV-meteor/pull/89**
The link to the home page works sometimes. I'm adding one more commit to fix that then moving to https://github.com/BRL-CAD/OGV-meteor/issues/63 today
Quentin Paden (Jun 25 2019 at 19:19):https://github.com/BRL-CAD/OGV-meteor/pull/89 I actually added a commit to fix it, but yesterday I acknoledged it was a temp solution until I test more browsers.
Once I submit that small commit and it is done, I'm going to go ahead and move onto https://github.com/BRL-CAD/OGV-meteor/issues/63
Quentin Paden (Jun 25 2019 at 19:24):@Panda (Gauravjeet Singh)
This link should show where I changed the code for the link to home page
https://github.com/BRL-CAD/OGV-meteor/pull/89/commits/d43fddbb1702924b6f7759f5dc8c571c7b543777#r297353675. It looks correct and does work some of the time. I believe something to do with the frame above the link https://github.com/BRL-CAD/OGV-meteor/pull/89/commits/d43fddbb1702924b6f7759f5dc8c571c7b543777#r297354371
it is blocking the link on some browsers I am testing it out and tweaking the commit a bit to make sure the link works on all browsers before moving on to https://github.com/BRL-CAD/OGV-meteor/issues/63 today.
Sean (Jun 25 2019 at 20:31):Is there an instance of the latest OGV up and running somewhere publicly? If not, it would be good to set it up so others can see these changes before/after. I know I would appreciate seeing what the 404 page and other work is looking like.
Quentin Paden (Jun 25 2019 at 21:32):@Sean
Yes this is definately a good idea!
This approach will help display improvements rapidly.
I want to be able to get the site somewhere running publicly to have you all see the changes and improvements I make going forward.
@Panda (Gauravjeet Singh)
The reason this simple link problem is taking longer today is because I'm taking apart the frame container parent div and child divs, and looking into various components of them (CSS, JS) to see what is blocking the onclick function and href function from working..
I am going to finish this and see is I can deploy a public version of the site to the web tonight.
Quentin Paden (Jun 25 2019 at 21:35):I am taking my time with these issues. I do not want to seem like I am just rushing through everything.. I realize I need to submit my changes incrementally so you know what point I am at.
Quentin Paden (Jun 26 2019 at 02:09):I was able to get the button link working, but I am working on fixing the opacity and zindex of the divs so the 404 page looked like it did before.
Quentin Paden (Jun 26 2019 at 02:11):im going to try to host the website to share with you for updates tonight after this last part and move on to #63
Quentin Paden (Jun 26 2019 at 17:01):finishing up this now ^
Sean (Jun 27 2019 at 03:56):Did you finish setting up a public version?
Quentin Paden (Jun 27 2019 at 22:03):@Sean I did not finish setting up a public version yesterday. I went ahead and finished this pull request https://github.com/BRL-CAD/OGV-meteor/pull/89/files. I am now working another branch and hosting it as a droplet or temporarily on firebase for public sharing purposes tonight on Friday I will send you a link to the side publicly, and I will start working on https://github.com/BRL-CAD/OGV-meteor/issues/63
@Panda (Gauravjeet Singh) @pooh (inder)
I would like to close the pull request and start working on https://github.com/BRL-CAD/OGV-meteor/issues/63
- I will have a public version of the site ready Friday to share with you so you can see my changes rapidly :D
Quentin Paden (Jun 27 2019 at 22:04):I am updating my Devlog tonight after I get back from the gym and some errands.
Quentin Paden (Jun 27 2019 at 22:05):I added some extra commits to fix the 404 page issue. https://github.com/BRL-CAD/OGV-meteor/pull/89/commits
Panda (Gauravjeet Singh) (Jun 28 2019 at 00:08):Quentin Paden: I am updating my Devlog tonight after I get back from the gym and some errands.
Hey, @Quentin Paden cool thanks for notifying it here.
Also, try to update your dev log every night unless there's some urgency and you could not.
Quentin Paden: I added some extra commits to fix the 404 page issue. https://github.com/BRL-CAD/OGV-meteor/pull/89/commits
Currently, you used the error template for 404-page error. But this template is also being used to show when model is not displayed. So we will get this 404 error, when there is a problem in the model rendering. Check the screenshot I posted on Github. Use the existing 404 template, instead of error template for 404 errors. And do the same fix in it.
Quentin Paden (Jun 28 2019 at 03:16):I would like to have a more in-depth discussion about this, because that model has not loaded and will not load on the landing page properly this whole time so I removed it.
The 404 page works correctly in other instances.. I believe the real problem is separating the model loading error from the 404 error, which is the same at the moment, that may require a separate PR to separate that, but for now I believe this works for the 404.
I just have to fix the model loading in a separate PR. Panda please let me move on to fixing that because the 404 page works as of now, I just have to fix the model loading error separately, their are a lot of other errors regarding model loading such as scale of models and error notification as well.
Quentin Paden (Jun 28 2019 at 03:16):@Panda (Gauravjeet Singh)
Quentin Paden (Jun 28 2019 at 03:20):Can I please create a seperate PR for solving the model loading and 404 page being the same?
I really want you to understand that the model loading on the front page never loaded since I have been using this library, and has been causing issues so I removed it.
We need to have more conversations about fixing the model loading because I have been talking about that for some time and would like some help with what you think may be the issue. I am going to show you more proof of this soon, but I would like to move on towards fixing the model loading and seperating it from the 404 page in routing because it was not properly seperated in the beggining. 404 page has always been connected to error.js it seems in routing.
Quentin Paden (Jun 28 2019 at 03:20):@Panda (Gauravjeet Singh)
The model on the front page will not load currently and needs to be removed temporarily because of this model loading issue.
Quentin Paden (Jun 28 2019 at 03:25):I honestly believe the 404 page works as of now, I just have to unconnected and separate how it was previously connected to model loading issues that from the model loading. This is a separate task and bundling that all into the 404 fix involves fixing the model loading code as well. I would like to seperate that into a different PR if you want me to solve both the model loading error and the 404 page.
If you go to localhost:3000/test on your machine, you can see the model loads correctly.
I am just going to go ahead and start hosting the site so you dont have to compile your own version to see my changes and I can move faster along with you seeing and testing out my changes faster
Quentin Paden (Jun 28 2019 at 03:34):*If you go to localhost:300/test on your machine, you can see the 404 page loads correctly
Quentin Paden (Jun 28 2019 at 03:37):I am confident I can work rapidly through the other issues and I know personally I can do this. I am going to get through a lot more of those issues on github before the end of July and make the site function and work great.
Quentin Paden (Jun 28 2019 at 03:43):@Panda (Gauravjeet Singh)
Is it possible to close https://github.com/BRL-CAD/OGV-meteor/issues/64?
I got my Pull Request closed for https://github.com/BRL-CAD/OGV-meteor/pull/88 but https://github.com/BRL-CAD/OGV-meteor/issues/70 and https://github.com/BRL-CAD/OGV-meteor/issues/54 are still open.. I can update them again if you want.
Sean (Jun 28 2019 at 03:49):Looking forward to reading a couple missed log entries... getting awfully close. The summaries can be just as important, helps keep an eye on priorities.
Quentin Paden (Jun 28 2019 at 04:15):http://brlcad.org/wiki/User:Quentinpaden
Inder Singh (Jun 28 2019 at 05:04):Panda (Gauravjeet Singh)
Is it possible to close https://github.com/BRL-CAD/OGV-meteor/issues/64?
I got my Pull Request closed for https://github.com/BRL-CAD/OGV-meteor/pull/88 but https://github.com/BRL-CAD/OGV-meteor/issues/70 and https://github.com/BRL-CAD/OGV-meteor/issues/54 are still open.. I can update them again if you want.
Thank you for pointing out the outdated issues. :) They should be closed by now.
Panda (Gauravjeet Singh) (Jun 28 2019 at 05:18):@Quentin Paden
Okay, let me rephrase.
This problem occurs because you copy pasted the 404 page template code in the error template.
We use the error template when a model is not loaded. And 404 page template when we are on the wrong URL.
Commenting out the 3d model from landing page doesn't fix this. because then it will show 404 error inside OGV, when there's an error in the uploaded 3d model.
Quentin Paden (Jun 28 2019 at 05:34):@Panda (Gauravjeet Singh)
I want to let you know the reason why it seems like I just copy pasted the 404 page into error template (I actually did more than that, I cchanged the 404 page style and layout as well)
I understand what you were telling me, what I am trying to emphasize and communicate to you is that the Error.html template is connected to error.js which in iron-router is currently connected to the 404 page for the website and the model error at the same time..
I have to go into iron-router and revamp the route for the model loading error so it is seperate from the 404 page which requires me to go into the model loading code and change it so it is seperate. To me this seems related to the other model loading error issues
On another note, the model which loads on the landing page comes from an SRC link which does not work at the moment at all. Before I edited the landing page, that model would default to an error, which previously just was an image which was not centered and didnt have any CSS or style properly attached to it.
What I am suggesting is that I move the model loading error towards another issue relating to model loading and proper model style to make more progress on that front.
1) The landing page model SRC does not load whatsoever and defaults to error, it would be better to just not have it there because it doesnt actually load any model
2) Before I started working on the 404 issue and even now, the 404 page is currently error.js in routing, I have to create a 404.js or something similiar and reroute the routing from error.js to the new file for 404.js and fix the model loading file error.js , to me this is a very different issue not related to fixing the original issue which is the "low hanging" issue of https://github.com/BRL-CAD/OGV-meteor/issues/72 which just wants to fix the link on the 404 page..
I want to let you know I have been working hard on this and I really hope you understand :(
Quentin Paden (Jun 28 2019 at 05:36):These are the two things which I would like to emphasize and more clearly discuss about
Quentin Paden (Jun 28 2019 at 05:54):In Summary:
I am trying to say to you I have in fact done real work and fixed the href link issue for the 404 page in https://github.com/BRL-CAD/OGV-meteor/issues/72 anything related to fixing the routing on model error should be it's own seperate issue and PR
The original issue https://github.com/BRL-CAD/OGV-meteor/issues/72 does not really mention the very serious routing problem of the default unedited "error.js" file routing by default as the 404 page (this is still doing this in the unedited master version of the repository and I can prove the the routing for the error.js file was acting as the 404 page).
The original issue mentions of fixing the link on the 404 page, in order to actually see the edits I made to the 404 page because of the problem mentioned above I had to paste it into error.js because by Default the error.js file is routing to the 404 page.
@Panda (Gauravjeet Singh)
As you now know, previously by default the error.js model error template would load as the 404 page because the routing is not as it should be, which is a different issue than what is said as a "low hanging" issue in https://github.com/BRL-CAD/OGV-meteor/issues/72
I want to clarify that the landing page model SRC is not a correct link and does not load anything from the server, the link is broken as of now. I can repair this and try to get a model which it needs to load actually working, but that may be a seperate issue as well.
I would like to move on to the fixing the routing for the model loading error.js page so it's not acting as the 404 page but that is a much different solution and problem than the one described in https://github.com/BRL-CAD/OGV-meteor/issues/72 and is related much more to the model error issue listed in the repository.
Quentin Paden (Jun 28 2019 at 05:54):@Panda (Gauravjeet Singh)
Quentin Paden (Jun 28 2019 at 05:58):Until a proper model is loaded from the server for the model on the landing page, and the very big routing issue with model loading errors and 404 errors being previously linked 2 years ago via iron-router, I believe the model on the landing page should not be there.
Quentin Paden (Jun 28 2019 at 06:01):I am excited to share the OGV hosted site publicly later in the afternoon with everyone though! :D
Many great improvements will be made on model loading and the overall site CSS and layout in the coming weeks and days.
Sean (Jun 28 2019 at 06:11):I have to go into iron-router and revamp the route for the model loading error so it is seperate from the 404 page which requires me to go into the model loading code and change it so it is seperate. To me this seems related to the other model loading error issues
makes sense.
2) Before I started working on the 404 issue and even now, the 404 page is currently error.js in routing, I have to create a 404.js or something similiar and reroute the routing from error.js to the new file for 404.js and fix the model loading file error.js , to me this is a very different issue not related to fixing the original issue which is the "low hanging" issue of https://github.com/BRL-CAD/OGV-meteor/issues/72 which just wants to fix the link on the 404 page..
I think this is part of the disconnect, that different issues are being mixed together. Doing that can easily result in frustration because different people are going to be focusing on different issues. For example, issue #72 is simply about a link not working. Does PR #89 fix that issue without causing any other problems or side effects? If not, then there should probably be a different issue created for PR #89 or a different PR submitted in response to issue #72.
I don't think anyone would argue against separating 404 errors from other types of errors. ;)
Sean (Jun 28 2019 at 06:20):In Summary:
I am trying to say to you I have in fact done real work and fixed the href link issue for the 404 page in https://github.com/BRL-CAD/OGV-meteor/issues/72 anything related to fixing the routing on model error should be it's own seperate issue and PR
Again, I don't think that's in question -- it's demonstrably work. I think the valid point raised was that it also has some other negative consequences. If it's not possible to fix the link (without negative effect) without fixing the routing, then it's not a separate issue. If it is, then a different solution is probably needed for the link (one without negative effect).
as an aside, you really don't need to repeat yourself so many times (I think you've stated the routing issue 3-5 times before anyone has had a chance to respond?), and fwiw sending messages in smaller chunks makes replying easier for others.
Panda (Gauravjeet Singh) (Jun 28 2019 at 16:57):Hey @Quentin Paden
Just want you to know:
- I can see that you working really hard now to fix this issue.
- With copy pasted, I meant using the 404 template code in the error template. I never meant to disapprove you of your work.
- We can't merge a PR until it has the right solution. My PR also went through revisions when I was a GSoC student.
I understand what you were telling me, what I am trying to emphasize and communicate to you is that the Error.html template is connected to error.js which in iron-router is currently connected to the 404 page for the website and the model error at the same time..
I have to go into iron-router and revamp the route for the model loading error so it is seperate from the 404 page which requires me to go into the model loading code and change it so it is seperate. To me this seems related to the other model loading error issues
Yes, that's the part of the issue. You combined the model loading error and 404 error in the same template. That's why we are getting a 404 page embedded inside the box where the model was supposed to load. That's the reason we have a separate template for both errors.
2) Before I started working on the 404 issue and even now, the 404 page is currently error.js in routing, I have to create a 404.js or something similiar and reroute the routing from error.js to the new file for 404.js and fix the model loading file error.js
That's what I was trying to tell. You don't have to create a new file/template. There is a file already in OGV source code. I pointed out the exact path in the PR conversation. Just use it to show 404 template instead of error template in the routing file.
The original issue mentions of fixing the link on the 404 page, in order to actually see the edits I made to the 404 page because of the problem mentioned above I had to paste it into error.js because by Default the error.js file is routing to the 404 page.
Yes, that is true. This is what I have told you earlier. And you commented the following on Github
(In PR conversation, you left this comment)
I am going to revert these changes and fix the 404.html template instead and the routing.
From the above comment, I thought, we are on the same page on how to fix it.
Let me know if you still have doubts on how to fix this, and we can talk about it.
Panda (Gauravjeet Singh) (Jun 28 2019 at 18:04):@Quentin Paden If you want to, you can take a break from this 404 issue, and start with the one @pooh (inder) suggested days ago.
https://github.com/BRL-CAD/OGV-meteor/issues/53
It's totally your call. You can finish this up first, or you can work on above issue and come back to 404 issue after that. As of now, current PR needs more work before we can merge it.
Quentin Paden (Jun 30 2019 at 06:26):Sorry for taking so much time to get this site publicly hosted.
I have been working on getting the site publicly hosted this weekend for sharing and dev testing purposes. I have been running into problems with Firebase in Google Cloud, Digital Ocean, and AWS due to payment methods being declined for hosting and Meteor.js not being a static site, which involves some complicated setups depending on the cloud provider
Luckily through Trial and Error I have settled with https://www.meteor-now.com/ which is a free way to deploy meteor apps using the lesser known and newer ZEIT deployment engine. I am learning the library now and I really want to deploy this before the weekend is over. This has been a very fun learning experience figuring out how to get this deployed. It should be up soon.
I am going to keep working on the issue that I was working on before, and I would like to get some low hanging issues cleared up with some PRs this week.
Looking forward to using https://github.com/jkrup/meteor-now to help deploy this site nicely!
Quentin Paden (Jun 30 2019 at 06:27):Once the site is deployed I think I will be enjoyable for others to interact with changes quickly.
Quentin Paden (Jun 30 2019 at 06:30):*I think IT will be enjoyable for others
Panda (Gauravjeet Singh) (Jul 02 2019 at 00:19):Hey @Quentin Paden , how are you? So what exactly are you working on right now and how's the progress so far? Also, please keep your wiki updated. I mostly go there, to see your progress.
Quentin Paden (Jul 02 2019 at 00:21):Hello I hope you all have been well. I am coming back from my families house. I am looking forward to deploying OGV when I get home tonight being home and staying up all night to organize some of the code.
@Panda (Gauravjeet Singh)
I have been focusing on getting the site deployed, I have had to try a lot of different providers but I am now adding the meteor-now dependency and working on getting the site public
I am going to continue to work on the iron-router issue and https://github.com/BRL-CAD/OGV-meteor/issues/58 later on
Quentin Paden (Jul 02 2019 at 00:22):I am going to start to transition my updates from here to the wiki more often instead of just posting in zulip
Quentin Paden (Jul 02 2019 at 00:23):I will come back online when I get closer to home tonight and update my wiki and provide the OGV public link. Some things are still being actively worked on, but it can do a lot of things still at the moment.
Panda (Gauravjeet Singh) (Jul 02 2019 at 00:27):Can you prioritize working on the issue over deployment? We can work on the deployment part in parallel.
Instead of coming up with a temporary deploy solution, how about if we design a system that can also be used to deploy OGV in production. But before spending any more time on that, I would strongly encourage you to get few issues fixed.
Quentin Paden (Jul 02 2019 at 00:50):I am reading through some issues I plan on working on this week. @Panda (Gauravjeet Singh) can you explain more of https://github.com/BRL-CAD/OGV-meteor/issues/57 in zulip? "Don't allow the creation of user account until the admin has set email server.
A better way is to create a set of settings called required settings and signup/login nothing should even begin before those required settings are done."
Quentin Paden (Jul 02 2019 at 00:52):I'm going to try to get the issues labeled BUG started and hopefully cleared up through this week and some of next week. Once that is done I will focus on the issues labeled enhancement.
Quentin Paden (Jul 02 2019 at 00:53):What were you thinking of using personally for deployment? Digital Ocean? I would reccomend ZEIT and meteor-now if you chose one because it's free as opposed to Digital Ocean and has a dedicated community for meteor.
Panda (Gauravjeet Singh) (Jul 02 2019 at 00:54):@Quentin Paden That's a low hanging issue. If you go here: https://github.com/BRL-CAD/OGV-meteor/projects/1
There's a list called ToDo high priority. And the issues are arranged as per their priority. Can you pick up the first issue from that list (issue #53)
Quentin Paden (Jul 02 2019 at 01:03):@Gurveer Singh I am having trouble undersanding ttps://github.com/BRL-CAD/OGV-meteor/issues/57. I am going to submit PR's for many of the High Priority ones for sure but I am really looking into doing https://github.com/BRL-CAD/OGV-meteor/issues/66 so users here can see there models properly.
Quentin Paden (Jul 02 2019 at 01:03):I would like the freedom to move through the issues which I feel like I can accomplish.
Quentin Paden (Jul 02 2019 at 01:05):Will update my devlog later on with progress and work on the high priority updates. I will provide progress through the ZEIT link as well afterwards to show you updates quickly and prove that I can work on this.
Quentin Paden (Jul 02 2019 at 01:05): Panda (Gauravjeet Singh) (Jul 02 2019 at 01:41):@Quentin Paden You mentioned three completely different issues, in your past three messages.
(Issue #57, Issue #58, Issue #66)
Can you please clarify what exactly do you want to work on?
Inder Singh (Jul 02 2019 at 02:00):I would like the freedom to move through the issues which I feel like I can accomplish.
@Quentin Paden
Regarding 57: My bad, I should have written it more thoroughly. So for sending email verifications, we need "admin" account to have email server setup in settings. Currently, even when admin account does not have an email server setup, other users can reach login/sign up forms, fill it but they never receive a verification email (hence never able to sign up). What we want is, that we should not allow any user to reach and fill sign up form until admin has set its email server in settings.
Doing this would be a very minor code change, and this bug comes only for a small amount of time before admin signs up. So it's a semi-edge case scenario. I think you can see how it's not that important or urgent (as compared to other issues on the list).
Regarding freedom: Yes Quentin, you have the freedom (as long as we are looking in issues under scope of GSoC) . We are just trying to make sure that
a) you are able to choose one issue and get it merged so that we can soon award you with commit access. :medal:
b) we can work on issues that effect the project the most. Issues that can give you better chances at having a super successful GSoC. :tada:
I hope you can understand that and we can get more done soon.
Quentin Paden (Jul 02 2019 at 02:06):@pooh (inder)
Thank you for the clarification, I really appreciate that! I definately want to look more into that to see what is going on there I reminder seeing a placeholder somewhere in the code for the email admin server I will look into that
@Panda (Gauravjeet Singh)
I want to get these done before the halfway point for July in any order.
https://github.com/BRL-CAD/OGV-meteor/issues/72 (Iron-Router Part of 404 Fix, I fixed the 404 page but now I have to fix routing)
https://github.com/BRL-CAD/OGV-meteor/issues/58 (CSS code improvement [Code Quality] )
https://github.com/BRL-CAD/OGV-meteor/issues/66 (Fix Model Position)
https://github.com/BRL-CAD/OGV-meteor/issues/68 (Make OGV Responsive)
https://github.com/BRL-CAD/OGV-meteor/issues/87 (Improve ReadMe)
https://github.com/BRL-CAD/OGV-meteor/issues/53 (Meteor Admin User Creation)
https://github.com/BRL-CAD/OGV-meteor/issues/74 (Fix CFS dependency)
Inder Singh (Jul 02 2019 at 02:06):@Quentin Paden P. S Just edited my previous response. :see_no_evil: :pray:
Inder Singh (Jul 02 2019 at 02:07):@Quentin Paden Wow, that would be great. Especially the #74 and #53 would be a big deal.
#87 is not part of GSoC but I think we can do it as long as it does not take more than an hour or two.
I would keep 58 for later because we have been working on the front end from the past couple of GSoCs and would like to prioritize on backend first. The code quality issue also requires some work from my side, so we will have to collaborate together on that;). Maybe we do a full day e-hackathon together in next week or two and get it done. What do you say? Up for some camaraderie?
Quentin Paden (Jul 02 2019 at 03:02):@pooh (inder)
That sounds like a fun time! I would definitely be up for that! I will focus of the backend issues going forward.
Quentin Paden (Jul 02 2019 at 04:10):Sorry for spending to much time on trying to deploy the site publicly myself, I definitely should focus more on big fixes on the backend and leave deployment to the advisor of mentors.
Am going to focus on the bigger backend issues to help the repository author more directly and be more helpful.
It would be cool to be able to show updates publicly with deployment, but deploying a mongoDB server with a Meteor.js is definately a task better suited for the paid deployment Docker hosting solutions.
The ZEIT deployment didn't work due to free docker meteor.js deployment being switched to paid only like most other platforms.
Screen-Shot-2019-07-02-at-12.06.53-AM.png
Screen-Shot-2019-07-01-at-11.45.24-PM.png
Screen-Shot-2019-07-02-at-12.05.11-AM.png
Quentin Paden (Jul 02 2019 at 16:10):I am working on https://github.com/BRL-CAD/OGV-meteor/issues/53 right now from the high priority issues. Just wanted to let you know I think config.json file named in the issue desscription was renamed to settings.json https://github.com/BRL-CAD/OGV-meteor/blob/development/settings.json.
Quentin Paden (Jul 02 2019 at 16:14):https://github.com/BRL-CAD/OGV-meteor/blob/719d4194b868eb2985d32f69262577c2ba5c97c1/package.json#L19 mentions setting.json as well instead of config.json
Quentin Paden (Jul 02 2019 at 16:21):Working on randomly generating a password in the settings.json file and making a console.log in it now
Quentin Paden (Jul 02 2019 at 17:47):Reading more into https://docs.meteor.com/api/core.html#Meteor-settings and https://github.com/meteor/meteor/issues/2005, people are saying the file doesnt have to be a .JSON file but can be a .JS file containing JSON data!
Following Meteor.js docs and some threads from their github and stackoverflow, changing settings.json to settings.js and dynamically creating the json file then passing the json with the randomizd password using settings.js to "meteor --settings settings.js" will give me the flexibility to generate the JSON data with a random password
I am going to test this out and see if it works.
To ensure the console.log of the randomized password in settings.js doesnt appear on the client, I can try to add an additional script in package.json to make sure the console.log appears on the server for the random password.
I am going to try this solution now and see if it works.
Panda (Gauravjeet Singh) (Jul 02 2019 at 20:01):@Quentin Paden
Yeah, good catch. It's settings.json now.
To display the password on the server, you don't have to add a script in the package.json. Instead, you can console log the password from the server file. If you console log from the server, it won't show the password in the browser. Take a look at OGV-meteor/imports/startup/server/accounts.js file to see how we are getting the value password from settings.
Quentin Paden (Jul 02 2019 at 21:30):@Panda (Gauravjeet Singh)
Thanks I ended up doing the solution using Meteor.Settings through dynamically creating the randomly generated 32 digit alphanumeric password and applying it to the settings.json using Meteor.Settings instead of settings.json so I could fix it using just that one startup/server/account.js file.
I learned a lot about Meteor in the process of this fix, here is the pull request for https://github.com/BRL-CAD/OGV-meteor/issues/53
Pull Request for Meteor Admin User Creation Fix:
https://github.com/BRL-CAD/OGV-meteor/pull/91
Quentin Paden (Jul 02 2019 at 21:31):Code:
https://github.com/BRL-CAD/OGV-meteor/pull/91/files
Quentin Paden (Jul 02 2019 at 21:32):Thanks for the suggestion
Quentin Paden (Jul 02 2019 at 21:33):It helped a bunch! :tada:
Panda (Gauravjeet Singh) (Jul 02 2019 at 22:55):Awesome @Quentin Paden Added my review on Github.
I must say, I am pretty glad, it's almost fixed. Just a few minor things. Let me know if you still have any doubts about it.
Quentin Paden (Jul 03 2019 at 00:16):Thank you for the guidance! @Panda (Gauravjeet Singh) I have reviewed the Github response and I am looking forward to submitting another PR today!
Inder Singh (Jul 03 2019 at 03:58):@Quentin Paden can't wait to merge your PRs :see_no_evil: . So excited.
Quentin Paden (Jul 03 2019 at 19:36):I am looking forward to finishing the issue later on today and working on previous issue so I can get both PR's merged this week. Not feeling too good today, but I will finish up one of them tonight.
Quentin Paden (Jul 04 2019 at 16:40):https://github.com/BRL-CAD/OGV-meteor/pull/91/files#diff-85207ec3ffd02327adfb13aec22778a2
Fixed the rest of the adminPassword issue.
Response to: "Don't set all the meteor settings from code, we need to use the values they get from the settings.json file."
I had to set the random admin password and the smtp settings at the same time in Meteor.settings function due to how Meteor created the function. When not settings the new random Meteor AdminPassword with the default smtp settings, it clears out the settings and gives an smtp error due to the function erasing the original settings.json except for adminpassword if you don't set the additional new adminPassword with the previous default Meteor.Settings for public, private, and smtp set in package.json.
This solution works exactly how you wanted it too.
I am going to try to finish https://github.com/BRL-CAD/OGV-meteor/pull/89 this week as well.
Quentin Paden (Jul 04 2019 at 16:40):@Panda (Gauravjeet Singh) @pooh (inder)
Panda (Gauravjeet Singh) (Jul 04 2019 at 17:18):Hey @Quentin Paden, almost there.
Added my review in the pull request. Let me know if you have any doubts about it.
Quentin Paden (Jul 04 2019 at 17:38):@Panda (Gauravjeet Singh)
I do not have doubts about this one. https://github.com/BRL-CAD/OGV-meteor/pull/91/files#diff-85207ec3ffd02327adfb13aec22778a2
Panda (Gauravjeet Singh) (Jul 04 2019 at 17:46):yeah, go ahead, what's the doubt?
Quentin Paden (Jul 04 2019 at 17:50):@Panda (Gauravjeet Singh) Panda I just said I do NOT have any doubts lol.
Quentin Paden (Jul 04 2019 at 17:50):hahahaha
Quentin Paden (Jul 04 2019 at 17:51):Hopefully that one is going to be merged.
Panda (Gauravjeet Singh) (Jul 04 2019 at 17:51):oh! misread your message. Awesome! let me know when you do the changes.
Quentin Paden (Jul 04 2019 at 17:52):https://github.com/BRL-CAD/OGV-meteor/pull/91/files#diff-85207ec3ffd02327adfb13aec22778a2 @Panda (Gauravjeet Singh) The changes are right here..
Panda (Gauravjeet Singh) (Jul 04 2019 at 17:52):oh great! looks perfect. Will close it after testing it once.
Panda (Gauravjeet Singh) (Jul 04 2019 at 22:25):Hey @Quentin Paden , did you check to log in the admin account using this random password?
I tried to do it, but it says "incorrect password". Can you please investigate into that. I think there's something wrong with changing meteor settings. Maybe look into fixing this issue without changing the settings.
Here's what we want: We want to login with that random password instead of the default value 'password'.
To test, try logging in an admin account, with the email id: admin@example.com with that random password generated.
Inder Singh (Jul 06 2019 at 16:00):Hey @Quentin Paden please keep updating your logs daily. There has been no update after 2nd of July. Is everything okay? Do you need help with anything?
Quentin Paden (Jul 07 2019 at 01:44):i hve been working on the adminpassword issue and 404 issue, im going to update my logs tonight
Panda (Gauravjeet Singh) (Jul 09 2019 at 18:04):Hey @Quentin Paden, how's it going? It's been a while since you gave an update. Also, the wiki log is not updated.
Quentin Paden (Jul 09 2019 at 18:14):http://brlcad.org/wiki/User:Quentinpaden yea I updated it on the 5th, I’ve been having trouble with the adminPassword sign in working in that login page with admin@example.com. I did not know too much about where that account is set from previously and im trying to sign in with that but I am running into obstacles
Quentin Paden (Jul 09 2019 at 18:15):do you know more about where admin@example is set, and does that have to be the one to test on?
Quentin Paden (Jul 09 2019 at 18:22):I have been digging into the codebase to try to find more info about the admin account email and main places where the routing is being set. Any tips or hints?
Panda (Gauravjeet Singh) (Jul 10 2019 at 05:33):@Quentin Paden
As told by @pooh (inder) and other mentors, you should aim for updating the log daily. So that we can keep track of your progress.
Regarding your email question:
Yeah, there can only be one admin, and we are creating the user manually from code.
And, also Admin account is being set up in the same file, you were currently working on (accounts.js)
You don't need to go into the routing for this issue.
Here's what you have to do: If the password is not changed in settings.json, you have to use a random password instead of password from settings.json while creating this admin account.
Quentin Paden (Jul 10 2019 at 23:58):I’ve been looking into how the admin email account is created and I’ve been going through trial and error with getting something to work with the main admin account and password, but I think tonight I will be able to submit another commit for
that issue to fix it. I understand what you want me to do, I was mainly just was asking more about the logic in how you
originally set that up that adresss
With the routing, that was referring to the 404 issue.
Quentin Paden (Jul 11 2019 at 03:34):About to commit another PR now for https://github.com/BRL-CAD/OGV-meteor/pull/91/commits/df03ac2d38f1162b0f6f0d4f418922abee9f04ea, testing admin account.js change with a test solution
Quentin Paden (Jul 11 2019 at 06:06):Previously I thought https://docs.meteor.com/api/core.html#Meteor-settings Meteor Settings would work, but the way the Admin is created in the server is not allowing me to change the admin password with that method.
The admin@example.com is actually an account which is set on the MongoDB server and I think it is only created
if (Meteor.users.find().fetch().length === 0) {
Quentin Paden (Jul 11 2019 at 06:08):@Panda (Gauravjeet Singh) The admin account and test account is only created and changed pretty much if no users are found in the server..
I wish I knew that the admin@example.com was already created in the mongo db server
Quentin Paden (Jul 11 2019 at 06:09):This means it's permanent in the server until you delete it. I was under the impression it was like a temporary admin account created for every user with a random password.
Quentin Paden (Jul 11 2019 at 06:09):I have to get the user Id of the admin then user Accounts.setPassword on that userId but I'm having trouble getting the userId logs from the MongoDB server for the admin account to get the UserID
Quentin Paden (Jul 11 2019 at 06:17):@Panda (Gauravjeet Singh)
My previous solution only did not work because admin@example.com is already created and set on the mongoDB server if you create the admin account again through clearing out users, it will be randomized.
https://github.com/BRL-CAD/OGV-meteor/blob/df03ac2d38f1162b0f6f0d4f418922abee9f04ea/imports/startup/server/accounts.js#L68
"If you run meteor without properly writing config.json. Default admin user is created without any password.
We would also like the default admin password be generated randomly and shown in server console rather than your_password_here"
I did the create solution in the last commit, but you tested it with an user which already had it's password set. Clearing out the MongoDB and restarting would create a randomPassword user using my last commit.
Quentin Paden (Jul 11 2019 at 06:19):I could set the password of the user if the adminPassword is "password" using Account.setPassword to prevent you having to clear anything out, but I have to get the userId of the admin from the server. Which I'm doing now. When I do that, I'm just going to plug the admin userId into that function and it will be done.
Quentin Paden (Jul 11 2019 at 06:20):I wish I knew more about this previously.
Quentin Paden (Jul 11 2019 at 07:51):I have fixed the issue finally!
https://github.com/BRL-CAD/OGV-meteor/pull/91/files#diff-85207ec3ffd02327adfb13aec22778a2
The way the issue was worded and obstacles I ran into along the way really misguided me and my initial attempts at solving it even after asking some questions.
Config.json (really settings.json) described in the issue description doesn't really have much to do with the core issue, The main issue consisted of finding a way to get the user Id without knowing the userId at all, finding the admin account and getting the function for setting the password to work to allow the admin to see the randomly generated password each time in dev console to sign in.
What was taking me so long and frustrating me was that it kept telling me incorrect password for the sign in after setting the password multiple ways, but it actually had an extra space at the beggining for the admin password which was confusing me so I fixed that and now everything works
Getting the userId for the admin to set the password or any user when you don't have the userId saved is a bit hard. I had to get the userID from creating logs at a specific place in explore.js when exploring models in the client.
I'm going to put this progress into my dev log now.
I prefer to use Zulip for immediate progress updates, which I why I update my dev log so slow, I really try to share my updates with you, but I will try to update progress consistently on the wiki going forward.
Quentin Paden (Jul 11 2019 at 07:52):https://github.com/BRL-CAD/OGV-meteor/issues/53 can be closed now
Panda (Gauravjeet Singh) (Jul 11 2019 at 20:31):Awesome @Quentin Paden , I will follow up on what u said regarding admin user and get back to you. In the meantime, start with the next issue. I am travelling back to India today, so wont be available for next two days. I will test and merge this PR after I reach home.
Panda (Gauravjeet Singh) (Jul 15 2019 at 04:38):Hey @Quentin Paden , how are you? Which issue were you working on?
You did an awesome job in investigating why admin user wasn't working. Thank you for doing that. Now that, we know the problem, let's work on it step by step.
We just need to add some final touches to step 1, check my review on Github and you will know what needs to be done.
Once step 1 is totally complete, we will move on to the second step. Sounds good?
Panda (Gauravjeet Singh) (Jul 15 2019 at 04:40):Also, I am now in Indian Time Zone (GMT +5:30), so my replies might delay a little. And if you could share your work progress at the end of every day (preferably using wiki), it would make our communications smoother.
Quentin Paden (Jul 15 2019 at 04:45):@Panda (Gauravjeet Singh)
Panda the issue already has a comment for every time you run meteor on line #49. plz let me know if you see that console log.
https://github.com/BRL-CAD/OGV-meteor/commit/b81874c23bc7e7ab691a9ba032cf7397de43f64b
will update wiki.im working on the 404 issue with iron router now and looking at some others if I cant find the right place to edit routing still
Quentin Paden (Jul 15 2019 at 04:45):i already solved the issue on my final commit on the last one I dont see how it needs more improvement
Panda (Gauravjeet Singh) (Jul 15 2019 at 04:45):@Quentin Paden Did you check my review on github?
Quentin Paden (Jul 15 2019 at 04:48):how do you get the database id
Quentin Paden (Jul 15 2019 at 04:48):if you dont have the userId
Quentin Paden (Jul 15 2019 at 04:48):its the same everytime..
Quentin Paden (Jul 15 2019 at 04:48):the database user id is the same
Quentin Paden (Jul 15 2019 at 04:49):@Panda (Gauravjeet Singh) i just checked it
Quentin Paden (Jul 15 2019 at 04:49):and why would you fet eid of the comment
Quentin Paden (Jul 15 2019 at 04:49):*rid of the comment
Quentin Paden (Jul 15 2019 at 04:50):im sorry that code review doesnt make sense
Quentin Paden (Jul 15 2019 at 04:50):im very confused now
Quentin Paden (Jul 15 2019 at 04:51):i get the first review but the second is confusing
Panda (Gauravjeet Singh) (Jul 15 2019 at 04:51):Okay @Quentin Paden , let's work on that together.
Do meteor reset and start your meteor server again.
Panda (Gauravjeet Singh) (Jul 15 2019 at 04:52):When the admin user is created, it will get a different id, which won't be same as what you wrote in code.
Panda (Gauravjeet Singh) (Jul 15 2019 at 04:53):Similarly, if I run meteor on my local computer, the database id of admin user would be different then what you have
Panda (Gauravjeet Singh) (Jul 15 2019 at 04:54):I know this is confusing, that's why I was dividing it into steps. If you totally understood, the first step we can talk about the second step now. Or I can wait until you complete the first review part.
Quentin Paden (Jul 15 2019 at 04:57):ok
Quentin Paden (Jul 15 2019 at 04:57):so
Quentin Paden (Jul 15 2019 at 04:57):the adminPassword is staying “password”
Quentin Paden (Jul 15 2019 at 04:57):when you reset
Quentin Paden (Jul 15 2019 at 04:58):and the user Id changes because of the reset
Panda (Gauravjeet Singh) (Jul 15 2019 at 04:59):Yeah, exactly.
Panda (Gauravjeet Singh) (Jul 15 2019 at 04:59):And also, we don't want to change password everytime we run meteor.
Panda (Gauravjeet Singh) (Jul 15 2019 at 05:00):It's just the first time when admin user is created.
Quentin Paden (Jul 15 2019 at 05:00):thats the easy part
Panda (Gauravjeet Singh) (Jul 15 2019 at 05:00):yeah, and you already did most of it.
Quentin Paden (Jul 15 2019 at 05:00):the hard part is getting the userId set in settings
Quentin Paden (Jul 15 2019 at 05:01):it only able to be saved in settings when you reset meteor
Panda (Gauravjeet Singh) (Jul 15 2019 at 05:01):We don't have to set the user id in settings. There's a better and easier way to do it.
Quentin Paden (Jul 15 2019 at 05:01):you have to save it somewhere permantly to be able to call it and reset it after the inital meteor reset
Panda (Gauravjeet Singh) (Jul 15 2019 at 05:02):Hear me out @Quentin Paden
So, firstly we set the admin password when it's created, using the logic I mentioned in github review
After that, we search for that user using Meteor.users.find() and then get its password in a variable and use console log to print it out.
Panda (Gauravjeet Singh) (Jul 15 2019 at 05:03):To console log the password, we will get it from the database, instead of using the randomPassword variable.
Panda (Gauravjeet Singh) (Jul 15 2019 at 05:03):Makes sense?
Quentin Paden (Jul 15 2019 at 05:04):you have to use the userId to search it in the database
Quentin Paden (Jul 15 2019 at 05:04):its only created when the accounts are created in the database
Panda (Gauravjeet Singh) (Jul 15 2019 at 05:04):No, we can search using email id as well.
Panda (Gauravjeet Singh) (Jul 15 2019 at 05:04):Which we already know.
Quentin Paden (Jul 15 2019 at 05:04):what do you mean you already know?
Quentin Paden (Jul 15 2019 at 05:04): Panda (Gauravjeet Singh) (Jul 15 2019 at 05:05):the email id: admin@example.com
We use the above email id to search for admin user.
Panda (Gauravjeet Singh) (Jul 15 2019 at 05:06):We don't have to set the password to random password every time we run meteor. We set it once (on first time), and just show it on every other run.
Quentin Paden (Jul 15 2019 at 05:14):thanks i understand it way better now much appreciated
Inder Singh (Jul 17 2019 at 04:05):Hi @Quentin Paden you have not updated your daily log, is everything okay?
Also any update on the admin user issue? Do you need further help? Feel free to ask for help. Also, a nice way to go about development is "commit small, commit often". This helps us make sure you are not going on the wrong path. :pray:
Quentin Paden (Jul 17 2019 at 05:42):@pooh Something happened which I will PM you about, I'm going to submit a Commit for the PR redo of the fix for step 1 and step 2 which Panda has layed out for me.
Quentin Paden (Jul 17 2019 at 05:49):My sister is going through serious health issues, so I had to take a few days away but now things are better and i will resume with updates
Inder Singh (Jul 17 2019 at 06:40):@Quentin Paden Thank you for update. Sending all the good wishes for your sister. :pray: Keep us updated.
Quentin Paden (Jul 17 2019 at 22:07):@pooh (inder)
@Panda (Gauravjeet Singh)
Thanks for the help!
Try Out This new Commit in OGV.
https://github.com/BRL-CAD/OGV-meteor/pull/91/commits/85a0c7a82ce1505c9a338e7263ca0c2994ca4553
It makes it easier to log in with the Admin User and Adds more security.
- updating logs today
I tested a solution recommended by you a lot today and I think this commit fixes this issue.
https://github.com/BRL-CAD/OGV-meteor/pull/91/commits/85a0c7a82ce1505c9a338e7263ca0c2994ca4553
Quentin Paden (Jul 17 2019 at 22:10):This new commit should close #53
https://github.com/BRL-CAD/OGV-meteor/issues/53
Quentin Paden (Jul 17 2019 at 22:13):I believe this should also fix #57
https://github.com/BRL-CAD/OGV-meteor/issues/57
Quentin Paden (Jul 17 2019 at 22:16):After reviewing that I would like suggestions on #72, and more info about the current iron-router code
https://github.com/BRL-CAD/OGV-meteor/pull/89
https://github.com/BRL-CAD/OGV-meteor/issues/72
Inder Singh (Jul 18 2019 at 05:58):Hey @Quentin Paden , the random password login is working perfectly, congratulations on that.
However, there's a small problem with this logic, we want to set the random password of the admin user, only when password in settings.json is not changed.
If the password in meteor settings is not changed, set the password to a random password.
Else set the password to what is saved in meteor settings.
I think @Panda (Gauravjeet Singh) has already pointed this out in his code review.
Quentin Paden (Jul 23 2019 at 19:20):DEV LOG:
http://brlcad.org/wiki/User:Quentinpaden
Added logic condition for the password not changing in settings.json (https://github.com/BRL-CAD/OGV-meteor/pull/91/commits/7581208ec78066b7c4b4a05d82d0b6a783d3f9c0)
Would like to close this after a code review,
(https://github.com/BRL-CAD/OGV-meteor/pull/91/commits)
In this same file account.js , I believe I can also fix this issue in another commit later tonight
https://github.com/BRL-CAD/OGV-meteor/issues/57
Inder Singh (Jul 24 2019 at 03:12):@Quentin Paden Great! I will take a look.
Inder Singh (Jul 24 2019 at 05:01):Hey @Quentin Paden, I added my review on Github, let me know if you have any doubts regarding it.
Quentin Paden (Jul 27 2019 at 20:02):thank you for this review, I want to uphold the standards regarding code quality and value that principle very much. I am going to look through this solution to enhance the code quality while also working on finishing a acceptable solution for https://github.com/BRL-CAD/OGV-meteor/issues/57 @pooh (inder)
Quentin Paden (Jul 27 2019 at 20:02):Thank you for the help on everything @Panda (Gauravjeet Singh) @pooh (inder)
Panda (Gauravjeet Singh) (Jul 29 2019 at 12:48):Hey @Quentin Paden , how's it going? I hope everything is alright! Keep us updated with your daily diary.
Quentin Paden (Jul 30 2019 at 18:01):It is going wonderful! My birthday was yesterday and I moved back to the dorms in school. Now that I am moved back in a dorm I am going to update the development log with the work ive done today
Quentin Paden (Jul 30 2019 at 18:01):@Panda (Gauravjeet Singh)
Quentin Paden (Aug 01 2019 at 20:27):submitting the PR accordingly today and updating dev log
Quentin Paden (Aug 01 2019 at 20:28):doing it now, will be submitted now in this hour
Quentin Paden (Aug 01 2019 at 20:57):http://brlcad.org/wiki/User:Quentinpaden
Quentin Paden (Aug 01 2019 at 20:58):i have been working a lot on https://github.com/BRL-CAD/OGV-meteor/issues/57. I believe the account.js file is a part of the solution
Quentin Paden (Aug 01 2019 at 22:23):Formatted a Pull Request for solving the Admin Email Server Error Issue
https://github.com/BRL-CAD/OGV-meteor/pull/89/files#diff-85207ec3ffd02327adfb13aec22778a2
In submitting this PR to fix the Admin Email Server Issue, I added a required settings function (isAdminEmailServerOn) to validator.js, doing this will allow me to check Login.js and Signin.js if the required meteor SMTP email settings have been saved before allowing Logins and Signups into the meteor server for OGV. https://github.com/BRL-CAD/OGV-meteor/issues/57.
Inder Singh (Aug 02 2019 at 04:41):Hey @Quentin Paden, thank you for the PR, I will put up the review on Github.
Just confirming, the last issue you were working on wasn't complete. It needed some work apart from the code quality issues. Let me know if you got my comment on the previous PR I did a while ago: https://github.com/BRL-CAD/OGV-meteor/pull/91#issuecomment-514479875
Inder Singh (Aug 02 2019 at 05:47):@Quentin Paden With your recent PR, I am unable to login. Nothing happens if I click the login/signup button.
I even updated the SMTP settings to my own, it still doesn't work.
Quentin Paden (Aug 02 2019 at 21:41):Thank you for the update
I have now seen the review and comment
i am going to fix yhr previous issue and look further into the smtp issue and look into it again.
Quentin Paden (Aug 03 2019 at 20:06):@pooh (inder) @Panda (Gauravjeet Singh)
DEV LOG:
http://brlcad.org/wiki/User:Quentinpaden
Thank you for the previous feedback, it has been very helpful, and I am excited to help with the visualization of the models in the next issue ahead in https://github.com/BRL-CAD/OGV-meteor/issues/66 after working on the rest of the ongoing bugs in the project board https://github.com/BRL-CAD/OGV-meteor/projects/1
I have done two commits on both ongoing PR's which I would like to be reviewed.
Admin Email Server Error PR https://github.com/BRL-CAD/OGV-meteor/pull/89/commits/6b62bc7e602aa6b0ffece8f94d2a2c4950d1881c
Admin Meteor User Creation Issue https://github.com/BRL-CAD/OGV-meteor/pull/91/commits/06425846802069420e0fe5da42b143e9922d2b4a
Panda (Gauravjeet Singh) (Aug 05 2019 at 05:48):Hey @Quentin Paden ,
In the Admin Email server error, there are few changes related to the admin meteor user creation issue, can you please clean that out.
For Admin meteor user creation issue: I still have to log in with a random password after changing the password in settings.json file (testing it after doing meteor reset). @pooh (inder) already gave some ideas on how to fix that on Github. Have a look.
Quentin Paden (Aug 05 2019 at 11:55):@Panda (Gauravjeet Singh) Thank you for the information, I will go through and test the solution as well as making the proper adjustments
Quentin Paden (Aug 07 2019 at 22:22):Aloha @Panda (Gauravjeet Singh) after testing and reviewing the PR commit review here is a commit for the solution https://github.com/BRL-CAD/OGV-meteor/pull/91/commits/9b28a0d261fff70cf2257b0ce3b6bb7d19f4c74b
Inder Singh (Aug 08 2019 at 06:53):Hey @Quentin Paden , meteor admin user works perfectly now. Good work!
However, there's one little thing, which will make it even more awesome. I commented it on GitHub, let me know if you have any doubts regarding it.
Quentin Paden (Aug 11 2019 at 21:19):awesome im going to fix this and start to work further on the rest of the bugs
Quentin Paden (Aug 12 2019 at 04:12):@pooh (inder)
Thank you for the review, your suggestion was a great addition. Here is the commit for the PR https://github.com/BRL-CAD/OGV-meteor/pull/91/commits/61f7392eb02d72fbc59349d976d14716f78a257f
DEV LOG:
http://brlcad.org/wiki/User:Quentinpaden
I have been researching into these issues so I can make progress on them this week:
No error shown if upload fails
https://github.com/BRL-CAD/OGV-meteor/issues/63
Upload progress
https://github.com/BRL-CAD/OGV-meteor/issues/62
Auto Position 3D Model Upload depending upon object's width/height
https://github.com/BRL-CAD/OGV-meteor/issues/66
Panda (Gauravjeet Singh) (Aug 12 2019 at 06:26):Hey @Quentin Paden I added my review on github for Meteor admin user creation PR.
And before moving on to new issues, can we first clean up the existing issues you were working on. Any update on https://github.com/BRL-CAD/OGV-meteor/pull/89?
Quentin Paden (Aug 12 2019 at 06:36): Quentin Paden (Aug 12 2019 at 06:37):this commit cleaned up the validator.js and fixed the login and signup @Panda (Gauravjeet Singh)
Panda (Gauravjeet Singh) (Aug 12 2019 at 06:44):Will test it out again. Also to avoid code conflicts, please remove all random password related code changes in this PR https://github.com/BRL-CAD/OGV-meteor/pull/89
Inder Singh (Aug 20 2019 at 12:38):@Quentin Paden Hi, good progress on the PRs, we are almost there. :) Thank you for working hard on this.
Can you please update your dev log as well? It has not been updated from 9 days.
Quentin Paden (Aug 20 2019 at 23:42):Yes I am excited to merge those two PR’s after editing some of the commits and removing them
I have been having trouble with deleting the PR Merge from before with command line so I am doing it from github web app now.
Inder Singh (Aug 21 2019 at 06:39):Great, can't wait.
Quentin Paden (Aug 21 2019 at 09:34):http://brlcad.org/wiki/User:Quentinpaden
Moved logic statement in account.js to ensure it works every time Meteor.js server runs
https://github.com/BRL-CAD/OGV-meteor/pull/91/commits/8a2748cbf7f5b472f6d472a175daa97760d34437
Matched solution from patch-1 branch to development branch to prevent conflicts on account.js. Was having trouble with github CLI with redacting the previous commits on files in this PR such as account.js, error.css, and landingPage.html to match the patch-1 branch.
https://github.com/BRL-CAD/OGV-meteor/pull/89/commits/35122fa28f88048e89fea1ff1a517ed50ec3d986
Inder Singh (Aug 21 2019 at 11:31):Hey @Quentin Paden , congratulations on getting your PR merged.
Inder Singh (Aug 21 2019 at 11:33):Closed the issue https://github.com/BRL-CAD/OGV-meteor/issues/53 and merged your pull request https://github.com/BRL-CAD/OGV-meteor/pull/91
Panda (Gauravjeet Singh) (Aug 21 2019 at 15:13):Hey @Quentin Paden , good to see your work finally getting merged.
Regarding this second PR #89, if I look at the files changed tab https://github.com/BRL-CAD/OGV-meteor/pull/89/files, there's still some code changes regarding random password change. Since those changes are not part of this PR, we should not get that.
To fix it, I would suggest pulling the development branch of BRL-CAD's repo into the development branch of your fork. This will update your fork with latest code from BRLCAD repo. Let me know if you still have any doubts regarding it.
Quentin Paden (Aug 25 2019 at 22:22):Is there a way for this to be done through github with cli? im having major troubles finding out where this patch branch is coming from and not my development branch
Quentin Paden (Aug 25 2019 at 23:43):@Panda (Gauravjeet Singh) @pooh (inder) Thank you for all of your help with this. Your reviews were extremely positive and benefitial with guiding me in the right direction.
I would like to still keep contribution and to work on getting the user admin issue merged, and eventually working my way toward helping with other issues in tbe repository
Here is the link for work for GSOC final evaluation which I have submitted
https://scene.gitbook.io/scene/
Daniel Rossberg (May 18 2021 at 16:50):Hi @Amanjot Singh, congratulations to you on getting selected to work with BRL-CAD under the 2021 GSoC! You can use this stream and topic to talk about your project.
Daniel Rossberg (May 18 2021 at 16:54):Unfortunately, the prior developers of OGV aren't available any more. So, I'm your (primary) mentor, even if this is new for me.
Daniel Rossberg (May 18 2021 at 17:02):How was your start with OGV? The references to Meteor and plugins look a bit outdated.
Amanjot Singh (May 18 2021 at 19:04):Hey @Daniel Rossberg thanks. Sure I'll keep the discussion here.
I learned meteor and found it good. Though there are a few things which are better in some new frameworks like React and Vue.
Nevertheless, I'm already taking a walk through of the code and about to complete that.
Amanjot Singh (May 23 2021 at 06:36):Good morning @Daniel Rossberg I hope you doing well. There is a quick update. I've created user page on BRL-CAD for updates. Today I'll update stuff on that page and will let you know.
Amanjot Singh (May 23 2021 at 10:39):I was thinking before we start the development further what about we merge the existing fixes (PR's) opened by others? I think we can get it before the community bonding period ends. It could be beneficial for further development and bug fixing too.
Daniel Rossberg (May 23 2021 at 17:36):In general, for sure! But, I'm still struggling with the app. E.g., I don't get the 404 page when hitting the Edit button (the bug report you write a fix for). In addition, every feature seems to behave wrong, starting with the registration.
Amanjot Singh (May 24 2021 at 07:06):If I talk about reproducing the bug. After I uploaded the model and viewed it. There was an edit button under the model to edit the information related to the project. When we hit that button it shows 404.
Steps to reproduce the bug.
Daniel Rossberg (May 24 2021 at 12:18):Which webbrowser/OS do you use? I'm testing with Firefox and Chromium on Debian stable (buster). However, Chromium doesn't show me the preview after upload. That's why I'm ending up with Firefox. I suppose, you are on the development branch too.
Amanjot Singh (May 24 2021 at 19:29):I'm using Brave browser with Debian stable Linux (Ubuntu). Yes, I'm in the development branch. I can see the preview though it was zoomed out that's why I was also not able to see the model until I zoomed in.
Daniel Rossberg (May 28 2021 at 16:41):I merged your pull request. Shall I merge all requests from the dependabot too?
Amanjot Singh (May 31 2021 at 05:09):Daniel Rossberg said:
I merged your pull request. Shall I merge all requests from the dependabot too?
Yes, I think that would be great. If you say, I can test the existing PR's for some existing bug fixes and you can merge them as well. I know it will consume a lot of time but I think that would be worth it. We still have a week to handle this stuff. Please let me know what do you think about that.
Daniel Rossberg (May 31 2021 at 17:58):Okay, I merged the dependapot's pull requests. What's remaining:
Maybe, you can have a look at these.
Amanjot Singh (Jun 01 2021 at 07:42):okay, I'll see them. For other pull requests, we can merge them after testing.
Daniel Rossberg (Jun 01 2021 at 17:44):After updating meteor to 2.2 and - probably more important - removing the .meteor/local directory, it doesn't crash any more.
Amanjot Singh (Jun 02 2021 at 10:32):okay
Amanjot Singh (Jun 05 2021 at 15:05):I was trying to update the meteor version of the application. Currently, we are using the Meteor version 1.8.0.2 if we say we want to go for 2.0 we have to update 14 versions of meteor.
Amanjot Singh (Jun 05 2021 at 15:07):We have around 1 day and 1 night left before the coding period starts. I think we should go with the upgrading process and get it done though it seems like a bit less time to upgrade and test.
Amanjot Singh (Jun 05 2021 at 15:08):Starting now! Wish me luck :smile:
Amanjot Singh (Jun 05 2021 at 16:38):Update: Updated meteor from 1.8.0.2 to 1.8.2
Amanjot Singh (Jun 05 2021 at 16:46):I've drafted a PR https://github.com/BRL-CAD/OGV-meteor/pull/104
I'll make this ready to review when we'll have all the versions upgraded. Also, I think I should post the updates related to the Meteor Version upgrade in this PR.
Daniel Rossberg (Jun 06 2021 at 14:35):The upgrade of Meteor to version 2.2 took me 3 steps:
meteor updatemeteor update --all-packages Amanjot Singh (Jun 07 2021 at 05:05):@Daniel Rossberg by this way we can't confirm if it is working after every breaking change update. https://docs.meteor.com/changelog.html#breakingchanges-12 They have mentioned all the breaking changes on this page. Nevertheless, is everything running smoothly on your machine after you updated using the above way?
Amanjot Singh (Jun 07 2021 at 06:50):I've also tried the above way and things are running well. I think we were not using things that contain breaking changes with version updates. So that is why it is running well after the direct update.
Daniel Rossberg (Jun 07 2021 at 17:48):I haven't seen any difference after the Meteor update. But, I wouldn't say it runs smoothly, because it hasn't done this before ;) I posted a list of some of the issues here before.
Daniel Rossberg (Jun 07 2021 at 17:52):Anyway, you should update every package to its most recent version possible, and make your own changes upon on them. There is no much sense in fixing old versions.
Amanjot Singh (Jun 08 2021 at 05:59):yeah I agree, I'll update them and today I'll start with the first task in our list.
Amanjot Singh (Jun 10 2021 at 07:04):I was trying to update the meteor and started getting some errors. I think the error is specific to my machine setup. Will update that and send it. Another update I took some break from this error and was looking to solve the issue of no error shown when upload fails.
Amanjot Singh (Jun 10 2021 at 07:06):I also want to give an update about my final exams the date is still not decided for theory exams but my practicals are going to start from tomorrow. Though I don't need to prepare much for them as I'm already prepared still I'll have to revise things a bit. I'll try to complete my working hours this weekend.
Daniel Rossberg (Jun 10 2021 at 11:26):After updates and if you change something by yourself (e.g. the BRL-CAD program locations), don't forget to remove the .meteor/local directory. Otherwise, you may run into issues.
Amanjot Singh (Jun 10 2021 at 15:48):The issues was bcrypt_lib.node: undefined symbol: napi_add_finalizer and related to bcrypt module. I read this stackoverflow question https://stackoverflow.com/questions/29495599/bcrypt-lib-node-undefined-symbol-node-module-register but nothing was actually working. So I reinstalled the meteor on my local machine and updated the project. It went well :)
PS I've turned the PR to ready for review https://github.com/BRL-CAD/OGV-meteor/pull/104 you can now check :thumbs_up:
Daniel Rossberg (Jun 10 2021 at 17:23):Your pull request seems to be okay. But, on first startup it still complains about the babel package, and I need to call meteor npm install --save @babel/runtime. Can there something be done?
Daniel Rossberg (Jun 10 2021 at 17:24):In addition, it complains about a depreciated Buffer() on startup.
Amanjot Singh (Jun 10 2021 at 20:20):Daniel Rossberg said:
Your pull request seems to be okay. But, on first startup it still complains about the babel package, and I need to call
meteor npm install --save @babel/runtime. Can there something be done?
Yes, I tried to see this issue but couldn't find much. I'll still find things related to this tomorrow. I hope there will be some solution for sure :)
Amanjot Singh (Jun 10 2021 at 20:22):Daniel Rossberg said:
In addition, it complains about a depreciated Buffer() on startup.
Yes, I also noticed that and tried to debug the issue. It started popping up on the terminal after I updated the meteor version.
Daniel Rossberg (Jun 11 2021 at 17:41):Amanjot Singh said:
Good morning Daniel Rossberg I hope you doing well. There is a quick update. I've created user page on BRL-CAD for updates. Today I'll update stuff on that page and will let you know.
Are there any updates on this?
Amanjot Singh (Jun 12 2021 at 09:37):Daniel Rossberg said:
Amanjot Singh said:
Good morning Daniel Rossberg I hope you doing well. There is a quick update. I've created user page on BRL-CAD for updates. Today I'll update stuff on that page and will let you know.
Are there any updates on this?
Yes, @Daniel Rossberg I'm writing things in brief and will write about the first week on Sunday. So it is like I'll keep the brief things written down in my notes and turn them into the blog on weekend.
Amanjot Singh (Jun 12 2021 at 15:31):@Daniel Rossberg I was trying to reproduce the issue that is linked with this https://github.com/BRL-CAD/OGV-meteor/issues/63 I tried uploading a file that is .mdl and it gave me an error. I think I need more context on this issue because when I saw the function that was saving the file it already has an error handling function that throws an error if there is any. You can check the function below
ModelFiles.insert(fsFile, err => {
if (err) {
sAlert.error(
"There was some error in uploading your file, please try again/later"
);
} else {
sAlert.success(
"File Uploaded, and will appear in file manager after it's converted"
);
}
});
Therefore, you mean that this issue is not reproducible? This can happen.
BTW, I find it remarkable that Router.go() well be called in case of an error too. Is this reasonable?
Amanjot Singh (Jun 13 2021 at 18:54):Ahh! I see. This is not right. In case of error, it should stay on the same route and show a popup displaying an error message. I've fixed it this way. If think we should go for some other solution for this please LMK.
Amanjot Singh (Jun 15 2021 at 16:32):Update: I am working on email server issue
Amanjot Singh (Jun 15 2021 at 16:35):if I talk about the blog I drafted my first week this Sunday. Need to make some changes and will publish after that.
Daniel Rossberg (Jun 17 2021 at 06:18):Amanjot Singh said:
if I talk about the blog I drafted my first week this Sunday. Need to make some changes and will publish after that.
Can I see it?
Amanjot Singh (Jun 17 2021 at 17:31):Daniel Rossberg said:
Amanjot Singh said:
if I talk about the blog I drafted my first week this Sunday. Need to make some changes and will publish after that.
Can I see it?
Yes sure, I published the community bonding blog you can read it https://dev.to/theamanjs/getting-selected-and-community-bonding-period-in-gsoc-3ik9
Daniel Rossberg (Jun 18 2021 at 07:17):Ah, there it is. Nice post :grinning:
However, Community Bonding is over :wink:
Amanjot Singh (Jun 18 2021 at 08:11):Daniel Rossberg said:
Ah, there it is. Nice post :grinning:
However, Community Bonding is over :wink:
Yeah, I got some format ideas about the first week's post. I'll share that along with the second week this weekend. I hope that will be okay. :smiley:
Amanjot Singh (Jun 20 2021 at 07:43):@Daniel Rossberg I've sent the fix for the email validation fix. There was a PR that was solving this issue, however, this PR was not clear in terms of code. Link to PR https://github.com/BRL-CAD/OGV-meteor/pull/89
Amanjot Singh (Jun 20 2021 at 07:44):Before we move ahead I want to finish the task of linting and code cleaning. It's very hard to work with the code that has linting issues. I'll do this by the end of the day.
Daniel Rossberg (Jun 20 2021 at 17:56):Okay, I'll have a look at your pull requests.
Amanjot Singh (Jun 20 2021 at 19:19):I was seeing the upload progress bar code. There is existing PR for that too but we need to make some changes.
Amanjot Singh (Jun 20 2021 at 19:22):Actually, I cannot add or update code in that PR. https://github.com/BRL-CAD/OGV-meteor/pull/94 I don't have edit access. I was thinking I can cherry-pick the commit from that PR and create new PR. Please suggest what to do with that.
Daniel Rossberg (Jun 21 2021 at 17:31):There shouldn't be much cherry picking: This pull request is one line only. If there has to be something changed, I recommend to handle it similar to the #89: Make an own of it.
Amanjot Singh (Jun 21 2021 at 17:52):Okay sure
Amanjot Singh (Jun 22 2021 at 19:07):Sharing the link to blogs of week 1 and 2.
Week 1 blog: https://dev.to/theamanjs/week-1-of-coding-period-in-gsoc-30l0
Week 2 blog: https://dev.to/theamanjs/week-2-of-coding-period-in-gsoc-k1j
I was learning about some management for the project that will help me to handle things smoothly. I've written about that in the week 2 blog as well. From the next weeks, the blogs will be published exactly the day week ends.
Amanjot Singh (Jun 22 2021 at 19:20):@Daniel Rossberg I was about to create a Trello board to manage the tasks of GSoC but the board of GitHub came to my mind. Can there be any way I can edit this board? https://github.com/BRL-CAD/OGV-meteor/projects/1
Amanjot Singh (Jun 24 2021 at 19:54):@Daniel Rossberg I've updated the PR https://github.com/BRL-CAD/OGV-meteor/pull/108 of upload progress. I tried using the old code but when I was searching for a solution I found a package of Upload Progress bar. Details are given in the comment of the same PR. We can use this Upload progress on other things like when users search for models in Explore etc. It is quite useful.
Amanjot Singh (Jun 24 2021 at 19:57):Tomorrow I'll be setting up Husky to the project.
Amanjot Singh (Jun 24 2021 at 20:32):Adding husky to the project excited me a lot that I couldn't wait till morning :see_no_evil: :stuck_out_tongue:
Amanjot Singh (Jun 24 2021 at 20:33):Link to PR of Adding husky https://github.com/BRL-CAD/OGV-meteor/pull/109
Daniel Rossberg (Jun 25 2021 at 06:36):Okay, I'll review your pull requests.
Regarding having a project on Github: I played a bit with projects in the BRL-CAD organization, but didn't found a solution. Can you create a project in your own fork of the OGV-meteor repository?
Amanjot Singh (Jun 25 2021 at 08:49):Daniel Rossberg said:
Okay, I'll review your pull requests.
Regarding having a project on Github: I played a bit with projects in the BRL-CAD organization, but didn't found a solution. Can you create a project in your own fork of the OGV-meteor repository?
Okay, thanks for checking. I've created a project on my folk :raised_hands: I'll manage that board and will share link here in the channel.
Amanjot Singh (Jun 25 2021 at 21:07):https://github.com/theamanjs/OGV-meteor/projects/1 link to the board where all the cards are kept.
Amanjot Singh (Jun 25 2021 at 21:08):PS I'm working on CFS uploader collection removal
Amanjot Singh (Jun 26 2021 at 12:27):@Daniel Rossberg Something urgent came up. I cannot work today.
Amanjot Singh (Jun 28 2021 at 18:38):https://dev.to/theamanjs/week-3-of-coding-period-in-gsoc-12am week 3 blog is here
Amanjot Singh (Jul 02 2021 at 19:43):Update: @Daniel Rossberg I was working on removing the CFS dependency task and trying to add a new package. Learning and solving the issues I'm facing :smile: Will try to finalize the PR on this weekend. This task is actually a bit longer because the codebase is a lot dependent on the FS collection.
Daniel Rossberg (Jul 05 2021 at 17:43):How is your work going on? Does the new file uploader work as expected?
Amanjot Singh (Jul 05 2021 at 21:44):There are a lot of breaking changes on the front-end, back-end, and database. I'm still working on fixes those issues. I'm wondering what would be the benefit of using the new library. I know the current library (CollectionFS) is outdated but the new library has to be fully integrated and tested. I'm asking this question to better understand the need for this change.
Daniel Rossberg (Jul 06 2021 at 09:46):Which this huge amount of dependencies in OGV, we strongly depend on their maintenance. It's hardly possible for us to track the includes and assess how issues there would effect us. I.e., even if this transition doesn't improvement any OGV feature, it has to be made, because otherwise it isn't advisable to set up a real server with OGV.
Amanjot Singh (Jul 06 2021 at 16:16):Okay, I got that. Firstly I tried to add the new package to the project and tried to achieve functionality similar to CFS. Meanwhile, I was understanding the flow of the backend as well. So that I can make myself aware of possible breaking changes. Both are very different. Anyway, I got stuck in the backend part first. Integrating the new package on the front-end is not a big deal but handling the pub/subs with the CFS framework is a bit different. Now I'm at the place where I can see the files are getting saved in the directory, the file information is getting saved in Mongo collection though there is some information that is not getting updated on the database. Today I will complete the uploading of the obj file, save the information of the file in the mongo collection database and test this thing. If this will work as expected the rest of the features like uploading profile pictures and MTL files uploading would be similar. I hope that won't take much longer.
Daniel Rossberg (Jul 10 2021 at 17:25):Hi @Amanjot Singh, you haven't committed something for a while, and your development log is overdue too. If you feel that you are stuck in replacing the file interface, you should start working on something else. There are enough other issues. Then, with more experience in Meteor development, you can tackle the file system stuff again.
In addition, keep writing on your development log, to remind yourself (beside others) on your achievements.
Amanjot Singh (Jul 10 2021 at 19:39):Yes, @Daniel Rossberg I'm doing the same way. Actually, due to that FS task i couldn't commit much. I've shifted to new task of writing tests. I'm trying to create some tests and will commit them today.
Amanjot Singh (Jul 10 2021 at 19:40):I'm writing my development log in weekly blogs.
Amanjot Singh (Jul 11 2021 at 08:13):Update: I've wrapped and committed the WIP code of new backend and frontend of obj files uploading.
Amanjot Singh (Jul 11 2021 at 08:14):While I'm getting more information about tests. I would like to complete this task first.
Amanjot Singh (Jul 11 2021 at 09:07):https://github.com/BRL-CAD/OGV-meteor/pull/111 Here I've splitted the CSS files. I'll add SCSS to the project then this can be merged.
Daniel Rossberg (Jul 11 2021 at 12:24):Amanjot Singh said:
I'm writing my development log in weekly blogs.
I know, but your last one was 13 days ago.
Amanjot Singh (Jul 11 2021 at 17:41):Yes, I've moved further now and will complete other things now. I've also committed the code that I was working on in those days.
Amanjot Singh (Jul 11 2021 at 17:42):Setting up SCSS is the new ongoing task
Amanjot Singh (Jul 11 2021 at 18:30):Amanjot Singh said:
https://github.com/BRL-CAD/OGV-meteor/pull/111 Here I've splitted the CSS files. I'll add SCSS to the project then this can be merged.
Completed this PR by:
However, I think CSS could be refactored as well. But doing the all in the same PR would make clutter and I think that should not be preferred. I've written that in my project board and will refactor CSS and use mixins and variables wherever I can use them. This could be treated as low priority task for now.
Amanjot Singh (Jul 11 2021 at 18:33):Before I move ahead, I would like to change the directory structure that will make the files more manageable and easy to work on.
Amanjot Singh (Jul 11 2021 at 19:33):https://github.com/BRL-CAD/OGV-meteor/pull/112 link to new directory structure PR
Amanjot Singh (Jul 11 2021 at 19:34):I'll complete this by tomorrow afternoon. Wrapping up for today.
Amanjot Singh (Jul 12 2021 at 17:44):I've completed the PR https://github.com/BRL-CAD/OGV-meteor/pull/112 of new directory structure
Daniel Rossberg (Jul 12 2021 at 17:50):Thanks Amanjot! Unfortunately, I can test these PRs not earlier than Wednesday. Which should I do first? Do they depend on each other?
Amanjot Singh (Jul 12 2021 at 18:45):It's alright, please take your time. I would say the SCSS PR could be reviewed first as I would need this PR to work further. Then you can move to Directory structure PR.
Amanjot Singh (Jul 12 2021 at 18:46):The Directory structure branch was derived from SCSS PR.
Amanjot Singh (Jul 12 2021 at 18:50):I've also tagged you in a PR you can treat this one on the least priority as I have already tested this.
PS Other than the tasks I defined in my proposal I've added more issues of the project in the project board. Will keep fixing them alongside.
Amanjot Singh (Jul 13 2021 at 20:39):https://github.com/BRL-CAD/OGV-meteor/issues/73 We need a few more description words on this. I'm not able to understand this issue exactly.
Amanjot Singh (Jul 13 2021 at 20:46):Next task working on is https://github.com/BRL-CAD/OGV-meteor/issues/67
Amanjot Singh (Jul 14 2021 at 21:50):I explored about canvas today. I'm now thinking about creating a pallete and also giving option to fill color of their choice using rgb or hex value.
Amanjot Singh (Jul 14 2021 at 21:50):Also tried experiment with canvas in code. Will commit work tomorrow turned off machine and forgot to push code.
Amanjot Singh (Jul 15 2021 at 19:33):I was working with setting up a custom background color for canvas and I realize we do have shortcuts in the project to change the camera view i.e top, bottom, etc. I think we should have written those shortcuts somewhere or create buttons explicitly for that functionality. :thinking:
Amanjot Singh (Jul 15 2021 at 19:45):(deleted)
Amanjot Singh (Jul 15 2021 at 20:02):oh it shows deleted :stuck_out_tongue: I don't want to let anyone see that I deleted something :joy:
Anyways the deleted message was: It would help the mobile users to handle the camera angle as they won't be able to use shortcuts from the phone.
Amanjot Singh (Jul 15 2021 at 20:03):I deleted that because it came to my mind mobile users can easily change the camera view using by dragging the camera position.
Amanjot Singh (Jul 16 2021 at 21:06):https://github.com/BRL-CAD/OGV-meteor/pull/113 I have updated the PR
Amanjot Singh (Jul 16 2021 at 21:07):Having some troubles with refreshing the canvas after I update the background color. I'm researching about that and the required output is getting generated there.
Amanjot Singh (Jul 16 2021 at 21:07):Or I can say there is a known issue that I mentioned in PR comment
Amanjot Singh (Jul 19 2021 at 16:33):Started working on this https://github.com/BRL-CAD/OGV-meteor/issues/59
Daniel Rossberg (Jul 20 2021 at 17:37):Amanjot Singh said:
Having some troubles with refreshing the canvas after I update the background color. I'm researching about that and the required output is getting generated there.
OK, I just came around it. Is there any chance to fix it?
Daniel Rossberg (Jul 20 2021 at 17:51):A render(); at the end of "change #viewer-bg-color": function(e) should do it(?)
Amanjot Singh (Jul 20 2021 at 18:06):Daniel Rossberg said:
Amanjot Singh said:
Having some troubles with refreshing the canvas after I update the background color. I'm researching about that and the required output is getting generated there.
OK, I just came around it. Is there any chance to fix it?
Yes, It fixed the issue :) Can you please share the link of solution or documentation where you found this? I really want to see that.
Amanjot Singh (Jul 20 2021 at 18:08):Just want to see if there is any side effect of rendering the whole scene (especially when the model will be of large size)
Amanjot Singh (Jul 20 2021 at 18:19):When I was digging for the answer I found the solution with animate() it actually creates a loop with the number of times the screen gets refresh. Basically, works similar to setting screen refresh with javascript setInterval
Amanjot Singh (Jul 20 2021 at 18:21):Though I guess, we should go for render as it only updates the view.
Amanjot Singh (Jul 21 2021 at 20:07):Update: I'm looking into Mediawiki oAuth docs.
Amanjot Singh (Jul 22 2021 at 08:50):@Daniel Rossberg I need some clarity on this task. Are we supposed to create MediaWiki extension https://www.mediawiki.org/wiki/Manual:Developing_extensions?
Amanjot Singh (Jul 22 2021 at 08:51):Though I am not working on this above task and working on this one first https://github.com/BRL-CAD/OGV-meteor/issues/59.
Daniel Rossberg (Jul 22 2021 at 10:30):Amanjot Singh said:
Daniel Rossberg I need some clarity on this task. Are we supposed to create MediaWiki extension https://www.mediawiki.org/wiki/Manual:Developing_extensions?
Yes, this was the idea. The goal was to enable MediaWiki to display and manage 3D CAD Data, like e.g. images.
I'm however in doubt, if it makes sense to compete with e.g. https://www.khronos.org/gltf/.
Daniel Rossberg (Jul 22 2021 at 10:44):Amanjot Singh said:
Though I am not working on this above task and working on this one first https://github.com/BRL-CAD/OGV-meteor/issues/59.
Although I'm not convinced of the reasonableness of a MediaWiki plugin, the ability to use alien user accounts would be a desirable feature (e.g. the BRL-CAD website MediaWiki logins).
Amanjot Singh (Jul 22 2021 at 11:49):Daniel Rossberg said:
Amanjot Singh said:
Though I am not working on this above task and working on this one first https://github.com/BRL-CAD/OGV-meteor/issues/59.
Although I'm not convinced of the reasonableness of a MediaWiki plugin, the ability to use alien user accounts would be a desirable feature (e.g. the BRL-CAD website MediaWiki logins).
Okay, I got it. Working on this.
Amanjot Singh (Jul 22 2021 at 11:50):Daniel Rossberg said:
Amanjot Singh said:
Daniel Rossberg I need some clarity on this task. Are we supposed to create MediaWiki extension https://www.mediawiki.org/wiki/Manual:Developing_extensions?
Yes, this was the idea. The goal was to enable MediaWiki to display and manage 3D CAD Data, like e.g. images.
I'm however in doubt, if it makes sense to compete with e.g. https://www.khronos.org/gltf/.
I'll see this service today when I'll be free from coding. Though I think I should not think about this task RN.
Sean (Jul 23 2021 at 05:50):When OGV started, there were not any 3D options for displaying content on mediawiki/wikipedia. We talked with them and they were very much interested in the possibility of having 3D content supported via a plugin (e.g. on wikipedia itself) we would develop.
Alas, we didn't move fast enough, and now there are options like Extension:3D and Extension:3DAlloy. There is still room for an extension, but it would have to do more or be better than at least those two in some way (e.g., supporting more geometry types or nurbs or step or ...etc.)
Amanjot Singh (Jul 23 2021 at 16:22):Sean said:
When OGV started, there were not any 3D options for displaying content on mediawiki/wikipedia. We talked with them and they were very much interested in the possibility of having 3D content supported via a plugin (e.g. on wikipedia itself) we would develop.
Alas, we didn't move fast enough, and now there are options like Extension:3D and Extension:3DAlloy. There is still room for an extension, but it would have to do more or be better than at least those two in some way (e.g., supporting more geometry types or nurbs or step or ...etc.)
I see. Will try those extensions and see how it goes. Thanks for letting me know :)
Amanjot Singh (Jul 24 2021 at 04:27):Good morning @Daniel Rossberg I'm not feeling well today. I might not be able to work. I'll try if I can work at evening. Update about the task is. I've added the front-end component for oAuth with mediawiki. Will push the code today.
PS I also tried CFS removal task yesterday and the files are now getting uploaded (obj) will push the code for this one as well at evening.
Amanjot Singh (Jul 24 2021 at 16:44):Still not well. Might not work at night.
Daniel Rossberg (Jul 24 2021 at 16:58):Get well soon!
Amanjot Singh (Jul 28 2021 at 06:43):I am feeling better and will continue work today. :innocent:
Daniel Rossberg (Jul 28 2021 at 08:22):Good to hear that you are feeling better today :smiley:
You have to go a bit easy fore some days, for sure. But, a bit coding could help you to bring yourself back to live.
Amanjot Singh (Jul 28 2021 at 17:17):Yes, I hope the same :) I thought I will continue today and tried but the headache wasn't in control. :pray:
Amanjot Singh (Jul 30 2021 at 16:21):Working on oAuth of MediaWiki
Amanjot Singh (Jul 30 2021 at 16:21):will push all code today
Amanjot Singh (Jul 31 2021 at 12:57):Since we made mail server setup compulsory. OGV prevents the users from login if the mail server is not set up. This information is not given in the README file.
Amanjot Singh (Jul 31 2021 at 14:05):Taking a break of 1 hour. Will continue after that.
Daniel Rossberg (Jul 31 2021 at 17:15):Amanjot Singh said:
Since we made mail server setup compulsory. OGV prevents the users from login if the mail server is not set up. This information is not given in the README file.
The README.md doesn't mention the setting of the correct path to the BRL-CAD commands in imports/startup/server/fixtures.js as well. Maybe, this setting should be moved to settings.json in the root directory too?
Amanjot Singh (Aug 02 2021 at 05:12):Yes, I'll see how can I take those settings to root and fix that as well. I'll fix that in Improve readme PR as I think it is very much related.
Amanjot Singh (Aug 03 2021 at 18:19):Update: To understand things properly, after struggling with oAuth. I've set up a new meteor application and trying to implement OAuth in that. I used to try this way to avoid the complexity of the project and to have a better understanding of things.
Amanjot Singh (Aug 03 2021 at 18:20):PS: Will release all pending dev log blogs tomorrow.
Amanjot Singh (Aug 06 2021 at 06:15):Update: I registered a dummy application on MediaWiki for OAuth purposes. I have a good hope of completing this OAuth task by the end of tomorrow. I've been experimenting with this on local.
Daniel Rossberg (Aug 06 2021 at 16:12):dependabot wants me to update tar from version 4.4.13 to 4.4.15. Is this okay for you?
Amanjot Singh (Aug 06 2021 at 18:05):Yeah, that's totally okay for me.
Amanjot Singh (Aug 08 2021 at 10:18):While I was working with improving docs. I noticed there are some changes required in the install scripts as well. I'll update the comments and scripts as well.
Amanjot Singh (Aug 10 2021 at 21:53):I was thinking I should divide some work to make all PRs ready to review. As I'm getting confused maybe because I have started multiple tasks at once. I'll spend some time prioritizing things and manage the pending tasks. I hope dividing tasks can help me better improving and handle things.
Daniel Rossberg (Aug 11 2021 at 19:16):That's probably a good idea.
Amanjot Singh (Aug 13 2021 at 21:14):Hey, @Daniel Rossberg I'm stuck in the OAuth part of MediaWiki. I tried Wikimedia oAuth in a simple new JavaScript application and I got stuck in /oauth/authorize that's the authorization route. Somehow, I managed to fix issues with it and the application got redirected to MediaWiki for login.
After entering the credentials it shows the error Client authentication failed (e.g., unknown client, no client authentication included, or unsupported authentication method) I tried searching for a solution to the issue. Unfortunately, I didn't find any. I found one link on the official platform https://www.mediawiki.org/wiki/Topic:Vmwiwu073xo33eh5 even this link doesn't have the solution.
I tried implementing oAuth with GitHub in a new JS application and it worked super smooth. I also have the code on Github and I can show you. I'm not sure why it is not working with MediaWiki. I need your help/suggestion with this issue. I have tried all the possible things I could do.
Daniel Rossberg (Aug 14 2021 at 08:13):Could the error message mean that the authentication on the MediaWiki side failed?
Amanjot Singh (Aug 14 2021 at 09:38):Yes, it's possible.
Amanjot Singh (Aug 17 2021 at 21:38):I added the feature of changing the camera positions with buttons from front end which solves https://github.com/BRL-CAD/OGV-meteor/issues/117
Amanjot Singh (Aug 26 2021 at 11:05):Hey, @Daniel Rossberg @Sean I'm thinking of porting OGV to Node and React. It was hard to maintain and work with Meteor.js. Most of the Meteor packages are now deprecated or about to deprecate. I already talked with Daniel about this. I think it will be hard for us to maintain the project with meteor. We will face issues while adding new features as well.
This all came to my mind when I was working on the task of replacing CFS dependency. It required a total rewrite of frontend, backend, and database collections. I think instead of a rewrite, we should start planning about porting the application in node. This is a suggestion, please let me know what you think of this? If you think we should migrate OGV to some other technologies I'll still be up for it.
Daniel Rossberg (Aug 26 2021 at 12:00):This sounds very reasonable to me. I suppose that the React community is larger than the one of Meteor. This gives better guarantees for the future. I'm supportive of this plan.
How would this work? Do you create an OGV-react repository on your Github site, which can be moved to BRL-CAD later?
Amanjot Singh (Aug 26 2021 at 16:15):Daniel Rossberg said:
This sounds very reasonable to me. I suppose that the React community is larger than the one of Meteor. This gives better guarantees for the future. I'm supportive of this plan.
How would this work? Do you create an OGV-react repository on your Github site, which can be moved to BRL-CAD later?
I have no issues working on the fork as well. I just have to compromise with my git graph showing no activity :P You can let me know which method suits you best. Though I think the backend and frontend repos should be different. That means if you can create repo for these two I'll fork and work on them
Amanjot Singh (Aug 26 2021 at 16:56):PS: I have good experience in front-end but I have not worked much in the backend. So I'm going to learn backend things before we start working on it.
Sean (Sep 01 2021 at 12:41):@Amanjot Singh I think that sounds like a perfectly reasonable plan, especially if you're willing to do it! As for where it happens, what is your preference?
Sean (Sep 01 2021 at 15:22):I think what daniel was suggesting is that you create the repos, and then they can be transferred to the BRL-CAD project later. Alternatively, we can create the repo and add you to the project. What works best for you?
Amanjot Singh (Sep 02 2021 at 04:42):I'm good with both. But I think if I'll create repos and transfer them to BRL-CAD I'll be able to save some time of yours.
Amanjot Singh (Sep 02 2021 at 04:43):Sean said:
Amanjot Singh I think that sounds like a perfectly reasonable plan, especially if you're willing to do it! As for where it happens, what is your preference?
Yes, I've started learning to create a backend with node. I already have an idea of how it works but I think I should learn that a bit more before I start working on that.
Amanjot Singh (Sep 02 2021 at 04:44):I think the MVP of the project should be creating a back-end with all the APIs of the existing application. We should keep the backend ahead, so we will complete the backend stuff first. For the frontend, React sounds best to me.
Daniel Rossberg (Sep 06 2021 at 17:04):Amanjot Singh said:
I'm good with both. But I think if I'll create repos and transfer them to BRL-CAD I'll be able to save some time of yours.
I think that it's practical if you have full control of the repository, at least for the beginning. For example, I removed some of my Github repositories and recreated them, because I thought they need a fresh start.
Later on, we can move the repository to the BRL-CAD account and add you to the project. This way, you can carry on with your development at your own speed.
Amanjot Singh (Sep 06 2021 at 17:34):Daniel Rossberg said:
Amanjot Singh said:
I'm good with both. But I think if I'll create repos and transfer them to BRL-CAD I'll be able to save some time of yours.
I think that it's practical if you have full control of the repository, at least for the beginning. For example, I removed some of my Github repositories and recreated them, because I thought they need a fresh start.
Later on, we can move the repository to the BRL-CAD account and add you to the project. This way, you can carry on with your development at your own speed.
Yes, I'll create them on my end first then transfer them to BRL-CAD.
Update: I'm learning node and probably in a month and a half I'll be able to create the application. Nevertheless, I'll start by creating the boilerplate and some basic development alongside.
Amanjot Singh (Sep 15 2021 at 16:07):Hey, @Daniel Rossberg,
I want to tell you that my college now reopens and I have to spend some time on classes and I'm able to spend very little time learning and working on new stuff.
Daniel Rossberg (Sep 16 2021 at 17:53):That's understood. College should be your main priority.
Sean (Sep 17 2021 at 04:56):Amanjot Singh said:
I want to tell you that my college now reopens and I have to spend some time on classes and I'm able to spend very little time learning and working on new stuff.
Agreed, college is definitely your priority. Perhaps you can incorporate OGV into some homework assignments or class projects later in the semester. ;)
Amanjot Singh (Sep 17 2021 at 07:01):Sean said:
Amanjot Singh said:
I want to tell you that my college now reopens and I have to spend some time on classes and I'm able to spend very little time learning and working on new stuff.
Agreed, college is definitely your priority. Perhaps you can incorporate OGV into some homework assignments or class projects later in the semester. ;)
Yeah :hearts: I have plans to work on OGV in my major project. Once I get approval from college I'll have more time to spend on OGV :grinning_face_with_smiling_eyes:
Amanjot Singh (Feb 14 2022 at 19:19):Hey @Sean @Daniel Rossberg sharing my personal interest to be a mentor this year here in OGV. I've already started creating plan for OGV with enw rewrite. I would love to do it this year. Though I shared my this interest with you in DM I'm mentioning here in public channel as well. :raised_hands: Looking forward to work on this :hearts:️
@Sean theamanjs@gmail.com is my email.
Amanjot Singh (Feb 16 2022 at 19:20):@Sean @Daniel Rossberg Will share the road map for the OGV kanban board in a day or two. I hope that works.
Daniel Rossberg (Mar 06 2023 at 17:35):@VR Shyam Sunder, what kind of issue do you face with the mail server settings? I used dummy settings only, e.g. "username": "abcd".
Daniel Rossberg (Mar 06 2023 at 17:49):Regarding the proposal: Include everything you want to do in your project. This may include fixing existing issues, but features, that have a higher priority for you, too.
Daniel Rossberg (Mar 06 2023 at 17:51):BTW, the last (really) active developer was @Amanjot Singh. @Divyanshu Garg contributed some code too.
VR Shyam Sunder (Mar 07 2023 at 16:50):Im greeted with "Cannot connect to Email Server. Please contact Admin. If you are Admin please setup Email server." when I try to signup, Im a bit lost, the instructions on the readme of the repo says to "Move config.example.json to config.json and write admin password there." But I cant find either files, a helping hand in setting up is much appreciated.
Daniel Rossberg (Mar 07 2023 at 17:10):My settings.json is:
{
"adminPassword": "password",
"private": {},
"public": {
"smtp": {
"username": "abcd",
"password": "efgh",
"server": "ij.kl",
"port": 8686
},
"general": {
"sender": "mnop"
},
"fixtures": {
"settingSwitch": true,
"siteName": "Online Geomtry Viewer",
"mailUrl": "https://username:password@example.com",
"gobjPath": "/home/brlcad/bin/brlcad/bin/g-obj",
"mgedPath": "/home/brlcad/bin/brlcad/bin/mged",
"landingPageModel": "axis.obj"
}
}
}
However, you need a standard BRL-CAD installation (in the above example in /home/brlcad/bin/brlcad) to run OGV.
Daniel Rossberg (Mar 07 2023 at 17:14):If I remember correctly, the real admin password will be generated at the first run and printed to the terminal where you typed the npm run start.
Daniel Rossberg (Mar 07 2023 at 17:17):The line regarding config.json is probably outdated.
VR Shyam Sunder (Mar 07 2023 at 20:35):Thank you very much, I am now able to run the app locally, I have explored it for a while now, and noticed that uploading a .g file raises an error, I was wondering if its an issue with my setup, I also looked into the issues, there is a requirement to remove the CFS dependency, not sure but this could also be why I'm not able to upload models.
VR Shyam Sunder (Mar 07 2023 at 20:46):I'd like to focus on
Making OGV Responsive
making all ui elements look good on a wide range of screen sizes
I have observed, for starters, that the navbar is not responsive,
I will have to populate all the ui elements and actually see them rendered on the screen to see where fixes are needed
UX improvements
adding labels to models
these labels can be used for search and can be used for filtering newsfeed
Fixing the uploads issue by working on Removing the CFS dependency
I still have to figure this out, Ive seen that some work has been done on this front, would like to discuss with contributes where further work is needed
VR Shyam Sunder (Mar 07 2023 at 20:56):Ill keep editing this message to gradually detail the working points on my proposal for GSOC, meanwhile I appreciate your inputs and insights
Amanjot Singh (Mar 08 2023 at 02:25):@VR Shyam Sunder you should be able to upload the models even if the dependence is deprecated. Are you now using the config shared by Daniel? Also can you check if there's any error on console (browser dev tool)?
VR Shyam Sunder (Mar 14 2023 at 05:41):Sorry for the delay, I have a few mid-semester exams right now, was a bit occupied.
@Amanjot Singh Im getting this error on the terminal-
I20230314-11:08:00.251(5.5)? Exception in callback of async function: Error: Command failed: /usr/brlcad/dev-7.24.2/bin/mged -c /home/shyam/OGV-meteor/.meteor/local/cfs/files/modelFiles/modelFiles-BTNwn6n5S8QpCHwM7-pipe_keep.g ls -a 2>&1
I20230314-11:08:00.251(5.5)? at checkExecSyncError (child_process.js:635:11)
I20230314-11:08:00.252(5.5)? at execSync (child_process.js:671:15)
I20230314-11:08:00.252(5.5)? at execSyncUtf (imports/startup/server/cfs_uploader.js:131:24)
I20230314-11:08:00.252(5.5)? at convertG (imports/startup/server/cfs_uploader.js:142:19)
I20230314-11:08:00.252(5.5)? at imports/startup/server/cfs_uploader.js:78:46
I20230314-11:08:00.252(5.5)? at runWithEnvironment (packages/meteor.js:1286:24) {
I20230314-11:08:00.252(5.5)? status: 127,
I20230314-11:08:00.252(5.5)? signal: null,
I20230314-11:08:00.253(5.5)? output: [
I20230314-11:08:00.253(5.5)? null,
I20230314-11:08:00.253(5.5)? '/bin/sh: 1: /usr/brlcad/dev-7.24.2/bin/mged: not found\n',
I20230314-11:08:00.253(5.5)? ''
I20230314-11:08:00.253(5.5)? ],
I20230314-11:08:00.253(5.5)? pid: 9100,
I20230314-11:08:00.253(5.5)? stdout: '/bin/sh: 1: /usr/brlcad/dev-7.24.2/bin/mged: not found\n',
I20230314-11:08:00.254(5.5)? stderr: ''
I20230314-11:08:00.254(5.5)? }
VR Shyam Sunder (Mar 14 2023 at 05:52):I have a standard BRL-CAD installation at /home/BRL-CAD, and I have also set the path in the settings.json file. But it still seems to look for the installation at /usr/brlcad/dev-7.24.2/bin
Daniel Rossberg (Mar 14 2023 at 05:54):You may need to clean the cache (haven't the directory to hand) and rebuild the application.
Sean (Mar 14 2023 at 05:59):Yeah, @VR Shyam Sunder that seems like possibly a cache issue. You could search for /usr/brlcad/dev-7.24.2 in the files to be sure a reference isn't embedded too. That said, that's an ancient version of BRL-CAD too. One easy task could be to update that to 7.34 to get it working with the latest version.
VR Shyam Sunder (Mar 14 2023 at 07:45):Yes! I am finally able to upload and view models, thank you very much!
VR Shyam Sunder (Mar 14 2023 at 08:03):I was thinking if I could also work on improving the UI, in terms of the looks and feels that modern social media apps have. @Sean @Daniel Rossberg @Amanjot Singh If you think its a good way forward I am thinking of building a case for how we can improve the UI.
This will require me to look at current trends and best practices in UI/UX and build a figma prototype to visualize the envisioned improvements.
Daniel Rossberg (Mar 14 2023 at 12:08):Sure, you can improve the UI. But, keep in mind that it should be easy to maintain. The developers will probably keep changing, and it should be easy to jump in.
Mohamed Adel (Mar 14 2023 at 13:43):Hi, My name is Mohamed Adel, a computer science student. I'm looking to partitcipate in GSoC this year and I was searching for a good organization I'm interested in and I found BRL-CAD, I'm studying computer graphics with OpenGL this semester and I really liked it, and I liked that BRL-CAD depending on computer graphics. so can someone tell me where to start? like by cloning and building the project and start to play with the code
Amanjot Singh (Mar 14 2023 at 17:44):@VR Shyam Sunder I was a little busy somewhere. Have you had a look at existing issues that needs attention?
Amanjot Singh (Mar 14 2023 at 17:49):Mohamed Adel said:
Hi, My name is Mohamed Adel, a computer science student. I'm looking to partitcipate in GSoC this year and I was searching for a good organization I'm interested in and I found BRL-CAD, I'm studying computer graphics with OpenGL this semester and I really liked it, and I liked that BRL-CAD depending on computer graphics. so can someone tell me where to start? like by cloning and building the project and start to play with the code
Welcome here @Mohamed Adel :tada: I hope you will enjoy contributing and learning with BRL-CAD. Thank you for showing your interest in development. This thread is mainly about the OGV (online cad based software) If you want to contribute specifically to this software you are at the right place and you can go through the above chat.
VR Shyam Sunder (Mar 20 2023 at 11:22):Im very sorry for the delay again, the midterms were hectic, yes @Amanjot Singh , Im working on #73, trying to get search by label, although Im a bit in the early stages, will keep updating you on the progress now that the midterms are over
Amanjot Singh (Mar 20 2023 at 12:00):Sure @VR Shyam Sunder keep me updated when you work on that
Amanjot Singh (Mar 27 2023 at 04:27):@VR Shyam Sunder any update on this?
VR Shyam Sunder (Mar 28 2023 at 06:06):@Amanjot Singh I am able to filter the search result by categories by modifying ModelSearch while testing my work on my local pc I am getting "iron:router\n No route definitions found", its strange since I didnt modify any routes or the main.js file, I am currently figuring out how I can get it back running. Any help regarding this will be very helpful.
VR Shyam Sunder (Mar 28 2023 at 06:10):And this issue isn't isolated to my branch, it persists with the development branch too
VR Shyam Sunder (Mar 28 2023 at 06:34):[[[[[ ~/OGV-meteor ]]]]]
=> Started proxy.
=> Meteor 2.11.0 is available. Update this project with 'meteor update'.
=> Started MongoDB.
I20230328-12:02:08.911(5.5)? Initial Users Have Already Been Created.
W20230328-12:02:08.942(5.5)? (STDERR) /home/shyam/.meteor/packages/promise/.0.11.2.11rgw49.1224g++os+web.browser+web.browser.legacy+web.cordova/npm/node_modules/meteor-promise/promise_server.js:218
W20230328-12:02:08.943(5.5)? (STDERR) throw error;
W20230328-12:02:08.943(5.5)? (STDERR) ^
W20230328-12:02:08.943(5.5)? (STDERR)
W20230328-12:02:08.943(5.5)? (STDERR) TypeError: Cannot read property 'algorithm' of undefined
W20230328-12:02:08.943(5.5)? (STDERR) at getPasswordString (packages/accounts-password/password_server.js:39:18)
W20230328-12:02:08.943(5.5)? (STDERR) at hashPassword (packages/accounts-password/password_server.js:54:14)
W20230328-12:02:08.943(5.5)? (STDERR) at AccountsServer.Accounts.setPassword (packages/accounts-password/password_server.js:565:40)
W20230328-12:02:08.944(5.5)? (STDERR) at module (imports/startup/server/accounts.js:115:12)
W20230328-12:02:08.944(5.5)? (STDERR) at fileEvaluate (packages/modules-runtime.js:336:7)
W20230328-12:02:08.944(5.5)? (STDERR) at Module.require (packages/modules-runtime.js:238:14)
W20230328-12:02:08.944(5.5)? (STDERR) at Module.moduleLink [as link] (/home/shyam/.meteor/packages/modules/.0.16.0.ndp1vm.omt9++os+web.browser+web.browser.legacy+web.cordova/npm/node_modules/reify/lib/runtime/index.js:52:22)
W20230328-12:02:08.944(5.5)? (STDERR) at module (server/main.js:1:8)
W20230328-12:02:08.944(5.5)? (STDERR) at fileEvaluate (packages/modules-runtime.js:336:7)
W20230328-12:02:08.944(5.5)? (STDERR) at Module.require (packages/modules-runtime.js:238:14)
W20230328-12:02:08.945(5.5)? (STDERR) at require (packages/modules-runtime.js:258:21)
W20230328-12:02:08.945(5.5)? (STDERR) at /home/shyam/OGV-meteor/.meteor/local/build/programs/server/app/app.js:1437:1
W20230328-12:02:08.945(5.5)? (STDERR) at /home/shyam/OGV-meteor/.meteor/local/build/programs/server/boot.js:401:38
W20230328-12:02:08.945(5.5)? (STDERR) at Array.forEach (<anonymous>)
W20230328-12:02:08.945(5.5)? (STDERR) at /home/shyam/OGV-meteor/.meteor/local/build/programs/server/boot.js:226:21
W20230328-12:02:08.945(5.5)? (STDERR) at /home/shyam/OGV-meteor/.meteor/local/build/programs/server/boot.js:464:7
=> Exited with code: 1
=> Your application is crashing. Waiting for file change.
Here is the console log
Daniel Rossberg (Mar 28 2023 at 16:48):Did you cleared the cache after your changes?
VR Shyam Sunder (Mar 30 2023 at 12:13):Yes, Ive cleared the cache as well, the issue still persists
VR Shyam Sunder (Mar 30 2023 at 12:14):Btw, by clearing cache you mean .meteor/local/bundler-cache?
Amanjot Singh (Mar 31 2023 at 03:46):Did you make any changes in the code?
VR Shyam Sunder (Mar 31 2023 at 07:41):yes, I was working on the search-by-label issue#73 when this happened
Amanjot Singh (Apr 01 2023 at 02:39):VR Shyam Sunder said:
Btw, by clearing cache you mean .meteor/local/bundler-cache?
Yes deleting the .meteor folder
Amanjot Singh (Apr 01 2023 at 02:43):If that doesn't work. Give a link to the PR that contains your changes.
Vidit Jain (Mar 27 2024 at 06:31):@Sean , I was going through the issues and found out this one, I have almost set it up locally but I don't know how to setup email server, can you help me with that? I am on linux.
Vidit Jain (Mar 27 2024 at 06:32):what all should I fill in settings.json?
Vidit Jain (Mar 27 2024 at 06:33):@Amanjot Singh if you can help
Notification Bot (Mar 27 2024 at 06:37):3 messages were moved here from #Google Summer of Code > Video meeting for GSoC candidates by Sean.
Sean (Mar 27 2024 at 06:39):@Vidit Jain I'm not as familiar with OGV's setup requirements, particularly w.r.t. setting up an email server. That's general linux administration for which there are many many approaches and systems that can work. If you can't find resources online, hopefully one of the other mentors can help you through it.
Vidit Jain (Mar 27 2024 at 07:48):Vidit Jain said:
Sean , I was going through the issues and found out this one, I have almost set it up locally but I don't know how to setup email server, can you help me with that? I am on linux.
@Daniel Rossberg if you can help?
Daniel Rossberg (Mar 27 2024 at 07:58):You don't have to setup your own email server, just fill in settings.json the address and credentials of an server where you have access.
BTW, you can fill in dummy (invalid) values too. If you do so, you won't get emails, if you can live with that.
Vidit Jain (Mar 27 2024 at 08:02):I have filled dummy values, but still when I am trying to login in, its failing showing cannot connect to email server
Vidit Jain (Mar 27 2024 at 08:03):I am using admin email and password to login
Vidit Jain (Mar 27 2024 at 08:06):Also there is no config.example.json and config.json file in the repo? @Daniel Rossberg
Daniel Rossberg (Mar 27 2024 at 08:11):Vidit Jain said:
I have filled dummy values, but still when I am trying to login in, its failing showing cannot connect to email server
Is it failing or complaining? If you filled in dummy values, it's granted that it cannot connect to a server.
I can't look at the config I used, but I remember that the values had to be meaningful. They must look as they could work.
Vidit Jain (Mar 27 2024 at 08:14):Screenshot-from-2024-03-27-19-13-25.png
Its prompting on top when I try logging in.
Daniel Rossberg said:
Vidit Jain said:
I have filled dummy values, but still when I am trying to login in, its failing showing cannot connect to email server
Is it failing or complaining? If you filled in dummy values, it's granted that it cannot connect to a server.
I can't look at the config I used, but I remember that the values had to be meaningful. They must look as they could work.
Vidit Jain (Mar 27 2024 at 08:15):Daniel Rossberg said:
Vidit Jain said:
I have filled dummy values, but still when I am trying to login in, its failing showing cannot connect to email server
Is it failing or complaining? If you filled in dummy values, it's granted that it cannot connect to a server.
I can't look at the config I used, but I remember that the values had to be meaningful. They must look as they could work.
But there should be some sort of mockup for config which I can fill in?
Daniel Rossberg (Mar 27 2024 at 08:18):Can you go on after hitting the "x"?
You could fill in the data for a real email server too.
Vidit Jain (Mar 27 2024 at 08:24):Daniel Rossberg said:
Can you go on after hitting the "x"?
You could fill in the data for a real email server too.
No after hitting the "x", it is staying on the same screen.
Daniel Rossberg (Mar 27 2024 at 10:11):As I wrote, I can't look at it now. Maybe, you can post your configuration here, just for information.
Amanjot Singh (Mar 27 2024 at 13:08):Yeah Vidit, can you post your configuration here?
Vidit Jain (Mar 27 2024 at 13:09):Amanjot Singh said:
Yeah Vidit, can you post your configuration here?
I am not sure which configuration you are talking about. Can you give me more details. Thanks
Amanjot Singh (Mar 27 2024 at 13:10):The email config that you must have written in settings.json
Vidit Jain (Mar 27 2024 at 13:24):Screenshot-from-2024-03-28-00-23-41.png
This is my configration
Daniel Rossberg (Mar 27 2024 at 13:26):"port": null doesn't look good. The log output should have told you?
Vidit Jain (Mar 27 2024 at 13:36):I changed it to 465 (SSL port for gmail)
Vidit Jain (Mar 27 2024 at 13:37):Log wasn't saying anything
Vidit Jain (Mar 27 2024 at 13:38):Yes, it worked now
Vidit Jain (Mar 27 2024 at 14:06):@Amanjot Singh @Daniel Rossberg what all are you expecting in OGV in GSOC'2024, I am willing to contribute. I have 1.5 years of experience in full stack web development. If you can tell me what all can I add in my proposal?
Amanjot Singh (Mar 27 2024 at 15:06):@Daniel Rossberg can confirm if OGV is our priority for this year GSoC.
However, if you are willing to contribute perhaps you can suggest some good enhancements and improvements. Maybe it can be selected but again Daniel can tell better on this decision.
Vidit Jain (Mar 27 2024 at 15:17):Amanjot Singh said:
Daniel Rossberg can confirm if OGV is our priority for this year GSoC.
However, if you are willing to contribute perhaps you can suggest some good enhancements and improvements. Maybe it can be selected but again Daniel can tell better on this decision.
Oh, ok! If you any other web based project that is in priority?
Daniel Rossberg (Mar 27 2024 at 17:11):The Online Geometry Viewer (OGV) was not selected as a priority for this year. This does however not mean that we can not accept a proposal for such a project, but you would need to be more independent then. Especially, you had to be able to fix such issues like the one with the port number by yourself. You must be able to debug the program, find the place where the error message is generated, and follow the paths leading to it.
Vidit Jain (Mar 28 2024 at 02:28):Daniel Rossberg said:
The Online Geometry Viewer (OGV) was not selected as a priority for this year. This does however not mean that we can not accept a proposal for such a project, but you would need to be more independent then. Especially, you had to be able to fix such issues like the one with the port number by yourself. You must be able to debug the program, find the place where the error message is generated, and follow the paths leading to it.
I am really sorry about that.. actually for some reasons, logs weren't visible. I will keep that in mind
Sean (Apr 17 2024 at 17:21):It would be great to have the wiki updated with the OGV development priorities, basically combining https://brlcad.org/wiki/Online_Geometry/TODO and https://brlcad.org/wiki/OGV#To_Do_List and https://brlcad.org/wiki/Online_Geometry and https://brlcad.org/wiki/OGV etc
Sean (Apr 17 2024 at 17:22):OGV appears to be the most up-to-date but then there is useful information in the other pages for sure.
Amanjot Singh (Apr 17 2024 at 17:23):Sure I can look into it and do the needful
Sean (Apr 17 2024 at 17:52):Awesome @Amanjot Singh ! Feel free to delete the old or split them up or whatever makes sense. It would just be nice to have a concise up-to-date summary of what it is, what it does, how it does it, and what's next. Be good to update all the references as well -- I see a few citations if you follow the "What Links Here" links on each page that should probably be updated to OGV or have the link removed.
Last updated: Oct 09 2024 at 00:44 UTC